summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-01-02Fix warnings in make test code.Jeremy Allison5-12/+44
Jeremy.
2008-12-31Fix typo found by Volker. Thanks for the review.Jeremy Allison1-1/+1
Jeremy.
2008-12-31Fix all warnings in source3 with gcc4.3.Jeremy Allison16-53/+168
Jeremy.
2008-12-31Fix more asprintf and "ignoring return code" warnings from gcc 4.3.Jeremy Allison5-58/+103
Jeremy.
2008-12-31Replace a static variable and alarm() calls by using sys_select()Volker Lendecke1-23/+24
Günther, please check!
2008-12-31Fix some nonempty blank linesVolker Lendecke1-5/+5
2008-12-31Make a CONST_DISCARD unnecessary by applying some constVolker Lendecke1-3/+2
Derrell, please check!
2008-12-31Replace "goto again" by "return NT_STATUS_RETRY" in receive_message_or_smbVolker Lendecke1-11/+13
This gives lower-level routines the chance to indicate a retry condition
2008-12-31Disable the use of splice(2)Volker Lendecke1-1/+1
On a debian lenny installation with a kernel that calls itself 2.6.28, I could repeatably block smbd using splice. According to the output of netstat, the recvq of the TCP connection was full and at the same time according to strace smbd was stuck in a splice syscall trying to read from that TCP connection. We can not protect ourselves from this condition, as nobody will ever notify us that something is broken. So sadly we can't use splice yet at all. Maybe in 2.6.29...
2008-12-31Try to fix recvfile using splice on LinuxVolker Lendecke1-21/+36
According to the splice(2) manpage, one of the file descriptors *must* be a pipe. With this patch I could successfully run splice(2) on a debian lenny installation. Jeremy, please check!
2008-12-31Fix a "nested extern" warningVolker Lendecke1-1/+1
2008-12-31Rename parent_dirname_talloc() to parent_dirname()Volker Lendecke12-34/+17
2008-12-31Remove unused function parent_dirnameVolker Lendecke2-14/+0
2008-12-31Use parent_dirname_talloc instead of parent_dirname in smb_unix_mknodVolker Lendecke1-3/+7
2008-12-31Use parent_dirname_talloc instead of parent_dirname in copy_internalsVolker Lendecke1-2/+6
2008-12-31Use parent_dirname_talloc instead of parent_dirname in vfswrap_mkdirVolker Lendecke1-1/+6
2008-12-31Make use of TALLOC_MEMDUP in parent_dirname_talloc()Volker Lendecke1-2/+1
2008-12-31Remove unused function get_numlist()Volker Lendecke2-52/+0
2008-12-31recvfile can't be used for printing so farVolker Lendecke1-0/+4
2008-12-31s3:winbindd: we don't need to call messaging_reinit() twiceStefan Metzmacher1-7/+0
reinit_after_fork() already calls messaging_reinit() metze
2008-12-31Enable individual smbtorture_s3 subtests in make testVolker Lendecke1-0/+4
2008-12-31Fix an ancient uninitialized variable readVolker Lendecke4-8/+10
The callers of open_file_ntcreate expect *psbuf to be filled correctly
2008-12-30s3 build: Revert previous patch to fix the buildTim Prouty1-3/+101
888524623d179ceb4d540f5ac0f3b013d3ce5735 broke the build. I'm reverting it for the short term, while I work on a better fix.
2008-12-30Fix more "ignore return value" warnings from gcc 4.3.Jeremy Allison4-15/+31
Jeremy
2008-12-30librpc: Re-run make idl-full from source3Tim Prouty3-9/+9
2008-12-30pidl: Fix a const build warning in the samba3 merged buildTim Prouty1-1/+1
The warning: ../librpc/gen_ndr/ndr_spoolss.c: In function ‘ndr_pull_spoolss_EnumPrinterData’: ../librpc/gen_ndr/ndr_spoolss.c:14792: warning: passing argument 1 of ‘memset’ discards qualifiers from pointer target type In some case the pidl generated code needs to memset a const struct field. This causes the above warning. This patch discardeds the const in this case. I'm open to a more elegant fix, but this eliminates the warning and should be relatively safe.
2008-12-30s3/s4: Move CONST_DISCARD into lib/util so it's available from s3 and s4Tim Prouty2-2/+2
2008-12-30s3 build: Remove redundant #defines that are in idl generated headersTim Prouty1-101/+3
This fixes a series of samba3 build warnings in the merged build: 'error: "X" redefined', where X is one of the redundant #defines
2008-12-30s4: simplify some overly-complicated logicTim Prouty1-1/+1
2008-12-30s3 build: Fix warningTim Prouty1-0/+2
2008-12-30s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADDStefan Metzmacher4-13/+27
This means we correctly pass IPv6 addresses too. (CTDB_CONTROL_TCP_CLIENT was IPv4 only) metze
2008-12-30Fix a memory leak in cups_pull_comment_locationVolker Lendecke1-0/+4
We allocated "request" with ippNew, so we also should ippDelete it.
2008-12-30Fix a spinning smbd when printingVolker Lendecke1-1/+1
Without this, we end up adding more than one timed event. In the event handler print_notify_event_send_messages() only one event will be deleted, all others will fire indefinitely.
2008-12-30Print the vuid in BENCH-SESSSETUPVolker Lendecke1-0/+2
2008-12-30Second part of the bugfix for #5933Volker Lendecke1-7/+13
Incrementing the next vuid did not correctly overflow Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-) Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
2008-12-30First part of bugfix for #5933Volker Lendecke1-3/+0
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing num_validated_vuids twice per session setup, but decrement it only once. Looking at sesssetup.c we always call register_initial_vuid() before register_existing_vuid(), so there's no point in incrementing it in register_existing_vuid(). Jeremy, please check!
2008-12-30Move a comment to its placeVolker Lendecke1-5/+5
2008-12-30Simplify invalidate_vuid slightlyVolker Lendecke1-4/+0
get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
2008-12-30Simplify is_partial_auth_vuid slightlyVolker Lendecke1-5/+1
2008-12-30Simplify invalidate_all_vuids() slightlyVolker Lendecke1-5/+2
invalidate_vuid takes care of removing the user_struct from validated_users
2008-12-30Fix the merged buildStefan Metzmacher1-0/+1
metze
2008-12-30lib/tevent: fix standalone make distclean realdistcleanStefan Metzmacher1-2/+2
Bug report by Brad Hards <bradh@frogmouth.net>. metze
2008-12-29pidl: don't generate invalid C codeStefan Metzmacher1-1/+3
When we don't know how to handle a type for the python bindings, we should not generate invalid C code. Jelmer: please fix do the full fix for this. metze
2008-12-29s3:pdb_tdb: store the next rid counter in passdb.tdb instead of ↵Stefan Metzmacher1-75/+47
winbind_idmap.tdb This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4. metze
2008-12-29s3:passdb: add SAMU_BUFFER_V4 with no changesStefan Metzmacher2-2/+19
The upgrade is required because of the followin TDBSAM_VERSION upgrade. metze
2008-12-29s3:passdb: make marshalling struct samu from and to a buffer more genericStefan Metzmacher4-667/+679
This marshalling isn't specific to tdbsam and it's ugly to have the related functions in two different files. metze
2008-12-29s4:cluster: fix dependency to TDB_WRAPStefan Metzmacher1-0/+1
metze
2008-12-29s4:lib/tevent: rename structsStefan Metzmacher211-684/+681
list="" list="$list event_context:tevent_context" list="$list fd_event:tevent_fd" list="$list timed_event:tevent_timer" for s in $list; do o=`echo $s | cut -d ':' -f1` n=`echo $s | cut -d ':' -f2` r=`git grep "struct $o" |cut -d ':' -f1 |sort -u` files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4` for f in $files; do cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp mv $f.tmp $f done done metze
2008-12-29s4:pvfs_aio: use teventStefan Metzmacher2-12/+12
metze
2008-12-29s4:sys_lease_linux: use teventStefan Metzmacher2-8/+8
metze