summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-07-17Fix Coverity CID 929. Potential NULL deref after code refactoring.Jeremy Allison1-0/+5
Jeremy.
2009-07-17Fix coverity CID 930. Pointer check can never be null here.Jeremy Allison1-1/+1
Jeremy
2009-07-17Fix coverity CID 931. This check is redundent as smb_fname canJeremy Allison1-1/+1
never be null in this function. Jeremy.
2009-07-17Fix a typo reading uninitialized memory. Caught by valgrind.Jeremy Allison1-3/+1
Jeremy.
2009-07-17Move the initialization of smbd_server_conn from smbd/process,Jeremy Allison2-5/+5
after the accept and fork, to smbd_init_globals(), so it's done immediately on server startup. This is needed as some messages are sent to all active smbd processes (including the master listening daemon). If it gets a message that forces it to scan it's current connections (ie. conn_find()) then it discovers that sconn->smb1.tcons.Connections dereferences null (as sconn == NULL in the parent) and crashes. Yes, I could fix all cases where sconn is used and explicitly check for NULL but this fix is easier. It means that the smbd_event_context() is initialized in the master daemon and then re-initialized after fork, but that should be being done correctly in every fork call anyway. Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789 still panics in the reproducible test case for bug 6564, as this is one case where such a message (MSG_SMB_CONF_UPDATED) is sent to the parent. Metze please check. This change passes valgrind. Jeremy.
2009-07-17Fix bug #6564 - SetPrinter fails (panics) as non root.Jeremy Allison2-0/+5
Missing become_root()/unbecome_root() around reload_services. Jeremy.
2009-07-173.4 is released...Volker Lendecke1-1/+1
2009-07-17s4-spoolss: fix the build after OsVersion changes.Günther Deschner1-3/+6
Guenther
2009-07-17spoolss: fill in some unknowns in spoolss_OSVersion and spoolss_OSVersionEx.Günther Deschner3-18/+33
Guenther
2009-07-18s3: add failure check.Bo Yang1-1/+4
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-17s3-rpcclient: add createprinteric command.Günther Deschner1-0/+43
Guenther
2009-07-17spoolss: fill in spoolss_Create/DeletePrinterIC + rerun make samba3-idl.Günther Deschner6-2/+134
Guenther
2009-07-17s3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.Günther Deschner1-6/+10
Guenther
2009-07-17s3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().Günther Deschner1-6/+24
Guenther
2009-07-17s3-lsa: add (not yet activate) level specific access checks for ↵Günther Deschner1-0/+42
_lsa_QueryInfoPolicy. Guenther
2009-07-17s3-lsa: also implement level 13 in lsa_QueryInfoPolicy.Günther Deschner1-19/+24
Guenther
2009-07-17s3-lsa: Fix policy handle memleak and handle type check in _lsa_DeleteObject().Günther Deschner1-4/+14
Guenther
2009-07-17s3-rpcclient: add LSA storeprivatedata command.Günther Deschner1-0/+56
Guenther
2009-07-17s3-rpcclient: add LSA retrieveprivatedata command.Günther Deschner1-0/+60
Guenther
2009-07-17s3-rpcclient: add LSA setsecret command.Günther Deschner1-0/+71
Guenther
2009-07-17s3-rpcclient: add LSA querysecret command.Günther Deschner1-0/+86
Guenther
2009-07-17s3-rpcclient: add LSA deletesecret command.Günther Deschner1-0/+50
Guenther
2009-07-17s3-rpcclient: add LSA createsecret command.Günther Deschner1-0/+43
Guenther
2009-07-17lsa: fill in lsa_StorePrivateData and lsa_RetrievePrivateData and rerun make ↵Günther Deschner6-7/+214
samba3-idl. Guenther
2009-07-18s3: compile warning and upn handlingBo Yang3-14/+31
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-18s3: don't do this, upper callbacks will check itBo Yang1-4/+0
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-18s3: Fix crsh in net usershare listBo Yang1-0/+1
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-16More conversions of NULL -> talloc_autofree_context()Jeremy Allison3-19/+24
so we at least know when we're using a long-lived context. Jeremy.
2009-07-16Replace more long-lived contexts with talloc_autofree_context().Jeremy Allison2-2/+2
Jeremy.
2009-07-16Replace short-lived NULL talloc contexts with talloc_tos().Jeremy Allison3-22/+22
Jeremy.
2009-07-16Remove an unused talloc context.Jeremy Allison1-8/+2
Jeremy.
2009-07-17Revert "s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the ↵Andrew Bartlett1-8/+0
compiler version" This is now handled correctly in the newly imported Heimdal This reverts commit 4a754d029b0eb229b23980aa4a80dae2b485a302.
2009-07-17s4:heimdal: import lorikeet-heimdal-200907162216 (commit ↵Andrew Bartlett6-23/+60
d09910d6803aad96b52ee626327ee55b14ea0de8) This includes in particular changes to the KDC to resolve bug 6272, originally by Matthieu Patou <mat+Informatique.Samba@matws.net>. We need to sort the AuthorizationData elements to put the PAC first, or else WinXP breaks when browsed from Win2k8. Andrew Bartlett
2009-07-17s4:kdc Rework KDC to pull in less attributes for krbtgt lookupsAndrew Bartlett3-31/+62
Each attribute we request from LDB comes with a small cost, so don't lookup any more than we must for the (very) frequent krbtgt lookup case. Similarly, we don't need to build a PAC for a server (as a target), so don't ask for the PAC attributes here either. Andrew Bartlett
2009-07-17s4:kdc rename functions from LDB_ to hdb_samba4Andrew Bartlett1-71/+71
The LDB_ prefix is misleading, and stomps on the LDB namespace. This is a Samba4 hdb module, and not something generic. Andrew Bartlett
2009-07-17Revert "fix LSA-PRIVILEGES"Günther Deschner1-3/+2
This reverts commit 0d9fdbceedddb08dbea8ed84e06a218d3ec562f4.
2009-07-17Revert "fix LSA-TRUSTED-DOMAINS"Günther Deschner1-3/+2
This reverts commit 3c9b26276083002124674678ac757e859fb6b20e.
2009-07-17s4-smbtorture: use secinfo flags instead of numbers in lsa test.Günther Deschner1-1/+3
Guenther
2009-07-17s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().Günther Deschner1-13/+3
Guenther
2009-07-17s3-lsa: implement _lsa_LookupPrivName().Günther Deschner1-6/+45
Guenther
2009-07-17s3-lsa: implement _lsa_EnumAccountsWithUserRight().Günther Deschner1-6/+57
Guenther
2009-07-16Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.Jeremy Allison1-2/+3
Jeremy.
2009-07-16s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler versionStefan Metzmacher1-0/+8
Otherwise heimdal/lib/gssapi/gssapi/gssapi.h will just define it to __attribute__ ((deprecated)) which is not supported by all compilers we care about. This should fix the build on Tru64 metze
2009-07-16s4:heimdal_build: try to fix the build on systems without ifaddrs.hStefan Metzmacher2-0/+10
metze
2009-07-16tevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART ↵Stefan Metzmacher1-1/+11
defined metze
2009-07-16s4:heimdal_build: tell heimdal we have inet_aton()Stefan Metzmacher1-0/+4
This should fix problems on Solaris. metze
2009-07-16s4-smbtorture: use torture_comment in RPC-LSA tests.Günther Deschner1-204/+204
Guenther
2009-07-16fix LSA-PRIVILEGESGünther Deschner1-2/+3
2009-07-16fix LSA-TRUSTED-DOMAINSGünther Deschner1-2/+3
2009-07-16s4-smbtorture: move all privilege tests to RPC-LSA-PRIVILEGES.Günther Deschner2-12/+54
Guenther