summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r19237: fix typoStefan Metzmacher1-1/+1
metze (This used to be commit d91041d4b6973fd9779d355cd6f9634e207b7653)
2007-10-10r19236: prepare for --with-pam=auto as defaultStefan Metzmacher1-39/+72
but still leave --with-pam=no the default for now and wait for discussion on samba-technical metze (This used to be commit b045d5afcf2e352ebb797132bd6b7c02f3b685a0)
2007-10-10r19235: merge from samba4:Stefan Metzmacher1-2/+2
fix configure test for net/if.h on some platforms AC_LANG_SOURCE() adds the content of confdefs.h in front of the compiled file metze (This used to be commit 7cbdc06ad9b68544c8eeaa68fdd7b03f71c0b739)
2007-10-10r19233: remove unused --with-spinlocks optionStefan Metzmacher1-24/+0
the defines are not used anywhere in the tree. (grep -R SPINLOCKS . in the topdir) metze (This used to be commit 1697686d9da7dd1ac707c7af9c145c0fc6204108)
2007-10-10r19232: merge from samba4:Stefan Metzmacher2-16/+19
- machine/sys/getppdp.h workaround for HPUX 11.23 - more verbose check for net/if.h metze (This used to be commit 9b5c5bc3f3912776af6a8c9b13a9cb8dd2eff8f8)
2007-10-10r19231: I encountered a WinXP/Home system which, acting as the master ↵Derrell Lipman1-1/+2
browser for its workgroup, decided periodically to stop sending recognized responses to a NetServerEnum2 request for the workgroup. Instead of returning the list of servers (only itself; nothing else in the workgroup), it returns a status code of 8 which is unsupported by samba3, samba4, and ethereal. The code for this request assumed that if an unexpected status code was received, the connection had a problem, i.e. that cli_errno() would show a problem. That turns out not to be the case. This patch changes the behavior so tha any time a response is received and cli_errno() == 0, we continue processing the reply and base our response on the returned count (zero). The pre-existing code then converts this count=0 into an ENOENT errno which can be properly handled by the application (whereas an error return with errno=0 can't be). This packet dump has only 2 frames. Sorry about the text version but it's most easily attached to this log message. I also have it saved as .pcap if anyone wants it. Derrell No. Time Source Destination Protocol Info 1 14:31:59.802668 192.168.1.106 192.168.1.100 LANMAN NetServerEnum2 Request, Server, SQL Server, Domain Controller, Backup Controller, Time Source, Apple Server, Novell Server, Domain Member Server, Print Queue Server, Dialin Server, Xenix Server, NT Workstation, Windows for Workgroups, Unknown server type:14, NT Server Frame 1 (196 bytes on wire, 196 bytes captured) Arrival Time: Oct 10, 2006 14:31:59.802668000 Time delta from previous packet: 0.000000000 seconds Time since reference or first frame: 0.000000000 seconds Frame Number: 1 Packet Length: 196 bytes Capture Length: 196 bytes Protocols in frame: eth:ip:tcp:nbss:smb Ethernet II, Src: IntelCor_4a:47:bb (00:13:20:4a:47:bb), Dst: Micro-St_74:16:e7 (00:0c:76:74:16:e7) Destination: Micro-St_74:16:e7 (00:0c:76:74:16:e7) Source: IntelCor_4a:47:bb (00:13:20:4a:47:bb) Type: IP (0x0800) Internet Protocol, Src: 192.168.1.106 (192.168.1.106), Dst: 192.168.1.100 (192.168.1.100) Version: 4 Header length: 20 bytes Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00) 0000 00.. = Differentiated Services Codepoint: Default (0x00) .... ..0. = ECN-Capable Transport (ECT): 0 .... ...0 = ECN-CE: 0 Total Length: 182 Identification: 0xb838 (47160) Flags: 0x04 (Don't Fragment) 0... = Reserved bit: Not set .1.. = Don't fragment: Set ..0. = More fragments: Not set Fragment offset: 0 Time to live: 64 Protocol: TCP (0x06) Header checksum: 0xfdea [correct] Good: True Bad : False Source: 192.168.1.106 (192.168.1.106) Destination: 192.168.1.100 (192.168.1.100) Transmission Control Protocol, Src Port: 44932 (44932), Dst Port: netbios-ssn (139), Seq: 851982066, Ack: 1274726157, Len: 130 Source port: 44932 (44932) Destination port: netbios-ssn (139) Sequence number: 851982066 Next sequence number: 851982196 Acknowledgement number: 1274726157 Header length: 32 bytes Flags: 0x0018 (PSH, ACK) 0... .... = Congestion Window Reduced (CWR): Not set .0.. .... = ECN-Echo: Not set ..0. .... = Urgent: Not set ...1 .... = Acknowledgment: Set .... 1... = Push: Set .... .0.. = Reset: Not set .... ..0. = Syn: Not set .... ...0 = Fin: Not set Window size: 6432 Checksum: 0xb4e0 [correct] Options: (12 bytes) NOP NOP Time stamp: tsval 1184074739, tsecr 11576161 NetBIOS Session Service Message Type: Session message Flags: 0x00 .... ...0 = Add 0 to length Length: 126 SMB (Server Message Block Protocol) SMB Header Server Component: SMB Response in: 2 SMB Command: Trans (0x25) NT Status: STATUS_SUCCESS (0x00000000) Flags: 0x08 0... .... = Request/Response: Message is a request to the server .0.. .... = Notify: Notify client only on open ..0. .... = Oplocks: OpLock not requested/granted ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized .... 1... = Case Sensitivity: Path names are caseless .... ..0. = Receive Buffer Posted: Receive buffer has not been posted .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported Flags2: 0xc801 1... .... .... .... = Unicode Strings: Strings are Unicode .1.. .... .... .... = Error Code Type: Error codes are NT error codes ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported .... .... .0.. .... = Long Names Used: Path names in request are not long file names .... .... .... .0.. = Security Signatures: Security signatures are not supported .... .... .... ..0. = Extended Attributes: Extended attributes are not supported .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response Process ID High: 0 Signature: 0000000000000000 Reserved: 0000 Tree ID: 2048 Process ID: 12967 User ID: 2048 Multiplex ID: 6 Trans Request (0x25) Word Count (WCT): 14 Total Parameter Count: 36 Total Data Count: 0 Max Parameter Count: 8 Max Data Count: 65535 Max Setup Count: 0 Reserved: 00 Flags: 0x0000 .... .... .... ..0. = One Way Transaction: Two way transaction .... .... .... ...0 = Disconnect TID: Do NOT disconnect TID Timeout: Return immediately (0) Reserved: 0000 Parameter Count: 36 Parameter Offset: 90 Data Count: 0 Data Offset: 126 Setup Count: 0 Reserved: 00 Byte Count (BCC): 63 Transaction Name: \PIPE\LANMAN SMB Pipe Protocol Microsoft Windows Lanman Remote API Protocol Function Code: NetServerEnum2 (104) Parameter Descriptor: WrLehDz Return Descriptor: B16BBDz Detail Level: 1 Receive Buffer Length: 65535 Server Type: 0x0000fffe .... .... .... .... .... .... .... ...0 = Workstation: This is NOT a Workstation .... .... .... .... .... .... .... ..1. = Server: This is a Server .... .... .... .... .... .... .... .1.. = SQL: This is an SQL server .... .... .... .... .... .... .... 1... = Domain Controller: This is a Domain Controller .... .... .... .... .... .... ...1 .... = Backup Controller: This is a Backup Controller .... .... .... .... .... .... ..1. .... = Time Source: This is a Time Source .... .... .... .... .... .... .1.. .... = Apple: This is an Apple host .... .... .... .... .... .... 1... .... = Novell: This is a Novell server .... .... .... .... .... ...1 .... .... = Member: This is a Domain Member server .... .... .... .... .... ..1. .... .... = Print: This is a Print Queue server .... .... .... .... .... .1.. .... .... = Dialin: This is a Dialin server .... .... .... .... .... 1... .... .... = Xenix: This is a Xenix server .... .... .... .... ...1 .... .... .... = NT Workstation: This is an NT Workstation .... .... .... .... ..1. .... .... .... = WfW: This is a WfW host .... .... .... .... 1... .... .... .... = NT Server: This is an NT Server .... .... .... ...0 .... .... .... .... = Potential Browser: This is NOT a Potential Browser .... .... .... ..0. .... .... .... .... = Backup Browser: This is NOT a Backup Browser .... .... .... .0.. .... .... .... .... = Master Browser: This is NOT a Master Browser .... .... .... 0... .... .... .... .... = Domain Master Browser: This is NOT a Domain Master Browser .... .... ...0 .... .... .... .... .... = OSF: This is NOT an OSF host .... .... ..0. .... .... .... .... .... = VMS: This is NOT a VMS host .... .... .0.. .... .... .... .... .... = Windows 95+: This is NOT a Windows 95 or above host .0.. .... .... .... .... .... .... .... = Local: This is NOT a local list only request 0... .... .... .... .... .... .... .... = Domain Enum: This is NOT a Domain Enum request Enumeration Domain: WORKGROUP No. Time Source Destination Protocol Info 2 14:31:59.803918 192.168.1.100 192.168.1.106 LANMAN NetServerEnum2 Response Frame 2 (134 bytes on wire, 134 bytes captured) Arrival Time: Oct 10, 2006 14:31:59.803918000 Time delta from previous packet: 0.001250000 seconds Time since reference or first frame: 0.001250000 seconds Frame Number: 2 Packet Length: 134 bytes Capture Length: 134 bytes Protocols in frame: eth:ip:tcp:nbss:smb Ethernet II, Src: Micro-St_74:16:e7 (00:0c:76:74:16:e7), Dst: IntelCor_4a:47:bb (00:13:20:4a:47:bb) Destination: IntelCor_4a:47:bb (00:13:20:4a:47:bb) Source: Micro-St_74:16:e7 (00:0c:76:74:16:e7) Type: IP (0x0800) Internet Protocol, Src: 192.168.1.100 (192.168.1.100), Dst: 192.168.1.106 (192.168.1.106) Version: 4 Header length: 20 bytes Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00) 0000 00.. = Differentiated Services Codepoint: Default (0x00) .... ..0. = ECN-Capable Transport (ECT): 0 .... ...0 = ECN-CE: 0 Total Length: 120 Identification: 0xea10 (59920) Flags: 0x04 (Don't Fragment) 0... = Reserved bit: Not set .1.. = Don't fragment: Set ..0. = More fragments: Not set Fragment offset: 0 Time to live: 128 Protocol: TCP (0x06) Header checksum: 0x8c50 [correct] Good: True Bad : False Source: 192.168.1.100 (192.168.1.100) Destination: 192.168.1.106 (192.168.1.106) Transmission Control Protocol, Src Port: netbios-ssn (139), Dst Port: 44932 (44932), Seq: 1274726157, Ack: 851982196, Len: 68 Source port: netbios-ssn (139) Destination port: 44932 (44932) Sequence number: 1274726157 Next sequence number: 1274726225 Acknowledgement number: 851982196 Header length: 32 bytes Flags: 0x0018 (PSH, ACK) 0... .... = Congestion Window Reduced (CWR): Not set .0.. .... = ECN-Echo: Not set ..0. .... = Urgent: Not set ...1 .... = Acknowledgment: Set .... 1... = Push: Set .... .0.. = Reset: Not set .... ..0. = Syn: Not set .... ...0 = Fin: Not set Window size: 64606 Checksum: 0x1e0d [correct] Options: (12 bytes) NOP NOP Time stamp: tsval 11576161, tsecr 1184074739 NetBIOS Session Service Message Type: Session message Flags: 0x00 .... ...0 = Add 0 to length Length: 64 SMB (Server Message Block Protocol) SMB Header Server Component: SMB Response to: 1 Time from request: 0.001250000 seconds SMB Command: Trans (0x25) NT Status: STATUS_SUCCESS (0x00000000) Flags: 0x88 1... .... = Request/Response: Message is a response to the client/redirector .0.. .... = Notify: Notify client only on open ..0. .... = Oplocks: OpLock not requested/granted ...0 .... = Canonicalized Pathnames: Pathnames are not canonicalized .... 1... = Case Sensitivity: Path names are caseless .... ..0. = Receive Buffer Posted: Receive buffer has not been posted .... ...0 = Lock and Read: Lock&Read, Write&Unlock are not supported Flags2: 0xc801 1... .... .... .... = Unicode Strings: Strings are Unicode .1.. .... .... .... = Error Code Type: Error codes are NT error codes ..0. .... .... .... = Execute-only Reads: Don't permit reads if execute-only ...0 .... .... .... = Dfs: Don't resolve pathnames with Dfs .... 1... .... .... = Extended Security Negotiation: Extended security negotiation is supported .... .... .0.. .... = Long Names Used: Path names in request are not long file names .... .... .... .0.. = Security Signatures: Security signatures are not supported .... .... .... ..0. = Extended Attributes: Extended attributes are not supported .... .... .... ...1 = Long Names Allowed: Long file names are allowed in the response Process ID High: 0 Signature: 0000000000000000 Reserved: 0000 Tree ID: 2048 Process ID: 12967 User ID: 2048 Multiplex ID: 6 Trans Response (0x25) Word Count (WCT): 10 Total Parameter Count: 8 Total Data Count: 0 Reserved: 0000 Parameter Count: 8 Parameter Offset: 56 Parameter Displacement: 0 Data Count: 0 Data Offset: 64 Data Displacement: 0 Setup Count: 0 Reserved: 00 Byte Count (BCC): 9 Padding: 00 SMB Pipe Protocol Microsoft Windows Lanman Remote API Protocol Function Code: NetServerEnum2 (104) Status: Unknown (8) Convert: 0 Entry Count: 0 Available Entries: 0 (This used to be commit 88fa5ac7347cbae92abe17da8d3af00e85110c43)
2007-10-10r19230: Doh ! Fix obvious crash bug.....Jeremy Allison1-5/+5
(This used to be commit e6560270499365ca42517f6a7cf40845ee80edfb)
2007-10-10r19224: Add setting the rng_fault_state to the already converted pipes.Volker Lendecke7-147/+597
Convert the low-hanging fruit of the LSA server. This provides a sample how the server calls can be converted one by one, see the "proxy_lsa_call" function. Volker (This used to be commit 99e54a213ad3561ea6e8dc44c483847c18c5681e)
2007-10-10r19221: Monster-Checkin after "make idl"Volker Lendecke11-716/+3580
(This used to be commit 416466a16f58ac644baacaa2522c4e98176d0e70)
2007-10-10r19220: Check if a backend has set rng_fault_state and send a dce-level ↵Volker Lendecke1-0/+7
fault pdu. Volker (This used to be commit 21c08e7ef460ae7eaf1f441e8aadcfe0502fa1ad)
2007-10-10r19218: With the new RPC server infrastructure all backend functions are ↵Volker Lendecke1-0/+6
filled, at least with dummy routines. We need a way to indicate that we do not support a call, so that srv_pipe_hnd.c can return the DCE level RNG_ERROR. This flag can be set in the backend routines for this one. I'll change pidl to generate code to "return False" in srv_lsa.c if this flag is set. Volker (This used to be commit 5260657664caf9546d324a81c392f0d9e8532d58)
2007-10-10r19212: Make sure domains marked internal don't doJeremy Allison2-14/+29
network queries. Jeremy. (This used to be commit e4d5e1d90b40fee1edc5cf0134b276645eea63bf)
2007-10-10r19209: Ensure we don't make mistakes by sending online/offlineJeremy Allison1-26/+100
messages to internal domains, or to domains not being serviced by a winbindd child. Ensure the child online offline requests are domain specific. Jeremy. (This used to be commit 81a9dc4b9fbd4a9bb67f55aa744bf609d6aba1c2)
2007-10-10r19207: Properly canonicalize incoming names to theJeremy Allison3-4/+33
NSS protocols auth, chauthtok, logoff, ccache_ntlm_auth. That way we ensure winbindd only deals with fully qualified names internally. The NSS protocols auth_crap and chng_pswd_auth_crap should be fixed to do the same thing. Jeremy. (This used to be commit dbd2454d3337f64cddbdaf39e9efd6505e6b2590)
2007-10-10r19206: Jeremy, for some reason storing a value-less entry in TDB does not workGünther Deschner2-18/+14
anymore in 3_0. I'm just adding a time(NULL) as value for the WINBINDD_OFFLINE key. Guenther (This used to be commit 2bdf9f140f76d6eb73b34148c47f7d3447e2e563)
2007-10-10r19203: Part two of returning our real name. This code is a bit ancient... :-)Volker Lendecke1-1/+1
(This used to be commit 370c24ba2ad3bce29929886f96d626e698da0238)
2007-10-10r19193: merge from samba4:Stefan Metzmacher1-1/+3
fixed another checker warning and a possible error on allocation failure metze (This used to be commit d64583a763ffcff27f0bd6761196f7d554d44849)
2007-10-10r19192: merge from samba4:Stefan Metzmacher1-1/+6
ensure that data values from ldap libs are null terminated, to allow ldb_msg_find_attr_as_string() to work correctly. Thanks to Jim Myers for spotting this! metze (This used to be commit a5ea82bb05fb9d5c1842f9a105f6a10e39141c89)
2007-10-10r19191: merge from samba4:Stefan Metzmacher2-1/+2
fix checker warnings metze (This used to be commit 93a0fe093b4614a18e99d0c3a71c5c8af2e57e4f)
2007-10-10r19190: merge from samba4:Stefan Metzmacher1-6/+1
remove wrong check and statement. to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements. metze (This used to be commit b81cae4180452d2a14c445392fd828032e6eddec)
2007-10-10r19189: No display name is normal for some GPOs.Günther Deschner1-5/+3
Guenther (This used to be commit 1ec1c5dd17c498d5a8a9804ad2ef114fb7603c31)
2007-10-10r19185: merge comment from samba4Stefan Metzmacher1-0/+4
metze (This used to be commit 256b83820168d14df2b15a75d8681be5f418ddf8)
2007-10-10r19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same.Volker Lendecke3-2/+86
Implement 'net rap server name'. Volker (This used to be commit 919385ed2a2a07e848bc0baaac9ed3d1964d4386)
2007-10-10r19183: merge from samba4:Stefan Metzmacher1-3/+13
don't crash on invalid utf8 chars metze (This used to be commit 71e1f8550f96eaaae7e4fc4d02eb36f1d894abc8)
2007-10-10r19182: merge from samba4:Stefan Metzmacher4-1/+16
add ldb_set_create_perms() function to set the create_perms after ldb_init() and before ldb_connect() metze (This used to be commit dd9d469eef337954b6aee4c86ac0691f52812456)
2007-10-10r19181: merge from samba4:Stefan Metzmacher1-1/+6
with "export MAKE_TEST_KEEP_PCAP=yes" make test doesn't delete the generated pcap files metze (This used to be commit 74212c30563826e2248c1cb16e4c953a28a25488)
2007-10-10r19179: remove difference with samba4Stefan Metzmacher1-0/+4
metze (This used to be commit e97e1ffea8e124c8001cf33ecac7500ae875f42f)
2007-10-10r19177: merge from samba4:Stefan Metzmacher1-9/+34
fix the standalone build of socket_wrapper by not using samba's DLIST_ macros metze (This used to be commit bc7b2e8db8fb34d6f321cd6b13b74e58945d7124)
2007-10-10r19172: merge from samba4:Stefan Metzmacher2-36/+72
change the socket wrapper license to what heimdal uses... metze (This used to be commit d19c19ae4be3f3ad349b72ba3181051bb4da335e)
2007-10-10r19170: use a very clever trick to pass the binary name to theStefan Metzmacher2-2/+15
gdb_backtrace script, I never noticed that %$(envvar) exists... Thanks to Bjoern Jacke for the suggestion! metze (This used to be commit 12a37bab3eafdabeb4f0dc23254bdec41860cd87)
2007-10-10r19169: port the trick to only display the smbd and nmbd log outputStefan Metzmacher1-4/+27
of the current test metze (This used to be commit f668d4839de0ec98fcacf2efb6a69970757bebdd)
2007-10-10r19168: use the correct configurationStefan Metzmacher1-4/+4
metze (This used to be commit bf90ac567fc809bb8949b066e822a88170b73ac5)
2007-10-10r19164: merge the gdb_backtrace script from samba4Stefan Metzmacher1-25/+71
this more portable and try to make use of ladebug on Tru64, but that only works when the binary is passed as 2nd arg to gdb_backtrace as Tru64 doesn't know /proc/${PID}/exe we need to find a way to pass the progname in 'panic action' in samba3 metze (This used to be commit 2f55fd82ff5db82974f91648cc386daa423e38be)
2007-10-10r19163: pass always a mem_ctx to functions and a ldb_context where neededStefan Metzmacher5-20/+23
It would be nice if someone can merge that to samba4, otherwise I'll merge that to samba4 on monday metze (This used to be commit 6bc42f31ce294f2bd50ffbd536e1ee42607ef799)
2007-10-10r19161: Add NET_GETANYDCNAME (getdcname only gives the PDC while getanydcnameGünther Deschner4-1/+179
gives just any DC), also make sure to set timeouts in rpcclient accordingly so that we actually get the DC's reply. Guenther (This used to be commit 6091c8152a3998d2503cb0911a217ee904509633)
2007-10-10r19160: Add new WERR codes seen by working with NETLOGON getdcname.Günther Deschner2-0/+4
Guenther (This used to be commit 78b0124a6e7051da2df3157f02593f06f7f31a1b)
2007-10-10r19159: The getdc call can take a long time. Allow for timeouts.Jeremy Allison1-1/+9
Jeremy. (This used to be commit 99bebb65273c78d9867254c47438577bb21af4ee)
2007-10-10r19158: Remove root and nobody users from ldif, from Björn JackeJim McDonough1-63/+1
(This used to be commit 17880d6cadbb0b1b428430c26bb4b4545eb834ff)
2007-10-10r19157: Fix the buildVolker Lendecke1-0/+12
(This used to be commit 3fc328dadeb5b4b35c6d58ba26c3ac9d1fcf4015)
2007-10-10r19156: Make enumprinters use the share iterators.Volker Lendecke1-25/+29
Volker (This used to be commit 9b1759617ce7841a78d9f792254a9e4fa814858f)
2007-10-10r19155: Fix debug message.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 42e5481ce4bebc65040d466b49e3c45cd4e79f5d)
2007-10-10r19154: Trivial logic simplification: Get rid of two indentation levels. ↵Volker Lendecke1-32/+51
Survives the consistency checks just checked into Samba4. Volker (This used to be commit c48bb4b37b32fac9d01d243290532641d3701ec7)
2007-10-10r19151: Create some dummy printers in the build farmVolker Lendecke1-0/+11
(This used to be commit c26a20e6d5ac36be137fa63f477155a9613f050f)
2007-10-10r19148: Finish last nights patch - make offlineJeremy Allison4-51/+78
work again. Still under test. Jeremy. (This used to be commit 40a455db78f805daa6bfeb9e78fb78dcc12fd9a7)
2007-10-10r19147: This is WRONG, but the way the VFS works this is the only fix to get ↵Volker Lendecke1-1/+1
rid of this type-punned warning. Volker (This used to be commit d815b1a7e9609a760f93433bf022826f58f256db)
2007-10-10r19145: talloc_reference() can fail!Stefan Metzmacher1-1/+3
metze (This used to be commit e4f2183684da90a67bc6a635d008b72a6dd3d0dd)
2007-10-10r19143: getdcname on the NETLOGON pipe returns WERROR, not NTSTATUS.Günther Deschner6-22/+24
Guenther (This used to be commit 44e228ac796fca2db8509915067511ed705032bf)
2007-10-10r19137: that looks nicer:-)Stefan Metzmacher2-2/+2
metze (This used to be commit db40552d9471f4a8ce2c5c724319a4eb242ed24a)
2007-10-10r19135: fix bugs...Stefan Metzmacher1-5/+4
- passing mem_ctx as ldb_context is a bad idea! - naming a static function talloc_ is also bad and misleading metze (This used to be commit 0523ad249335c6094854bc9cefb46e2095f4c0ba)
2007-10-10r19133: More C++ warnings -- Merge across?Volker Lendecke1-6/+12
(This used to be commit c879ed3d1edffeda629dc1e05031dca91c1a1e30)