summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-07-21tdb: fix locking errorRusty Russell1-1/+1
54a51839ea65aa788b18fce8de0ae4f9ba63e4e7 "Make tdb transaction lock recursive (samba version)" was broken: I "cleaned it up" and prevented it from ever unlocking. To see the problem: $ bin/tdbtorture -s 1248142523 tdb_brlock failed (fd=3) at offset 8 rw_type=1 lck_type=14 len=1 tdb_transaction_lock: failed to get transaction lock tdb_transaction_start failed: Resource deadlock avoided My testcase relied on the *count* being correct, which it was. Fixing that now. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org>
2009-07-20s3: Add some asserts to the filename util functionsTim Prouty1-0/+12
In the smb_filename struct stream_name must equal NULL if there is no stream name. These asserts should catch any future offenders of this invariant early.
2009-07-20s3: Plumb smb_filename through open_fake_fileTim Prouty3-20/+26
2009-07-20s3: Separate out a new file: filename_utils.cTim Prouty6-254/+280
This is to ease the linking pain of everything that links LOCKING_OBJ
2009-07-20s3: Move is_ntfs_stream*() to filename.cTim Prouty3-26/+26
2009-07-20s3: Finish plumbing the fsp->fsp_name smb_fname conversion through the modules.Tim Prouty23-263/+312
2009-07-20s3: Change fsp->fsp_name to be an smb_filename struct!Tim Prouty32-590/+585
2009-07-20s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx()Tim Prouty1-16/+16
2009-07-20s3: Change file_structs to be allocated with talloc instead of mallocTim Prouty1-10/+15
2009-07-20lib util: Fix const warningTim Prouty1-1/+1
2009-07-20Make cli_send_mailslot() static. Preparing to do away with unexpected.tdb....Jeremy Allison2-9/+1
Jeremy.
2009-07-20Make tdb transaction lock recursive (samba version)Rusty Russell3-21/+20
This patch replaces 6ed27edbcd3ba1893636a8072c8d7a621437daf7 and 1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals inside transactions would release the transaction lock early. This solution is more general, and solves the more minor symptom that nested traversals would also release the transaction lock early. (It was also suggestd in Volker's comment in 6ed27ed). This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb code never received the previous two fixes). Tested using the testsuite from ccan (adapted to the samba code). Thanks to Michael Adam for feedback. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Michael Adam <obnox@samba.org>
2009-07-20Re-add accidently removed shares test.Jelmer Vernooij1-0/+74
2009-07-20s4:kdc Add in a simple check for constrained delegation to selfAndrew Bartlett1-1/+70
To do this properly, we must use the PAC, but for now this is enough to check that we are delegating to another name on the same host (which must be safe). (Windows 7 does this a lot, also noted in bug 6273) Andrew Bartlett
2009-07-20[SAMBA 4 directory] Refactoring and clean up of directory structureMatthias Dieter Wallnöfer9-81/+167
- Adds more system objects which make sense to have them in SAMBA 4 also to have them when we add more and more services related to the directory (volume support, DFS, replication service, COM...) - Make sure that "isCriticalSystemObject" and "showInAdvancedViewOnly" attributes are set correctly on each object
2009-07-19pidl: Print actual type names in errors about unknown origins rather than ↵Jelmer Vernooij2-17/+20
'HASH(0x....)'.
2009-07-19pidl: Print proper errors when arrays don't have a specified size rather ↵Jelmer Vernooij2-7/+18
than spewing pages of perl warnings.
2009-07-19Remove unused parameter setting.Jelmer Vernooij2-11/+0
2009-07-19Remove unnecessary imports.Jelmer Vernooij6-14/+9
2009-07-19Merge branch 'master' of git://git.samba.org/sambaJelmer Vernooij20-194/+100
2009-07-19Include ntsvc NDR in libndr-standard.Jelmer Vernooij1-8/+5
2009-07-19Remove unused variable.Jelmer Vernooij1-1/+0
2009-07-19source4/lib/registry/patchfile.c(reg_diff_load): fixed possible resource leak.Slava Semushin1-0/+1
File descriptor leaks when write(2) fails and we are returning from function. Found by cppcheck: [./source4/lib/registry/patchfile.c:319]: (error) Resource leak: fd
2009-07-19lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.Slava Semushin1-0/+1
Found by cppcheck: [./lib/util/util_file.c:383]: (error) Resource leak: fd
2009-07-19Fix broken password quality checkMatthieu Patou2-1/+4
This fixes broken password tests when the passwords contain non ASCII characters (e.g. accentuated chars like ('e, `e, ...)
2009-07-19Fix typoMatthias Dieter Wallnöfer1-1/+1
2009-07-19[SAMBA 4] Some cosmetic changes for the LDB modulesMatthias Dieter Wallnöfer2-12/+12
Some corrections which make the code a bit more readable (no functional changes here)
2009-07-19include unix.h if it's availableMatt Kraai2-0/+5
2009-07-19Cosmetic correctionMatthias Dieter Wallnöfer1-1/+1
Changes the order of two commands. First set up the "priv" structure, then assign it to the "ntvfs" structure.
2009-07-19Merge more ndr interfaces into libndr-standard.Jelmer Vernooij2-59/+23
2009-07-19librpc: Integrate some subsystems now part of libndr-standard and integrate ↵Jelmer Vernooij1-30/+14
ndr_dfs in libndr-standard.
2009-07-19Add missing includes.Jelmer Vernooij2-0/+2
2009-07-19provision: Remove unused imports.Jelmer Vernooij1-4/+0
2009-07-19Create libndr-standard, which includes the NDR marshalling code forJelmer Vernooij4-19/+41
the "standard" set of DCE/RPC interfaces found on Windows.
2009-07-19Remove unnecessary include, update README.Jelmer Vernooij2-4/+0
2009-07-19Remove outdated status file about samba3 -> samba4 upgrade project.Jelmer Vernooij1-68/+0
2009-07-19Fix a few type errors in VFS modulesVolker Lendecke6-10/+18
2009-07-18VFS examples: Update copy of config.{guess,sub}.Jelmer Vernooij2-75/+282
2009-07-18python: Set right ldb modules directory when using system ldb.Jelmer Vernooij1-0/+2
2009-07-18Actually fill in ldb modules directory.Jelmer Vernooij1-1/+1
2009-07-18Remove pyldb_util and simply duplicate the 5-line function it contains,Jelmer Vernooij6-53/+21
rather than creating a separate shared library for it.
2009-07-18ldb: Display SHLD_FLAGS when building.Jelmer Vernooij1-0/+1
2009-07-17Fix Coverity CIDs 887, 888. Don't pass NULL's to functionsJeremy Allison1-4/+3
that deref them. Jeremy.
2009-07-17Fix Coverity CID 928. Removed check as this can never be null.Jeremy Allison1-1/+1
Jeremy.
2009-07-17Fix Coverity CID 929. Potential NULL deref after code refactoring.Jeremy Allison1-0/+5
Jeremy.
2009-07-17Fix coverity CID 930. Pointer check can never be null here.Jeremy Allison1-1/+1
Jeremy
2009-07-17Fix coverity CID 931. This check is redundent as smb_fname canJeremy Allison1-1/+1
never be null in this function. Jeremy.
2009-07-17Fix a typo reading uninitialized memory. Caught by valgrind.Jeremy Allison1-3/+1
Jeremy.
2009-07-17Move the initialization of smbd_server_conn from smbd/process,Jeremy Allison2-5/+5
after the accept and fork, to smbd_init_globals(), so it's done immediately on server startup. This is needed as some messages are sent to all active smbd processes (including the master listening daemon). If it gets a message that forces it to scan it's current connections (ie. conn_find()) then it discovers that sconn->smb1.tcons.Connections dereferences null (as sconn == NULL in the parent) and crashes. Yes, I could fix all cases where sconn is used and explicitly check for NULL but this fix is easier. It means that the smbd_event_context() is initialized in the master daemon and then re-initialized after fork, but that should be being done correctly in every fork call anyway. Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789 still panics in the reproducible test case for bug 6564, as this is one case where such a message (MSG_SMB_CONF_UPDATED) is sent to the parent. Metze please check. This change passes valgrind. Jeremy.
2009-07-17Fix bug #6564 - SetPrinter fails (panics) as non root.Jeremy Allison2-0/+5
Missing become_root()/unbecome_root() around reload_services. Jeremy.
generated by cgit (git 2.34.1) at 2024-12-30 17:48:59 +0000