summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-06-26s3:net registry import: reduce indentationMichael Adam1-7/+8
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-26s3:net registry import: fix the return code when transaction commit failsMichael Adam1-1/+1
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-26s3:net registry import: improve regdb_open/close layeringMichael Adam1-3/+4
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
2012-06-26s3:net registry import: untangle nested function callsMichael Adam1-3/+8
2012-06-26s3:net registry import: reduce indentation and untangle assignment from checkMichael Adam1-4/+9
in import_with_precheck_action().
2012-06-26s3:net registry import: move precheck-and-import code to its own functionMichael Adam1-9/+20
This is the code that is executed in a registry transaction. The purpose of the refactoring is to be able to simplify and untangle the code structure in the sequel.
2012-06-26s3:net registry: fix violation of coding conventionsGregor Beck1-32/+35
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:net registry import: add option --precheckGregor Beck3-5/+197
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: add function registry_value_cmp()Gregor Beck2-0/+10
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:net registry import: check return values + codecleanupGregor Beck1-16/+30
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:net registry: fix output of dwords with sign bit setGregor Beck1-1/+1
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: fix possible double free in importGregor Beck1-0/+1
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: improve debug output in reg_parseGregor Beck1-1/+2
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: add functions to conveniently create registry_valuesGregor Beck2-0/+65
Pair-Programmed-With: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: silence net_deletekey_recursiveGregor Beck1-4/+4
WERR_BADFILE may not be an error for the caller because the result is the same. Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26s3:registry: make reg_delete_path() delete the path recursively.Michael Adam1-3/+3
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> (cherry picked from commit a56992ab71032b54d9879834c12f6b88e6174cb4)
2012-06-26s3:registry: compile reg_create_path() & reg_delete_path()Gregor Beck2-7/+0
Signed-off-by: Michael Adam <obnox@samba.org>
2012-06-26Merge suggested fix from bug 7511 and enhance itBjörn Jacke1-3/+2
Changes from Lars Müller and Olaf Flebbe: a) The location in the filesystem defaults to STATEDIR/usershare b) If undefined the default location is used; if set to zero (the default) user defined shares are ignored. Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Tue Jun 26 19:55:00 CEST 2012 on sn-devel-104
2012-06-26s3:test_registry_upgrade: make more portable and eliminate "local" keywordBjörn Jacke1-6/+6
prefer to use function syntax with (...) to make variables local
2012-06-26s3-torture: Use static printer for smbd spooler testDavid Disseldorp1-1/+9
Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Tue Jun 26 18:04:43 CEST 2012 on sn-devel-104
2012-06-26s3-printing: use euid for vlp job trackingDavid Disseldorp1-1/+2
vlp can be called by print_run_command as root with euids set appropriately, vlp should use this to track the job owner.
2012-06-26s3-printing: fill print_generic sysjob id on job submissionDavid Disseldorp1-57/+88
Change the generic print backend to fill the printing backend job identifier (sysjob) on submission of a new job. This is needed to ensure correct mapping of spoolss jobs and entries in the backend print queue. This and the last 13 commits attempt to address bug 8719.
2012-06-26s3-printing: pass lpq command to job_submitDavid Disseldorp5-5/+37
Currently the generic print backend does not fill the printing backend job identifier (sysjob) on submission of a new job. The sysjob identifier is required to correctly map jobs in the printer queue to corresponding spoolss print jobs. Passing the lpq command to job_submit allows the generic print backend to check the printer queue for the new job following submission. This behaviour will come in a later commit.
2012-06-26s3-printing: remove unused print_job_fname()David Disseldorp2-17/+1
2012-06-26s3-printing: pass a talloc ctx to unpack_pjobDavid Disseldorp2-18/+22
Rather than allocating the devicemode on a null context.
2012-06-26s3-printing: return talloced print jobsDavid Disseldorp2-96/+199
print_job_find() currently returns print jobs to callers via a statically allocated variable, this is particularly messy as the device mode is talloced under the static variable. This change adds or passes a talloc context to all callers, giving them ownership of the returned print job.
2012-06-26s3-printing: clean up print_job_pause/resume interfaceDavid Disseldorp3-31/+36
Currently both return a bool and sometimes set a werr pointer argument, always return werror instead.
2012-06-26s3-printing: fix potential print db refcount leakDavid Disseldorp1-1/+1
2012-06-26s3-spoolss: remove duplicate "." in smbd spooler pathDavid Disseldorp1-3/+8
2012-06-26s3-printing: remove print_parse_jobid()David Disseldorp2-20/+0
With all callers fixed, it is now safe to remove.
2012-06-26s3-printing: remove redundant variable setDavid Disseldorp1-3/+0
2012-06-26s3-printing: remove print_parse_jobid() calls from printing.cDavid Disseldorp1-21/+27
In all cases the spoolss layer job id can be determinded from the printing subsystem allocated job identifier (sysjob).
2012-06-26s3-printing: rename queue->job sysjobDavid Disseldorp6-35/+35
Print jobs maintain two job identifiers, the jobid allocated by the spoolss layer (pj->jobid), and the job identifier defined by the printing backend (pj->sysjob). Printer job queues currently only contain a single job identifier variable (queue->job), the variable is sometimes representative of the spoolss layer job identifier, and more often representative of the printing backend id. This change renames the queue job identifier from queue->job to queue->sysjob, in preparation for a change to only store the printing backend identifier.
2012-06-26s3-printing: remove print_parse_jobid() from print_cups.cDavid Disseldorp1-11/+1
The spoolss print job identifier is now passed to the cups layer via struct printjob, therefore it is no longer necessary to parse the job filename to determine it.
2012-06-26s3-printing: store print jobid as part of struct printjobDavid Disseldorp2-13/+19
Printing code in some places relies upon the spool-file format to retrieve the print jobid. By storing the jobid as part of struct printjob, and hence in the printing TDB, we can move away from this ugly behaviour.
2012-06-26torture: add test for smbd print job spoolingDavid Disseldorp1-0/+73
Clients can print by performing file IO on a printer share, rather than issuing spoolss RPCs. This commit attempts to reproduce bug 8719.
2012-06-26s3-pdbtest: Fix pdbtest to compare the same fieldsAndrew Bartlett1-1/+1
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Jun 26 16:09:28 CEST 2012 on sn-devel-104
2012-06-26s4-samldb: do not talloc_steal() the elements of the original requestAndrew Bartlett1-4/+10
2012-06-26s3-pdbtest: Report and handle errors in pdb->getsampwnam()Andrew Bartlett1-3/+5
2012-06-26s3-pdb_samba4: Allocate and free a talloc_stackframe() in ↵Andrew Bartlett1-3/+10
pdb_samba4_replace_by_sam()
2012-06-26s3: Restore async i/o with the "native" AIO interfaceVolker Lendecke2-4/+1
eff3609 moved the async signal handler initialization to later in the process to enable aio_fork and aio_pthread on platforms without realtime signals. This commit broke the use of the native aio interface. aio_pending_size is initialized to 0, so aio.c will not allow async i/0 at all if modules do not set that variable correctly. Initialize to 100 right from the start. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue Jun 26 14:08:22 CEST 2012 on sn-devel-104
2012-06-26s3:smbXsrv_tcon: pass max_tcons explicitly for smbXsrv_tcon_table_init()Stefan Metzmacher1-9/+24
metze
2012-06-26s3:smbXsrv_session: pass max_sessions explicitly for ↵Stefan Metzmacher1-9/+24
smbXsrv_session_table_init() metze
2012-06-26tdb: finish weaning off err.h.Rusty Russell7-23/+28
Commit 3c4263e7580143c69225729f5b67f09c00add2fd said it removed err.h from tdb, unfortuntely it didn't: tap-interface.h still included it. This finishes it properly! Reported-by:Stefan Metzmacher <metze@samba.org> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date(master): Tue Jun 26 10:22:03 CEST 2012 on sn-devel-104
2012-06-26s3:test_net_registry_check: eliminate "local" keyword in shellBjörn Jacke1-15/+15
prefer to use function syntax with (...) to make variables local Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Tue Jun 26 00:32:11 CEST 2012 on sn-devel-104
2012-06-25s3:Makefile: use our "$MAKE" instead of "make" in our own MakefileBjörn Jacke1-2/+2
2012-06-25s3:selftest: run SMB2-SESSION-RECONNECTStefan Metzmacher2-1/+2
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Mon Jun 25 22:42:03 CEST 2012 on sn-devel-104
2012-06-25selftest/known: samba3.smb2.session.*reconnect passes nowStefan Metzmacher1-1/+0
metze
2012-06-25s3:smb2_sesssetup: make use of smb2srv_session_close_previous_send/recvStefan Metzmacher1-0/+66
metze
2012-06-25s3:smbXsrv_session: react on MSG_SMBXSRV_SESSION_CLOSEStefan Metzmacher1-0/+154
metze