Age | Commit message (Collapse) | Author | Files | Lines |
|
- changed the hash size to 13 (much smaller than before). This should
make for more efficient shared memory usage as it will lead to less
fragmentation.
(This used to be commit 9c1e4c2dae6323c9a1bd74148d0b45aac61e7c0a)
|
|
memory then frees it. Useful for catching bugs.
(This used to be commit 99782754f79f3795f81cbf57caeb0925f6a66c10)
|
|
to account for padding/alignment issues. Eventually I'd like to find a
way to get rid of this construct altogether as it is a bit error
prone and hard to debug.
also added a new macro:
ZERO_STRUCTP() that takes a pointer to a structure and zeros the
structure. Used in nmbd to zero allocated structures before freeing
them to try to catch bugs a bit faster.
(This used to be commit d3dda65d5177154e2128f50ca3dd34e8e13b6b08)
|
|
areas of memory before freeing them.
While doing this I also found a couple of real bugs. In two places we
were freeing some memory that came from the stack, which leads to
a certain core dump on many sytems.
(This used to be commit c5e5c25c854e54f59291057ba47c4701b5910ebe)
|
|
dumps. It is gone until someone can tell us why its needed and what it
does. (It was only used on OSF1 and core dumped there anyway!)
(This used to be commit a564e4662711d384069757ce3ee5adcadc1b061d)
|
|
(This used to be commit f18b4e95bffb25fa016dd6e7f9a128a9fc69466f)
|
|
correctly. Added new parameter "stat cache size" - set to 50 by default.
I now declare the statcache code officially "open" for business :-).
It gets a hit rate of 97% with a NetBench run and seems to make
using a case insensitive run as efficient as a case sensitive run.
Also tidied up our sys_select usage - added a maxfd parameter and
also added an implementation of select in terms of poll(), for systems
where poll() is much faster. This is disabled by default.
Jeremy.
(This used to be commit 779b924ec1f6c81ff578d22295b20fece698d1fc)
|
|
problem was a buffer overflow in process_node_status_request().
this really points out a general problem is allocating MAX_DGRAM_SIZE
packets on the stack in nmbd. There must be a better way.
(This used to be commit 7db45f169c33e0f3a67ba2260049226992de8bdf)
|
|
Jeremy.
(This used to be commit d6a9087e7e626e6e07503dba38854b136fe70c23)
|
|
NetBench testing though.... :-). Attempts to efficiently reduce
the number of stat() calls Samba does.
Jeremy.
(This used to be commit d0e48a2d8072c3e77a57ac6a2fb5044c05f03b41)
|
|
(This used to be commit cdc38c276d8344127c9edf35f24754c098a90754)
|
|
arrays. This prevents (harmless) warnings from some compilers
(This used to be commit c2da46d1d0820a86e7f77506563cfe7f67b08fee)
|
|
(This used to be commit afe98165a261a740cd0ee88bf041d69721ec72e6)
|
|
needs them and what should really be there.
(This used to be commit c2bf18fb8d2fea5af86ba8cf5d92b1dc076dd7d5)
|
|
(This used to be commit c8b0041570a1fb0be0318f511c6ba746c733cda9)
|
|
the changes made re: -a and -o options.
Chris -)-----
(This used to be commit e162819054d0241e92978b6b630be8cccc886caf)
|
|
rpcsvc/ypclnt.h wants a struct dom_binding. knock-on include effect under
freebsd 2.1.
(This used to be commit d1005b5692e41660a2a7230231b0591aa0773485)
|
|
(This used to be commit 2af95650174ae02a9768fbbbf7c206e15bf18f79)
|
|
(This used to be commit e4f81f4a230130f53857e3664e6d83ce252c207e)
|
|
(This used to be commit b32a346a1c50ba40224b8165e08e78867be2d376)
|
|
if ((sbuf->st_mode & S_IWUSR) == 0)
result |= aRONLY;
rather than the very complex user/group permissions checks we do
currently. This is equivalent ot setting "alternate permissions = yes"
in the old code. The change is motivated by three main reasons:
1) it's basically impossible to second guess whether a file is
writeable without trying to open it for writing. ACLs, root squash etc
just make it too hard.
2) setting it not RONLY if the owner can write is closer to what NT
does (eg. look at a cdrom - files are not marked read only).
3) it prevents the silly problem of copying files from a read only
share to a writeable share and then finding you can't write to them as
windows preserves the RONLY flag. Lots of people get bitten by this
when they drag a folder from a Samba drive. It also hurts some install
programs.
I have also added a new flag type for loadparm.c called
FLAG_DEPRECATED which I've set for "alternate permissions". I'll soon
add code to testparm to give a warning about deprecated options.
(This used to be commit c4363a12fdc0be329ca2bfeb1d7b89bfe90031dc)
|
|
SMB_SET_FILE_ALLOCATION_INFO.
Office 97 expects this call to succeed when you tell it you do NT SMB calls.
Jeremy.
(This used to be commit 260e7e27401d863e9f580d4748c577334d9fc9d0)
|
|
have an ASSERT macro defined.
Jeremy.
(This used to be commit dbe6ad014a8b5dcbf17d7cd9865650c2e040d666)
|
|
(This used to be commit e94ab03a4f97ff7ee7bb938245cf054a00f950fd)
|
|
in the rpc code.
(This used to be commit e6ce1c5b5a9f29d8fcbbd23019186ff5c600e795)
|
|
(This used to be commit bd9290c36c9993a994e485da0a81df926f8662e4)
|
|
If the output line is longer than the format buffer could manage, I was
simply ignoring the additional output (that is, *not* copying it to the
format buffer--thus avoiding a buffer overrun). Instead, I now output
the current content followed by " +>\n", and then reset the format buffer.
I have never seen a debug line that exceeds the size of a pstring, but I
might as well handle the situation...just in case.
Chris -)-----
(This used to be commit 8a11d04b7796b256953bf92b2f2ccab763215bc4)
|
|
default to overwrite and smbd would default to append. Also, the -a option
(actually a toggle, such that "-a -a" would set the default) was documented
as append mode for nmbd, and *overwrite mode* for smbd.
nmbd now defaults to append mode, to match smbd. The -a option now always
means append, and I've added the -o option to both, meaning overwrite.
Note that the change to nmbd's default behavior may confuse some people.
I've not seen anything about 2.0.0 changes in the WHATSNEW.txt file.
Where would I document a change like this?
Chris -)-----
(This used to be commit b1d374fb14b1fb92a84260f1dcc59a39a4b99a3d)
|
|
if we do then NTws gets a BSOD.
I checked and NT server refuses these queries too :)
(This used to be commit d2fb7ee8f55dd1ff25fca46e18b02a05bc2b71ae)
|
|
Note: It is intended to extend this so that the release
process produces all the packaging scripts, templates, etc.
that may be needed.
(This used to be commit 6e196841c618044d33da45d3de5371004a58e4c6)
|
|
explanation.
(This used to be commit c6899df44c34088a4d2bf1edc840320b0ba7e32e)
|
|
Luke, you need to do something similar in the rest of the rpc code.
Have fun!
(This used to be commit bdd8aaa544780898e20189195d4019b9beb4445c)
|
|
structures declared on the stack.
(This used to be commit f323af8fce54cd5d51c848aa7ea7be4dd3538f2e)
|
|
Regards
Richard Sharpe
(This used to be commit 749ec1e0a79c5836bba0fc0213576ed79ef761d5)
|
|
(This used to be commit 268cbede0fd909da1cb5bbc964244456f32006a6)
|
|
(This used to be commit 0d641d0cebfbd8cc6015d2361e088ce0410c5d20)
|
|
perms on lock dir should be 755 not 644.
(This used to be commit 930a4292e95947d20696b7ce08bbb936442fe327)
|
|
basename of a file but the whole file name. silly error.
(This used to be commit 6e00de7a1d3d5f9fa9bcc40db119fcb8602165c9)
|
|
chain_fsp on close (if you don't know what this means, consider yourself
lucky - this one took a day to track down :-).
Jeremy.
(This used to be commit 193cb5382464173e99a538867a266d793f0ceab5)
|
|
the head of an SMB request (ie. are part of a chain) will not be queued -
this will be fixed when we move to the new chain code. In practice, this
doesn't seem to cause much of a problem (in my admittedly limited testing)
bug a debug level zero message will be placed in the log when this
happens to help determine how real the problem is.
smbd/locking.c: New debug messages.
smbd/blocking.c: New blocking code - handles SMBlock, SMBlockread and SMBlockingX
smbd/chgpasswd.c: Fix for master fd leak.
smbd/files.c: Tidyup comment.
smbd/nttrans.c: Added fnum to debug message.
smbd/process.c: Made chain_reply() use construct_reply_common(). Added blocking
lock queue processing into idle loop.
smbd/reply.c: Added queue pushes for SMBlock, SMBlockread and SMBlockingX.
Jeremy.
(This used to be commit e1dd03ecda0bc6d7eaa31070c83774bb5679fd1b)
|
|
permissions.
(This used to be commit 10303a78d4b12a03166db89202759cd745c516c5)
|
|
(This used to be commit dbe333b590ef004ccbd31a14ad161d73139b2486)
|
|
Jeremy.
(This used to be commit 9cdb148ef56dc8f74891f5c6e9cae10142bd4c6e)
|
|
include/includes.h: Added nterr.h.
locking/locking.c: Moved blocking lock code into smbd/blocking.c for link purposes.
smbd/close.c: Added blocking lock removal to file close.
smbd/filename.c: Tidied up unix_convert() so I could read it (:-) in preparation
for the stat_cache code.
smbd/nttrans.c: Added WRITE_ATTRIBUTES check.
smbd/reply.c: Fixed multibyte char problem in wildcard mask.
Jeremy.
(This used to be commit 148eaba3dadb1d0bd3ac3ef53da3d9811636e89a)
|
|
locking/locking.c: More blocking lock changes.
Jeremy.
(This used to be commit 2ca4fc95a4227645f1009a057d46b58508846a92)
|
|
could be overwritten in oplock processing code.
Jeremy.
(This used to be commit 908a583b48e37c5e869216f4dc92d4a587ff1238)
|
|
(This used to be commit 722312c326d54849e2552327fcd88ac77257ad2c)
|
|
(This used to be commit f92475aa3cb3ade576c39c02c7996c949c42082a)
|
|
the splitup was done with an axe, not a scalpel, so there are some
rough edges. I mostly wanted to get the general form right with fine
tuning of what goes where to come later. Still, this is better than
what we had before where server.c was a general repository for
anything that didn't fit elsewhere.
(This used to be commit a6d194886a4a5f7507fa37289ff96c1be56f14a6)
|
|
created dosmode.c and filename.c
(This used to be commit 534a90ca44641417c21f6ed6d4b94b1de60f808d)
|