Age | Commit message (Collapse) | Author | Files | Lines |
|
On a debian lenny installation with a kernel that calls itself 2.6.28, I could
repeatably block smbd using splice. According to the output of netstat, the
recvq of the TCP connection was full and at the same time according to strace
smbd was stuck in a splice syscall trying to read from that TCP connection. We
can not protect ourselves from this condition, as nobody will ever notify us
that something is broken. So sadly we can't use splice yet at all. Maybe in
2.6.29...
|
|
According to the splice(2) manpage, one of the file descriptors *must* be a
pipe. With this patch I could successfully run splice(2) on a debian lenny
installation.
Jeremy, please check!
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
reinit_after_fork() already calls messaging_reinit()
metze
|
|
|
|
The callers of open_file_ntcreate expect *psbuf to be filled correctly
|
|
888524623d179ceb4d540f5ac0f3b013d3ce5735 broke the build. I'm
reverting it for the short term, while I work on a better fix.
|
|
Jeremy
|
|
|
|
The warning:
../librpc/gen_ndr/ndr_spoolss.c: In function ‘ndr_pull_spoolss_EnumPrinterData’:
../librpc/gen_ndr/ndr_spoolss.c:14792: warning: passing argument 1 of ‘memset’ discards qualifiers from pointer target type
In some case the pidl generated code needs to memset a const struct
field. This causes the above warning. This patch discardeds the const
in this case. I'm open to a more elegant fix, but this eliminates the
warning and should be relatively safe.
|
|
|
|
This fixes a series of samba3 build warnings in the merged build:
'error: "X" redefined', where X is one of the redundant #defines
|
|
|
|
|
|
This means we correctly pass IPv6 addresses too.
(CTDB_CONTROL_TCP_CLIENT was IPv4 only)
metze
|
|
We allocated "request" with ippNew, so we also should ippDelete it.
|
|
Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
|
|
|
|
Incrementing the next vuid did not correctly overflow
Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)
Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
|
|
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().
Jeremy, please check!
|
|
|
|
get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
|
|
|
|
invalidate_vuid takes care of removing the user_struct from validated_users
|
|
metze
|
|
Bug report by Brad Hards <bradh@frogmouth.net>.
metze
|
|
When we don't know how to handle a type for the python bindings,
we should not generate invalid C code.
Jelmer: please fix do the full fix for this.
metze
|
|
winbind_idmap.tdb
This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4.
metze
|
|
The upgrade is required because of the followin TDBSAM_VERSION
upgrade.
metze
|
|
This marshalling isn't specific to tdbsam and it's
ugly to have the related functions in two different files.
metze
|
|
metze
|
|
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"
for s in $list; do
o=`echo $s | cut -d ':' -f1`
n=`echo $s | cut -d ':' -f2`
r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
for f in $files; do
cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
mv $f.tmp $f
done
done
metze
|
|
metze
|
|
metze
|
|
deadtime hits without any files open. To enable long runtimes, open a file with
delete_on_close set.
|
|
We don't need a full copy of ctdb...
If we want to readd cluster support,
we should just use a ctdb client library.
metze
|
|
If we readd this later, we should share the code with
samba3 and make it async/non-blocking.
metze
|
|
makes the"
This reverts commit 4792285282e2ec78ccb0ebc3cac6465d1d26ef10.
Conflicts:
source4/ntvfs/common/brlock_tdb.c
source4/ntvfs/common/config.mk
|
|
|
|
It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
|
|
|
|
|