summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-05-14s3:rpc_server/srvsvc check access before doing workShekhar Amlekar1-10/+10
Before doing the (potentially) costly enumerations, check if the user has necessary privileges first Signed-off-by: Shekhar Amlekar <samlekar@in.ibm.com> Reviewed-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Tue May 14 16:22:24 CEST 2013 on sn-devel-104
2013-05-14torture: Remove some unused codeVolker Lendecke1-5/+0
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christian Ambach <ambi@samba.org>
2013-05-14tdb: include information about hash function being used in tdbtool info outputChristian Ambach1-0/+2
makes it possible to easily determine if the tdb under examination uses jenkins hash or not Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
2013-05-14smbd: Remove a pointless variableVolker Lendecke1-2/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 14 13:19:44 CEST 2013 on sn-devel-104
2013-05-14selftests-drs: make our generated class subclass of classschemaMatthieu Patou1-1/+2
Without this change objectclass=["top", "classSchema", "Foobar"] will not be sorted correctly and will generated an error saying that class Foobar is unreleated to classSchema (which is not true). It's mimicing what other classes of the default schema are doing (ie. contact) Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue May 14 07:07:19 CEST 2013 on sn-devel-104
2013-05-14Export PROMOTED_DC related variableMatthieu Patou2-0/+11
Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-05-14dsdb: make the name of non related class more obviousMatthieu Patou1-2/+3
Signed-off-by: Matthieu Patou <mat@matws.net> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-05-14build: Add missing dep from vfs_nfs4acl_xattr to NDR_NFS4ACLAndrew Bartlett1-1/+1
Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Tue May 14 01:23:17 CEST 2013 on sn-devel-104
2013-05-12lib: Fix CID 241650 Sizeof not portableVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Sun May 12 17:44:55 CEST 2013 on sn-devel-104
2013-05-12pthreadpool: Fix CID 710828 Sizeof not portableVolker Lendecke1-1/+1
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
2013-05-12dbwrap: Fix CID 1002092 Uninitialized scalar variableVolker Lendecke1-1/+3
We don't set saved_errno in the ret==0 case. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
2013-05-10docs: smb.conf: fix max read/write/trans default values (bug #9871)Björn Baumbach3-6/+15
Commit 6d128aac119d948f0ecb0dcf6b400b4eb4027fe6 has increased the limit: "s3:smb2_server increase defaults for read/write/trans sizes to 1MB" Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri May 10 23:14:50 CEST 2013 on sn-devel-104
2013-05-09s4:torture fix a build break on AIXChristian Ambach1-1/+0
Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu May 9 08:05:12 CEST 2013 on sn-devel-104
2013-05-09s3:modules/vfs_aixacl2 fix compile errorsChristian Ambach1-9/+8
fix various compile errors that were introduced with latest ACL changes Signed-off-by: Christian Ambach <ambi@samba.org> Pair-Programmed-With: Alexander Werth <alexander.werth@de.ibm.com> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09Fix missing TALLOC_FREE of stackframes.Jeremy Allison2-2/+6
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-05-09Tidy up old bool usage. False -> false, True -> true.Jeremy Allison1-13/+13
Signed-off-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Allow CREATOR GROUP to be used with vfs_zfsaclAndrew Bartlett1-1/+1
The solaris acl() code requires that both ACE_GROUP|ACE_IDENTIFIER_GROUP be set to indicate the @group permissions. Otherwise, it would return Invalid Paramter to clients. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s4-smbtorture: Run tests for nfs4:modes simple and special.Alexander Werth3-9/+26
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Update vfs_gpfs man page with new nfs4:mode help text.Alexander Werth1-6/+6
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Update README.nfs4acls.txtAlexander Werth1-8/+15
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Use mode bits in some cases in mode simple.Alexander Werth1-0/+46
Non inheriting ACL entries will show mode bits. With this an file owner change does affect the effective ACL because the special owner acl will now refer to the new owner. This could be fixed by updating the ACL on a file owner change. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Add changes that keep nfs4:mode special behavior.Alexander Werth1-1/+41
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Mapping of cifs creator owner to nfs owner@ ace.Alexander Werth1-0/+24
This is ignored in nfs4mode special for compatibility. Also ensure that we drop non inheriting creator owner aces since these don't contribute to who can access a file. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Mapping of special entries to creator owner in mode simple.Alexander Werth1-6/+60
Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Add params parameter to smbacl4_nfs42win function.Alexander Werth1-12/+27
Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Change smbacl4_get_vfs_params to use connection_struct instead of fsp.Alexander Werth1-5/+6
Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s3: Move up declaration of params struct and related function.Alexander Werth1-49/+49
We need the parameters earlier in the code so we move up the declaration of the params struct. Since reading the parameters is closely related the definition of the function smbacl4_get_vfs_params has also been moved up. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09s4-smbtorture: Set result message when failing the inheritance test.Alexander Werth1-0/+7
Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add inheritance emulation to vfs_nfs4acl_xattr.Alexander Werth2-30/+263
Recursively inherit ACL from parent directory if no acl xattr is found on the current file. Use a default ACL if a non-inheriting ACL is encountered. With this the nfs4acl_xattr.dynamic test passes. But the nfs4acl_xattr.inheritance test results in an error because of warnings that cause the test to pass a failed result. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09selftest: Run raw.acls test against the nfs4acl_xattr moduleAndrew Bartlett3-0/+18
This is the first time we have tested the NFSv4 ACL mapping code. Sadly most tests fail but these can be fixed from here. This at least shows that the code does not segfault. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09librpc: Add special owner/group/other constants to nfs4acl.idlAndrew Bartlett1-0/+4
As per nfs4acl-0.9/lib/nfs4acl.c (the package where this structure is originally defined) Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09build: Add vfs_nfs4acl to the autoconf buildAndrew Bartlett2-1/+4
Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add new VFS module vfs_nfs4acl_xattr to use nfs4acl.idlAndrew Bartlett5-2/+430
This uses the xattr format used by the patches at http://users.suse.com/~agruen/nfs4acl/ Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Remove unused security_info argument in vfz_zfsacl.cAndrew Bartlett1-3/+1
Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Fix compile of vfs_gpfs.c.Alexander Werth1-18/+33
Since the smb4acl is now correctly allocated on mem_ctx and not the talloc stack frame we can free the stack frame correctly. And the chmod emulation code now needs the vfs handle since that is now required by the callback function to set the smb4acl. Reviewed-By: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Allocate SMB4ACL_T on an explict memory contextAndrew Bartlett5-33/+78
This ensures the caller knows exactly what the memory lifetime of this returned object is. This makes the NFSv4 ACL code consistent with the POSIX and NT ACL code, to avoid supprising developers who have worked on those other parts of the ACL code. Most of this patch is adding a memory context to the callers and passing it in. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09vfs: Add vfs_handle_struct argument to smb_set_nt_acl_nfs4 and the callbackAndrew Bartlett5-15/+16
This allows the callback to call xattr based storage functions that need this argument. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-09build: Move nfs4acl to the top levelAndrew Bartlett5-9/+7
This is to create IDL-stored NFSv4 ACLs, just as we use for posix ACLs to permit better testing. Andrew Bartlett Reviewed-by: Jeremy Allison <jra@samba.org>
2013-05-08pidl:NDR/Parser: correctly set $ndr->[relative_highest_]offset for ↵Stefan Metzmacher1-1/+1
relative_short pointers Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Wed May 8 20:49:55 CEST 2013 on sn-devel-104
2013-05-08Revert "Remove a bunch of "unused variable _relative_save_offset" warnings."Stefan Metzmacher1-4/+2
This reverts commit fa5898b6de797431d5ae9d2ce6dcddcb35a60b66. This is the wrong fix for the warnings, the correct fix will follow. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Günther Deschner <gd@samba.org>
2013-05-08Remove a bunch of "unused variable _relative_save_offset" warnings.Jeremy Allison1-2/+4
Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Wed May 8 07:47:45 CEST 2013 on sn-devel-104
2013-05-07Tests processing an oplock break within a compound SMB2 request.Richard Sharpe2-0/+164
Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Richard Sharpe <sharpe@samba.org> Autobuild-Date(master): Tue May 7 19:45:36 CEST 2013 on sn-devel-104
2013-05-07Remove the compound_related_in_progress state from the smb2 global state.Jeremy Allison2-12/+0
And also remove the restriction that we can't read a new request whilst we're in this state. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@samba.org>
2013-05-07The core of the fix to allow opens to go async inside a compound request.Jeremy Allison1-43/+53
This is only allowed for opens that cause an oplock break, otherwise it is not allowed. See [MS-SMB2].pdf note <194> on Section 3.3.5.2.7. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Move a variable into the area of code where it's used.Jeremy Allison1-2/+2
Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Ensure we don't try and cancel anything that is in a compound-related request.Jeremy Allison1-0/+8
Too hard to deal with splitting off the replies. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Only do the 1 second delay for sharing violations for SMB1, not SMB2.Jeremy Allison1-1/+2
Match Windows behavior. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
2013-05-07Makefile: Fix bug 9868 - Don't know how to make LIBNDR_PREG_OBJ.Volker Lendecke1-1/+1
Thanks to Lucs for finding the issue Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Günther Deschner <gd@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue May 7 17:57:57 CEST 2013 on sn-devel-104
2013-05-07winbind: Fix bug 9854 -- NULL pointer dereferenceVolker Lendecke1-3/+3
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 7 14:49:07 CEST 2013 on sn-devel-104
2013-05-07Fix up the man pages to explain that "store dos attributes" overrides them.Jeremy Allison5-2/+26
Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue May 7 01:24:54 CEST 2013 on sn-devel-104
generated by cgit (git 2.34.1) at 2024-11-16 13:44:42 +0000