summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-04-16In net_conf_import, start a transaction when importing a single share.Martin Schwenke1-0/+8
Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction start to be conditional but the commit is still unconditional, so an error occurs when importing a single share. An alternate fix would be to return the transaction start to be unconditional but then it would occur before other error checking. Signed-off-by: Martin Schwenke <martin@meltin.net> Signed-off-by: Michael Adam <obnox@samba.org>
2009-04-16tsocket: fix the build without ipv6 supportStefan Metzmacher1-0/+2
metze
2009-04-16s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.Günther Deschner1-1/+9
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED. Guenther (cherry picked from commit 1c9266c8caa59e287b993393b6050732a0b33547)
2009-04-15Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+Jeremy Allison12-59/+51
What a difference a name makes... :-). Just because something is missnamed SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN, don't automatically use it for a security check in _samr_OpenDomain(). Jeremy.
2009-04-15s4-smbtorture: Fix crash bugs in RPC-SAMR_ACCESSMASK.Günther Deschner1-7/+15
Also disable security descriptor based tests while testing samba3. Guenther
2009-04-15s3-examples: make sure to match correct key name in adssearch.Günther Deschner1-1/+1
Guenther
2009-04-15s4-smbtorture: define TORTURE_DEFAULT_SERVICE and set to netlogon.Günther Deschner1-6/+8
Guenther
2009-04-15Enable software rollout through ADMatthias Dieter Wallnöfer1-0/+10
This enables the sofware rollout feature in Samba4 Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2009-04-14Ensure a tls key is only generated once - wrap create & destroy in a mutex.Jeremy Allison4-40/+71
Change the function names to add _once to the tls_create & tls_destroy to make this obvious. Jeremy.
2009-04-14s3-spoolss: Fix format of description string in spoolss_PrinterInfo1.Günther Deschner1-10/+6
This is what windows does and should get us closer to show the appropriate printer location string in explorer. Guenther
2009-04-14netdomjoin-gui: make sure to grey out change fields when not running as root.Günther Deschner1-0/+15
Guenther
2009-04-14Try and fix the S4 build - include thread includes.Jeremy Allison1-0/+4
Jeremy.
2009-04-14Make talloc_stack threadsafe using TLS. Volker pleaseJeremy Allison4-25/+93
check. Passes make test and basic valgrind testing. Jeremy.
2009-04-14libwbclient: Fix undocumented arguments doxygen warnings.Günther Deschner1-8/+8
Guenther (cherry picked from commit f2b3fbf0c04a6f9484853da263174a472eb6bb6d)
2009-04-14s3-nsswitch: fix make test_wbpad.Günther Deschner1-1/+1
Guenther
2009-04-14socket_wrapper: fix the build on systems without ipv6 supportStefan Metzmacher1-0/+2
metze
2009-04-14s4-smbtorture: make sure samba3 does not regress in EnumServicesStatusW call.Günther Deschner1-0/+3
Guenther
2009-04-14s3-svcctl: fix memcpy in _svcctl_EnumServicesStatusW().Günther Deschner1-2/+1
Make sure we are not copying more than what we have as valid data. Fix from Jeremy. Thanks a lot for watching this so closely! Guenther
2009-04-14s3-spoolss: remove unused dup_nt_devicemode().Günther Deschner2-29/+0
Guenther
2009-04-14s4-smbtorture: print SPOOLSS_JOB_CONTROL flags in RPC-SPOOLSS test.Günther Deschner1-1/+32
Guenther
2009-04-14s3:charcnv remove now unused malloc() based conversion functionsAndrew Bartlett2-43/+0
2009-04-14Add some harmless use of talloc_tos() in ntlm_authAndrew Bartlett2-5/+5
2009-04-14Convert Samba3 to use the common lib/util/charset APIAndrew Bartlett21-356/+190
This removes calls to push_*_allocate() and pull_*_allocate(), as well as convert_string_allocate, as they are not in the common API To allow transition to a common charcnv in future, provide Samba4-like strupper functions in source3/lib/charcnv.c (the actual implementation remains distinct, but the API is now shared) Andrew Bartlett
2009-04-14Solve some of the conflict between Samba3 and Samba4 push_stringAndrew Bartlett8-53/+86
This renames push_string in Samba3 into push_string_base and push_string_check for the two different use cases. This should allow push_string to be imported from Samba4, using it's calling conventions.
2009-04-14Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-develAndrew Bartlett4-41/+102
2009-04-14s4:ldb Make it possible to re-run ldap.py againAndrew Bartlett1-2/+6
The parentGUID test didn't clean up after itself correctly. Andrew Bartlett
2009-04-13s3-rpcclient: add set_job command.Günther Deschner1-0/+55
Guenther
2009-04-13s4-smbtorture: fix two valgrind warnings.Günther Deschner1-0/+2
Guenther
2009-04-13s4-smbtorture: disable test_SecondaryClosePrinter when running against s3 ↵Günther Deschner1-4/+8
for now. Guenther
2009-04-13s4-smbtorture: move test_ReplyOpenPrinter from RPC-SPOOLSS to ↵Günther Deschner2-36/+36
RPC-SPOOLSS-NOTIFY. Guenther
2009-04-13s3-spoolss: fix typo in fill_printer_driver_info3().Günther Deschner1-1/+1
Guenther
2009-04-13s3-loadparm: Fix resume command typo for "printing = vlp".Günther Deschner1-1/+1
Guenther
2009-04-13s3-spoolss: Fix permission checks for _spoolss_AddForm,SetForm and DelForm.Günther Deschner1-12/+34
Found by smbtorture test. Guenther
2009-04-13s3: re-run make samba3-idl.Günther Deschner3-3/+29
Guenther
2009-04-13spoolss: add spoolss_DriverAttributes bitmask.Günther Deschner1-2/+6
Guenther
2009-04-13s3-spoolss: use enumprinterdrivers_level() for level 3 enum.Günther Deschner1-67/+6
Guenther
2009-04-13s3-spoolss: use enumprinterdrivers_level() for level 2 enum.Günther Deschner1-66/+6
Guenther
2009-04-13s3-spoolss: use enumprinterdrivers_level() for level 1 enum.Günther Deschner1-67/+7
Guenther
2009-04-13s3-spoolss: add generic enumprinterdrivers_level function.Günther Deschner1-0/+86
Guenther
2009-04-13s4-smbtorture: use printerinfo level 1 name, not description inGünther Deschner1-4/+11
test_EnumPrinters_old(). Guenther
2009-04-13s3: re-run make samba3-idl.Günther Deschner2-73/+73
Guenther
2009-04-13spoolss: fix order of strings in PrinterInfo1 structs.Günther Deschner1-2/+2
Guenther
2009-04-13Use convert_string_talloc, thanks Andrew!Volker Lendecke1-1/+1
2009-04-12We have to deny a level 2 oplock if kernel oplocks are enabledVolker Lendecke1-0/+6
The second r/o opener of a file is supposed to get a level2 oplock. The first opener due to the protection in process_oplock_break_message() has been forced to break to no oplock. The second opener according to locking.tdb gets a level2 oplock. Further down in open_file_ntcreate we try to set this level2 oplock in the kernel, and the non-clustered Linux kernel disallows this. The rules for the kernel leases are a bit baroque, but the attempt to do the SETLEASE correctly fails and we end up with no oplock for any client. In the clustered case however the linux kernel on the second opening node has not seen the open fd of the first node, it is only the cluster fs that has this information. If the cluster fs does not have the very same notion of leases as the local kernel has, we can end up with a WRLCK style kernel lease for the second opener where locking.tdb only indicates a level2 oplock. Getting a kernel oplock break signal with just a level2 oplock in locking.tdb is something smbd is not prepared for. For example after sending out the break in response to the kernel signal we set a timeout, waiting for a reply. More work needs to be done to make level2 kernel oplocks real for us. This patch addresses a real problem we have right now without them.
2009-04-12Fix a bug in smbclient not sending the correct called nameVolker Lendecke1-1/+5
Jeremy, I think the ability to say smbclient //foo/bar -I <ip-address> -p 139 making the called name to "foo" got lost with 3d2d0203. Was this removed deliberately? If so, please revert this patch. If not, please merge appropriately. Thanks, Volker
2009-04-12Add "netbios retarget"Volker Lendecke1-0/+93
This is fun -- XP still does this :-) netbios retarget : foo = 192.168.234.10:1139 and if you connect to port 139 name foo, XP will happily do SMB over 1139
2009-04-12Reactivate get_socket_portVolker Lendecke2-4/+2
2009-04-12write_data already guarantees everything was writtenVolker Lendecke1-9/+6
2009-04-12Extract and print the server name type the client connects toVolker Lendecke1-7/+7
2009-04-11Fix some nonempty blank linesVolker Lendecke1-4/+4