summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r16582: Fix Klocwork #1997 and all generic class of problemsJeremy Allison6-6/+62
where we don't correctly check the return from memdup. Jeremy. (This used to be commit ce14daf51c7ee2f9c68c77f7f4674e6f0e35c9ca)
2007-10-10r16581: Fix Klocwork #2017. Possible null deref.Jeremy Allison1-0/+5
Jeremy. (This used to be commit 6967fd4cefa84a7b7b5e14467bfa8152907d55c9)
2007-10-10r16579: Fix Klocwork #2016. Possible null deref.Jeremy Allison1-1/+1
Jeremy. (This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e)
2007-10-10r16576: Fix Klocwork #2015. Possible null deref.Jeremy Allison1-0/+5
Jeremy. (This used to be commit 9cbfaf62a3c4bb7d2e594e412449506ab0af4063)
2007-10-10r16570: Corrected the copyright notice. I had requested and received permissionChristopher R. Hertel1-3/+3
from my management at the University to release under my own copyright. My mistake for entering the wrong info. (This used to be commit c65ebeb02810fb4039555c55779ec62a4a8de564)
2007-10-10r16554: Sorry, just had to change this. Don't use int whenJeremy Allison1-3/+5
you're passing a BOOL parameter, don't use "clever" code in while statement - make things easier and clearer to understand when triggering something with an if. Jeremy. (This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)
2007-10-10r16552: Fix bug 3849.Derrell Lipman2-10/+38
Added a next_token_no_ltrim() function which does not strip leading separator characters. The new function is used only where really necessary, even though it could reasonably be used in many more places, to avoid superfluous code changes. Derrell (This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)
2007-10-10r16550: Fix bug 3866. Thanks for the report!Derrell Lipman3-9/+44
Although I've never met a computer or compiler that produced pointers to functions which are a different size than pointers to data, I suppose they probably exist. Assigning a pointer to a function is technically illegal in C anyway. Change casts of the option_value based on the option_name to use of variable argument lists. For binary compatibility, I've maintained but deprecated the old behavior of debug_stderr (which expected to be passed a NULL or non-NULL pointer) and added a new option debug_to_stderr which properly expects a boolean (int) parameter. Derrell (This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)
2007-10-10r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.Jeremy Allison2-16/+17
Jeremy. (This used to be commit 2b8d72f09c6d79d5d41421545b538da573adcd9d)
2007-10-10r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.Jeremy Allison1-10/+10
Jeremy. (This used to be commit be888a3cda637149c3183418c6e721c6fef1b652)
2007-10-10r16544: Fix bug #3864 reported by jason@ncac.gwu.edu.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 16e42b446bea171c3ad848aefaa92c7404aade42)
2007-10-10r16542: Fix #3863, reported by jason@ncac.gwu.eduJeremy Allison2-2/+6
Jeremy. (This used to be commit cde8323fdc4d4ddaa30e8c59bec89dc130fe26a6)
2007-10-10r16541: Fix #3862 reported by jason@ncac.gwu.edu.Jeremy Allison1-3/+0
Jeremy. (This used to be commit 09e11dcb2304eec9656e76c24921c82f4a870914)
2007-10-10r16537: Fix for bug #3858, all files in a directory notJeremy Allison1-6/+7
being deleted when hide unreadable set to true. Here's the scoop. This one is really interesting. The pattern of deleting a directory is to do a findfirst to get the first part of the list, then for each name returned it does a open/set delete on close/close -> thus deleting the file. Then it does a findnext with the last file name THAT IT JUST DELETED ! Now we can handle this in the findnext in the case where hide unreadable is set to false as we look back in our cache of names and just seek to the right point. The bug is actually fixed in the first hunk of this patch - the one that removes the is_visible_file() check after SearchDir returns false. We don't actually need it and in this case it's causing the delete to be aborted because it can't find the name (doh ! it was just deleted). We don't need it as SearchDir is only ever called from findnext, and findnext should only ever be returning names we gave it. The rest of the patch are the debugs I used to find the problem but they're generically useful. Phew - that one took a while to track down..... Jerry, please merge for 3.0.23 final. Jeremy. (This used to be commit cd048cb775f0a8525fc19aa463db07c477521f5b)
2007-10-10r16528: Self-confidence is plummeting. How could one person goofGerald Carter1-1/+1
the same change 3 times...... Fix pam_winbind compilation again. (This used to be commit f3d2bbf0d222794bbb39b51a0f19167c6e8add1a)
2007-10-10r16521: Fix different extended_dn handling for win2k/2k3 (thanks to FredericGünther Deschner1-8/+8
Brin at Novell). Guenther (This used to be commit f19f781e15da98cfaa94c71fc455fe095dac7b4d)
2007-10-10r16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.soGerald Carter1-1/+1
(This used to be commit 4490fbdfc27eab02bf0140d3ffb70402858423e1)
2007-10-10r16490: Fix a memleak and two typosVolker Lendecke2-2/+3
(This used to be commit 8cf364e602eea408fd9cd6acd12f2b72971361ae)
2007-10-10r16486: fix RedHat init scripts to rely on OS provided killproc() functionGerald Carter3-12/+5
(This used to be commit 164cdf69f395236ffef9ecc202543d53b5eda2da)
2007-10-10r16484: Bugzilla 3805. Only define _ABS if it is not already defined.James Peach1-0/+2
(This used to be commit 09fb20f4fe26a5ec82e2f296bf033ab0864af669)
2007-10-10r16483: Turn off some useless MIPSPro warnings be default.James Peach1-0/+8
(This used to be commit a22bf28bcab6ef3c4addaf57fdeb2020625ead0e)
2007-10-10r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.James Peach1-1/+8
(This used to be commit 2131ddd7a13f078be471d327c8d73300facf8def)
2007-10-10r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:Günther Deschner1-1/+39
When trying to login using krb5 with a trusted domain account, we need to make sure that our and the remote domain are AD. Guenther (This used to be commit 5853525f111c0ab6a97b081d5964f778e7c36565)
2007-10-10r16479: When dcip_to_name failed to get the name of the ip in saf_servername weGünther Deschner1-1/+1
cannot put saf_name in the failed conn cache as it's uninitialized. Store saf_servername (the ip) in that case. Volker, please check. Guenther (This used to be commit 098a87f492f69caeb523478a7ebcd0e3f636497d)
2007-10-10r16478: small cleanup to make pam_winbind.so build and iniparserGerald Carter2-6/+3
include directory like other parts of the build files. (This used to be commit 0fca41efde36d535a274b983e032c1def33f081e)
2007-10-10r16475: destroy talloc ctx when we weren't able to collect onlinestatusGünther Deschner1-0/+4
messages. Guenther (This used to be commit d6b52e818109e6eb5a3df1bbc127c333e819141d)
2007-10-10r16474: There is no point in figuring out lockout policies if we do not allowGünther Deschner1-1/+1
offline logons at all. Guenther (This used to be commit dfbe555c69b3272bcff1d76a699aae2bdb85bdaf)
2007-10-10r16473: There is no point in calling set_dc_type_and_flags() before eachGünther Deschner1-2/+9
pam_auth login (when using kerberos). Guenther (This used to be commit 520777f7946e55b1437df138e529fdc053362d16)
2007-10-10r16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.Gerald Carter1-0/+25
Add missing automatic add of the Administrators SID in the absence of winbindd and precense of Domain Admins SID in the user's token. (This used to be commit ce7846d6f19f63ca99179b75e6f2195cc593795f)
2007-10-10r16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make cleanGerald Carter1-1/+2
(This used to be commit 8421d1b080dd65d1459cc66f0bd4e20fed5d0385)
2007-10-10r16458: Increase debuglevel of cli_rpc_pipe_close().Günther Deschner1-1/+1
Guenther (This used to be commit 840ac23ec007df445892d851144d6458c4e06a6b)
2007-10-10r16453: Fix another memleak.Günther Deschner1-0/+1
Guenther (This used to be commit 49fb1a3ebc44602302c347195752891bf28c7037)
2007-10-10r16452: Fix memleak in the CLDAP processing (found by valgrind).Günther Deschner1-0/+3
Guenther (This used to be commit 479dec68459df606ff566ac86eb3b4bbbd2ca77a)
2007-10-10r16435: Add in the uid info that Jerry needs into theJeremy Allison7-15/+27
share_mode struct. Allows us to know the unix uid of the opener of the file/directory. Needed for info level queries on open files. Jeremy. (This used to be commit d929323d6f513902381369d77bcd7b714346d713)
2007-10-10r16433: Fix Coverity #300 (triggered by a Klockwork bugfixJeremy Allison1-5/+1
I think). If a alloc fails just return NT_STATUS_NO_MEMORY, don't go to "done" label and deref pointers. Jeremy. (This used to be commit 490c7c84674860ecd9daa24341edb427b9fe0aa5)
2007-10-10r16429: Fix final 4 Klocwork bugs we're going to fix beforeJeremy Allison2-8/+8
release - #785, #786, #787, #788. Jeremy. (This used to be commit 9017547cccadeecb80f3db58a43838dc656fce2f)
2007-10-10r16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release ↵Volker Lendecke1-0/+13
candidate! Volker (This used to be commit adf2dcce09ae29a8c1677b25e1cd5f022b804d01)
2007-10-10r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554Jeremy Allison2-20/+35
Jeremy. (This used to be commit e71cc6647a2eaba0eac95b6abb40745e45db72a4)
2007-10-10r16424: Fix possible null deref and a memory leak found byJeremy Allison2-1/+7
examining Klockwork #1519. get_printer_subkeys() could return zero without initializing it's return pointer arg. Fixed this. Added free of subkey pointer return in registry/reg_printing.c (interesting that neithe Coverity or Klocwork found this one). Jeremy. (This used to be commit 4fbeae1a3ac3499e5d9f566655cbafccd9d691cb)
2007-10-10r16422: winbindd_demote_client isn't used and generatesJeremy Allison1-8/+0
a Klocwork issue (#1844). Remove it Jeremy. (This used to be commit e83c3e0a65edeb423d964488e219e30d023b13e8)
2007-10-10r16420: Fix Klocwork #1674. Null deref.Jeremy Allison1-4/+8
Jeremy. (This used to be commit f5dddf339ee3a867e21f34a81bd0b33195b7397d)
2007-10-10r16415: Also delete object files from iniparser.Günther Deschner1-1/+1
Guenther (This used to be commit 4e1816855a8f86d1228c44b39126fbfb3cb893c0)
2007-10-10r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for tryingVolker Lendecke1-23/+31
(This used to be commit 601643a4608cdccf33277cef8900c4da61712268)
2007-10-10r16409: Fix Klocwork ID's.Volker Lendecke8-17/+87
1177 In reg_perfcount.c: 1200 1202 1203 1204 In regfio.c: 1243 1245 1246 1247 1251 Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This is really your code, and I'm not sure I did the right thing to return an error. smbcacls.c: 1377 srv_eventlog_nt.c: 1415 1416 1417 srv_lsa_nt.c: 1420 1421 srv_netlog_nt.c: 1429 srv_samr_nt: 1458 1459 1460 Volker Volker (This used to be commit d6547d12b1c9f9454876665a5bdb010f46b9f5ff)
2007-10-10r16397: Fix Klocwork #11767 and drasticly simplify theJeremy Allison6-191/+198
logic in smbd/process.c. All interested (Volker, Jerry, James etc). PLEASE REVIEW THIS CHANGE. The logic should be identical but *much* easier to follow and change (and shouldn't confuse Klockwork :-). Jeremy. (This used to be commit d357f8b33594472ffa78d0a112accccc2a8b1fe7)
2007-10-10r16396: Klocwork #1170. Null deref.Jeremy Allison1-0/+4
Jeremy. (This used to be commit 220627ab70977a9a26dc0e010f73195c2c87ec96)
2007-10-10r16393: Klocwork #1164. Null deref.Jeremy Allison1-1/+1
Jeremy. (This used to be commit c9a4ce51ed85686a35f350f4681b95d68adebbd6)
2007-10-10r16392: Klockwork #1168. Protect against null deref.Jeremy Allison1-2/+4
Jeremy. (This used to be commit cab256d72a91f59432e28e9623c10384d9ca2b5e)
2007-10-10r16390: Klocwork #604 - ensure if NULL pointer we assertJeremy Allison1-2/+8
if len != 0. Jeremy. (This used to be commit e99cedfb0cabe3863797c8bd4594ee0826022d2e)
2007-10-10r16388: Klocwork #320. Null deref.Jeremy Allison1-0/+5
Jeremy. (This used to be commit ceea8e21006bd6bae9e203a672f82e4d066bba28)