Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2011-03-17 | Nulling out the op_mid is never the right thing to do. We depend on | Jeremy Allison | 1 | -1/+0 | |
this value when searching for specific share mode entries. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Mar 17 19:59:51 CET 2011 on sn-devel-104 | |||||
2011-03-17 | Fix compiler warning in debug message. | Jeremy Allison | 1 | -1/+1 | |
2011-03-17 | s3:Makefile.in: make sure we rebuild bin/smbtorture4 if there where changes | Stefan Metzmacher | 1 | -0/+2 | |
and bin/ndrdump4... metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Mar 17 16:31:45 CET 2011 on sn-devel-104 | |||||
2011-03-17 | lib-util: put data_blob back in the public library | Simo Sorce | 2 | -3/+3 | |
data_blob is defined ina public header, so it needs to be exposed in the public library. Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Mar 17 15:39:08 CET 2011 on sn-devel-104 | |||||
2011-03-17 | s3-waf: add --with-pam_smbpass configure option. | Günther Deschner | 1 | -0/+1 | |
We build pam_smbpass independent from this configure option though. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 17 14:52:33 CET 2011 on sn-devel-104 | |||||
2011-03-17 | s3-waf: move HAVE_LDAP_SASL_WRAPPING define to the HAVE_LDAP block. | Günther Deschner | 1 | -5/+5 | |
Guenther | |||||
2011-03-17 | s3:net Find uid before using it | Sumit Bose | 1 | -7/+7 | |
Signed-off-by: Günther Deschner <gd@samba.org> | |||||
2011-03-17 | s4-smbtorture: more torture_fail usage in raw.write test. | Günther Deschner | 1 | -6/+6 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 17 13:10:14 CET 2011 on sn-devel-104 | |||||
2011-03-17 | s3-username: rename static getpwnam_alloc to getpwnam_alloc_cached. | Günther Deschner | 1 | -5/+5 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 17 00:32:40 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3-build: only include asn1 headers where actually needed. | Günther Deschner | 11 | -1/+13 | |
Guenther | |||||
2011-03-16 | dcerpc: we do not need these as public headers | Simo Sorce | 2 | -3/+1 | |
latest openchange doesn't need these headers either fix _PRINTF_ATTRIBUTE in tdr.h, as it was failing to work after removing proto.h due to side effects. PRINTF_ATTRIBUTE is ok and is define in talloc.h which is included by tdr.h Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Wed Mar 16 23:45:20 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2231, REVERSE_INULL | Volker Lendecke | 1 | -2/+3 | |
No point in checking for !ctx after dereferencing it Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2232, REVERSE_INULL | Volker Lendecke | 1 | -2/+4 | |
No point checking for !cli after dereferencing it | |||||
2011-03-16 | s3: Fix Coverity ID 2233, REVERSE_INULL | Volker Lendecke | 1 | -1/+1 | |
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425 | |||||
2011-03-16 | s3: Fix Coverity ID 2234: REVERSE_INULL | Volker Lendecke | 1 | -2/+2 | |
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521 | |||||
2011-03-16 | s3: Fix Coverity ID 2140, DEADCODE | Volker Lendecke | 1 | -1/+1 | |
This routine was never executed after f0dcc90f because "netname" was always NULL. Jeremy, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 2144, DEADCODE | Volker Lendecke | 1 | -1/+1 | |
We could never have assigned the real value in line 481. Andreas, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 2147, FORWARD_NULL | Volker Lendecke | 1 | -1/+1 | |
How could this ever have worked??? | |||||
2011-03-16 | s3: Fix Coverity ID 2148, FORWARD_NULL | Volker Lendecke | 1 | -3/+2 | |
Further down we unconditionally reference *info | |||||
2011-03-16 | s3: Fix Coverity ID 1402: PASS_BY_VALUE | Volker Lendecke | 1 | -11/+11 | |
There's no point in passing GROUP_MAP on the stack Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2213, PASS_BY_VALUE | Volker Lendecke | 1 | -6/+6 | |
There's little point to pass a copy of this structure on the stack. Günther, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 1012, CHECKED_RETURN | Volker Lendecke | 1 | -6/+5 | |
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO. | |||||
2011-03-16 | s3: Fix Coverity ID 1013, CHECKED_RETURN | Volker Lendecke | 1 | -6/+5 | |
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO. | |||||
2011-03-16 | s3: Fix Coverity ID 1017, CHECKED_RETURN | Volker Lendecke | 1 | -1/+3 | |
Günther, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 1018, CHECKED_RETURN | Volker Lendecke | 1 | -3/+5 | |
2011-03-16 | s3: Fix Coverity ID 1034, CHECKED_RETURN | Volker Lendecke | 1 | -3/+1 | |
In all other places we check the result of secrets_init. | |||||
2011-03-16 | s3: Fix Coverity ID 2100, BAD_SIZEOF | Volker Lendecke | 1 | -1/+1 | |
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2317: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s3: Fix Coverity ID 2318: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s3: Fix Coverity ID 2319: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s4-smbtorture: use torture_assert in torture_samba3_rpc_sharesec(). | Günther Deschner | 1 | -23/+18 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 17:47:11 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _assert in torture_samba3_rpc_getusername(). | Günther Deschner | 1 | -48/+16 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: remove explicit mem_ctx from torture_samba3_rpc_getusername(). | Günther Deschner | 1 | -20/+14 | |
Guenther | |||||
2011-03-16 | s3-packet: only include packet.h where needed. | Günther Deschner | 3 | -1/+2 | |
Guenther | |||||
2011-03-16 | s3-interfaces: only include interfaces.h where needed. | Günther Deschner | 5 | -1/+4 | |
Guenther | |||||
2011-03-16 | s3-msdfs: avoid global inclusion of msdfs.h. | Günther Deschner | 5 | -1/+5 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_assert in samr large-dc test. | Günther Deschner | 1 | -14/+38 | |
Guenther | |||||
2011-03-16 | s3-printing: fix memory leak in print_cups.c | David Disseldorp | 1 | -16/+9 | |
As found by valgrind, tmp_pcap_cache is not freed following printer list tdb update. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3-printing: remove duplicate cups response processing code | David Disseldorp | 1 | -147/+94 | |
There is currently a lot of duplicate code included for processing responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This change splits this code into a separate function. Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | s3-printing: use printcap IDL for IPC | David Disseldorp | 3 | -132/+109 | |
Use printcap IDL for marshalling and unmarshalling messages between cups child and parent smbd processes. This simplifies the IPC and ensures the parent is notified of cups errors encountered by the child. https://bugzilla.samba.org/show_bug.cgi?id=7994 Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | idl: define printcap IPC message format | David Disseldorp | 3 | -1/+24 | |
Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _assert macros in torture_netlogon_samba3(). | Günther Deschner | 1 | -30/+16 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 15:51:12 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s4-smbtorture: remove explicit mem_ctx from torture_netlogon_samba3(). | Günther Deschner | 1 | -12/+3 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _skip in raw.write test. | Günther Deschner | 1 | -54/+30 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: remove duplicate if branch in raw.write test. | Günther Deschner | 1 | -5/+0 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_fail/-assert api in torture_samba3_hide(). | Günther Deschner | 1 | -59/+26 | |
Guenther | |||||
2011-03-16 | s3-build: stop including ldap and lber headers everywhere in the code. | Günther Deschner | 8 | -51/+67 | |
Instead use new header smb_ldap.h where all LDAP API related things are handled, while smbldap.h only deals with our smbldap_X() API. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3-includes: avoid global include of gssapi headers. | Günther Deschner | 3 | -12/+20 | |
Guenther | |||||
2011-03-16 | s3-libsmb: move smb encryption structs into own header. | Günther Deschner | 7 | -28/+67 | |
Guenther | |||||
2011-03-16 | libcli/security: move display_sec headers to own header file and add to | Günther Deschner | 8 | -10/+40 | |
security.h grouping header. Guenther |