Age | Commit message (Collapse) | Author | Files | Lines |
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
|
|
Karolin
(This used to be commit be5ee4999ee8708ec06c1563a62c565a890df622)
|
|
(This used to be commit df995eddbddec80a0d9d4659bbb9c6ca8a45d02b)
|
|
Guenther
(This used to be commit bc0b68709cbbdd71996a39e23fe8305e1f144f31)
|
|
(This used to be commit f5f46de404dba2e4a03d205a62cd5cf7ea4e075a)
|
|
(This used to be commit 15ef5e4884505bca7990e44200d0235764e9057f)
|
|
testwrite: create or truncate a file and write to it.
teststat3: compare the results from smbc_stat() and smbc_fstat()
Derrell
(This used to be commit 5a4a7aec761c3388b741b9b47fa6358fc71a66ce)
|
|
handle FS capabilities.
As discussed with Volker, it is better to calculate FS capabilities at
connection time. We already do this with help of VFS statvfs() call
which allows to fill-in system-specific attributes including FS
capabilities. So just re-use it if you want to represent additional
capabilities in your modules. The only caution is that you need to
call underlying statvfs() call to actually get system-specific
capabilities (and other fields) added. Then add module-specific ones.
(This used to be commit e342ca0d931f9a5c8ec9e472dc9c63f1fe012b3a)
|
|
result for a file.
This makes sense as upper levels are only taking returned result of 0
(no error) into consideration when deciding whether to mark file
offline/online as returned from is_offline.
That means that we simply can move the decision down to VFS module and
clean up upper levels so that they always see only file status. If there
is an error when trying to identify file status, then VFS module could
decide what to return (offline or online) by itself -- after all, it
ought to have system-specific knowledge anyway.
(This used to be commit 75cc08661473cce62756fa062071bb2bc1fb39ec)
|
|
NEEDS MORE TESTING !
Jeremy.
(This used to be commit bcc94aed6f03211866aa85753a90fece87846ba9)
|
|
There's been a problem seen where open/read/close a number of times causes
open failures eventually. This program has been modified to create the
context once and then loop requesting file names to open/read/close.
This program also demonstrates the current error in cli_read() where it
returns an error instead of length 0 upon end of file.
Derrell
(This used to be commit 9d75ea577b407ccab59196760d376831062a3ab5)
|
|
GetTimeOfDay() seems to no longer be exported. For the smbsh example, just
use the native gettimeofday() for now.
(This used to be commit 296a6783fbc03460e87ac4136a0a9e6d2743b2ff)
|
|
(This used to be commit 01f6a4cca7a91ae41ff393263418216324502f84)
|
|
(This used to be commit 3a61e663e51fe620225691bc8673bf8800a36f47)
|
|
Michael
(This used to be commit dcb5034acd35d219106e1d855f4c4d36b3c8d83b)
|
|
When the capability of using full names for DOS attributes was added, a bug
was introduced which caused the wrong number of bytes to be returned. This
patch to smbc_listxattr_ctx() fixes the problem.
Thanks to Jack Schmidt for this patch.
Derrell
(This used to be commit 913c335d21c503d32b35bf65da7b2bddf0473875)
|
|
(This used to be commit 2f432842442859f98ecd263464ce02821ab10fca)
|
|
Michael
(This used to be commit 3958abffaf2866c69ad9e13ec345364fde5c78bb)
|
|
Michael
(This used to be commit a52cfb7d777157c93c9dc26c67f457be592dd537)
|
|
Michael
(This used to be commit c8ae7d095a2a6a7eac920a68ca7244e3a423e1b1)
|
|
Michael
(This used to be commit a8fc2ddad8d5f7c6c00cb36c74a32a02d69d1d04)
|
|
Guenther
(This used to be commit 88d6683872f4bb9c3074280f385f73c7af9de784)
|
|
Guenther
(This used to be commit 8f411753b2130e9c1f260a15d031f57ba07b62a1)
|
|
Michael
(This used to be commit ef7c9a765bcdb1c774ff4f6d14053c4aa3815f31)
|
|
Michael
(This used to be commit c88555ce45aa2998037d316f3a8edccd04be04a4)
|
|
Michael
(This used to be commit 4f3ab2c406072e0b43581057e7e785e8ad454cfa)
|
|
Michael
(This used to be commit 2ad66050a0452b8e7e08b1e7a01efa00c72fd451)
|
|
Michael
(This used to be commit fbb193db3e0dc51cb000ae406a68bc547f31d9ab)
|
|
Michael
(This used to be commit a54d5604da556d1250ca9948d4acc4a187a9fede)
|
|
Michael
(This used to be commit 0b86c420be94d295f6917a220b5d699f65b46711)
|
|
Michael
(This used to be commit 8f83c9a7b245dbfef28195f9a7f33047a8ba95a0)
|
|
Michael
(This used to be commit df929796f2698698d2875227bda8500589cca2df)
|
|
Michael
(This used to be commit 8c4901a19ae2fd3ee085f9499f33aa7db016d182)
|
|
Michael
(This used to be commit d9d6775878f8b3425665c6a45a5ef9cb92932cf8)
|
|
Michael
(This used to be commit 73e28806ce87d829ea7c38ed3440020845bb13bf)
|
|
(This used to be commit e811b9f3bbf614f76e628755dafd358769b8a58b)
|
|
This adapts r23801 / 87c91e4362c51819032bfbebbb273c52e203b227
to files just added by cherry-pick.
Michael
(This used to be commit a0d595c2277d2f754cdb0c85119fdc130d86f7ea)
|
|
Jeremy.
This adapts r23780 / c2f7ab1c175ecff0cf44d0bbc4763ba9f7d7803f
for files added by cherry-pick.
(This used to be commit 1b6cf93992fbe338dff83a9f904ec9dfc422e242)
|
|
to lists of groups (or aliases). Useful for creating large test
scenarios.
Michael
(cherry picked from commit b3e5082e105f6eaeed51e9a42d525d811e7155ee)
(This used to be commit 78a2344fe7ed53e9927e189fa4d465652731deab)
|
|
Michael
(cherry picked from commit 26349c0b173e8baf6fa43deb39cb2bfdb31bf18e)
(This used to be commit 852570059c974bc6c06f893e4bf5e76674e4ec00)
|
|
This is done via rpc client. The main purpose is to
be able to fill a domain controller with a large number
of users / groups easily. A the object names are
built as <prefix><num> where number ranges from a given
start number counting up until a given number of objects
has been created.
In a next step, I will submit scripts to add (many) users to
a group and to add a user to (many) groups.
Michael
(cherry picked from commit 8b81fbb7d998eda65978a772f2194b4a3de467f9)
(This used to be commit 79414f8bfa9cce1b4543b3cf5d6ea65651fc0769)
|
|
implementation. Needed for the zero-copy write code.
Jeremy.
(This used to be commit bfbdb6324c5d13bfde8b742e9c5a0e0c9092bd86)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
|
|
This script is useful for migrating OpenLDAP schema files to FDS/RHDS
lidf schema files.
License kindly updated to GPLv3+ at our request.
Simo.
(This used to be commit ab7770b34b3202a5836cfa098187eeed1bd16be3)
|
|
Michael
(This used to be commit 7dc68ce0fb4490761326eaaca516fde3bf642ed5)
|
|
have the current and possibly the previous trust password
stored as clear text passwords. (Previous use of NTPassword
was a mistake - this is a hash value.)
Michael
(This used to be commit 0beae52ff469903adbfefdffd93a34bb7ad7d68d)
|
|
(This used to be commit 501e8b6c79afdefb9955b92e5c25dbe1033ab518)
|
|
pointer was
incremented too far in some circumstances. In these cases, only the first
of multiple concatenated strings would be seen.
- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
crash. It appears to have been an incomplete switchover from malloc to
talloc, as the memory was still being freed with SAFE_FREE.
Deleting ACLs still doesn't work. Although a valid request is sent to the
server and a SUCCESS response is returned, the method that's used in
libsmbclient for deleting ACLs seems to be incorrect. In looking at the
samba4 torture tests, it appears that we should be turning on the INHERIT
flag if we want to delete the ACL. (I could use some assistance on the
proper flags to send, from anyone familiar with this stuff.)
- Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not
returning a value useful to smbc_lseekdir_ctx().
Derrell
(This used to be commit 2ac502e29bd8390252fe4ae8344faab49ca01ff5)
|
|
metze
(This used to be commit 0bc5a9cd0136f8512e963a30b6e7b009667fb0bf)
|