summaryrefslogtreecommitdiff
path: root/lib/ldb/common/ldb.c
AgeCommit message (Collapse)AuthorFilesLines
2013-01-26ldb: Ensure to decrement the transaction_active whenever we delete a transactionAndrew Bartlett1-0/+1
This is in the error path for prepare_commit, which rarely fails, but when it does we need to ensure that when a new transaction is opened, that it really starts a new transaction. We bump the version to recognise critical fix for the AD DC Without this fix, a single invalid inbound replicated link disables all subsequent replication as we operate without a transaction (which is refused by ldb_tdb). Andrew Bartlett Reviewed-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2012-11-30ldb: fix a typo in the comment for ldb_req_is_untrusted()Michael Adam1-1/+1
Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Nov 30 15:44:46 CET 2012 on sn-devel-104
2012-08-29lib/ldb: Avoid printing secret attributes in ldb trace logsAndrew Bartlett1-6/+25
These are printed when Samba has debug level 10, which is often used for debugging. Instead, print a note to say that this attribute has been skipped. Andrew Bartlett
2012-08-09lib/ldb: Do not vasprintf() the tevent debug messages that will not be shownAndrew Bartlett1-5/+4
This malloc() and free() actually shows up quite high on a call profile of provision of the AD DC. This allows the debug handler to decide if the argument list should be printed. Andrew Bartlett
2012-06-27lib/ldb: Print trace messages for modify correctlyAndrew Bartlett1-1/+1
2011-10-20dsdb: improve debug messageAndrew Tridgell1-3/+3
show the reply type in "Invalid reply type" messages Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Oct 20 00:57:05 CEST 2011 on sn-devel-104
2011-10-11ldb:ldb_autotransaction_request - error string shouldn't be set hereMatthias Dieter Wallnöfer1-5/+0
A generic error string should be set independently of the access mechanism to an LDB operation. Hence it should be handled in "ldb_wait" and "ldb_request" Signed-off-by: Andrew Tridgell <tridge@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Tue Oct 11 10:15:18 CEST 2011 on sn-devel-104
2011-10-11ldb:ldb.c/"ldb_wait" - make "ldb_wait" always return an error stringMatthias Dieter Wallnöfer1-4/+39
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c/"ldb_wait" - change "ldb_wait" slightly in order to introduce ↵Matthias Dieter Wallnöfer1-3/+5
error messages In this occasion remove a redundant check for "LDB_ASYNC_DONE": if (handle->state == LDB_ASYNC_DONE || if (handle->state == LDB_ASYNC_DONE) handle->status != LDB_SUCCESS) { return handle->status; return handle->status; == if (handle->status != LDB_SUCCESS) } return handle->status; ... ... return LDB_SUCCESS; return LDB_SUCCESS; Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c/"ldb_request" - make "ldb_request" always return an error stringMatthias Dieter Wallnöfer1-1/+15
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c - "ldb_set_errstring" can be implemented by using ↵Matthias Dieter Wallnöfer1-10/+7
"ldb_asprintf_errstring" Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb_autotransaction_request - fix a typo in a commentMatthias Dieter Wallnöfer1-1/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-09-19ldb:"ldb_extended" -make the call more similar to "ldb_search"Matthias Dieter Wallnöfer1-2/+6
For example NULL out the LDB result pointer on failures. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-07-05ldb: make ldb a top level library for Samba 4.0Andrew Bartlett1-0/+1923
Signed-off-by: Andrew Tridgell <tridge@samba.org>