summaryrefslogtreecommitdiff
path: root/lib/ldb/common
AgeCommit message (Collapse)AuthorFilesLines
2013-02-08ldb: use strncmp instead of strcmp when comparing the val partMatthieu Patou1-2/+2
val part of a DN's component is DATA_BLOB and nothing insure that it will be finished by a '\0' Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-01-26ldb: Ensure to decrement the transaction_active whenever we delete a transactionAndrew Bartlett1-0/+1
This is in the error path for prepare_commit, which rarely fails, but when it does we need to ensure that when a new transaction is opened, that it really starts a new transaction. We bump the version to recognise critical fix for the AD DC Without this fix, a single invalid inbound replicated link disables all subsequent replication as we operate without a transaction (which is refused by ldb_tdb). Andrew Bartlett Reviewed-by: Matthieu Patou <mat@matws.net> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2012-11-30ldb: fix a typo in the comment for ldb_req_is_untrusted()Michael Adam1-1/+1
Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Fri Nov 30 15:44:46 CET 2012 on sn-devel-104
2012-11-13lib/ldb: add missing newline in the output of ldb_ldif_write_trace()Stefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Nov 13 13:53:31 CET 2012 on sn-devel-104
2012-11-01ldb: fixed callers for ldb_pack_data() and ldb_unpack_data()Andrew Tridgell1-26/+23
with ltdb_pack_data() and ltdb_unpack_data() now moved into common, we need to increase the minor version and fixup callers of the API Note that this relies on struct ldb_val being the same shape as TDB_DATA, in much the same way as we rely on ldb_val and DATA_BLOB being the same shape. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2012-11-01ldb: move ldb_pack.c into commonAndrew Tridgell1-0/+290
this code should not be tied to the ldb_tdb backend, both because it could be used for any record oriented backend, and because it should be exposed for use by diagnosis/repair tools such as the recently added ldbdump tool Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2012-09-11At Michael's suggestion, factor common code into a function. My bad :-).Jeremy Allison1-4/+9
Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Tue Sep 11 20:08:37 CEST 2012 on sn-devel-104
2012-09-10Fix bug #9147 - winbind can't fetch user or group info from AD via LDAPJeremy Allison1-2/+4
Don't use "isprint" in ldb_binary_encode(). This is locale specific. Restrict to ASCII only, hex encode everything else.
2012-08-29lib/ldb: Avoid printing secret attributes in ldb trace logsAndrew Bartlett3-13/+80
These are printed when Samba has debug level 10, which is often used for debugging. Instead, print a note to say that this attribute has been skipped. Andrew Bartlett
2012-08-22LDB:ldif_handlers.c - LDB_OP_GREATER/LDB_OP_LESS are thought as ">=" or "<="Matthias Dieter Wallnöfer1-1/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-08-09lib/ldb: Do not vasprintf() the tevent debug messages that will not be shownAndrew Bartlett2-9/+16
This malloc() and free() actually shows up quite high on a call profile of provision of the AD DC. This allows the debug handler to decide if the argument list should be printed. Andrew Bartlett
2012-06-27lib/ldb: Print trace messages for modify correctlyAndrew Bartlett1-1/+1
2012-06-22ldb: lay foundation for proper utc/generalized time handlingMatthieu Patou2-5/+41
We use to handle UTCtime and generalized time the same way. The thing is that it's not the case, they are different in the way they are set (most of the time) with different format and also stored and return in different format too.
2012-06-22ldb: add the VERIFY_NAME controlMatthieu Patou1-0/+53
2012-04-18ldb: added ldb_msg_element_equal_ordered()Andrew Tridgell1-0/+20
this gives us a order sensitive msg element comparison. We need this to allow dbcheck to fix the order of objectClass attributes.
2012-04-11LDB:ldb_msg.c - add another OOM check in "ldb_msg_copy()"Matthias Dieter Wallnöfer1-0/+1
2012-04-10ldb: Allow access to the line number while reading ldif from a fileAndrew Bartlett1-6/+13
2012-01-02ldb:ldb/common/ldb_controls.c - reference "err_string" variable correctlyMatthias Dieter Wallnöfer1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-11-02ldb: fix compiler warningDavid Disseldorp1-1/+1
Mixed declarations and code. Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Wed Nov 2 16:51:24 CET 2011 on sn-devel-104
2011-10-27ldb:common/ldb_modules.c - fix a typo in commentMatthias Dieter Wallnöfer1-1/+1
Reviewed-by: abartlet
2011-10-20ldb: ldb_errstring() takes ldb_contxt as an argumentAmitay Isaacs1-1/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-20dsdb: improve debug messageAndrew Tridgell1-3/+3
show the reply type in "Invalid reply type" messages Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Oct 20 00:57:05 CEST 2011 on sn-devel-104
2011-10-18ldb: Output more error information when a connect failsAndrew Bartlett1-1/+1
2011-10-11ldb:ldb_autotransaction_request - error string shouldn't be set hereMatthias Dieter Wallnöfer1-5/+0
A generic error string should be set independently of the access mechanism to an LDB operation. Hence it should be handled in "ldb_wait" and "ldb_request" Signed-off-by: Andrew Tridgell <tridge@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Tue Oct 11 10:15:18 CEST 2011 on sn-devel-104
2011-10-11ldb:ldb.c/"ldb_wait" - make "ldb_wait" always return an error stringMatthias Dieter Wallnöfer1-4/+39
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c/"ldb_wait" - change "ldb_wait" slightly in order to introduce ↵Matthias Dieter Wallnöfer1-3/+5
error messages In this occasion remove a redundant check for "LDB_ASYNC_DONE": if (handle->state == LDB_ASYNC_DONE || if (handle->state == LDB_ASYNC_DONE) handle->status != LDB_SUCCESS) { return handle->status; return handle->status; == if (handle->status != LDB_SUCCESS) } return handle->status; ... ... return LDB_SUCCESS; return LDB_SUCCESS; Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c/"ldb_request" - make "ldb_request" always return an error stringMatthias Dieter Wallnöfer1-1/+15
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb.c - "ldb_set_errstring" can be implemented by using ↵Matthias Dieter Wallnöfer1-10/+7
"ldb_asprintf_errstring" Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-11ldb:ldb_autotransaction_request - fix a typo in a commentMatthias Dieter Wallnöfer1-1/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-10-07Revert "ldb: support raw OIDs in control string parsing"Stefan Metzmacher1-18/+0
This reverts commit ea41860d32d38448e08cefd79d30ee1150317a9e. This is not needed, because we already have the 'local_oid' magic. metze
2011-10-07ldb/ldb_controls: allow oid up to 255 charsStefan Metzmacher1-1/+1
We have char oid[256], so allow sscanf() to consume 255 chars. metze
2011-10-06ldb: support raw OIDs in control string parsingAndrew Tridgell1-0/+18
this makes it possible to use a raw OID string on the command line or in python scripts Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-10-06ldb: fixed memory leak in control string parsingAndrew Tridgell1-0/+24
if parsing fails, free ctrl Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-09-19ldb:"ldb_extended" -make the call more similar to "ldb_search"Matthias Dieter Wallnöfer1-2/+6
For example NULL out the LDB result pointer on failures. Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-09-11ldb:ldb_controls.c - remove duplicate definition of "LDB_CONTROL_CMP"Matthias Dieter Wallnöfer1-11/+3
And fix the comment Reviewed-by: Jelmer
2011-08-19ldb:ldb_controls.c - cosmetic indentation fixMatthias Dieter Wallnöfer1-5/+4
2011-08-09ldb: fix the canonicalisation of booleansAndrew Tridgell1-3/+3
we were canonicalising "FALSE" to "FALS" Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-08-04ldb: added a new always-fail ldap extended match OIDAndrew Tridgell1-1/+12
this is used when rewriting filter rules to replace a filter rule with one that is guaranteed not to match Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-08-04ldb: added ldb_parse_tree_walk()Andrew Tridgell1-16/+70
this walks a ldb parse tree, calling a callback on each node Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-08-04ldb: added ldb_dn_replace_components()Andrew Tridgell1-0/+56
this allows you to replace the string part of a DN with the string part from another DN. This is useful when you want to fix a DN that has the right GUID but the wrong string part, because the target object has moved. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
2011-07-29ldb: fixed a search expression parse bugAndrew Tridgell1-1/+11
when a secondary component of a & or | expression was invalid, it was ignored rather than giving an error. For example: (|(objectclass=user)(samaccountname=foo\blah)) was treated as being: (objectclass=user) whereas it should be an error, as foo\blah is invalid Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com> Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-13ldb: added ldb_val_string_cmp()Andrew Tridgell1-0/+12
this should help fix some places where we run past the end of a string Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-13ldb: don't return special DNs on non-base searchesAndrew Tridgell1-0/+5
to look at a special DN, give the full DN Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-13ldb: don't shortcut dn comparison for mismatched special DNsAndrew Tridgell1-1/+1
DNs that start with @ can't be compared via string comparison with normal DNs Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-07-05ldb: make ldb a top level library for Samba 4.0Andrew Bartlett14-0/+11302
Signed-off-by: Andrew Tridgell <tridge@samba.org>