summaryrefslogtreecommitdiff
path: root/lib/util
AgeCommit message (Collapse)AuthorFilesLines
2009-09-10util_strlist: Add some more "const"s - small correctionMatthias Dieter Wallnöfer1-1/+1
2009-09-10util_strlist: Add some more "const"sMatthias Dieter Wallnöfer2-22/+27
2009-09-08lib/util: add unique string generator helper functionSteven Danneman2-0/+69
2009-09-07s4:tests/iconv - Fix a warningMatthias Dieter Wallnöfer1-1/+2
2009-09-07s4: Fix "Small memory leak after calling several times lp_update"Inra2-37/+20
Should fix bug #6660.
2009-09-05util:tests: Correct time tests for negative UTC offsets.Andrew Kroeger1-2/+23
All: Please find attached a patch to fix the timestring and http_timestring tests on hosts that have a negative UTC offset (west of the Prime Meridian). Sincerely, Andrew Kroeger >From 8a8ca35edccf64aa98f2f3ae1469c4c27db8215e Mon Sep 17 00:00:00 2001 From: Andrew Kroeger <andrew@id10ts.net> Date: Fri, 4 Sep 2009 01:31:50 -0500 Subject: [PATCH] util:tests: Correct time tests for negative UTC offsets. The timestring and http_timestring tests were failing on hosts with negative offsets from UTC. Due to the timezone offset, the returned values were back in the year 1969 (before the epoch) and did not match the test patterns. The correction computes the offset from UTC, and if it is negative that offset is added onto the value given to the timestring() and http_timestring() calls so that the returned values fall on 01-Jan-1970 and match the test pattern.
2009-08-27util: fix comment and clarify argument name in DLIST_DEMOTE()Michael Adam1-3/+3
Michael
2009-08-24Fix make test.Jeremy Allison1-0/+1
Jeremy.
2009-08-11Rename ASN1_BITFIELD to ASN1_BIT_STRING.Kouhei Sutou1-1/+1
X.690 uses "BIT STRING" not "BIT FIELD".
2009-08-05make the UID_WRAPPER skip checks at runtimeAndrew Tridgell2-5/+8
This fixes two issues pointed out by Andrew. It adds a runtime uwrap_enabled() call that wraps the skips needed for uid emulation. It also makes the skip in the directory_create_or_exist() function only change the uid checking code, not the permissions code
2009-08-05added a uid_wrapper libraryAndrew Tridgell2-0/+3
This library intercepts seteuid and related calls, and simulates them in a manner similar to the nss_wrapper and socket_wrapper libraries. This allows us to enable the vfs_unixuid NTVFS module in the build farm, which means we are more likely to catch errors in the token manipulation. The simulation is not complete, but it is enough for Samba4 for now. The major areas of incompleteness are: - no emulation of setreuid, setresuid or saved uids. These would be needed for use in Samba3 - no emulation of ruid changing. That would also be needed for Samba3 - no attempt to emulate file ownership changing, so code that (for example) tests whether st.st_uid matches geteuid() needs special handling
2009-07-31util/asn1: fix potential memory leak in asn1_write_OID()Stefan Metzmacher1-0/+1
metze
2009-07-25No explicit initialization necessary for a zero blobVolker Lendecke1-3/+1
2009-07-20lib util: Fix const warningTim Prouty1-1/+1
2009-07-19lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.Slava Semushin1-0/+1
Found by cppcheck: [./lib/util/util_file.c:383]: (error) Resource leak: fd
2009-07-19Fix broken password quality checkMatthieu Patou2-1/+4
This fixes broken password tests when the passwords contain non ASCII characters (e.g. accentuated chars like ('e, `e, ...)
2009-07-01lib/util: fix order of includes in tevent_ntstatus.cMichael Adam1-1/+1
replace.h needs to be included first. Michael
2009-06-29lib/util: fix building tevent_ntstatus without config.hMichael Adam1-1/+0
(when called from places with "#define NO_CONFIG_H" set, such as configure) Michael
2009-06-29Fix ndrdump to use a common setup_logging() APIAndrew Bartlett2-1/+18
By adding a new common setup_logging_stdout() API, we no longer need to abuse the ABI compatability between the different setup_logging() calls in Samba3 and Samba4's DEBUG() subsystems. The revert of 49a6d757b4d944cd22c91b2838beb83f04fbe1e9 works with this to fix bug 6211. Andrew Bartlett
2009-06-29Revert "s4:debug: make setup_logging() a bit more compatible with samba3"Andrew Bartlett1-1/+1
The problem is that the enum was previously a 'rachet', that is, it would only reset to a level higher than it was previouly set to. Changing the order broke file-based logging for our production sites. This reverts commit 49a6d757b4d944cd22c91b2838beb83f04fbe1e9.
2009-06-29Two patches which fix issues on cross compiling/buildingNathaniel McCallum1-1/+1
2009-06-20Move asn1_load_nocopy() to lib/util/asn1.cVolker Lendecke2-0/+11
2009-06-20Move asn1_blob() to lib/util/asn1.cVolker Lendecke2-0/+17
2009-06-11Fix build of recurusion fix in reopen_logs()Andrew Bartlett1-1/+1
2009-06-11Don't recurse in reopen_logs().Andrew Bartlett1-0/+6
Use the state to avoid recursion in reopen_logs(), as DEBUG() can call this function. Andrew Bartlett
2009-06-10lib-util: move set_blocking() call into own file.Günther Deschner3-31/+63
Guenther
2009-06-10added asn1 functions for handling booleans in a simple contextAndrew Tridgell2-0/+25
2009-06-08libsamba-util: Fix soversion.Jelmer Vernooij1-1/+1
2009-06-06Use data_blob_null instead of data_blob(NULL, 0)Volker Lendecke1-1/+1
2009-06-04add gendb_search_single_extended_dn()Andrew Tridgell2-0/+103
This function searches for a single record using a given filter, adding the extended-dn control so that any returned DNs will have the GUID and SID fields returned. This will be used in the sam auth code to prevent us doing a member= search for the groups, which invokes an unindexed search.
2009-06-02Build libsamba-util as a shared library.Jelmer Vernooij1-1/+4
2009-05-29util: Change license on tevent_unix to LGPLv3+Volker Lendecke2-16/+24
2009-05-29util: move add_gid_to_array_unique to toplevel and add add_uid_to_array_unique.Günther Deschner3-1/+102
Guenther
2009-05-15Add extensive tests for str_list function behaviourAndrew Bartlett1-15/+343
2009-05-14Remove two unused variablesVolker Lendecke1-2/+0
2009-05-14Add new functions and tests: str_list_make_empty(), str_list_make_single()Andrew Bartlett3-0/+85
2009-05-13Take advantage of the easier-to-use thread macrosDerrell Lipman1-8/+0
- Now that we initialize for the non-thread-safe case in the macro, there's no need to do it here too. Derrell
2009-05-13Make the thread functions a bit easier to useDerrell Lipman3-8/+12
- Create separate macros for lock and unlock so that it's easier to identify which request is being made. - Initialize *ponce in the SMB_THREAD_ONCE macro in the non-thread-safe case, rather than requiring each init function to determine if it's in the non-thread-safe case and manually initialize. Derrell
2009-05-13Allow a parameter to smb_thread_once's initialization functionDerrell Lipman4-15/+28
- This should make life easier for ourselves. We're no longer constrained to the semantics of pthread_once, so let's allow passing a parameter to the initialization function. Some of Samba's init functions return a value. Although I haven't searched, I suspect that some of the init functions require in input parameters. The parameter added here can be used for input, output, or both, as necessary... or ignored, as is now done in talloc_stackframe_init(). Derrell
2009-05-12Fix broken smb_thread_once function (again)Derrell Lipman1-0/+3
- It would help if smb_thread_once did, eventually, set the variable that prevents the init function from being run again. Sigh. It must be getting late. Derrell
2009-05-12Fix broken smb_thread_once functionDerrell Lipman1-19/+3
- We can't set *ponce=true before running the function because although other threads wouldn't re-run the initialization function, they could potentially proceed beyond the initialization point while the first thread was still running the initialization function. If a second thread gets to an SMB_THREAD_ONCE() call while one with the same ponce is running, we need to ensure that it enters smb_thread_once() to await the mutex and then recheck whether *ponce is set or not. My original comment about other "once" functions possibly being called from within this "once" function is irrelevant since those other ones would have their own unique ponce. Derrell
2009-05-11Fix definition of smb_thread_once - must return int not void asJeremy Allison2-2/+5
it's used in a ? : comparison macro. Jeremy.
2009-05-11Ensure documentation matches the tdb_util function usage.Jeremy Allison1-2/+2
Jeremy.
2009-05-10Use bool instead of int for a boolean variableDerrell Lipman1-1/+1
2009-05-10Optimize smb_thread_once usage by not calling it if known already calledDerrell Lipman1-2/+6
- The macro SMB_THREAD_ONCE now tests whether the "once" variable is already set, and if so avoids calling smb_thread_once(). Derrell
2009-05-10Panic upon mutex lock or unlock failureDerrell Lipman1-2/+2
- It's a serious error if we can't lock or unlock a mutex in smb_thread_once(). Panic instead of just displaying a DEBUG message. Derrell
2009-05-10Don't require external use of internal enum smb_thread_lock_typeDerrell Lipman1-3/+4
- Internally, when locking or unlocking a mutex, we'll pass one of the values of enum smb_thread_lock_type. That enum is not available to users providing a thread implementation. Externally, we'll document the integer values which will be passed to their lock_mutex function, but not require them to access our internal header file. Derrell
2009-05-10Replace external thread "once" with an internal implementationDerrell Lipman3-22/+66
Jeremy, please check... - I'm in the process of providing an interface in libsmbclient to the recently-added threading capabilities. In the process, I discovered that different thread implementations have varying types for the variable passed to the thread_impl_once() function. pthreads, for example, uses type pthread_once_t. Since Samba needs to internally declare these variables, it would need to know the exact type required by each thread implementation's function. After considering multiple methods of obtaining an appropriately sized variable, I decided that for the basic "once" functionality required by Samba, it would be much simpler to just implement our own "once" functionality. We don't require cancellation points et all. This commit adds an smb_thread_once() function that is implemented using an internal mutex. The mutex itself uses the implementation's create_mutex function. This eliminates the need for the user to provide a smb_thread_once function pointer and the entire issue of that function's first parameter. Derrell
2009-05-03Clean up after Tridge's util_strlist changesVolker Lendecke2-25/+30
2009-04-28Fix a missing prototype warningVolker Lendecke2-0/+3