Age | Commit message (Collapse) | Author | Files | Lines |
|
When we have an enum that is used as a union discriminator, what
matters is that the scalar mappings are the same, not if the types are
the same (otherwise we get warnings about uint1632).
Thanks to gd for noticing this.
|
|
The default enum in NDR63 is 32 bits, not 16 bits. We need a uint1632
type to get the alignment right.
|
|
List,
Please review this patch to pidl.
Basically, we need to process the wireshark conformance file BEFORE
we process the idl file since this file may define external types
and set the alignment for them (using the TYPE directive).
Otherwise pidl will default all external types to use 4byte alignment
which breaks (much more often) on NDR64
regards
ronnie sahlberg
From 8f86903fc353d0906bd82e72ce19c5af09beb001 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Mon, 5 Oct 2009 15:22:43 +1100
Subject: [PATCH] In the PIDL wireshark backend, we define external types in the conformance
file using the TYPE directive.
If we declare external types here, we must parse this file before we process
the IDL file, or else these external types will all default to 4byte padding
(pidl assumes all unknown types are 4byte aligned).
Make sure we read the conformance file and create these new types before
we parse the idl file.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
|
This is the type used for a variable that is 32 bits for NDR32 and 64
bits for NDR64
|
|
This fixes the problem with samr UserInfo16 when NDR64 is enabled
|
|
Added support for NDR64 to the samba4 pidl generator
|
|
metze
|
|
midl also supports this:
struct {
long l1;
[string] wchar_t str[16];
long l2;
};
Where the wire size of str is encoded like a length_is() header:
4-byte offset == 0;
4-byte array length;
The strings are zero terminated.
metze
|
|
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
|
|
This eliminates a warning in pidl generated code, while preserving
cross-platform idl compatibility.
|
|
Compilers complain about ranges starting at 0 for unsigned types,
since an unsigned type is never less than 0. The max property
implicitly makes 0 the lower bound when used with unsigned types.
|
|
pidl-generated type.
|
|
|
|
|