Age | Commit message (Collapse) | Author | Files | Lines |
|
We need to align before the switch_type and before the
union arms. Both alignments are to the boundary of the largest
possible union arm.
This means that adding a new union arm with a larger alignment
would break compat!!!
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Oct 24 17:49:23 UTC 2010 on sn-devel-104
|
|
Match data type for info levels to data type returned by utility
functions.
Autobuild-User: Tim Potter <tpot@samba.org>
Autobuild-Date: Mon Oct 11 12:18:22 UTC 2010 on sn-devel-104
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
when using ndrdump you can get uninitialised structures containing
pointers. Don't segfault when trying to print them
|
|
|
|
Guenther
|
|
relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
foo / 5 * sizeof(bar)' isn't the same as
'(foo / 2) * sizeof(bar)'.
metze
|
|
relative pointers
metze
|
|
NDR64 has a 'trailing gap' alignment, which aligns the end of a
structure on the overall structure alignment.
This explains the discrepancy we had with the RPC-SAMR test and NDR64
|
|
This fixes the problem with samr UserInfo16 when NDR64 is enabled
|
|
This allows for easier implementation of the NDR32/NDR64 split
|
|
Added support for NDR64 to the samba4 pidl generator
|
|
|
|
metze
|
|
midl also supports this:
struct {
long l1;
[string] wchar_t str[16];
long l2;
};
Where the wire size of str is encoded like a length_is() header:
4-byte offset == 0;
4-byte array length;
The strings are zero terminated.
metze
|
|
Code isn't generated to iterate over arrays of length 0, but the
variable declarations still are. The result is 'unused variable'
warnings. This only seems to be happening in one place right now, so I
targeted the fix to this case, but refactoring could be done to make
all variable declarations do this zero length check. Making it the
default would be a much more invasive fix.
Jelmer, please check!
|
|
(bug #6140)
|
|
|
|
ndr_interface_table
metze
|
|
bug in pidl where pidl uses "const" in a struct where there should not be
const.
There is only a single place in the Samba codebase where this triggers a
warning.
|
|
|
|
This eliminates a warning in pidl generated code, while preserving
cross-platform idl compatibility.
|
|
Compilers complain about ranges starting at 0 for unsigned types,
since an unsigned type is never less than 0. The max property
implicitly makes 0 the lower bound when used with unsigned types.
|
|
|
|
The warning:
../librpc/gen_ndr/ndr_spoolss.c: In function ‘ndr_pull_spoolss_EnumPrinterData’:
../librpc/gen_ndr/ndr_spoolss.c:14792: warning: passing argument 1 of ‘memset’ discards qualifiers from pointer target type
In some case the pidl generated code needs to memset a const struct
field. This causes the above warning. This patch discardeds the const
in this case. I'm open to a more elegant fix, but this eliminates the
warning and should be relatively safe.
|
|
with talloc.
|
|
|