summaryrefslogtreecommitdiff
path: root/source3/auth
AgeCommit message (Collapse)AuthorFilesLines
2011-05-05More simple const fixes.Jeremy Allison1-8/+8
2011-05-05s3-auth: run minimal_includes.plGünther Deschner5-6/+0
Guenther
2011-05-04Remove obvious use of safe_strcpy + safe_strcat -> strlcpy + strlcat.Jeremy Allison1-10/+10
2011-05-03s3-include: use new roles.hAndrew Tridgell1-1/+1
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-13s3: Use wbcSidsToUnixIds in create_local_tokenVolker Lendecke1-6/+20
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-06s3-auth: Make server_info const in create_local_token()Andrew Bartlett2-5/+5
Andreas Schneider <asn@samba.org> correctly points out that this input parameter should now be const, and that found a bug where I used then used it incorrectly as a talloc context. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 6 00:33:31 CEST 2011 on sn-devel-104
2011-04-05s3-auth Rename user_session_key -> session_key to match auth_session_infoAndrew Bartlett4-27/+27
2011-04-05s3-auth use create_local_token() to transform server_info -> session_infoAndrew Bartlett4-116/+152
Before a auth_serversupplied_info struct can be used for authorization, the local groups and privileges must be calculated. create_local_token() now copies the server_info, and then sets the calulated token and unix groups. Soon, it will also transform the result into an expanded struct auth_session_info. Until then, the variable name (server_info vs session_info provides a clue to the developer about what information has been entered in the structure). By moving the calls to create_local_token within the codebase, we remove duplication, and ensure that the session key (where modified) is consistently copied into the new structure. Andrew Bartlett
2011-04-04s3-auth consolidate create_local_token() into make_server_info_krb5()Andrew Bartlett2-3/+13
This ensures that all callers don't need to each add builtin groups and privileges to the user's token Andrew Bartlett
2011-03-30s3: try to fix the build on some non-linux buildfarm machines.Günther Deschner1-0/+1
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 30 11:39:31 CEST 2011 on sn-devel-104
2011-03-30s3: only include lib/privileges.h where needed.Günther Deschner1-0/+1
This finally removes the global lsa.h inclusion. Guenther
2011-03-30s3-prototyes: user_in_netgroup and user_in_list moved to auth, out of smbd.Günther Deschner1-0/+2
Guenther
2011-03-30s3-auth: use auth.h where needed.Günther Deschner22-0/+22
Guenther
2011-03-30s3-auth: move auth prototypes to auth/proto.h.Günther Deschner1-0/+266
Guenther
2011-03-30s3: auth also needs parts of smbd.Günther Deschner2-0/+2
Guenther
2011-03-30s3-passdb: use passdb headers where needed.Günther Deschner4-0/+4
Guenther
2011-03-30s3-passdb: add passdb.h where needed.Günther Deschner3-0/+3
Guenther
2011-03-30s3: create_builtin_users/administrators belongs to passdb not auth.Günther Deschner1-130/+0
Guenther
2011-03-30s3-includes: only include system/filesys.h when needed.Günther Deschner1-0/+1
Guenther
2011-03-30s3-includes: only include system/passwd.h when needed.Günther Deschner2-0/+2
Guenther
2011-03-30s3-winbind: remove global inclusion of libwbclient.Günther Deschner6-0/+6
Guenther
2011-03-30lib/util/util_pw: share more code between lib/util/util_pw.c and ↵Günther Deschner1-0/+1
source3/lib/username.c Guenther
2011-03-30lib/util/util_pw: share sys_get{pw,gr} group of calls.Günther Deschner1-0/+1
Guenther
2011-03-27s3: Fix Coverity ID 2188: MISSING_BREAKVolker Lendecke1-0/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 23:11:10 CEST 2011 on sn-devel-104
2011-03-27s3: Fix Coverity ID 2189: MISSING_BREAKVolker Lendecke1-1/+3
2011-03-23s3: Fix a (invalid) uninitialized variable warningVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 23 11:13:14 CET 2011 on sn-devel-104
2011-03-16s3: Fix Coverity ID 1018, CHECKED_RETURNVolker Lendecke1-3/+5
2011-03-10Quite some callers of sid_split_rid do not care about the ridVolker Lendecke1-3/+1
2011-03-05s3: Fix a memory leak in check_sam_security_info3Volker Lendecke1-10/+12
Abartlet, this commit makes check_sam_security_info3 use talloc_tos() and also cleans up the temporary talloc stackframe. The old code created a temporary talloc context off "mem_ctx" but failed to clean up the tmp_ctx in all but one return paths. talloc_stackframe()/talloc_tos() is designed as a defense against exactly this error: Even if we failed to free the frame when returning from the routine, it would be cleaned up very soon, in our main event loop. Please check this patch! Thanks, Volker Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sat Mar 5 14:08:37 CET 2011 on sn-devel-104
2011-02-28s3-rpc_client: Move client pipe functions to own header.Andreas Schneider2-0/+2
2011-02-23s3-waf: move some parts of auth to AUTH_COMMON to avoid duplicate symbols ↵Günther Deschner1-7/+13
with winbindd. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Feb 23 02:16:23 CET 2011 on sn-devel-104
2011-02-22s3-includes: move some chgpasswd related defines to the locations where they ↵Günther Deschner1-0/+6
are used. Guenther
2011-02-22s3:auth: change num_groups to from size_t to uint32_tStefan Metzmacher2-5/+5
This will help with the change from UNIX_USER_TOKEN to security_unix_token metze
2011-02-22s3-auth Rename auth_serversupplied_info varaiables: server_info -> session_infoAndrew Bartlett2-21/+21
These variables, of type struct auth_serversupplied_info were poorly named when added into 2001, and in good consistant practice, this has extended all over the codebase in the years since. The structure is also not ideal for it's current purpose. Originally intended to convey the results of the authentication modules, it really describes all the essential attributes of a session. This rename will reduce the volume of a future patch to replaced these with a struct auth_session_info, with auth_serversupplied_info confined to the lower levels of the auth subsystem, and then eliminated. (The new structure will be the output of create_local_token(), and the change in struct definition will ensure that this is always run, populating local groups and privileges). Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-02-20s3: NO_SUCH_USER is a lot more likely than NO_MEMORYVolker Lendecke1-1/+1
2011-02-20s3: Convert init_system_info to NTSTATUSVolker Lendecke1-4/+3
2011-02-18s3-waf: use SAMBA3_*() build rules in source3/buildAndrew Tridgell1-11/+11
this brings the s3 waf build much closer to the proposed s3build top level build, using the same bld.SAMBA3_*() rules There are a few renames of subsystems in here, with a 3 suffix where it would create a conflict. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-02-16s3-auth Fix memory leak in security=share and force user =Andrew Bartlett1-1/+1
In these cases, the server_info was not stolen onto a long term memory context, and so remained on the NULL context where it was created. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Feb 16 01:08:19 CET 2011 on sn-devel-104
2011-02-10s3-auth Remove unused pam_handleAndrew Bartlett1-1/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-02-10s3-auth Rename cryptic 'ptok' to security_tokenAndrew Bartlett1-18/+18
This will allow the auth_serversupplied_info struct to be migrated to auth_session_info easier. Adnrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-02-08pam: share pam errors in a common location.Günther Deschner1-0/+1
Guenther
2011-02-06s3: Use the right credentials in check_netlogond_securityVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Feb 6 20:43:03 CET 2011 on sn-devel-104
2011-02-06s3: Fix auth_netlogond to cope with netlogon_creds_CredentialStateVolker Lendecke1-20/+69
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Feb 6 17:30:48 CET 2011 on sn-devel-104
2011-02-06s3: Fetch the machinepw via ldapi in pdb_adsVolker Lendecke1-41/+112
2011-02-04s3-winbindd: let winbind try to use samlogon validation level 6. (bug #7945)Günther Deschner2-0/+2
The benefit of this that it makes us more robust to secure channel resets triggered from tools outside the winbind process. Long term we need to have a shared tdb secure channel store though as well. Guenther Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Feb 4 18:11:04 CET 2011 on sn-devel-104
2011-02-04s3-auth: add copy_netr_SamBaseInfo().Günther Deschner1-56/+6
Guenther Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-01-17s3: Make sure we call wbcAuthenticateUserEx correctlyVolker Lendecke2-8/+29
There are cases where we fill in params.password.response.lm_data with non-NULL where params.password.response.lm_length is 0. wbcAuthenticateUserEx does not like that. I haven't been able to reproduce this with smbclient yet, I've seen it with a proprietary smb client implementation. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Jan 17 16:30:11 CET 2011 on sn-devel-104
2011-01-17s3: Avoid a few calls to cli_errstrVolker Lendecke1-3/+3
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Jan 17 08:47:25 CET 2011 on sn-devel-104
2010-12-20s3: Remove unused "retry" from cli_full_connectionVolker Lendecke1-1/+1
2010-12-20s3: Always retry the DC connection in auth_domainVolker Lendecke1-8/+4
The only condition that cli_full_connection marks as non-retryable is the basic name lookup and TCP connect. To me this is pretty fishy. For example if the negprot fails, this is supposed to be more retryable than a NetBIOS name lookup failure? I'd rather think the opposite is true. Jeremy, this is code from 2002, 389a16d9d533. If you have any comments from back then, let me know :-) Volker