summaryrefslogtreecommitdiff
path: root/source3/auth
AgeCommit message (Collapse)AuthorFilesLines
2010-03-24s3:ntlmssp: rename void *auth_context; into void *callback_private;Stefan Metzmacher1-5/+5
metze Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-24s3:ntlmssp: pass names to ntlmssp_server_start() and store them in ntlmssp_stateStefan Metzmacher1-6/+28
Inspired by the NTLMSSP merge work by Andrew Bartlett. metze Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-24s3:ntlmssp: replace server_role by a server.is_standalone in ntlmssp_stateStefan Metzmacher1-1/+5
Inspired by the NTLMSSP merge work by Andrew Bartlett. metze Signed-off-by: Günther Deschner <gd@samba.org>
2010-03-22Fix valgrind error when running under share level security. plaintext_passwordJeremy Allison1-2/+2
is a data blob with a data pointer pointing to an allocation of length zero. Jeremy.
2010-02-20s3: Fix some nonempty blank linesVolker Lendecke1-59/+57
2010-01-24s3: Remove some calls to memset -- reduces text size by some bytes for meVolker Lendecke1-8/+3
2010-01-14s3:auth: fix account unlock regression introduced with fix for bug #4347Michael Adam1-7/+5
By an oversight, the patchset for #4347 made the unlocking of a locked account after the lockout duration ineffective. Thanks to Björn for finding this! Michael
2010-01-12s3:auth: add comment to nulling out stolen sampassMichael Adam1-0/+4
Adding this comment makes me think, I could also have changed make_server_info_sam() talloc_move instead of talloc_steal, but that would have changed the signature... Well the comment is a first step. :-) Michael
2010-01-10s3: Replace most calls to sid_append_rid() by sid_compose()Volker Lendecke1-6/+4
2010-01-10s3: Remove the typedef for "auth_serversupplied_info"Volker Lendecke11-34/+36
2010-01-10s3: Remove the typedef for "auth_usersupplied_info"Volker Lendecke12-30/+30
2010-01-07s3:auth: don't update the bad pw count if pw is among last 2 history entriesMichael Adam1-1/+73
This conforms to the behaviour of Windows 2003: http://www.microsoft.com/technet/prodtechnol/windowsserver2003/technologies/security/bpactlck.mspx This is supposed to fixes Bug #4347 . Michael
2010-01-07s3:auth:check_sam_security: introduce a bool var to control pad_pw_count ↵Michael Adam1-1/+7
incrementation This is a preparatory patch for the last part in fixing bug #4347 . Michael
2010-01-07s3:auth:check_sam_security: improve calling and logging of ↵Michael Adam1-4/+16
pdb_update_sam_account Log what went wrongl, and also call pdb_update_sam_account inside become_root/unbecome_root: do the logging outside. Michael
2010-01-07s3:auth:check_sam_security: fix a leading tab/ws mixupMichael Adam1-1/+1
Michael
2010-01-07s3:auth:check_sam_security: create (and use) a common exit pointMichael Adam1-11/+7
for use after sam_password_ok() has been called. Michael
2010-01-07s3:auth:check_sam_security: null out sampass after it has been stolen.Michael Adam1-0/+1
So that a later talloc_free would not harm. I could have used talloc_move instead of talloc steal in make_server_info_sam(), but this would have required a change of the signature. Michael
2010-01-07s3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampassMichael Adam1-14/+20
This is in preparation to extending check_sam_security to also check against the password history before updating the bad password count. This way, sam_password_ok can more easily be reused for that purpose. Michael
2010-01-07s3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()Michael Adam1-2/+2
This way it is more explicit that there is no allocated data here that may leak. Michael
2010-01-07s3:auth:sam_password_ok: fix allocation of a data blob.Michael Adam1-1/+1
data_blob(mem_ctx, 16) does not use mem_ctx as a talloc ctx but copies 16 bytes from mem_ctx into the newly allocated data blob. This can not have been intentional. A blank uint8_t array of length 16 is allocated by passing NULL instead of mem_ctx. And using data_blob_talloc(mem_ctx, NULL, 16) adds the allocated blank 16 byte array to mem_ctx - so this is what must have been intended. Michael
2010-01-07s3:auth:sam_password_ok: enhance readability (imho) by adding some pointersMichael Adam1-17/+24
and removing bool variables and several checks. Michael
2010-01-07s3:check_sam_security: untangle assignment from statementMichael Adam1-1/+2
Michael
2009-12-29s3:ntlmssp: change get_challange() to return NTSTATUSStefan Metzmacher1-2/+3
metze
2009-12-22s3:ntlmssp: only include ntlmssp.h where actually neededAndrew Bartlett1-0/+1
Andrew Bartlett
2009-12-07s3:auth: Fix typo in debug message.Karolin Seeger1-2/+2
Karolin
2009-11-14s3:fix a comment typoMichael Adam1-1/+1
Michael
2009-11-14s3:is_trusted_domain: shortcut if domain name == global_sam_nameMichael Adam1-0/+4
A domain can't have a trust with itself. This saves some roundtrips to the ldap server for ldapsam. Michael
2009-11-14s3:is_trusted_domain: shortcut if domain name is NULL or emptyMichael Adam1-0/+4
This saves some roundtrips to LDAP in an ldapsm setup. Michael
2009-11-13s3/pam: move variable declaration into belonging ifdef sectionBjörn Jacke1-1/+1
This fixes a unused variable 'addr' warning on some platforms
2009-11-12Ensure all callers to the rpc_client/cli_pipe functions correctlyJeremy Allison1-6/+6
initialize return variables. Jeremy.
2009-11-03s3-passdb: cleanup some callers of pdb_get_trusteddom_pw().Günther Deschner1-3/+1
Guenther
2009-10-13s3: use enum netr_SchannelType all over the place.Günther Deschner1-1/+1
Guenther
2009-09-16schannel: fully share schannel sign/seal between s3 and 4.Günther Deschner1-13/+13
Guenther
2009-09-15s3-dcerpc: use dcerpc_AuthLevel and remove duplicate set of flags.Günther Deschner2-2/+2
Guenther
2009-09-11s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_schannel().Günther Deschner1-1/+1
Guenther
2009-08-22Implement Metze's suggestion of trying getpwuid(0) then getpwnam(root).Jeremy Allison1-9/+5
Jeremy.
2009-08-21Try and fix the buildfarm by using getpwnam(root) insteadJeremy Allison1-0/+7
of getpwuid(0) if DEVELOPER is defined. I'm hoping the build farm defines DEVELOPER... Jeremy.
2009-08-21s3: fix bug #6650, authentication at member servers when winbindd is not runningMichael Adam1-1/+1
Authentication of domain users on the member server fails when winbindd is not running. This is because the is_trusted_domain() check behaves differently when winbindd is running and when it isn't: Since wb_is_trusted_domain() calls wbcDomainInfo(), and this will also give a result for our own domain, this succeeds for the member server's own domain when winbindd is running. When winbindd is not running, is_trusted_domain() checks (and possibly updates) the trustdom cache, and this does the lsa_EnumTrustDom() rpc call to the DC which does not return its own domain. In case of winbindd not running, before 3.4, the domain part was _silently_ mapped to the workgroup in auth_util.c:make_user_info_map(), which effectively did nothing in the member case. But then the parameter "map untrusted to domain" was introduced and the mapping was made to the workstation name instead of the workgroup name by default unless "map untrusted to domain = yes". (Commits d8c54fddda2dba3cbc5fc13e93431b152813892e, 5cd4b7b7c03df6e896186d985b6858a06aa40b3f, and fbca26923915a70031f561b198cfe2cc0d9c3aa6) This was ok as long as winbindd was running, but with winbindd not running, these changes actually uncovered the above logic bug in the check. So the correct check is to treat the workgroup as trusted / or known in the member case. This is most easily achieved by not comparing the domain name against get_global_sam_name() which is the host name unless for a DC but against my_sam_name() which is the workgroup for a DC and for a member, too. (These names are not very intuitive...) I admit that this is a very long commit message for a one-liner, but this has needed some tracking down, and I think the change deserves some justification. Michael
2009-08-19Fix bug #6647 - get_root_nt_token: getpwnam("root") failed!Jeremy Allison1-2/+2
Not all systems may have a "root" user, but all must have a passwd entry for a uid of zero. Jeremy.
2009-07-28Added prefer_ipv4 bool parameter to resolve_name().Jeremy Allison1-1/+1
W2K3 DC's can have IPv6 addresses but won't serve krb5/ldap or cldap on those addresses. Make sure when we're asking for DC's we prefer IPv4. If you have an IPv6-only network this prioritizing code will be a no-op. And if you have a mixed network then you need to prioritize IPv4 due to W2K3 DC's. Jeremy.
2009-07-16Remove an unused talloc context.Jeremy Allison1-8/+2
Jeremy.
2009-07-16Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.Jeremy Allison1-2/+3
Jeremy.
2009-06-03s3:smbd: move more session specific globals to struct smbd_server_connectionStefan Metzmacher2-5/+9
metze
2009-06-03s3:smbd: move negprot related globals to struct smbd_server_connectionStefan Metzmacher1-11/+15
metze
2009-05-28s3/auth map NULL domains to our global sam nameSteven Danneman1-9/+3
This is an addendum to d8c54fdd, which made make_user_info_map() match Windows behavior by mapping untrusted domains given to smbd on the wire with the users credentials to smbd's global sam name. This fix was being circumvented in the case where the client passed a NULL domain. Vista clients do this. In that case smbd was always remapping the name to the machine workgroup. The NULL domain case should also be mapped to the global sam name. Removing the code in this patch, causes us to fall down to the logic added in d8c54fdd and properly map the domain.
2009-05-12s3 auth: Make debug message louder and more usefulDan Sledz1-2/+3
2009-05-11Fix a bunch of compiler warnings about wrong format types.Jeremy Allison1-5/+5
Should make Solaris 10 builds look cleaner. Jeremy.
2009-05-07s3-auth: use full 16byte session key in make_user_info_netlogon_interactive().Günther Deschner1-2/+1
Patch from Jeremy. With this patch, I was able to join Windows 7 RC to a Samba3 DC, and login into a Samba 3 Domain. There are still two registry settings required: HKLM\System\CCS\Services\LanmanWorkstation\Parameters DWORD DomainCompatibilityMode = 1 DWORD DNSNameResolutionRequired = 0 Do *not* modify the other netlogon registry parameters that were passed around, they weaken security. Guenther (cherry picked from commit b5097d54cb74ca0ea328f9e029562f65f4a01134)
2009-04-28Fix bug #6291 - force user stop working.Jeremy Allison1-1/+37
A previous fix broke the invariant that *uid is always initialized on return from create_token_from_username(). Restore it. Jeremy.
2009-04-19s3:auth Fix segfault: Always initialise returned session keysAndrew Bartlett1-1/+3
generated by cgit (git 2.34.1) at 2024-11-01 20:57:02 +0000