| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
clean up a bunch of no previous prototype warnings
(This used to be commit c60687db112405262adf26dbf267804b04074e67)
|
|
(This used to be commit ac3eb7813e33b9a2e78c9158433f7ed62c3b62bb)
|
|
(This used to be commit bc4e0a388a2859d2ddcfb8f07920f3b121a37894)
|
|
Merging these in - should have been merged back before (will
be tidied up later).
Jeremy.
(This used to be commit 1e9284590f42b61bd730104920bc535bf7dfcbf4)
|
|
(This used to be commit a03fb81a9d16c9db787c539d63c13ecaf6d6f80d)
|
|
metze
(This used to be commit 4a198cebe37d74437a8d526aff1139f1668bcd37)
|
|
and server code.
This has had some basic testing. I'll do more during the next couple of days and hopefully also
make RPC-SRVSVC from Samba4 pass against it.
(This used to be commit ef10672399c4b82700dc431b4d93431ffdd42d98)
|
|
Fix Bug ID 4084.
Volker
(This used to be commit 0baa3fcfa6b7d39d0f490ad0682042706f2518f2)
|
|
(This used to be commit 86f4ca84f2df2aa8977eb24828e3aa840dda7201)
|
|
(This used to be commit ac7087a6516fa7e0d10523a892acae852a80e29e)
|
|
on the wire. This allows us to go to nsec resolution
for systems that support it. It should also now be
easy to add a correct "create time" (birth time)
for systems that support it (*BSD). I'll be watching
the build farm closely after this one for breakage :-).
Jeremy.
(This used to be commit 425280a1d23f97ef0b0be77462386d619f47b21d)
|
|
(This used to be commit 05268d7a731861b10ce8556fd32a004808383923)
|
|
(This used to be commit acf237b3cd1b546c2744447d977d36a8e3ed4d10)
|
|
Volker
(This used to be commit 94817a8ef53589011bc4ead4e17807a101acf5c9)
|
|
in POSIX mode (clitar needs fixing too). Add test
posix lock/unlock commands.
Jeremy.
(This used to be commit 596497ccc250896025253be1d67711d6d7f059f0)
|
|
to be selected.
Jeremy.
(This used to be commit 2d8d4bd77bac6f5e7865657e12affd8b94aa85c3)
|
|
to do the upper layer directories but this is what
everyone is waiting for....
Jeremy.
(This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
|
|
Jeremy.
(This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)
|
|
Jeremy.
(This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)
|
|
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit 3df0bf7d6050fd7c9ace72487d4f74d92e30a584)
|
|
(This used to be commit ded2952e00fec712ce612cf6aaabf85c1a6f4488)
|
|
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.
Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit 848ac756f651a4be231e5635580c0fd5f3d3fa0e)
|
|
do
echo "I will always compile before commit :-)"
done
Also fix Klokwork ID 806.
Volker
(This used to be commit 4974c598c00abc20cfb73eee12a7c49c279e0f54)
|
|
Volker
(This used to be commit d7a75ee94db009085165c062f73b68162a8b6da8)
|
|
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
|
|
Guenther
(This used to be commit ff93fc7c1e22c035f6f1405d263702bbb9d61575)
|
|
Guenther
(This used to be commit a0548914c21bb769c3e97b47c9bc521c595f579b)
|
|
(This used to be commit a19d4f2bb4aa94ab40e371efbad9f17e38e3bbc4)
|
|
Ignore a file in a tar output if the first read fails. Also
cope with <2GB read fail.
Jeremy.
(This used to be commit 1b73e699e11c6e26e9a9123e74190eebd170fc05)
|
|
should list
long share names.
Volker
(This used to be commit d3d388180dacb7b9db5d122bc3f2ce1045434f53)
|
|
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
(This used to be commit a3b8bee3ff8211d78f793877c877ccd2e15825dd)
|
|
Fix Coverity #59.
Jeremy.
(This used to be commit d793e1550cc8c79a2764609cddec082470d226e4)
|
|
(This used to be commit 811ae2b21f98bd8926f8edd70de19fe18265e28e)
|
|
(This used to be commit ebc21336d80c5d417b309d4f9c22c074c324e123)
|
|
(This used to be commit 9f645e996279be74aaeebcbecbfa07adce49ec7c)
|
|
Jeremy.
(This used to be commit e5d6069cf88c0aa632af5582fcd7466729b20934)
|
|
Jeremy.
(This used to be commit 2ec461ae583b9a07da3ce5abd7f90ea18e1535ae)
|
|
over --with-kcm. No time to look after it for the moment.
Guenther
(This used to be commit 7ec2b31a8790db1466ffafeab533c11ab7ea801a)
|
|
Guenther
(This used to be commit 977079a0583497255fbd4a48de52ebd404710b62)
|
|
error path)
(This used to be commit 33a1e26114d7dfdfb72e393efa399454a588e11e)
|
|
(This used to be commit 2ec51635ae7ba448f18c4c1342a5fd2adb1ec869)
|
|
(This used to be commit 32c7243b80f1f06d37511fb87f7a5c715f4847c6)
|
|
Jeremy.
(This used to be commit af0ade470f2fac3509a44207b4572e279ba30e34)
|
|
Jeremy.
(This used to be commit ead13ca522d7b8cbb47d660d3cb73c3582088985)
|
|
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
|
|
"-"SAMBA_VERSION_OFFICIAL_STRING"-"SAMBA_VERSION_VENDOR_SUFFIX if
SAMBA_VERSION_VENDOR_SUFFIX is set or "-"SAMBA_VERSION_OFFICIAL_STRING
only if MOUNT_CIFS_VENDOR_SUFFIX is undefined.
This results in: mount.cifs -V
mount.cifs version: 1.10-3.1.2pre1-SVN-build-13706-foovendor
or
mount.cifs version: 1.10-3.1.2pre1-SVN-build-13706
Steve: If this is to long or you do not like it, we might add something
lile -VV to report the added part.
(This used to be commit 3c277c7a3cce14f185db7fede7c0c4ab77769670)
|
|
umount.cifs.c
(This used to be commit d294b28f1c9ed931efe29ebce1c8847215fc03dc)
|
|
(This used to be commit 1d23067e68f914ffb42374532b6454a0aaa7c657)
|
|
Jeremy.
(This used to be commit fe63a6ee06149195032320dd0fb9b6c7dfb460d3)
|
|
(This used to be commit 62b02a68438e0ff1119e68347b1ac3495572fa8a)
|
