Age | Commit message (Collapse) | Author | Files | Lines |
|
This patch makes Samba compile cleanly with -Wwrite-strings.
- That is, all string literals are marked as 'const'. These strings are
always read only, this just marks them as such for passing to other functions.
What is most supprising is that I didn't need to change more than a few lines of code (all
in 'net', which got a small cleanup of net.h and extern variables). The rest
is just adding a lot of 'const'.
As far as I can tell, I have not added any new warnings - apart from making all
of tdbutil.c's function const (so they warn for adding that const string to
struct).
Andrew Bartlett
(This used to be commit 92a777d0eaa4fb3a1c7835816f93c6bdd456816d)
|
|
(This used to be commit 723c4caf64c56b78052c52fec78c7143ec19e944)
|
|
(This used to be commit f3b994326ea4bfc9a74acb2901c733c35900af53)
|
|
(This used to be commit c53e10ff879535e931cb3267d9190fd798d85b31)
|
|
strncpy() to make it clear that we must operate on a PATH_MAX sized buffer.
Andrew Bartlett
(This used to be commit 49d9698ef08d66dc238b2e3469da8944b444dfa1)
|
|
to ensure the malloc is done.
Jeremy.
(This used to be commit e57853000aacc61ba3c73907a7afb85385b378c3)
|
|
(This used to be commit 5170a9f7ffac93c619358353834bc3024a6746d2)
|
|
dashes of const. This is a rather large check-in, some things may break.
It does compile though :-).
Jeremy.
(This used to be commit 82b8f749a36b42e22186297482aad2abb04fab8a)
|
|
Andrew Bartlett
(This used to be commit 7501b2a51835bae005d2ac015c3a428eaadce032)
|
|
(This used to be commit fdd70614d2dc29f6a676c30e254a0bf024687fb4)
|
|
(This used to be commit 59ecac901a231383bd4cacb326724f786e3d7244)
|
|
that app-head does.
Jeremy.
(This used to be commit b521abd86b10573ca8f9116907c81e6deb55f049)
|
|
attempting to calculate the bytes/second being transferred. (Avoid overflow
etc)
Andrew Bartlett
(This used to be commit cd41e5ab857a33e05fa231756ff15707f2f5ce23)
|
|
(This used to be commit d83cae2bbd1625aeb3b7c73ba8dde2d1371e7f89)
|
|
(This used to be commit 1e4ac9615d26bfbf90e3a45f088564f448f689ce)
|
|
(This used to be commit 0ad19825df318030b1772404570cd993fe49e40a)
|
|
name#03, not name#20.
Volker
(This used to be commit 99017e887e4189ac7f6e3b7df08f028dc155191e)
|
|
(This used to be commit cb0ed2faa5ed9163421a0f58d45bcd7ec38f06ec)
|
|
Jeremy.
(This used to be commit 03c49b2e519acb8cc7278ac97a203a7d122d2869)
|
|
and add commands reget and reput to smbclient that continues a transfer that has been onterrupted.
thanks to josef Zlomek that did the original patch.
(This used to be commit b275547c9ecc13bede5bd21a392fa1d695a3926d)
|
|
thanks Josef Zlomek
(This used to be commit fb32fd99b9878db2bacf0588d30fd5f1f37dbfd7)
|
|
future.
This moves us from fstrcpy() and global variables to 'get' and 'set' functions.
In particular, the 'set' function sainity-checks the input, in the same way as
we always have.
Andrew Bartlett
(This used to be commit e57a896f06b16fe7e336e1ae63a0c9e4cc75fd36)
|
|
samba-patches 852
(This used to be commit e2558baa32657a71fd7e0958446f72e373cfadc9)
|
|
- sombody using smbspool won't always have a full smb.conf, and this is how it
was written in the first place anyway.
Again, found by the IRIX compiler.
Andrew Bartlett
(This used to be commit 31181158766cd5f0e8409854f3c304f6fb46582b)
|
|
(and yes, some of these are real bugs)
In particular, the samr code was doing an &foo of various types, to a function
that assumed uint32. If time_t isn't 32 bits long, that broke.
They are assignment compatible however, so use that and an intermediate
variable.
Andrew Bartlett
(This used to be commit 30d0998c8c1a1d4de38ef0fbc83c2b763e05a3e6)
|
|
will make it easier to prove this package correct from an audit point of view.
smbumount to follow, but it uses pstrcpy() so I'll need to decide what to do
with that.
Andrew Bartlett
(This used to be commit 62c56f97248109ca80cc155974584bea9704cd50)
|
|
- removed an unused variable
(This used to be commit 66af95716de470600b0db58bdf8a1f0c15dba036)
|
|
(This used to be commit 922ab73c3c8f510fdbcb8b64d54b512d32c47b75)
|
|
code
(This used to be commit 91ad9041e9507d36eb3f40c23c5d4df61f139ef0)
|
|
few more places to use it.
Andrew Bartlett
(This used to be commit 23689b0746d5ab030d8693abf71dd2e80ec1d7c7)
|
|
(This used to be commit fa0037a294a9faaf3cdc894e2ec1280dad157553)
|
|
Now smbclient, net, and swat use their own proto files - now the global
proto.h
The change to libads/kerberos.c was to break up the dependency on secrets.c -
we want to be able to write an ADS client that doesn't need local secrets.
I have other breakups in the works - I will remove the dependency of
rpc_parse on passdb (and therefore secrets.c) shortly.
(NOTE: This patch does *not* break up includes.h, or other such forbidden
actions).
Andrew Bartlett
(This used to be commit edb41dad2df0ae3db364dbc3896cc75956262edf)
|
|
(This used to be commit 73ba155a6bba150b5bd8385fd609ed7fea30f02f)
|
|
This option was badly maintained, useless and confused our users and
distirbutors. (its SSL, therfore it must be good...)
No windows client uses this protocol without help from an SSL tunnel.
I can't see any reason why setting up a unix-side SSL wrapper would
be any more difficult than the > 10 config options this mess added
to samba in any case.
On the Samba client end, I think the LIBSMB_PROG hack should be
sufficient to start stunnel on the unix side. We might extend this
to take %i and %p (IP and port) if there is demand.
Andrew Bartlett
(This used to be commit b04561d3fd3ee732877790fb4193b20ad72a75f8)
|
|
(This used to be commit d3388d195308cf7fba83734424e78b5248786af5)
|
|
(This used to be commit a3cea5e9ae3b53ecbc45e61a39cbce0ca1b916aa)
|
|
processing work correctly in winbindd. This is a really good patch
that gives full select semantics to the Samba modified select.
Jeremy.
(This used to be commit 3af16ade173cac24c1ac5eff4a36b439f16ac036)
|
|
Changed "SMB/Netbios" to "SMB/CIFS" in file header.
(This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
|
|
(This used to be commit 91e8cb76628e9fcc5dc117d98d464b26db71654e)
|
|
smbclient -L //nautilus1/
should definitely not say "unknown host "nautilus1/". Sheesh.
(This used to be commit 1cd431b8f17e5ac394436d31f64032387ca11930)
|
|
(This used to be commit 6b123adda901ff05b0271eeda060297448f64eec)
|
|
to function again.
Add comment to warn anybody that wants to 'Alphabetize' the list to read crh's
existing comment on the issue.
Andrew Bartlett
(This used to be commit d123d79060caf3ad084e733dac02aa2f67bda35f)
|
|
Jeremy.
(This used to be commit 64301bc5f75283c948630d2b78d28e3869db39a2)
|
|
Jeremy.
(This used to be commit 794c3e2c76aae57d054e46b185def104ca02977c)
|
|
in any of these fields, they can corrupt the output. We
should remove them.
(This used to be commit 934aacdb39a0c21c43505dbba696b746f1333df3)
|
|
ahead of the service name (in standard Unix fashion) then smbclient
just spits out the usage message with no explanation of what in
particular was wrong. Is there any reason we can't just parse out the
service name and password after running getopt??
(This used to be commit 5f6feb55d7e7566549141ebb1786b6f2f9f2645b)
|
|
of commands when specified on command line.
(This used to be commit 39d6b31e14144a3ff4b992d4286b706147e58566)
|
|
This just turns of SPNGO becouse Win2k breaks if you attempt this and DOS
errors at the same time.
Andrew Bartlett
(This used to be commit 2c09907b537147189e77810f586558be6004733b)
|
|
- don't display Domain=[] for auth protocols that don't give us a domain
(This used to be commit 20368455ea59e6e9b85632848bbe92069e7b0f38)
|
|
Fixed winbindd to finally stop leaving log. file droppings :-).
Jeremy.
(This used to be commit 0bea6cf79a44f79fa3a4f2c8381e898e79c66509)
|