summaryrefslogtreecommitdiff
path: root/source3/client
AgeCommit message (Collapse)AuthorFilesLines
2008-08-21mount.cifs: don't prompt for password on krb5 mountsJeff Layton1-1/+2
krb5 mounts require that the user already have a valid krb5 ticket. Since we can't currently use the password entered, don't prompt for it. Also, switch to using strncmp instead of strcmp here. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit c75791c34abebe23c6f6a5534b0358514ec4eabc)
2008-08-14smbspool: Fix printing on port 139.Karolin Seeger1-1/+1
This one was introduced with 8eff35bc. Thanks to Noèl Köthe for tracking that down! Karolin (This used to be commit 250f5a40d6e80305220d7cdc6a8f8459d8d0de74)
2008-08-12cifs.upcall: negatively instantiate keys on errorJeff Layton1-2/+10
When a request-key upcall exits without instantiating a key, the kernel will negatively instantiate the key with a 60s timeout. Older kernels, however seem to also link that key into the session keyring. This behavior can interefere with subsequent mount attempts until the key times out. The next request_key() call will get this negative key even if the upcall would have worked the second time. Fix this by having cifs.upcall negatively instantiate the key itself with a 1s timeout and don't attach it to the session keyring. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit f760dd3f3128c846cdeab16cc52bbb5189427955)
2008-08-07Fix bug #5675 with a varient of Tim Waugh's patch,Jeremy Allison1-1/+1
as proposed by James Peach. Jeremy. (This used to be commit 5c27ad75836136c39774c9456d63f46fa62e281f)
2008-08-05Building cifs.upcall is giving this build warning:Steve French1-1/+1
client/cifs.upcall.c:205: warning: function declaration isn’t a prototype This patch fixes this by properly declaring usage() args as void. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org> (This used to be commit 148a012421cdd875167e708c5dfa771d97bf9856)
2008-08-05cifs.upcall: fix manpage and commentsSteve French1-4/+4
The "cifs.resolver" key type has been changed to "dns_resolver". Fix the comments at the top of cifs.upcall and the manpage accordingly. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org> --- docs-xml/manpages-3/cifs.upcall.8.xml | 4 ++-- source/client/cifs.upcall.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) (This used to be commit 24a93d03c2ca4e718968e2024604e0f398c96659)
2008-08-05Backing out most of changeset 5222b8db3fb692e5071bfd1b41849a8eb0a17995Steve French1-2/+5
(so parsing for domain parameter in mount.cifs matches online help) and rephrasing original code to make it more clear. The check for "domain" was meant to allow for "dom" or "DOM" and the option ("dom") described in the help (e.g. "/sbin/mount.cifs -?") is the shorter ("dom") form. The reason that the string we compare against is larger was to improve readability (we could compare against "dom" but note /* "domain" or "DOMAIN" or "dom" or "DOM" */ but it seemed terser to just show the larger string in the strcmp target. The change to "workgoup" from workg* (anything which begins with "workg" doesn't matter - it is a minor behavior change - but probably few scripts depend on the "alias" for this option). Rework code so that it is clearer what we are comparing against. (This used to be commit 92fad0fc537e75c726d5d6794dd0c4fd61edca2d)
2008-07-24cifs.upcall was not recognizing the newer name "dns_resolver" key typeSteve French1-1/+2
(as a synonym for the older "cifs.resolver" name) when resolving host names to ip addresses for the kernel. Acked-by: Jeff Layton (This used to be commit 22c36b27c60193102b3153e073216865adb1b6c1)
2008-07-23cifs.upcall: fix compile warningSteve French1-3/+3
Steve French noticed these warnings when building cifs.upcall: Compiling client/cifs.upcall.c client/cifs.upcall.c: In function 'usage': client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration client/cifs.upcall.c:33: warning: shadowed declaration is here Change the usage function to not take and arg and have it just use the global "prog" variable. Fix a typo in the log message generated when an unknown option is specified. Also getopt() always returns '?' when it sees an unknown option so there's no point in printing it out. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit 4b8362f9777debd21c47154e786b7017fbf847f7)
2008-07-20Refactoring: Change calling conventions for cli_rpc_pipe_open_noauthVolker Lendecke1-2/+3
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS (This used to be commit 9abc9dc4dc13bd3e42f98eff64eacf24b51f5779)
2008-07-16This patchset comprises a number of cleanups for the cifs upcallJeremy Allison1-11/+20
binary. The biggest change is that it renames it from cifs.spnego to cifs.upcall since the cifs.spnego name really isn't applicable anymore. It also fixes a segfault when the program is run without any args and adds a manpage. Comments and/or suggestions appreciated. This set should apply cleanly to the 3.3 test branch. Signed-off-by: Jeff Layton <jlayton@redhat.com> Jeremy. (This used to be commit c633f10d9e78327664e6bca51f66756bcf0505a6)
2008-07-02Fix bug #5578, reported by sendel2000@hotbox.ru. Bad (non-Samba) use of ↵Jeremy Allison1-0/+3
strlcat gives error. Jeremy. (This used to be commit d7c82997bdcf1acd7ac104efa0ad05e0b94935ea)
2008-06-27Fix two IBM checker warningsVolker Lendecke1-2/+2
Steve, please check! Thanks, Volker (This used to be commit 5222b8db3fb692e5071bfd1b41849a8eb0a17995)
2008-06-17Fix a brown paper bag segfault in clitarVolker Lendecke2-2/+2
Thanks to "No Body is Perfect" from gmail, whoever that is :-) Volker (cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4) (This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)
2008-05-30Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into ↵Jeremy Allison1-1/+1
v3-3-test (This used to be commit 3d01248f63d0d476c16236453983ffe759d0b2c2)
2008-05-30From Michael R Sweet <mike@easysw.com>.Jeremy Allison1-1/+1
All, Noticed that smbspool.c still has my Easy Software Products copyright on it. The following patch fixes it to match the other code I've contributed over the years... Jeremy. (This used to be commit 9f5897e28dfa0d0563cd2568b4bedc601681e41b)
2008-05-28Security fix for CVE-2008-1105: Boundary failure when parsing SMB responsesJeremy Allison1-1/+1
can result in a buffer overrun. Jeremy. (This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
2008-05-25Remove stuff from client_proto.hVolker Lendecke1-404/+0
(This used to be commit c1e115964b671802a4af5beab3ad3222ee17b9c0)
2008-05-22rpc_client: use endpoint mapper to get the port for rpc_pipe_open_tcp().Michael Adam1-1/+0
Michael (This used to be commit f7db445c828c0eef2c08b538bd07d485dc248689)
2008-05-22client: Fix the proto header to fix the build.Kai Blin1-1/+1
(This used to be commit 9e39ac1cc31d48db968e79c4698901e079007ff7)
2008-05-18smbclient: freeze client_proto.h from "make proto"Michael Adam1-0/+457
Michael (This used to be commit f8c0710165ee1ede46d7ed34daa5564d20d3f069)
2008-05-05Fix client authentication with -P switch in client tools (Bug 5435).Günther Deschner1-0/+5
Guenther (This used to be commit d077ef64cd1d9bbaeb936566c2c70da508de829f)
2008-05-01Tidyup to ensure '\n' is treated identically in allJeremy Allison1-0/+2
cases. Jeremy. (This used to be commit 818fbc9889af8c9fb6e7978e8ed2269a78f14404)
2008-05-01Fix bug #5434 found by Ted Percival <ted@midg3t.net>.Jeremy Allison1-0/+2
Introduced by me in the strlcpy cleanup. Ensure the loaded password doesn't contain the '\n' at the end. Jeremy. (This used to be commit 41984743d9e89b6568119832c35ee4c0024e43a2)
2008-04-25Sync up client/mount.cifs.c with v3-2-test.Jeremy Allison1-25/+4
Jeremy. (This used to be commit 7a724d78e11f016f154c0029dc394ce133f41110)
2008-04-25mount.cifs: Zero mountpassword content before freeing.Karolin Seeger1-3/+24
Karolin (This used to be commit d99a31848bd2172c15500dd61ce30fef963c1ac6)
2008-04-24Make mount.cifs.c consistent with other Samba code usage w.r.tJeremy Allison1-69/+54
SAFE_FREE. Use #define constants not arbitrary numbers. Stevef please check. Karolyn, once Steve has checked please pull for 3.2-stable. Jeremy. (This used to be commit cc23f91d639db61903bf8b6c9fa46ec9c1f44178)
2008-04-21smbspool: Fix the smbspool build.James Peach1-11/+15
(This used to be commit a51cb3c1a9549d74c1e5cf05bc43b955af1a25b7)
2008-04-21smbspool: minor formatting cleanups.James Peach1-88/+133
(This used to be commit 831a09ae25e98eacc0b0be5390d3ac3aa671a8a5)
2008-04-21smbspool: Run indent to approximate conding standards.James Peach1-533/+485
(This used to be commit 4244be792eeb69e883a1ece013b62fe6941086f2)
2008-04-21smbspool: add my copyright.James Peach1-0/+1
(This used to be commit b294b2055a422e1af59e3b6843b84750b6786d99)
2008-04-21smbspool: Fix CUPS authentication protocol support.Mike Sweet1-34/+75
There were a couple of places where we weren't checking for authentication correctly. This chance fixes those places and properly supports Kerberos where available. (This used to be commit 8eff35bc4acc13807c895af43b52db79ee195cb5)
2008-04-21smbspool: fix Kerberos support for CUPS 1.3.Mike Sweet1-144/+87
To summarize the changes, the patches remove the old (probably non- working) Kerberos support code which is unnecessary with CUPS 1.3 and adds some checks on the NT status we get back to see whether the connection error is related to authentication. If so, we send the ATTR: message to tell CUPS we need a username and password and return exit code 2 so cupsd will do the right thing. AUTH_USERNAME, AUTH_PASSWORD, and KRB5CCNAME are set and supported by CUPS 1.3. The new exit code is supported by CUPS 1.2.x and 1.3, and it treated as a general failure in CUPS 1.1. The ATTR: message is only supported by CUPS 1.3, while CUPS 1.2 will assume the "username,password" value we are setting. The current code only uses the AUTH_* env vars if they are set. If not, we fall back to the previous behavior. I really can't tell whether the Kerberos code that was in there would work at all. It did not work for Mac OS X which is why I dropped it. (This used to be commit 8c12c5cea01d9b801fe80c2a87b8139c488a62a5)
2008-04-20Replace cli_rpc_pipe_close by a talloc destructor on rpc_pipe_structVolker Lendecke1-2/+2
(This used to be commit 99fc3283c4ecc791f5a242bd1983b4352ce3e6cf)
2008-04-20Add "desthost" to rpc_pipe_clientVolker Lendecke1-1/+1
This reduces the dependency on cli_state (This used to be commit 783afab9c891dd7bcb78895b2a639b6f3a0edf5b)
2008-04-17Fix the problem when -L is used with IPv6 addresses. Don't try toJeremy Allison1-0/+8
connect on port 139 with IPv6. Found by David Holder @ Erion. Karolin please merge to 3.2-stable. Jeremy. (This used to be commit c003e66ff10b23bb30aef0071ba7a3ae9579174e)
2008-03-31mount.cifs: fix several problems when mounting subdirectories of shares (try 2)Jeff Layton1-24/+66
This patch is the second patch to attempt to fix up some of the problems with mounting subdirectories of shares. The earlier patch didn't handle this correctly when POSIX extensions were enabled. This one does. This is a bit of a confusing area since the different components of a service string have different rules: 1) hostname: no '/' (slash) or '\' (backslash) is allowed to be embedded within the string 2) sharename: same rules as hostname 3) prefixpath: '\' *is* allowed to be embedded in a path component, iff POSIX extensions are enabled. Otherwise, neither character is allowed. The idea here is to allow either character to act as a delimiter when we know that the character can't be anything but a delimiter (namely everywhere up to the start of the prefixpath). The patch will convert any '\' unconditionally to '/' in the UNC portion of the string. However, inside the prefixpath, we can't make assumptions about what constitutes a delimiter because POSIX allows for embedded '\' characters. So there we don't attempt to do any conversion, and pass the prefixpath to the kernel as is. Once the kernel determines whether POSIX extensions are enabled, it can then convert the path if needed and it's able to do so. A patch to handle this has already been committed to the cifs-2.6 git tree. This patch also fixes an annoyance. When you mount a subdir of a share, mount.cifs munges the device string so that you can't tell what the prefixpath is. So if I mount: //server/share/p1/p2/p3 ..then /proc/mounts and mtab will show only: //server/share Finally, it also tries to apply some consistent rules to the uppercasing of strings. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit e03d1dfdb80333c071b600245eb749ef5664aa22)
2008-03-28More ssize_t->SMB_OFF_TVolker Lendecke1-1/+1
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
2008-03-17Coverity fixesMarc VanHeyningen1-1/+4
(This used to be commit 3fc85d22590550f0539215d020e4411bf5b14363)
2008-03-15Fix Coverity ID 563Volker Lendecke1-5/+1
dirmask is always set here, we've dereferenced it before anyway (This used to be commit e6787aa133a1b241987319486c3bc46ac6ad41af)
2008-03-15Fix Coverity ID 564Volker Lendecke1-10/+0
finfo1==NULL just does not happen in current code (This used to be commit 9ea0078c3151984a901c9bba559ae2bd7959e077)
2008-03-10Use rpccli_srvsvc_NetShareEnumAll in smbclient.Günther Deschner1-15/+21
Guenther (This used to be commit 1121633652ffb77dce8df9cc91b7dfc2d55fd348)
2008-03-06Eliminate global variable in_client and a plethora of extern declarations.Derrell Lipman2-4/+2
Derrell (This used to be commit b7f34e7ef2907b498a0645ce68f2773ed7d60cdc)
2008-03-06Change default bufsize to 512kVolker Lendecke1-1/+1
I did not do any scientific tests, but the dummy test on my laptop against a w2k3 vmware shows that in this specific situation going beyond 512k seems not to gain anything anymore. smb: \> iosize 64512 iosize is now 64512 smb: \> lcd /dev smb: \> get random null getting file \random of size 104857600 as null (33453,1 kb/s) (average 19718,5 kb/s) smb: \> get random null getting file \random of size 104857600 as null (34236,0 kb/s) (average 20509,1 kb/s) smb: \> iosize 524288 iosize is now 524288 smb: \> get random null getting file \random of size 104857600 as null (49042,1 kb/s) (average 22521,9 kb/s) smb: \> get random null getting file \random of size 104857600 as null (49420,8 kb/s) (average 23432,9 kb/s) smb: \> iosize 1048576 iosize is now 1048576 smb: \> get random null getting file \random of size 104857600 as null (49420,8 kb/s) (average 24284,2 kb/s) smb: \> get random null getting file \random of size 104857600 as null (49136,3 kb/s) (average 25076,9 kb/s) (This used to be commit 1bcfef6a9093aa873550a263dc142c8a3f5edffd)
2008-03-06Use io_bufsize as window size in smbclient get commandVolker Lendecke1-1/+1
(This used to be commit e602f06cbba852a7eacd15b2511ef2571a95cc80)
2008-03-06Add async cli_pull supportVolker Lendecke1-29/+16
This is the big (and potentially controversial) one. It took a phone call to explain to metze what is going on inside cli_pull_read_done, but I would really like everybody to understand this function. It is a very good and reasonably complex example of async programming. If we want more asynchronism in s3, this is what we will have to deal with :-) Make use of it in the smbclient "get" command. Volker (This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
2008-03-01Revert "Add async cli_pull support"Volker Lendecke1-15/+27
This reverts commit 844a163458c7585e4306a21ffdae5d08e03d6e4d. (This used to be commit 5ab1cfda500de07ff3c712442ab2fc74eecc8886)
2008-03-01Revert "Fix warnings"Volker Lendecke1-1/+2
This reverts commit 9a966e5593ae4474014aec5d8c68c489ac8ce0c9. (This used to be commit 413695e8d0d8232a9c35e693f9a4a8009418ede4)
2008-02-29Fix warningsVolker Lendecke1-2/+1
(This used to be commit 9a966e5593ae4474014aec5d8c68c489ac8ce0c9)
2008-02-28Remove smbmount.Karolin Seeger3-1575/+0
Karolin (This used to be commit 5fbd98f7065268ae134108310119078ad8f62322)
generated by cgit (git 2.34.1) at 2024-11-30 10:55:48 +0000