summaryrefslogtreecommitdiff
path: root/source3/client
AgeCommit message (Collapse)AuthorFilesLines
2008-10-09mount.cifs: make return codes match the return codes for /bin/mount (try #3)Jeff Layton1-36/+46
The manpage for /bin/mount specifies that the return code should be a positive integer (actually, it's a bitfield). Clean up the return codes from mount.cifs to make them match the expected return values from /bin/mount. This necessary for proper integration with autofs. This is the third attempt at this patch. The changes here are minor, just changing some return's from main() into exit() calls for consistency's sake. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2008-10-09mount.cifs: have uppercase_string return success on NULL pointerJeff Layton1-2/+2
We currently don't attempt to uppercase the device portion of the mount string if there isn't a prefixpath. Fix that by making uppercase_string return success without doing anything on a NULL pointer. Signed-off-by: Jeff Layton <jlayton@redhat.com>
2008-10-03Fix the build farm. In this branch cli_echo returns NTSTATUS.Jeremy Allison1-1/+4
Jeremy
2008-10-03Correctly fix smbclient to terminate on eof from server.Jeremy Allison1-2/+11
Jeremy.
2008-09-21Attempt to fix bug 5778Volker Lendecke1-0/+10
Jeff, Steve, please check!
2008-09-15Fix display of POSIX ACLs.Timur1-2/+2
2008-09-12mount.cifs: make local versions of strlcat and strlcpy staticJeff Layton1-2/+2
...to silence -Wmissing-prototypes Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit fc7c71f15b39158ac58beaa90cc9038db680b8cb)
2008-09-12cifs.upcall: make most functions static and silence compiler warningsJeff Layton1-7/+11
...to silence -Wmissing-prototypes and some uninit'ed variable warnings. Thanks to GD for the extra-paranoid compiler flags. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit f0ee2c145fa031f91c28a69a44b7652f18eea0f0)
2008-09-11Use the given name, not the absolute pathname, when printing out ACL info.Jeremy Allison1-1/+1
Make this match the non-ACL case. Jeremy. (This used to be commit e695c1cc2b715afd713595e8daa77910d9f04138)
2008-09-11Fix bug #5751 cannot show ACLs on DFS reported by SATOH Fumiyasu ↵Jeremy Allison1-1/+1
<fumiyas@osstech.co.jp>. Fix for smbclient and libsmbclient. Jeremy. (This used to be commit dbd5d6b145528527a614c6207d81a6c955e57461)
2008-08-28Clarify usage of "force create mode".Jeremy Allison1-1/+1
Jeremy. (This used to be commit 1d252ffd313e0cd6fcb3d7cb2c99f2daf56728c1)
2008-08-28Add async smbecho client supportVolker Lendecke1-4/+6
(This used to be commit c1d645fbe39433541d8bfe6b818c855cee318dc5)
2008-08-27mount.cifs: unclear error message with "credentials"Steve French1-2/+3
Thanks to Christophe Curis for the suggestion (This used to be commit 3b5ad9190d2ad6d2ca0a569194bdff9003bda13b)
2008-08-22cifs.upcall: bump SPNEGO msg version number and don't reject old versionsJeff Layton2-3/+3
When we added the ability for the kernel to send sec=mskrb5 to the upcall, we subtly broke old cifs.upcall versions that don't understand it. Bump the spnego message version to 2 to make this clear. Also, change cifs.upcall to not reject requests with a version that's lower than the current one, and to send the reply with the same version that the request sent. The idea is to try and keep cifs.upcall backward compatible with old kernels. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit b868463015dedc684eb13d12118a98ccca71250a)
2008-08-21cifs.upcall: fix build warningJeff Layton1-1/+2
Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit aa3443492c58a7c109fe159e15d763dbafc66f2a)
2008-08-21cifs.upcall: handle MSKRB5 OID properlyJeff Layton1-5/+13
When the kernel sends the upcall a sec=mskrb5 parameter, that means the the MSKRB5 OID is preferred by the server. This patch fixes the upcall to use that OID in place of the "normal" krb5 OID when it gets a sec=mskrb5 parameter. Signed-off-by: Jeff Layton <jlayton@redhat.com> Acked-by: Steve French <smfrench@gmail.com> (This used to be commit 6287e13b34efeaa8fd94c7c6d99468350ce6172e)
2008-08-21mount.cifs: don't prompt for password on krb5 mountsJeff Layton1-1/+2
krb5 mounts require that the user already have a valid krb5 ticket. Since we can't currently use the password entered, don't prompt for it. Also, switch to using strncmp instead of strcmp here. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit c75791c34abebe23c6f6a5534b0358514ec4eabc)
2008-08-14smbspool: Fix printing on port 139.Karolin Seeger1-1/+1
This one was introduced with 8eff35bc. Thanks to Noèl Köthe for tracking that down! Karolin (This used to be commit 250f5a40d6e80305220d7cdc6a8f8459d8d0de74)
2008-08-12cifs.upcall: negatively instantiate keys on errorJeff Layton1-2/+10
When a request-key upcall exits without instantiating a key, the kernel will negatively instantiate the key with a 60s timeout. Older kernels, however seem to also link that key into the session keyring. This behavior can interefere with subsequent mount attempts until the key times out. The next request_key() call will get this negative key even if the upcall would have worked the second time. Fix this by having cifs.upcall negatively instantiate the key itself with a 1s timeout and don't attach it to the session keyring. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit f760dd3f3128c846cdeab16cc52bbb5189427955)
2008-08-07Fix bug #5675 with a varient of Tim Waugh's patch,Jeremy Allison1-1/+1
as proposed by James Peach. Jeremy. (This used to be commit 5c27ad75836136c39774c9456d63f46fa62e281f)
2008-08-05Building cifs.upcall is giving this build warning:Steve French1-1/+1
client/cifs.upcall.c:205: warning: function declaration isn’t a prototype This patch fixes this by properly declaring usage() args as void. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org> (This used to be commit 148a012421cdd875167e708c5dfa771d97bf9856)
2008-08-05cifs.upcall: fix manpage and commentsSteve French1-4/+4
The "cifs.resolver" key type has been changed to "dns_resolver". Fix the comments at the top of cifs.upcall and the manpage accordingly. Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@samba.org> --- docs-xml/manpages-3/cifs.upcall.8.xml | 4 ++-- source/client/cifs.upcall.c | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) (This used to be commit 24a93d03c2ca4e718968e2024604e0f398c96659)
2008-08-05Backing out most of changeset 5222b8db3fb692e5071bfd1b41849a8eb0a17995Steve French1-2/+5
(so parsing for domain parameter in mount.cifs matches online help) and rephrasing original code to make it more clear. The check for "domain" was meant to allow for "dom" or "DOM" and the option ("dom") described in the help (e.g. "/sbin/mount.cifs -?") is the shorter ("dom") form. The reason that the string we compare against is larger was to improve readability (we could compare against "dom" but note /* "domain" or "DOMAIN" or "dom" or "DOM" */ but it seemed terser to just show the larger string in the strcmp target. The change to "workgoup" from workg* (anything which begins with "workg" doesn't matter - it is a minor behavior change - but probably few scripts depend on the "alias" for this option). Rework code so that it is clearer what we are comparing against. (This used to be commit 92fad0fc537e75c726d5d6794dd0c4fd61edca2d)
2008-07-24cifs.upcall was not recognizing the newer name "dns_resolver" key typeSteve French1-1/+2
(as a synonym for the older "cifs.resolver" name) when resolving host names to ip addresses for the kernel. Acked-by: Jeff Layton (This used to be commit 22c36b27c60193102b3153e073216865adb1b6c1)
2008-07-23cifs.upcall: fix compile warningSteve French1-3/+3
Steve French noticed these warnings when building cifs.upcall: Compiling client/cifs.upcall.c client/cifs.upcall.c: In function 'usage': client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration client/cifs.upcall.c:33: warning: shadowed declaration is here Change the usage function to not take and arg and have it just use the global "prog" variable. Fix a typo in the log message generated when an unknown option is specified. Also getopt() always returns '?' when it sees an unknown option so there's no point in printing it out. Signed-off-by: Jeff Layton <jlayton@redhat.com> (This used to be commit 4b8362f9777debd21c47154e786b7017fbf847f7)
2008-07-20Refactoring: Change calling conventions for cli_rpc_pipe_open_noauthVolker Lendecke1-2/+3
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS (This used to be commit 9abc9dc4dc13bd3e42f98eff64eacf24b51f5779)
2008-07-16This patchset comprises a number of cleanups for the cifs upcallJeremy Allison1-11/+20
binary. The biggest change is that it renames it from cifs.spnego to cifs.upcall since the cifs.spnego name really isn't applicable anymore. It also fixes a segfault when the program is run without any args and adds a manpage. Comments and/or suggestions appreciated. This set should apply cleanly to the 3.3 test branch. Signed-off-by: Jeff Layton <jlayton@redhat.com> Jeremy. (This used to be commit c633f10d9e78327664e6bca51f66756bcf0505a6)
2008-07-02Fix bug #5578, reported by sendel2000@hotbox.ru. Bad (non-Samba) use of ↵Jeremy Allison1-0/+3
strlcat gives error. Jeremy. (This used to be commit d7c82997bdcf1acd7ac104efa0ad05e0b94935ea)
2008-06-27Fix two IBM checker warningsVolker Lendecke1-2/+2
Steve, please check! Thanks, Volker (This used to be commit 5222b8db3fb692e5071bfd1b41849a8eb0a17995)
2008-06-17Fix a brown paper bag segfault in clitarVolker Lendecke2-2/+2
Thanks to "No Body is Perfect" from gmail, whoever that is :-) Volker (cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4) (This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)
2008-05-30Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into ↵Jeremy Allison1-1/+1
v3-3-test (This used to be commit 3d01248f63d0d476c16236453983ffe759d0b2c2)
2008-05-30From Michael R Sweet <mike@easysw.com>.Jeremy Allison1-1/+1
All, Noticed that smbspool.c still has my Easy Software Products copyright on it. The following patch fixes it to match the other code I've contributed over the years... Jeremy. (This used to be commit 9f5897e28dfa0d0563cd2568b4bedc601681e41b)
2008-05-28Security fix for CVE-2008-1105: Boundary failure when parsing SMB responsesJeremy Allison1-1/+1
can result in a buffer overrun. Jeremy. (This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
2008-05-25Remove stuff from client_proto.hVolker Lendecke1-404/+0
(This used to be commit c1e115964b671802a4af5beab3ad3222ee17b9c0)
2008-05-22rpc_client: use endpoint mapper to get the port for rpc_pipe_open_tcp().Michael Adam1-1/+0
Michael (This used to be commit f7db445c828c0eef2c08b538bd07d485dc248689)
2008-05-22client: Fix the proto header to fix the build.Kai Blin1-1/+1
(This used to be commit 9e39ac1cc31d48db968e79c4698901e079007ff7)
2008-05-18smbclient: freeze client_proto.h from "make proto"Michael Adam1-0/+457
Michael (This used to be commit f8c0710165ee1ede46d7ed34daa5564d20d3f069)
2008-05-05Fix client authentication with -P switch in client tools (Bug 5435).Günther Deschner1-0/+5
Guenther (This used to be commit d077ef64cd1d9bbaeb936566c2c70da508de829f)
2008-05-01Tidyup to ensure '\n' is treated identically in allJeremy Allison1-0/+2
cases. Jeremy. (This used to be commit 818fbc9889af8c9fb6e7978e8ed2269a78f14404)
2008-05-01Fix bug #5434 found by Ted Percival <ted@midg3t.net>.Jeremy Allison1-0/+2
Introduced by me in the strlcpy cleanup. Ensure the loaded password doesn't contain the '\n' at the end. Jeremy. (This used to be commit 41984743d9e89b6568119832c35ee4c0024e43a2)
2008-04-25Sync up client/mount.cifs.c with v3-2-test.Jeremy Allison1-25/+4
Jeremy. (This used to be commit 7a724d78e11f016f154c0029dc394ce133f41110)
2008-04-25mount.cifs: Zero mountpassword content before freeing.Karolin Seeger1-3/+24
Karolin (This used to be commit d99a31848bd2172c15500dd61ce30fef963c1ac6)
2008-04-24Make mount.cifs.c consistent with other Samba code usage w.r.tJeremy Allison1-69/+54
SAFE_FREE. Use #define constants not arbitrary numbers. Stevef please check. Karolyn, once Steve has checked please pull for 3.2-stable. Jeremy. (This used to be commit cc23f91d639db61903bf8b6c9fa46ec9c1f44178)
2008-04-21smbspool: Fix the smbspool build.James Peach1-11/+15
(This used to be commit a51cb3c1a9549d74c1e5cf05bc43b955af1a25b7)
2008-04-21smbspool: minor formatting cleanups.James Peach1-88/+133
(This used to be commit 831a09ae25e98eacc0b0be5390d3ac3aa671a8a5)
2008-04-21smbspool: Run indent to approximate conding standards.James Peach1-533/+485
(This used to be commit 4244be792eeb69e883a1ece013b62fe6941086f2)
2008-04-21smbspool: add my copyright.James Peach1-0/+1
(This used to be commit b294b2055a422e1af59e3b6843b84750b6786d99)
2008-04-21smbspool: Fix CUPS authentication protocol support.Mike Sweet1-34/+75
There were a couple of places where we weren't checking for authentication correctly. This chance fixes those places and properly supports Kerberos where available. (This used to be commit 8eff35bc4acc13807c895af43b52db79ee195cb5)
2008-04-21smbspool: fix Kerberos support for CUPS 1.3.Mike Sweet1-144/+87
To summarize the changes, the patches remove the old (probably non- working) Kerberos support code which is unnecessary with CUPS 1.3 and adds some checks on the NT status we get back to see whether the connection error is related to authentication. If so, we send the ATTR: message to tell CUPS we need a username and password and return exit code 2 so cupsd will do the right thing. AUTH_USERNAME, AUTH_PASSWORD, and KRB5CCNAME are set and supported by CUPS 1.3. The new exit code is supported by CUPS 1.2.x and 1.3, and it treated as a general failure in CUPS 1.1. The ATTR: message is only supported by CUPS 1.3, while CUPS 1.2 will assume the "username,password" value we are setting. The current code only uses the AUTH_* env vars if they are set. If not, we fall back to the previous behavior. I really can't tell whether the Kerberos code that was in there would work at all. It did not work for Mac OS X which is why I dropped it. (This used to be commit 8c12c5cea01d9b801fe80c2a87b8139c488a62a5)
2008-04-20Replace cli_rpc_pipe_close by a talloc destructor on rpc_pipe_structVolker Lendecke1-2/+2
(This used to be commit 99fc3283c4ecc791f5a242bd1983b4352ce3e6cf)
generated by cgit (git 2.34.1) at 2024-11-15 07:24:44 +0000