summaryrefslogtreecommitdiff
path: root/source3/include/smb_macros.h
AgeCommit message (Collapse)AuthorFilesLines
2009-01-31Remove the global variable "chain_size"Volker Lendecke1-1/+1
2009-01-24talloc_free() copes with a NULL pointer just fineVolker Lendecke1-1/+1
Saved around 10kb of code on my box :-)
2008-12-14Move 128 bytes from the data to the text segmentVolker Lendecke1-1/+1
2008-11-08change CHECK_READ to use smb_request instead of inbufVolker Lendecke1-2/+2
2008-11-02Remove some direct inbuf references by adding smbreq_bufremVolker Lendecke1-0/+2
2008-11-01Remove IS_DOT and IS_DOTDOT macros, already provided by libreplace orJelmer Vernooij1-8/+0
the system.
2008-11-01Move ABS() to libutil.Jelmer Vernooij1-24/+0
2008-11-01Samba3: Include util.h header file rather than having custom prototypes.Jelmer Vernooij1-11/+1
2008-10-08Remove unused CHECK_FSP macroVolker Lendecke1-16/+0
2008-06-19Remove current_user references from trans2.cVolker Lendecke1-2/+0
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function. (This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)
2008-04-17IDL: build generated nbt code.Günther Deschner1-0/+3
Guenther (This used to be commit 554dcfdab03f9d06f319a3234d56cf44dc38c9da)
2008-02-28Remove smbmount.Karolin Seeger1-3/+2
Karolin (This used to be commit 5fbd98f7065268ae134108310119078ad8f62322)
2008-01-09Fixup hot paths - add macro for toupper (c < 0x80).Jeremy Allison1-0/+8
This now matches 3.0.x on my micro-tests. Jeremy. (This used to be commit 329b924cba8225002ca40db26c45b31d141a0925)
2008-01-04Refactor the crypto code after a very helpful conversationJeremy Allison1-4/+7
with Volker. Mostly making sure we have data on the incoming packet type, not stored in the smb header. Jeremy. (This used to be commit c4e5a505043965eec77b5bb9bc60957e8f3b97c8)
2007-12-26Add SMB encryption. Still fixing client decrypt butJeremy Allison1-10/+6
negotiation works. Jeremy. (This used to be commit d78045601af787731f0737b8627450018902b104)
2007-11-02Change the client library to write directly out ofJeremy Allison1-2/+2
the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison1-3/+2
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-5/+14
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25103: Ensure we don't return unwritten memory (valgrind caught).Jeremy Allison1-3/+0
Jeremy. (This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)
2007-10-10r24803: For some funny reason us4/gcc seems to fall over the 'Volker Lendecke1-1/+1
(This used to be commit 08e309e955eea58df1eb88f848386eb2acbd31ba)
2007-10-10r24762: Fix the build, missed TALLOC_SIZE -> talloc_named_const.Jeremy Allison1-1/+1
Jeremy. (This used to be commit e2d924248ef4c8158e80bfffa5d734b9723112ce)
2007-10-10r24759: Comment out the _nonnull calls for 3.2.x, as agreed with tridge.Jeremy Allison1-2/+22
Leaving the commented out code for now, in case I need to re-test some stuff. Jeremy (This used to be commit 343be0464342aac14a9592fd73a71b7589ba34d5)
2007-10-10r24464: Now Volker removed the readbmpx we don't need cached errors any more.Jeremy Allison1-6/+0
Jeremy. (This used to be commit 9256ec0a20f532c7dd7ddc2d3534336a47e6c2d2)
2007-10-10r24311: add a reply_force_nterror() macroStefan Metzmacher1-0/+1
metze (This used to be commit b9ae00f4980c305f2f7334b139f9bc72fd9afbd6)
2007-10-10r24078: Add reply_unixerrorVolker Lendecke1-0/+1
(This used to be commit 10ac991750e9476299d39ac6f763d1638ff8c619)
2007-10-10r23997: Check in the infrastructure for getting rid of the global ↵Volker Lendecke1-0/+4
InBuffer/OutBuffer The complete history of this patch can be found under http://www.samba.org/~vlendec/inbuf-checkin/. Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only checking into 3_2 at the moment, as it currently will slow down operations for all non-converted (i.e. all at this moment) operations, as it will copy the talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort to convert everything necessary for the normal operations an XP box does. I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More to come, but I would appreciate some help here. Volker (This used to be commit 5594af2b208c860d3f4b453af6a649d9e4295d1c)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23510: Tidy calls to smb_panic by removing trailing newlines. Print theJames Peach1-3/+4
failed expression in SMB_ASSERT. (This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)
2007-10-10r22920: Add in the UNIX capability for 24-bit readX, as discussedJeremy Allison1-0/+4
with the Apple guys and Linux kernel guys. Still looking at how to do writeX as there's no recvfile(). Jeremy. (This used to be commit a53268fb2082de586e2df250d8ddfcff53379102)
2007-10-10r22852: merge fixes for CVE-2007-2446 and CVE-2007-2447 to all branchesGerald Carter1-2/+0
(This used to be commit f65214be68c1a59d9598bfb9f3b19e71cc3fa07b)
2007-10-10r22564: Move the _strict -> _zeronull functions into lib/util.cJeremy Allison1-9/+9
and out of talloc at tridge's request. Jeremy. (This used to be commit da78488b86c464b6861d36398cca7524ad5906fe)
2007-10-10r22543: Fix bad call to talloc_strict (too few args).Jeremy Allison1-1/+1
Should fix build farm breakage. Jeremy. (This used to be commit efb43432b01f0b55df409225c7526ff232c00171)
2007-10-10r22542: Move over to using the _strict varients of the tallocJeremy Allison1-7/+9
calls. No functional changes. Looks bigger than it is :-). Jeremy. (This used to be commit f6fa3080fee1b20df9f1968500840a88cf0ee592)
2007-10-10r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison1-6/+6
to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy. (This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
2007-10-10r22298: move ZERO_*, ARRAY_SIZE and PTR_DIFF macros into libreplaceStefan Metzmacher1-19/+0
metze (This used to be commit 8a7d2e633b98aa9c73cf1f7d1369015b294cf2e1)
2007-10-10r22277: __location__ is defined in libreplace nowStefan Metzmacher1-5/+0
metze (This used to be commit 9b45075a265d00847cf77b549759ad9373a16615)
2007-10-10r21525: Go ahead and checkin the mlock() & memalign() fixes soGerald Carter1-0/+1
others don't get stuck with the winbindd hang. Still waiting on additional confirmation from Guenther that this fixes thes issues he was observing as well. But it's been running in my local tree for a day without problems. (This used to be commit 0d2b80c6c4a744b05a0efdec352cddccc430e0c4)
2007-10-10r20124: clean up nested extern declaration warningsHerb Lewis1-2/+2
(This used to be commit ac3eb7813e33b9a2e78c9158433f7ed62c3b62bb)
2007-10-10r17316: More C++ warnings -- 456 leftVolker Lendecke1-1/+1
(This used to be commit 1e4ee728df7eeafc1b4d533240acb032f73b4f5c)
2007-10-10r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison1-15/+16
to do the upper layer directories but this is what everyone is waiting for.... Jeremy. (This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-basedJames Peach1-0/+4
HSM is interested in. Tested on both IRIX and SLES9. (This used to be commit 514a767c57f8194547e5b708ad2573ab9a0719c6)
2007-10-10r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistentJeremy Allison1-1/+1
between Realloc and realloc_array. Jeremy. (This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-2/+4
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r9945: fix typos.Günther Deschner1-1/+1
Guenther (This used to be commit 12029e902277053a4066eae1b3ae311fae5e6422)
2007-10-10r9739: conver the reg_objects (REGSUBKEY_CTR & REGVAL_CTR) to useGerald Carter1-0/+1
the new talloc() features: Note that the REGSUB_CTR and REGVAL_CTR objects *must* be talloc()'d since the methods use the object pointer as the talloc context for internal private data. There is no longer a regXXX_ctr_intit() and regXXX_ctr_destroy() pair of functions. Simply TALLOC_ZERO_P() and TALLOC_FREE() the object. Also had to convert the printer_info_2->NT_PRINTER_DATA field to be talloc()'d as well. This is just a stop on the road to cleaning up the printer memory management. (This used to be commit ef721333ab9639cb5346067497e99fbd0d4425dd)
2007-10-10r8219: Merge the new open code from HEAD to 3.0. Haven't yet run the tortureJeremy Allison1-5/+6
tests on this as it's very late NY time (just wanted to get this work into the tree). I'll test this over the weekend.... Jerry - in looking at the difference between the two trees there seem to be some printing/ntprinting.c and registry changes we might want to examine to try keep in sync. Jeremy. (This used to be commit c7fe18761e2c753afbffd3a78abff46472a9b8eb)
2007-10-10r7200: Don't use memset, use SET_STAT_INVALID (has the same effect).Jeremy Allison1-0/+1
Jeremy. (This used to be commit 0b6f87d5e14da461bd2b1c3a4e6f47a69d2cd1c4)
2007-10-10r7139: trying to reduce the number of diffs between trunk and 3.0; changing ↵Gerald Carter1-1/+6
version to 3.0.20pre1 (This used to be commit 9727d05241574042dd3aa8844ae5c701d22e2da1)
2007-10-10r6613: Merge back fix for PARANOID_MALLOC checker.Jeremy Allison1-1/+3
Jeremy. (This used to be commit 9c8d0efbfdcf9f4558ef3c7d5623558e7142d7ad)