Age | Commit message (Collapse) | Author | Files | Lines |
|
Guenther
(This used to be commit 9f0ea1d727046fef4c23bcf1e71d10f33c93b00f)
|
|
Guenther
(This used to be commit a7aef18797407b1f451191647d4b0225ac838817)
|
|
Guenther
(This used to be commit 53a7e9b07d07d3e9d21360dee35fee27b46929b3)
|
|
(This used to be commit fd18b01016d1dc4b08983975353e62084fdc323c)
|
|
(This used to be commit 76ba37ac46b4a77fe228ca90635fa19140541ccd)
|
|
- James suggested using gcc's "deprecated" attribute to mark the context
structure fields to generate warnings. This creates a scenario with the
best of all worlds. I'm able to move to an organization that more easily
allows future enhancements, while avoiding any mandatory changes by
applications. Thanks, James!
- Updated WHATSNEW.txt so that it accurately reflects the current state of
affairs.
Derrell
(This used to be commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)
|
|
(This used to be commit 71e86f13b0ace3841c6712084728c79db74ff803)
|
|
(This used to be commit 1fd65359f6cd07539cfe43146ac367a48708a678)
|
|
(This used to be commit dec70fa3c0424c148016cc667a3c159e16d8a944)
|
|
(This used to be commit a8b4b773d4647f28e7b92c5968469721d34eb550)
|
|
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(This used to be commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
|
|
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
|
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
|
|
This reverts commit ae254cb61f4b9331755848c47ebc34e90dd80390.
(This used to be commit 030bef7f22f7a73466204b7860f397dbca9f2ab0)
|
|
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81.
(This used to be commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
|
|
Guenther
(This used to be commit 6d543b1a1a5a7af98affc9aea2edf650cb476379)
|
|
in the registry.
Guenther
(This used to be commit f673bbd300d972dd7ae2d092b3b1e642ed29cfd2)
|
|
Michael
(This used to be commit ee4810099c2d26a0ebab3c41a95bc6b57921683d)
|
|
Guenther
(This used to be commit 0a012c12d643e627ea1bad2a2ad6214f78918fa7)
|
|
Karolin
(This used to be commit 5fbd98f7065268ae134108310119078ad8f62322)
|
|
(This used to be commit f5356825698a02df2d400b51dd95d1f857c83e81)
|
|
(This used to be commit ae254cb61f4b9331755848c47ebc34e90dd80390)
|
|
Jeremy.
(This used to be commit 6f2b33f6072629be393f88d4450fa6631ef672f6)
|
|
Guenther
(This used to be commit 9ac2606d5214f1bf4a8ec2ac46bcaeba62e56992)
|
|
Guenther
(This used to be commit a69c6422bb7b1ab64236cbab193d54fd90c106f0)
|
|
Guenther
(This used to be commit 9e17e94c8ee6e555ca3322745faaeb946650bb15)
|
|
Guenther
(This used to be commit e6701352dc2cd4ff9cc7d04db6f1975594477cdb)
|
|
Guenther
(This used to be commit 6c6455157317049d65a9012f4e339b7e86fb0af6)
|
|
Guenther
(This used to be commit 618eae4c0cd6a68349a76cdf36f281733fb472ae)
|
|
Guenther
(This used to be commit 9e7d32e28ce40ff158f3705354e8673f99b462bc)
|
|
Guenther
(This used to be commit 61da5b8c003f9c8785a901fadb06f0dbb8139c5f)
|
|
Guenther
(This used to be commit 8f54ba22d21eb014624670d8fdba7a63d1af684d)
|
|
Guenther
(This used to be commit 58cca9faf9db506bd2f6eab4a99ef85153797ab2)
|
|
(This used to be commit 6f5051b9c1405ab1dc3e697419ceedb3acac46d8)
|
|
(This used to be commit a19e5fd5846685d5264e92bedf5cb57d99271f28)
|
|
Guenther
(This used to be commit eeb598a19a3d09f2175032e013857fe743da3eec)
|
|
Guenther
(This used to be commit 23d37a9aed145d38e2bd98b170b65096ab69b0d9)
|
|
Guenther
(This used to be commit 8a621f517fe38ce91f10e12fccc2963af6afc33d)
|
|
Guenther
(This used to be commit 84112a24f5292b8d2e4d446e39462e0402453b4a)
|
|
Guenther
(This used to be commit 57e03a7fd56062bbff19c88c3b6928e8a0481794)
|
|
(This used to be commit c22ec556b1df777b3b99669403dd1f9094a37a7a)
|
|
This also removes parse_lsa.c entirely.
Guenther
(This used to be commit f802ba035c95e63c5a6ff9f2fb484d62341cd1a7)
|
|
Guenther
(This used to be commit 6458ef3977b60f24b87eb88cf870a9f23929ca85)
|
|
Guenther
(This used to be commit 144f41e7c3c97afede71ed771acd130f9018f0df)
|
|
Guenther
(This used to be commit e0a8818af0e3e82e9b70ff6c485090986b435fed)
|
|
Guenther
(This used to be commit 1162b8a02d365b79f5a3e86c936bae80092f1869)
|
|
Guenther
(This used to be commit 2ec2eefc703df882599b6eac9147350c4df33006)
|
|
Guenther
(This used to be commit ddb3838be1ab5080add4db060432dfd007b1fd73)
|
|
Guenther
(This used to be commit bc1df536fa04e004ccf177e0f3ba56f3c47709aa)
|
|
Guenther
(This used to be commit 8971afaf744e5124d4b82cad76e368ccd05be394)
|