Age | Commit message (Collapse) | Author | Files | Lines |
|
replacement
for setlinebuf which apparantly doesn't exist on HPUX 11.
include/byteorder.h:
rpc_parse/parse_prs.c:
Ding Dong the witch is dead ! :-). Ok, I'm happy 'cos I've finally deleted
all the *HORRIBLE* DBG_RW_XXX and RW_XXX macros from include/byteorder.h.
They were macros that included macros that had conditional macros included.
No one understood them (they were the cause of most of the bigendian issue
bugs). Finally, I went into parse_prs.c and inlined all of that stuff with
regular function calls. They're understandable, they're easy to edit and
they don't include macros !
JF - please look at the one comment I added (JF PLEASE CHECK). I have
tested this partly with IRIX (a bigendian system) running with AS/U on
a Solaris box in SGI's lab, and I've also confirmed these new changes
work with W2K (vmware) but there may be the odd bug lurking. Herb, if
you could re-checkout and test again with this code that would help.
Extra. Fixed bug spotted by the sharp eyes of JF - big endian unicode
packet would cause a early truncate of string parsing as we were checking for a char *
0, not a uint16 * 0.
Jeremy.
(This used to be commit 13765eca71e54aa5d048ce36cd8066b8406777c8)
|
|
added srvstr_push_ascii() and srvstr_pull_ascii() as convenience
routines to replace the current usage of strncpy() like fns
for packet pull/push. We need to do this in *lots* of places
in Samba in order to get our codepage handling right
(This used to be commit 8b0e3679a6dc479c0e3177707dff386559779b69)
|
|
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
|
|
Jeremy.
(This used to be commit 6f7d9e29e4d3a17254ff0ae20c0da63eacded7fe)
|
|
Used in smbtorture mods. Re-cast cli_nt_create() as a call to cli_nt_create_full().
Jeremy.
(This used to be commit f602fa1205e99541e825ccae8502c35cd0e7ccfc)
|
|
(merge from 2.2)
(This used to be commit ea963a648b889da9e47661c61c7fafe13b277e75)
|
|
(This used to be commit 0799b272a07cc288be29e0f606b80219e3a029a3)
|
|
problems with smbd failing to create a log file. If we can't create a log
file keep using the old file.
Jeremy.
(This used to be commit c4e6aa1322fa7bc59708163c42eef6ccbd6c2305)
|
|
smb.conf
file in utf8.
Jeremy.
(This used to be commit 42052d6079479452aa43eb37ad3d679d28337779)
|
|
advantages:
- memory is trackable by insure
- a very simple talloc_realloc() is possible (I've added it)
It is slower than the previous talloc code, but I don't think that
is going to be a problem. If it is a problem then there are
some ways we can make it faster but I'd like to leave those
until we have tested this a bit and can see what performance
problems might show up in profiling
(This used to be commit 1ab63cf3a6f62c3e4ca19a549bde78dad0eb4340)
|
|
Jeremy.
(This used to be commit 2f658691e47406f38bec2fc20951f82043fbf894)
|
|
First one adds a new info level into the lanman printing and an ioctl to the trans2 code.
Andrew - this uses ASCII only. It looks ok to me but please check !
Second one adds a parameter "os2 driver map" that allows OS/2 driver names to be mapped.
Jeremy.
(This used to be commit da79b519e0b6b4317d7fb5260d74e0e74a7e0b46)
|
|
include/proto.h: Fix missing (void) in proto.
rpc_server/srv_samr_nt.c: Fix user private group problem by filtering out groups that
clash with users.
smbd/posix_acls.c: Ensure default ACE's are sensible.
utils/pdbedit.c: Fix from Simo Sorce.
Jeremy.
(This used to be commit 29414fe0d6665642d9b5f88a35e712426376c47f)
|
|
J.F.
(This used to be commit 7154deb026d53cb0cd503562174c3332a372be63)
|
|
Jeremy.
(This used to be commit 4fd8afaf573054eaa838398f62918757659c2c21)
|
|
this allows users to disable the cross-subnet browse extensions that I
added to Samba a couple of years ago. This may be useful for getting
rid of empty workgroups.
(This used to be commit 978980050e599d3830d0474bc9a8003bfe227719)
|
|
is still valid before setting prev and next to null.
Jeremy.
(This used to be commit 0d2e9e4d32b038c1a71e3a625db46876294e3abf)
|
|
lookup_name was expecting to be able to write to the string. Changed
lookup_name to use const.
Jeremy.
(This used to be commit 80c18d88491f1148ade623e81c33f84ba4f952f3)
|
|
(This used to be commit fd6bfe03f4454272bdce59c78ae7148a72caaf18)
|
|
Jeremy.
(This used to be commit 49f0e7e7143f82bce9dfd8b06e9e515bc0869ab7)
|
|
(This used to be commit 386fdff2dfeaeef60b210ebc0b4d33a6c7b5d5ec)
|
|
should work with readline 2.x
(This used to be commit 7940b6b0cf614ac72266d9e600220c9a9dbd2a43)
|
|
to make it a bit simpler
(This used to be commit e1487eb2c4626dbe0cc3b17606eda702cedef28b)
|
|
Jeremy.
(This used to be commit 7b97ac289ed472e03b2a6e9c51a568478a93562d)
|
|
the unicode support isn't complete, but it is good enough to be usable
for a test server.
(This used to be commit e787fc1daf4a46c182e87bf0697eec80ff0ce87a)
|
|
Jeremy.
(This used to be commit 9822f13ae23e244e5e9a4cf3355bea2eead8cf66)
|
|
(This used to be commit 8b2e21c33391ec3c7de72be881c545aff386f591)
|
|
(This used to be commit 86c56a69211f7bad92d9d9bfbd47875c3beec0e8)
|
|
(This used to be commit 5d321673850e1e28e1bee4093705d7e319421687)
|
|
(This used to be commit 7a84bc93eda0946521c0f5274d0b739295a49305)
|
|
(This used to be commit 161842a3e0a25e8cf9805dee3b60d127740816c8)
|
|
Jeremy.
(This used to be commit 28a0bc5f5710aa732db662caa38f9da2138b5db2)
|
|
(This used to be commit b28d51c8e8027231de843e8907f40772b4586eaa)
|
|
(This used to be commit 04d74c20bc689a8afd0a8af8457f18ed077aedee)
|
|
back to working order. The main change is that the cli_*() RPC
functions from libsmb/*.c now should accept a struct cli_state*.
The reason for this is that rpcclient should establish the
connection to the server at startup so that it is not necessary
to keep the clear test or password hash in memory for each command.
enumports and enumprinters now works as well. lsa* functions
have been tested. SAMR calls may or may not work (one of the core
dumps I know), but it compiles :-)
jerry
(This used to be commit d98ac8852ae6b39b6fcff92c346ba56d9e63c518)
|
|
(This used to be commit d5b39a1d435f7fe79eb556f7e6b55276ac68a73d)
|
|
unicode bit set differently to capabilities
(This used to be commit 34a0821e087810381996f5ff6cf3b4d7b9bb53a0)
|
|
it now uses outbuf not inbuf for the unicode flag, which
allows for some server fns to be ascii and means one less
parameter in push calls
(This used to be commit a6dd6662267eeddf368ff0ffba76b45761bf4eeb)
|
|
Jeremy.
(This used to be commit a24b248a77ccac364832ff7d4df083d437caf9ed)
|
|
Jeremy.
(This used to be commit e7ecb9410ff2e4fcd33bca9f82e14c060590942a)
|
|
- removes SMB_ALIGNMENT. That macro caused all sorts of problems with
getting unicode aligned right in sub-protocols (such as SMBtrans and
SMBtrans2). I believe the performance reasons for having
SMB_ALIGNMENT has gone away with the new variants of the SMB
protocol anyway, as newer commands tend to have their own internal
alignment.
- fix the locations where we set smb_flg2 to absolute values. We must
never do this if we want a hope of coping with unicode.
- add initial support for unicode on the wire in smbd. Currently
enabled using SMBD_USE_UNICODE environment variable.
(This used to be commit b98b1435e9d8f8622444c9ff33082977e661f16b)
|
|
now in pipe struct (where used) rather than user_struct.
Secured machine account password changing in srv_netlog_nt.c - ensure
that only the given machine can change its own password. May need to
free this up later for NT admin tools, but this is a fail-safe secure
position for now.
Jeremy.
(This used to be commit 46b12f2275dcd4b3114085160cd456441f9e921e)
|
|
Jeremy.
(This used to be commit 73c7ace168e4aa6a47b366cf40ed6743a21d3638)
|
|
system header files...
Jeremy.
(This used to be commit 31e0ce310ec38b3a3a05b344d6450d442c6be471)
|
|
Jeremy.
(This used to be commit d23b9be1ba15bedac046319e8f15e60b481d057b)
|
|
RPC code to merge with new passdb code.
Currently rpcclient doesn't compile. I'm working on it...
Jeremy.
(This used to be commit 0be41d5158ea4e645e93e8cd30617c038416e549)
|
|
macros to STR_
(This used to be commit 95c9e4e0ba8f37f565aaf136f41eb76489441ff7)
|
|
(This used to be commit db2e712ad3ccfceb87d36e59d5f2e18a992b3e72)
|
|
We were reading the endainness in the RPC header and then never propagating
it to the internal parse_structs used to parse the data.
Also removed the "align" argument to prs_init as it was *always* set to
4, and if needed can be set differently on a case by case basis.
Now ready for AS/U testing when Herb gets it set up :-).
Jeremy.
(This used to be commit 0cd37c831d79a12a10e479bf4fa89ffe64c1292a)
|
|
(This used to be commit 1d84da779a0fe3219d77686a493d2b2fa1f8072a)
|