| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
All callers expect 0 an success and -1 on error.
metze
|
|
(This used to be commit ddf3022595fe8ca378c5f52107f42e296f852685)
|
|
Michael
(This used to be commit f8f21c8e3922806230e240cb54205fc2db7a3619)
|
|
This is a regression introduced by the change to dbwrap.
The replacement dbwrap_change_int32_atomic() does not
correctly mimic the behaviour of tdb_change_int32_atomic():
The intended behaviour is to use *oldval as an initial
value when the entry does not yet exist in the db and to
return the old value in *oldval.
The effect was that:
1. get_rand_seed() always returns sys_getpid() in *new_seed
instead of the incremented seed from the secrets.tdb.
2. the seed stored in the tdb is always starting at 0 instead
of sys_getpid() + 1 and incremented in subsequent calls.
In principle this is a security issue, but i think the danger is
low, since this is only used as a fallback when there is no useable
/dev/urandom, and this is at most called on startup or via
reinit_after_fork.
Michael
(This used to be commit bfc5d34a196f667276ce1e173821db478d01258b)
|
|
Michael
(This used to be commit 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0)
|
|
The race is a regression introduced by the change to dbwrap.
It might have led to two concurrent processes returning the same id.
This fix is achieved by changing dbwrap_change_uint32_atomic() to
match the original behaviour of tdb_change_uint32_atomic(), which
is the following: *oldval is used as initial value when
the value does not yet exist and that the old value should be
returned in *oldval.
dbwrap_change_uint32_atomic() is used (only) in idmap_tdb2.c,
to get new ids.
Michael
(This used to be commit 72bd83fea7572a6202027b200d192c05023aa633)
|
|
TALLOC_FREE(rec) before transaction_cancel also in dbwrap_trans_delete().
Michael
(This used to be commit 04cd914a1f12691d27ddc67887a757cd813848a7)
|
|
Unlock before we cancel the transaction...
metze
(This used to be commit d70a8e9c413a7d3993e0d11db5ae9cbc7fdb12c7)
|
|
metze
(This used to be commit 9e739b4c99a9aba5c5bb58f3b6a9fb949e24c581)
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 2cf2684a11027431e6a93992413a5a5a697a4ba0)
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)
|
|
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit f1dd915ce802645166e0c8fc79d18d5ad41cfe7a)
|
|
failed.
Michael
(This used to be commit ab0aaed907fef233998ff0841d30eabef3263ee8)
|
|
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit f05e889bc05a816aef5b9ce4f22267e977dade01)
|
|
(This used to be commit e66e502bee65fe44944d325ebeeaa3bf56169eb8)
|
|
(This used to be commit 4ee21a98bc3d1c41a6d8868e98118c58372b2d1a)
|
|
(http://samba.org/~tridge/3_0-ctdb)
Signed-off-by: Alexander Bokovoy <ab@samba.org>(This used to be commit 0c8e23afbbb2d081fc23908bafcad04650bfacea)
|
