Age | Commit message (Collapse) | Author | Files | Lines |
|
There are error paths in S3 where va_end() is not properly called after
va_start() or va_copy() have been called.
These issues were noted while performing an inspection for S4 bug #6129. Thanks
to Erik Hovland <erik@hovland.org> for the original bug report.
|
|
* ldb_dn_new() now takes an initial DN string
* ldb_dn_string_compose() -> ldb_dn_new_fmt()
* dummy ldb_dn_validate(), since LDB DNs in the current implementation
are always valid if they could be created.
|
|
This argument is ignored (Samba3's LDB is synchronous) but having it
there is useful for API compatibility with the LDB used by Samba 4 and
available on some systems.
|
|
failures this week
The bug was introduced when converting samba3's ldb_search interface
to match samba4:
47951fc5d0085e124666b7667715bba98076820e
f3ecb701335b1129947127d4c45eef970b66875c
|
|
|
|
|
|
metze
Signed-off-by: Karolin Seeger <kseeger@samba.org>
|
|
This one fixes together with 2eaf4ed62 bug #5715 and CVE-2008-3789.
Thanks to Steve Langasek <vorlon@debian.org> for reporting!
Karolin
(cherry picked from commit b666d0a4b597218f5f5020bf36d80d84dcbf7259)
(This used to be commit 73f54df7fedc8f0db022f902100fd5eb1b629fb2)
|
|
retieve -> retrieve
Karolin
(This used to be commit 37c64130701ab13b6f34998ac17fec2d128c2e08)
|
|
(This used to be commit 9b174871a87677f7dfbd897a80e526f203906bea)
|
|
(This used to be commit 0c2fd687b25e32d446ef799927db6933bc61223d)
|
|
Coverity ID 464
(cherry picked from commit 496d44d2f21661c85bf07e8eb7cae6298fefd900)
(This used to be commit f30bc6503de6c712101e04fe26c004eeffcd300e)
|
|
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
|
|
(This used to be commit 8bcd2df841bae63e7d58c35d4728b7d853471697)
|
|
(This used to be commit c676a971142d7176fd5dbf21405fca14515a0a76)
|
|
(This used to be commit 1b78cace504f60c0f525765fbf59d9cc6506cd4d)
|
|
more no previous prototype warnings
(This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)
|
|
(This used to be commit fa6fa1268b33334d17869d0f096cf7600e88f993)
|
|
metze
(This used to be commit 4a5da57306ad8cce5522ee72349cb85b447e295c)
|
|
(This used to be commit cf4309b9048a8417104cac660421a3dcd2e96ffe)
|
|
(This used to be commit 3250d20d27d4f85421052e877077526975b16e02)
|
|
metze
(This used to be commit fe61e6ebf7d771ce6441198bf2e330d53bf7b10e)
|
|
metze
(This used to be commit 18171cf54b22f9f2d73753db580934bd10e95e3d)
|
|
metze
(This used to be commit b7965ac26cbfdfe60f929e2fa3a295b8c57d220d)
|
|
metze
(This used to be commit 207643e9c9c75546f38a09f12ea0b574b08086c5)
|
|
(This used to be commit a86a56fed3eb06b4b4a04329d42a9f57bad16271)
|
|
(This used to be commit aa464c9fda978f615230241921f83884a60f4c6f)
|
|
sure whether
to merge it to 4_0. I want it in 3_0 because it took a bit to persuade myself
that el can not be NULL here.
Volker
(This used to be commit c0c035b1c8b9d80cd205cde16ad3e838e2d44459)
|
|
and significant speedups
(This used to be commit bb5c205fef90aa8b89ba400fb9f2f37a111676a8)
|
|
fix checker warnings
metze
(This used to be commit 93a0fe093b4614a18e99d0c3a71c5c8af2e57e4f)
|
|
remove wrong check and statement.
to manipulate rootDSE we use ldb_dn_new() as base and that has 0 elements.
metze
(This used to be commit b81cae4180452d2a14c445392fd828032e6eddec)
|
|
don't crash on invalid utf8 chars
metze
(This used to be commit 71e1f8550f96eaaae7e4fc4d02eb36f1d894abc8)
|
|
add ldb_set_create_perms() function to set the create_perms after
ldb_init() and before ldb_connect()
metze
(This used to be commit dd9d469eef337954b6aee4c86ac0691f52812456)
|
|
It would be nice if someone can merge that to samba4,
otherwise I'll merge that to samba4 on monday
metze
(This used to be commit 6bc42f31ce294f2bd50ffbd536e1ee42607ef799)
|
|
metze
(This used to be commit db40552d9471f4a8ce2c5c724319a4eb242ed24a)
|
|
- passing mem_ctx as ldb_context is a bad idea!
- naming a static function talloc_ is also bad and misleading
metze
(This used to be commit 0523ad249335c6094854bc9cefb46e2095f4c0ba)
|
|
I have some problems resolving the last 3 ones in attrib_handlers.c. In line
251 the function ldb_dn_explode_casefold is called with mem_ctx as the first
argument. Looking at ldb_dn_explode_casefold I see that the first argument it
expects is a struct ldb_context. I could certainly add a cast to (struct
ldb_context *) to that call, but I would assume that this is the wrong fix. Is
it possible that attrib_handlers.c:251 and :254 should have ldb and not
mem_ctx as the first argument?
Can anybody from Samba4 clarify this for me and apply the correct fix?
Thanks a lot.
Volker
(This used to be commit 26f2cb71ebf00b2c6f356da5f32384f7fa083521)
|
|
(This used to be commit 7b6738522a80740824f3b96e73e7c48a0623b1b1)
|
|
(This used to be commit c247cf3fba13ce1a32878efcc922eadfcbc2b092)
|
|
(This used to be commit 0ab5d7692c2c0fe798a067866cb236ea9c304463)
|
|
4_0, I'd
like you to comment.
Volker
(This used to be commit ba18c58f1fb618447ba39bae6ef8f4e6c00c4d32)
|
|
(This used to be commit 6a8937ed03f0ee62eb81da798e0c38b405d44731)
|
|
Samba4 smbd force the umask to 0, which meant we ended up with ldb
being world writable.
This isn't really an ideal fix, as it means ldb no longer honors umask
(as it should do, like all good libraries).
Unfortunately the 'proper' fix is too complex for now
this also merges a tiny code style fix from s4 to s3
(This used to be commit dd8ec8725f168f4286bbfc00d69cd56089ba3543)
|
|
string is zero length. This allows callers to not have to worry about
creating an invalid ldap attribute.
See extensive discussion on samba-technical list :-)
(This used to be commit 9e66df05a4df3d3c7b02048d80e2661103d1d40a)
|
|
vl: you were a few seconds faster than me...:-)
metze
(This used to be commit 63e5727471bdf686f292a36aa43267213fb6e2f3)
|
|
merge this
one. Tridge? Metze?
Volker
(This used to be commit d0eef2f6e870031538959f2308a3414fc68ef18c)
|
|
as well?
Volker
(This used to be commit fd020a1998db7660ab093c136207df4fb09720cb)
|
|
code. Yay!
This first commit copies lib/ldb/ from Samba4. A huge congratulations
should go to Simo on this - he has put an enormous amount of work into
ldb, and it's great to see it go into the Samba3 tree.
(This used to be commit bbedf2e34315f5c420a3a05dfe22b1d5cf79f042)
|