summaryrefslogtreecommitdiff
path: root/source3/lib/serverid.c
AgeCommit message (Collapse)AuthorFilesLines
2010-08-18s3: Fix serverid_register_msg_flagsVolker Lendecke1-4/+2
Thanks, Andreas, for pointing this out! (How drunk have I been?...)
2010-08-18s3-lib: Fixed a possible crash bug.Andreas Schneider1-0/+2
Volker please check!
2010-07-20Fix warning on 64-bit machines.Jeremy Allison1-1/+1
Jeremy.
2010-07-05s3: Put serverid_key and serverid_data togetherVolker Lendecke1-5/+5
2010-07-04s3: Remove an unused variable -- thanks, metze!Volker Lendecke1-2/+1
2010-07-04s3: Replace register_message_flags() with serverid_register_msg_flags()Volker Lendecke1-0/+52
message_send_all is now done by walking the serverid.tdb, not the connections.tdb anymore. Günther, Simo, please check!
2010-07-04s3: Remove serverid_[de]register_selfVolker Lendecke1-21/+5
This removes some deep references to procid_self()
2010-07-04s3: ALWAYS run make test before checkin ....Volker Lendecke1-2/+2
2010-07-04s3: Slight reshaping of server_exists_parseVolker Lendecke1-4/+6
Doing a copy and then do the compare is a bit pointless, use memcmp
2010-03-25s3: Add a comment to serverid_parent_init, this is pretty confusingVolker Lendecke1-0/+6
2010-03-25s3: Make sure our CLEAR_IF_FIRST optimization works for serverid.tdbVolker Lendecke1-0/+16
In the child, we fully re-open serverid.tdb, which leads to one fcntl lock for CLEAR_IF_FIRST detection per smbd. This opens the tdb in the parent and holds it, so that tdb_reopen_all correctly catches the CLEAR_IF_FIRST bit.
2010-03-10s3: Fix a long-standing problem with recycled PIDsVolker Lendecke1-0/+293
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker