Age | Commit message (Collapse) | Author | Files | Lines |
|
thanks to simo for spotting this
(This used to be commit acd84ed762a5f50c69c79d13cb18e4204096b304)
|
|
(This used to be commit 8ca8875cd94dce8827ce8cb857b2d7a959ab7891)
|
|
add talloc_asprintf()
(This used to be commit 7264d611eff871f424d449e1ff1c7ec3f5fdde40)
|
|
(This used to be commit 60e907b7e8e1c008463a88ed2b076344278986ef)
|
|
changed some code to exploit the fact that Realloc(NULL, size) == malloc(size)
fixed some possible mem leaks, or seg faults.
thanks to andreas moroder (mallocs not checked in client/client.c, client/smbumount.c)
(This used to be commit 7f33c01688b825ab2fa9bbb2730bff4f2fa352be)
|
|
realloc(NULL) == malloc. realloc(p,0) == free() - a no-op in talloc.
Jeremy.
(This used to be commit 1ab31e5db53bc839d2785cce4d3c739c8004bbf6)
|
|
(This used to be commit 5f4889beb9311fd3912c3dfccf18fc9ab22b964c)
|
|
no way of telling if the call really failed
(This used to be commit 7a96ca313e2f6b5ad8a713babd3cac0bbcc4c399)
|
|
(This used to be commit eea43a5a916eb7f4bef6817ce0aa8051f9145b18)
|
|
Jeremy.
(This used to be commit be825b07464f54d717333318a08154cff632f706)
|
|
advantages:
- memory is trackable by insure
- a very simple talloc_realloc() is possible (I've added it)
It is slower than the previous talloc code, but I don't think that
is going to be a problem. If it is a problem then there are
some ways we can make it faster but I'd like to leave those
until we have tested this a bit and can see what performance
problems might show up in profiling
(This used to be commit 1ab63cf3a6f62c3e4ca19a549bde78dad0eb4340)
|
|
security descriptors and pointers. Syncup with 2.2 tree.
Jeremy.
(This used to be commit 14d5997dc841e78a619e865288486d50c245896d)
|
|
pool is getting bloated. Also added a talloc_zero function to return zeroed memory.
Added debug in rpc_server/srv_pipe_hnd.c so we know when a talloc pool is being
freed. Syncup with srv_pipe_hnd.c from 2.2 so we are freeing memory at the same time.
Jeremy.
(This used to be commit d3a56c6042acf037bbd53de88d7636a5803ead20)
|
|
in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open
problem.
Jeremy.
(This used to be commit 0a40bc83e14c69a09948ec09bb6fc5026c4f4c14)
|
|
memory access.
Tridge, I don't think using 0xdeadbeef for size allocations
of 0 is going to work. I ended up having to use NULL
as much code that works on UNISTR checks to see if the buffer ptr
is NULL. So valid code ends up with a seg fault.
Rather than rewriting it all, I added a DEBUG_TALLOC
#ifdef in talloc.h that sets a macro BAD_PTR.
This is the value assigned to ptr for an allocation of 0 bytes.
jerry
(This used to be commit 233b9cffa2350552d9f775f791d5d5e0464a1ed4)
|
|
jerry
(This used to be commit df51dc32f6ffc4fe2cebfaae5079417aad1ff34d)
|
|
in the RPC code. This change was prompted by trying to save a long (>256)
character comment in the printer properties page.
The new system associates a TALLOC_CTX with the pipe struct, and frees
the pool on return of a complete PDU.
A global TALLOC_CTX is used for the odd buffer allocated in the BUFFERxx
code, and is freed in the main loop.
This code works with insure, and seems to be free of memory leaks and
crashes (so far) but there are probably the occasional problem with
code that uses UNISTRxx structs on the stack and expects them to contain
storage without doing a init_unistrXX().
This means that rpcclient will probably be horribly broken.
A TALLOC_CTX also needed associating with the struct cli_state also,
to make the prs_xx code there work.
The main interface change is the addition of a TALLOC_CTX to the
prs_init calls - used for dynamic allocation in the prs_XXX calls.
Now this is in place it should make dynamic allocation of all RPC
memory on unmarshall *much* easier to fix.
Jeremy.
(This used to be commit 0ff2ce543ee54f7364e6d839db6d06e7ef1edcf4)
|
|
(This used to be commit 064cdb7ee69bff3af12d1e0b3c3b59207c594681)
|
|
Jeremy.
(This used to be commit 20d72e8959fc800836369e4c970f7cb84b95ac9a)
|
|
lp_string() bug properly.
we still need to add lp_talloc_free() calls in all the main event
loops, I've only put it in smbd and nmbd thus far.
(This used to be commit aa7f81552540f5dca2c146f5edd805611d5b390f)
|