summaryrefslogtreecommitdiff
path: root/source3/lib/util_str.c
AgeCommit message (Collapse)AuthorFilesLines
2007-12-05Remove some globalsVolker Lendecke1-23/+50
(This used to be commit 31d0a846db08d845e6cdfd85def4ac1c34031e02)
2007-12-04Ok, down to just the client/*.c code now.Jeremy Allison1-5/+0
Jeremy. (This used to be commit 7d3959f81a5439800b813ef052382e67424c90cd)
2007-12-04Remove tok pstring from util_str.cJeremy Allison1-2/+8
Do we even make rpctorture anymore ? Jeremy. (This used to be commit fecc3cc45af6145fad9a0570e6cae8422bd2443d)
2007-12-03Make strhex_to_str clear on string limits. Remove pstring from web/*.cJeremy Allison1-5/+9
Jeremy. (This used to be commit f9c8d62389f8cb47837e5360209936176537df13)
2007-11-30Fix restart after length count.Jeremy Allison1-1/+6
Jeremy. (This used to be commit fa8115f32bfd37f75c284ff0f6906dbc2af0f40c)
2007-11-30Add talloc versions of all the next_token() functions.Jeremy Allison1-3/+102
Now I can really start removing fixed length strings... Jeremy. (This used to be commit 0ae61e26547e594e94037d4474a008221e5df8cf)
2007-11-19Remove more pstring. Unify talloc_sub functions to makeJeremy Allison1-89/+41
them a better match for replacing string_sub. Remove more unused code. Jeremy. (This used to be commit ae7885711f504f1442335f09088cbe149a7e00f9)
2007-11-14Remove smbldap_get_single_pstring() and all pstringsJeremy Allison1-4/+22
from pdb_ldap.c. I don't have an LDAP passdb setup here, so I'm going to need some help on testing this. Jeremy. (This used to be commit 00760451b6c2b65f3a8a9187789ca4f270b622a2)
2007-11-12Remove all pstrings from smbd/chgpasswd.c.Jeremy Allison1-20/+44
Jeremy. (This used to be commit eaf14c701b08e9eff5b94bf57af68cb29142d7fc)
2007-11-09Make base64_encode_data_blob return a talloced stringVolker Lendecke1-1/+2
(This used to be commit 5f205ab48d8ac3b7af573ea0be1ce095ab835448)
2007-11-05Remove unnecessary codeVolker Lendecke1-6/+1
SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure (This used to be commit 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7)
2007-10-25Fix bug in writing names into gencacheJeremy Allison1-3/+4
as well as 2 typos where AF_INET6 was mistypes as AF_INET. JERRY YOU NEED THESE FIXES. Fixes smbclient -L localhost -U% Bugs reported by Kukks (thanks kukks). Jeremy. (This used to be commit f109f82622ca30ae2360e8300152e90b9587ffd8)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison1-23/+60
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-17Reformatting fix for new coding guidelines. BOOL ->bool.Jeremy Allison1-264/+320
Jeremy. (This used to be commit 315215e20e1e470c5077122a2e250ecb3d45ce9b)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-1/+0
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25184: Fix some C++ warnings and an uninitialized variableVolker Lendecke1-1/+1
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
2007-10-10r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison1-3/+8
to unix_convert(). Jeremy. (This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
2007-10-10r25121: Remove pstring limits from much of our string handling function.Jeremy Allison1-54/+174
Still a few left (mainly the substitute ones). Jeremy. (This used to be commit 6552e52979a7c6954faa8b2c9c0f08b3779835c4)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23518: Remove the silly assumption that string_replace requires a pstring.Volker Lendecke1-19/+44
Jeremy, I am always very confused about the different length arguments in convert_string and friends. Can you take a look at the change in string_replace and verify it's ok? Thanks! While at it, remove the pstring limit for strhasupper and strhaslower. (This used to be commit e6e5703658aeaeb0cca5d7281095e17553001d4b)
2007-10-10r23356: We missed to add the 'c' character to the list of valid ones forSimo Sorce1-1/+1
shell escaping. I hate this kind of bugs more than how Jeremy hates off by ones :( Simo. (This used to be commit 42d846ff870f93b7eaca316f04c12104330bbca8)
2007-10-10r22852: merge fixes for CVE-2007-2446 and CVE-2007-2447 to all branchesGerald Carter1-0/+163
(This used to be commit f65214be68c1a59d9598bfb9f3b19e71cc3fa07b)
2007-10-10r22045: As Volker noticed, skip_string's last argument isJeremy Allison1-15/+11
redundent. Remove it. Jeremy. (This used to be commit 140881cfbb59ce4a699b5900efe02bf315be7bd5)
2007-10-10r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,Jeremy Allison1-4/+32
but I've no option. Jeremy. (This used to be commit c3a565081d70b209a4f9e6e8f1859bf7194a5f74)
2007-10-10r20208: Change sprintf_append() never to use malloc,Jeremy Allison1-15/+3
but always use a talloc context. Thanks to simo for pointing this out. Jeremy. (This used to be commit 437cb7c88833d7eab0e3c3dcf175860df74a7a38)
2007-10-10r20090: Fix a class of bugs found by James Peach. EnsureJeremy Allison1-1/+3
we never mix malloc and talloc'ed contexts in the add_XX_to_array() and add_XX_to_array_unique() calls. Ensure that these calls always return False on out of memory, True otherwise and always check them. Ensure that the relevent parts of the conn struct and the nt_user_tokens are TALLOC_DESTROYED not SAFE_FREE'd. James - this should fix your crash bug in both branches. Jeremy. (This used to be commit 0ffca7559e07500bd09a64b775e230d448ce5c24)
2007-10-10r19786: My last checkin to winreg_StringBuf killed rpccli_winreg_EnumKeys ↵Volker Lendecke1-0/+18
against W2k3. The server requires that size==0 in the [in] name. Somehow I get the feeling that something is badly wrong here.... I did not yet recreate the gen_ndr equivalent, see next mail. Volker (This used to be commit 016ddce12005bb0829bf050e4d4851852751b3e5)
2007-10-10r18787: Fix the strlen_m and strlen_m_term code by mergingJeremy Allison1-0/+52
in (and using elsewhere) next_codepoint from Samba4. Jerry please test. Jeremy. (This used to be commit ece00b70a4621633f1ac9e576c4bbe332031de09)
2007-10-10r18652: libreplace has replacements for strndup and strnlenStefan Metzmacher1-43/+0
metze (This used to be commit 9f3599a7ca636dd21c150873f395abde153ee6fd)
2007-10-10r17866: Fix possible null deref - found by Stanford checker.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 84e8cc0593c20b1262965a320d89b72a3dc9b402)
2007-10-10r17862: Fix possible NULL deref (like rev 17861) found by theJeremy Allison1-1/+3
Stanford group. Jeremy. (This used to be commit cfd39c2804df3f67637adf223542daa208c893c7)
2007-10-10r17316: More C++ warnings -- 456 leftVolker Lendecke1-7/+8
(This used to be commit 1e4ee728df7eeafc1b4d533240acb032f73b4f5c)
2007-10-10r16945: Sync trunk -> 3.0 for 3.0.24 code. Still needJeremy Allison1-2/+120
to do the upper layer directories but this is what everyone is waiting for.... Jeremy. (This used to be commit 9dafb7f48ca3e7af956b0a7d1720c2546fc4cfb8)
2007-10-10r16595: Klocwork #2067. Fix possible memleak on error exit.Jeremy Allison1-0/+3
Jeremy. (This used to be commit 1d21a3dec9ea061ce900ad1223f7c2a43c064600)
2007-10-10r16554: Sorry, just had to change this. Don't use int whenJeremy Allison1-3/+5
you're passing a BOOL parameter, don't use "clever" code in while statement - make things easier and clearer to understand when triggering something with an if. Jeremy. (This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)
2007-10-10r16552: Fix bug 3849.Derrell Lipman1-7/+35
Added a next_token_no_ltrim() function which does not strip leading separator characters. The new function is used only where really necessary, even though it could reasonably be used in many more places, to avoid superfluous code changes. Derrell (This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)
2007-10-10r16375: Klocwork #1670.Jeremy Allison1-2/+8
Jeremy. (This used to be commit 99605ce296663b7697d737fd521f0e4d8436d1f2)
2007-10-10r15305: Let winbind search by sid directly (or in windows terms: "bind to aGünther Deschner1-1/+17
sid"); works in all AD versions I tested. Also add "net ads sid" search tool. Guenther (This used to be commit 5557ada6943b817d28a5471c613c7291febe2ad5)
2007-10-10r15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ↵Gerald Carter1-9/+3
ensure that global memory is freed when unloading pam_winbind.so (needs more testing on non-linux platforms) (This used to be commit 1e0b79e591d70352a96e0a0487d8f394dc7b36ba)
2007-10-10r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistentJeremy Allison1-1/+2
between Realloc and realloc_array. Jeremy. (This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-15/+19
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13622: Allow to rename machine accounts in a Samba Domain. This still uses theGünther Deschner1-3/+8
"rename user script" to do the rename of the posix machine account (this might be changed later). Fixes #2331. Guenther (This used to be commit b2eac2e6eb6ddd1bcb4ed5172e7cd64144c18d16)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-5/+5
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13393: Do not initialize the lp_svcctl_list() value since it is handledGerald Carter1-0/+3
internally in services_db.c now. This prevents internal services from being listed twice (one internal and one external) when no 'svcctl list' parameter is explcitly set in smb.conf (This used to be commit 6c4ede6cee7e1d25a6357e959972e8d390c27fe3)
2007-10-10r13316: Let the carnage begin....Gerald Carter1-12/+87
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r12522: Try and fix bug #2926 by removing setlocale(LC_ALL, "C")Jeremy Allison1-8/+8
and replace calls to isupper/islower/toupper/tolower with ASCII equivalents (mapping into _w variants). Jeremy. (This used to be commit c2752347eb2deeb2798c580ec7fc751a847717e9)
2007-10-10r12313: Introduce yet another copy of the string_sub function:Volker Lendecke1-1/+73
talloc_string_sub. Someone with time on his hands could convert all the callers of all_string_sub to this. realloc_string_sub is *only* called from within substitute.c, it could be moved there I think. Volker (This used to be commit be6c9012da174d5d5116e5172a53bbe6486d6c38)
2007-10-10r9282: Whitespace.Jeremy Allison1-10/+10
Jeremy. (This used to be commit 183a4705114da7c3662b71405457123ce35b5358)
2007-10-10r9271: Fix problems with german umlauts - strcmp_w was broken (needs to ↵Jeremy Allison1-5/+5
always re-call macro on termination). Fix all other cases where this was also occurring. Jeremy. (This used to be commit 816e2fbb39b544b7f62d5351f3a8e0af63717227)
generated by cgit (git 2.34.1) at 2024-11-02 19:46:27 +0000