Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
should *not* return const.
Jeremy.
|
|
I did this to match with the default util strlist library.
|
|
Jeremy.
|
|
The additional length check bit us exactly at 4, removing it. The
torture test survives valgrind up to 2000 bytes :-)
|
|
|
|
The merged version behaves differently: "Domain Users" is parsed into two
values, as it does not look at quotes. Samba3 users depend on the ability do
say for example
valid users = "domain users"
which would not work anymore with the merged version.
Thanks to Björn Jacke for testing this!
Volker
|
|
This removes calls to push_*_allocate() and pull_*_allocate(), as well
as convert_string_allocate, as they are not in the common API
To allow transition to a common charcnv in future, provide Samba4-like
strupper functions in source3/lib/charcnv.c
(the actual implementation remains distinct, but the API is now shared)
Andrew Bartlett
|
|
|
|
|
|
str_list_make(). From Dan Sledz <dan.sledz@isilon.com>:
In samba 3.2 passing NULL or an empty string returned NULL.
In master, it now returns a list of length 1 with the first string set
to NULL (an empty list).
Jeremy.
|
|
|
|
|
|
|
|
|
|
|
|
<Douglas_E_Wegscheid@whirlpool.com>.
Jeremy.
(This used to be commit 1295bb9787dde69b4be4acee7b66eb782afe9c42)
|
|
This fixes BUG #5635.
Finished print jobs were not removed from the $PRINTER.tdb file if
"printing=cups".
In print_queue_update, talloc_string_sub2 is used to assemble the
"lprm command". In the case of using "printing=cups", the default
"lprm command" is an empty string. talloc_string_sub2 is called with
this empty string and returns NULL which leads to exiting
print_queue_update without doing the actual print queue update.
Signed-off by Michael Adam <obnox@samba.org>
(This used to be commit 03d66554d1bbd9d6c72a3dd5203e5305343c76b8)
|
|
We did not allocate enough memory for the \0 and a = at the end
(This used to be commit ea110de1dc6257b78631b7d83b7bbb728180c1a1)
|
|
Guenther
(This used to be commit 7f8b0b4d151fa4d07758b6fd7b47b0b7c07dda17)
|
|
This patch is the second iteration of an inside-out conversion to cleanup
functions in charcnv.c returning size_t == -1 to indicate failure.
(This used to be commit 6b189dabc562d86dcaa685419d0cb6ea276f100d)
|
|
Thanks to Moskvin for testing
(This used to be commit d3c31aa36c451f0a19496cd33c0b055b466e6b09)
|
|
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0aee265a3e4d8b7552610f4b9a105434d)
|
|
Karolin
(This used to be commit 2bec0a1fb7857e6fb8ec15e5f597b2d4125f105b)
|
|
(This used to be commit feddc1447d585fd108d22a36bccc576fa81197ef)
|
|
(This used to be commit e2c9fc4cf5f0ff725330fa44f53782db65fca37e)
|
|
(This used to be commit d471dd4adb79d480c89436b2ed98f9ec6812aaa0)
|
|
(This used to be commit ab0ee6e9a6a9eee317228f0c2bde254ad9a59b85)
|
|
This now matches 3.0.x on my micro-tests.
Jeremy.
(This used to be commit 329b924cba8225002ca40db26c45b31d141a0925)
|
|
Only client.c and clitar.c used this, I think they should carry the static
themselves. Also move the a bit funny routine toktocliplist to clitar.c, the
only place where it is used.
(This used to be commit 86d9412611fd99c21e15c71d30a3f95e35d8535b)
|
|
No more temptations to use static length strings.
Jeremy.
(This used to be commit ec003f39369910dee852b7cafb883ddaa321c2de)
|
|
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
Jeremy
(This used to be commit 4c32a22ac50ada3275d2ffba3c1aa08bee7d1549)
|
|
Don't build this for now.
Jeremy.
(This used to be commit 46b67fd82c795d1a34a1efca9e409c0f3fa4f3a2)
|
|
(This used to be commit 31d0a846db08d845e6cdfd85def4ac1c34031e02)
|
|
Jeremy.
(This used to be commit 7d3959f81a5439800b813ef052382e67424c90cd)
|
|
Do we even make rpctorture anymore ?
Jeremy.
(This used to be commit fecc3cc45af6145fad9a0570e6cae8422bd2443d)
|
|
Jeremy.
(This used to be commit f9c8d62389f8cb47837e5360209936176537df13)
|
|
Jeremy.
(This used to be commit fa8115f32bfd37f75c284ff0f6906dbc2af0f40c)
|
|
Now I can really start removing fixed length strings...
Jeremy.
(This used to be commit 0ae61e26547e594e94037d4474a008221e5df8cf)
|
|
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.
(This used to be commit ae7885711f504f1442335f09088cbe149a7e00f9)
|
|
from pdb_ldap.c. I don't have an LDAP passdb setup here,
so I'm going to need some help on testing this.
Jeremy.
(This used to be commit 00760451b6c2b65f3a8a9187789ca4f270b622a2)
|
|
Jeremy.
(This used to be commit eaf14c701b08e9eff5b94bf57af68cb29142d7fc)
|
|
(This used to be commit 5f205ab48d8ac3b7af573ea0be1ce095ab835448)
|
|
SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure
(This used to be commit 4cdebda39b9b1790fc5c7df3dc81bfb46b047ad7)
|
|
as well as 2 typos where AF_INET6 was mistypes as AF_INET.
JERRY YOU NEED THESE FIXES.
Fixes smbclient -L localhost -U%
Bugs reported by Kukks (thanks kukks).
Jeremy.
(This used to be commit f109f82622ca30ae2360e8300152e90b9587ffd8)
|
|
to struct sockaddr_storage in most places that matter (ie.
not the nmbd and NetBIOS lookups). This passes make test
on an IPv4 box, but I'll have to do more work/testing on
IPv6 enabled boxes. This should now give us a framework
for testing and finishing the IPv6 migration. It's at
the state where someone with a working IPv6 setup should
(theorecically) be able to type :
smbclient //ipv6-address/share
and have it work.
Jeremy.
(This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
|
|
Jeremy.
(This used to be commit 315215e20e1e470c5077122a2e250ecb3d45ce9b)
|
|
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
|
|
(This used to be commit b64df8a3c504ab7749c21ffb26e4771a9a0a328f)
|