Age | Commit message (Collapse) | Author | Files | Lines |
|
Guenther
|
|
First, this immediately gave me the warning that TDB_ERR_NESTING was not
covered and second, this saved 48 bytes in the .o :-)
|
|
This hides the use of talloc_reference from the caller, making it impossible to
wrongly call talloc_free() on the result.
|
|
|
|
|
|
|
|
So this gets now linked only into its single user: winbindd
(needed by winbindd_cache.c)
Michael
|
|
|
|
Guenther
|
|
<realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.
We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
|
|
|
|
In tdb_wrap_log(), in on occurrence of "debug_level = 0"
instead of "debuglevel = 0" caused me segfaults when
accessing DEBUGLEVEL (which is defined as "*debug_level"...)
Michael
(This used to be commit d9bd894c2ec4faf87e8ff96e27c7e2b8175f9387)
|
|
It has been replaced by tdb_wipe_all().
Michael
(This used to be commit cdde2e4eaca51d51f036ad99d55df7bfd6535b03)
|
|
Users of these are currently being written...
Michael
(This used to be commit 1c51bec5318bad085c09931aa7e8f72f41d103fe)
|
|
Michael
(This used to be commit abf02a5a142c55d9e0053d319c867e4fcc3e6c30)
|
|
Replace all callers of traverse with this tdb_traverse_delete_fn() and
don't export tdb_traverse_delete_fn() anymore.
Michael
(This used to be commit d4be4e30cd8c3bdc303da30e42280f892a45a8c9)
|
|
Michael
(This used to be commit b42cf3fc69414270be9d0f430f2e95a72894f00e)
|
|
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result
(This used to be commit ad37b7b0aee265a3e4d8b7552610f4b9a105434d)
|
|
Just a small commit to get a handle on this git thingy. This patch
fixes some missing calls to va_end() to match various calls to va_start()
and VA_COPY().
Tim.
(This used to be commit ec367f307dff7948722b9ac97beb960efd91991f)
|
|
than expect a pstring space to put data into.
Fix the (few) callers.
Jeremy.
(This used to be commit 7722a7d2c63f84b8105aa775b39f0ceedd4ed513)
|
|
an alarm sig would not terminate and could lead
to runaway smbd processes.
Thanks to Dave Daugherty @ Centrify for pointing
this out to us.
Jeremy.
(This used to be commit ef8da1698371c95495add53df81a978df709c88d)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
Return error instead.
Michael
(This used to be commit 9b25355dd66519afd548fecbf2da7608b024a35b)
|
|
A new wrapper tdb_validate_open() takes a filename an opens and closes
the tdb before and after calling tdb_validate() respectively.
winbindd_validata_cache_nobackup() now dynamically calls one of
the above functions depending on whether the cache tdb has already
been opened or not.
Michael
(This used to be commit dc0b08e6590caa4974fd4d9f34f39f261d1f1dee)
|
|
(This is more safely used with casts from int to uint8, e.g.)
Michael
(This used to be commit cb3583b39212688a627a29bbddb2e98497714d42)
|
|
I had only tested with "net getlocalsid". posix_locking_init() calls this
with a NULL name...
(This used to be commit 3eee1fe28057e2e3da2e9d1506f57f3e35fd37b7)
|
|
This makes it possible to set the default hashsize for any tdb. I would
like to remove the "open files database hash size" in favor of this one.
I'll check that removal in with the next commit, please complain/revert
if it's not ok.
Volker
(This used to be commit e9bd7a63a8d462b1fc3bab99ff843e25bffd156b)
|
|
If restoring a backup fails due to lack of space, remove the
corrupt tdb previously moved away to "name.corrupt", and retry.
If restoring still fails, move the backup in place instead of
copying it.
Michael
(This used to be commit f81f2bf480a955213be8461636ee6f81643f17b8)
|
|
(This used to be commit 909172839a512b60db075fb1a7488345a2e48eb0)
|
|
Michael
(This used to be commit efabd7fe03733d1fcb02d0d270c18ede7836f3a9)
|
|
- call tdb_validate on the given tdb.
- if validation is successful, create a backup
return 0 (success) even if the backup fails.
- if validation fails:
- move tdb to name.corrupt (don't exit if this fails)
- look for a valid backup
- if a valid backup is found, restore it, else return -1 (failure)
if restoring succeeds, return 0 (success), else -1 (failure)
Summing up:
If 0 is returned, there is a valid tdb at the given location:
either the original one ore one restrored from a backup.
If -1 is returned, there is no valid tdb at the given location:
Either there is no file at all, or the original file is still
in place (if moving it away failed).
Michael
(This used to be commit 1c36ccd86d85b02f27ec66d37bdf7f04ad760901)
|
|
(This used to be commit 6bd2c48921dd8dbf2885a8135ba01a1324e020c8)
|
|
functions did not do so but returned an error. (This is the case when
error occurred deeper than at the level of the content checking done by
the per entry validate_fn.)
Michael
(This used to be commit e56be59947a29d0a5692f3f3bc6c089dd8b4b5d9)
|
|
This is a wrapper around tdb_validate, that does backup handling:
* if the given tdb is valid, a backup is created (name.bak)
* if the tdb is invalid, if a valid bakup is found (validated
with the same validation function) under the name "name.bak"
the orignal tdb is moved to name.corrupt and the backup
is restored.
For the backup handling, a variant of the backup_tdb function
from lib/tdb/tools/tdbbackup.c is included in lib/util_tdb.c.
The copy function for the traverse action eliminates the need
to maintain a global success state by using a struct wrapping
the target tdb and a success flag as the private data.
Michael
(This used to be commit ca63a99b6188c0976603dc2852e478cc7a6b2f8b)
|
|
at a lower debug level.
Michael
(This used to be commit b636f8cdad72a9a9bc1d302d8d681dca2da6105a)
|
|
amount as in source code formatting...)
Michael
(This used to be commit 9794b94ebf79686da2e1b3ae343953581e3459a1)
|
|
from the validating child process down to the parent though the
pipe. All the parent evaluates is the overall success, so the exit
status should do.
Michael
(This used to be commit 9415ea0fde2ff0c801d043ce77b778fceedb6592)
|
|
(This used to be commit ef40ef67649c8793921619c128e2923e20aa68da)
|
|
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
|
|
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
|
|
to the caller (winbindd_validate_cache in this case).
Next, there will be a backup handling for the tdb files.
Michael
(This used to be commit 821bc84109625c9d85edee38fa26d16f9f0a0fe2)
|
|
Michael
(This used to be commit b68856d9902f41079224ba11c7d0ab811b082201)
|
|
Michael
(This used to be commit d4accdbb5285216d532f57f545a846734a2fe774)
|
|
back to winbindd_cache.c. The generic mechanism
should open the cache tdb readonly and with default
flags.
Michael
(This used to be commit 062d8c61294a1e9f8588fa8af31954dd286c7bde)
|
|
code into a generic tdb validation code.
In lib/util_tdb.c for a start.
Michael
(This used to be commit 527edfa0cbcb233218ebabc395666d1d7228ee37)
|
|
failed expression in SMB_ASSERT.
(This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)
|
|
this in your tree.
(This used to be commit c0f40eb5846f617d9c421136b0e1ea593c8d8458)
|
|
(This used to be commit 02beae81c8ecef7cfe300a29852d74813c9409bf)
|
|
and fix all compiler warnings in the users
metze
(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)
|
|
metze
(This used to be commit d03094708378bde088bf6e90efe54deb83d3952e)
|