summaryrefslogtreecommitdiff
path: root/source3/lib
AgeCommit message (Collapse)AuthorFilesLines
2008-08-13handle two special casesAndrew Tridgell1-16/+42
1) when all nodes write the same value to the record, or when writing a value that is already there, we can skip the write and save ourselves a network transactions 2) when all remote nodes fail an update, and we then fail a replay, we don't need to trigger a recovery. This solves a corner case where we could get into a recovery loop (This used to be commit 2481bfce4307274806584b0d8e295cc7f638e184)
2008-08-13put a limit on the number of retries. I found a case where a recoveryAndrew Tridgell1-0/+12
could lead to it blocking forever (This used to be commit a633390d3a7cb04a7c4e14cba9c533621793287e)
2008-08-13we need to commit, not cancel, on record destructionAndrew Tridgell1-1/+4
(This used to be commit ba64a757f86fb60994e12e81416083ac0fa11c21)
2008-08-13removed more unused codeAndrew Tridgell1-72/+0
(This used to be commit 30a697c82db53f9d801e220a7c6277f873ebce67)
2008-08-13all persistent databases now do all stores via automatic transactionsAndrew Tridgell1-150/+46
(This used to be commit 76fbe56e827193d939676da23a580aa0f9394dd1)
2008-08-13fixed fetch of empty recordsAndrew Tridgell1-6/+11
(This used to be commit 037516f1362c8d64da1d47a0cdaf83198d3eaeaf)
2008-08-13samba3 can't handle NOREPLY yetAndrew Tridgell1-0/+3
(This used to be commit 21729256a550509c3c038efa5acdd6ac39027dce)
2008-08-13cleanup debugging and fix handling of empty transactionAndrew Tridgell1-13/+11
(This used to be commit 2e85cbe88b3d1674b915f62e02be7d005fddaa39)
2008-08-13first cut at adding full transactions for ctdb to samba3Andrew Tridgell7-1359/+635
(This used to be commit f91a3e0f7b7737c1d0667cd961ea950e2b93e592)
2008-08-13dbwrap ctdb: fix a DEBUG message.Michael Adam1-1/+1
Michael (This used to be commit d776d8df262e1753fb428450140df94e63035af5)
2008-08-13dbwrap ctdb: don't retry when tdb_store failed in db_ctdb_persistent_store().Michael Adam1-0/+1
Only retry when ctdbd_persisten_update() failed. Michael (This used to be commit ff413a4614c8b272a34b2a9e56a329a8e8749a34)
2008-08-13dbwrap ctdb: add a partial mapping from tdb_error to NTSTATUS and use it for ↵Michael Adam1-3/+26
store. Michael (This used to be commit eaf76c751f9bde2843174b400c109304831df83e)
2008-08-13dbwrap ctdb: add db_ctdb_delete_persistent() and use it for persistent DBsMichael Adam1-1/+17
as delete_rec operation from fetch_locked() Michael (This used to be commit f4aab595a0219305fbedf8890e787b690660a55a)
2008-08-13dbwrap ctdb: call db_ctdb_store() in db_ctdb_delete().Michael Adam1-7/+2
to reduce code duplication. Michael (This used to be commit 09a197e756459877cab7b4d09f534c6a41cfdd71)
2008-08-13dbwrap ctdb: add a retry loop to the persistent store operation.Michael Adam1-51/+120
This is because ctdbd can fail in performing the persistent_store due to race conditions, and this does not mean it can't succeed the next time. To not loop infinitely, this makes use of a new parametric option: "dbwrap ctdb:max store retries" (integer) which defaults to 5 and sets the upper limit for the number or repeats of the fetch/store cycle. Michael (This used to be commit 2bcc9e6ecef876030e552a607d92597f60203db2)
2008-08-13dbwrap ctdb: release the lock before calling ctdbd_persistent_store()Michael Adam1-0/+26
in the persistent db_ctdb_store operation. This is to prevent deadlocks in db_ctdb_persistent_store(). There is a tradeoff: Usually, the record is still locked after db->store operation. This lock is usually released via the talloc destructor with the TALLOC_FREE to the record. So we have two choices: - Either re-lock the record after the call to persistent_store or cancel_persistent update and this way not changing any assumptions callers may have about the state, but possibly introducing new race conditions. - Or don't lock the record again but just remove the talloc_destructor. This is less racy but assumes that the lock is always released via TALLOC_FREE of the record. I choose the first variant for now since it seems less racy. We can't guarantee that we succeed in getting the lock anyways. The only real danger here is that a caller performs multiple store operations after a fetch_locked() which is currently not the case. Michael (This used to be commit d004c9a7281d2577c3ba2012c8f790cc198ea700)
2008-08-13dbwrap ctdb: remove erroneously duplicated comment.Michael Adam1-1/+0
Michael (This used to be commit c939c55e5182258092faceefa58a7f328f18619e)
2008-08-13Use transaction start/cancel for persistent writes to avoid leaving the ↵Ronnie Sahlberg2-6/+46
database in an inconsistent state if we crash during the operation Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com> (This used to be commit 09329f1f9114af44fc4e5e4f29a7315912313125)
2008-08-13Correctly return NULL from messaging_ctdbd_connection if messaging_init failedVolker Lendecke1-0/+1
(This used to be commit 549db133df6782bcca7d033e8573e47716877cbd)
2008-08-13Attempt to fix bug 5684Volker Lendecke1-1/+1
With the ctdb checkin dde9f3f006 tdb optimized out write lock checks for write-enabled transaction. Sadly, this also removed the possibility to ever remove dead records left over from tdb_delete calls within a transaction. Tridge, please check this! Did dde9f3f006 have any reason beyond performance optimizations? Thanks, Volker (This used to be commit 3f884c4ae36f3260e63626bdd4989d9258ae6497)
2008-08-12Fix bug 5686 - libsmbclient segfaults with more than one SMBCCTX.Jeremy Allison4-16/+25
Here is a patch to allow many subsystems to be re-initialized. The only functional change I made was to remove the null context tracking, as the memory allocated here is designed to be left for the complete lifetime of the program. Freeing this early (when all smb contexts are destroyed) could crash other users of talloc. Jeremy. (This used to be commit 8c630efd25cf17aff59448ca05c1b44a41964b16)
2008-08-12I found lots of places where we assume error will be set when callingAndrew Tridgell1-2/+10
one of our virtualised functions, such as db_open(), but error is only set when a system call fails, and it is not uncommon for us to fail a function internally without ever making a system call. That led to us passing back success when a function had in fact failed. I found two places where we relied on map_nt_error_from_unix() returning success when errno==0, but lots and lots of places where we relied on the reverse, so I fixed those two places. map_nt_error_from_unix() will now always return an error, returning NT_STATUS_UNSUCCESSFUL if errno is 0 (cherry picked from commit 69d40ca4c1af925d4b0e59ddc69ef8c26e6501d1) (This used to be commit 834684a524a24bb4eb46b4af583d39947dc87d95)
2008-08-12ensure we give an error code to any routines above that are lookingAndrew Tridgell1-0/+3
for one (This used to be commit 469ba9b87103aa0053c371e481acc5acf0f98ac1)
2008-08-11netapi: add NetLocalGroupSetMembers example code.Günther Deschner2-0/+147
Guenther (This used to be commit 4fea49ae83510225c51c580a2bea2c664851bb39)
2008-08-11netapi: add NetLocalGroupDelMembers example code.Günther Deschner2-0/+147
Guenther (This used to be commit b2a413148e470e059c877f4e54955ab61559edee)
2008-08-11netapi: add NetLocalGroupAddMembers example code.Günther Deschner2-0/+147
Guenther (This used to be commit 01c4640b1ca66c3285fd23d447d08db12cf83b42)
2008-08-11netapi: implement NetLocalGroupSetMembers_r().Günther Deschner1-7/+69
Guenther (This used to be commit bb52ba58e47364d7c7ed38862a007e8e3d9dc104)
2008-08-11netapi: implement NetLocalGroupDelMembers_r().Günther Deschner1-5/+36
Guenther (This used to be commit bd31d8f9ec9a24ca68e1d5441c0cafd98132060f)
2008-08-11netapi: implement NetLocalGroupAddMembers_r().Günther Deschner1-2/+260
Guenther (This used to be commit 53dc9a11810b93a1771304fbfbf4ae84f551612b)
2008-08-11netapi: add NetLocalGroup*Member calls to public headers.Günther Deschner1-0/+57
Guenther (This used to be commit d4a51bb01d33ad17db4e623085a89d258e91b57e)
2008-08-11netapi: add skeleton for NetLocalGroup*Member calls.Günther Deschner3-0/+311
Guenther (This used to be commit 563fb06107d2d3279e08c5c801a940f03229131b)
2008-08-11netapi: add NetUserModalsGet and NetUserModalsSet tests.Günther Deschner1-0/+55
Guenther (This used to be commit a9c444a342968b539918c082b78af8640f8c87cd)
2008-08-11netapi: implement NetUserModalsSet_r.Günther Deschner1-2/+466
Guenther (This used to be commit bb345187b7c62e9ad214037120545addd87a666d)
2008-08-11netapi: implement NetUserModalsGet_r.Günther Deschner1-2/+372
Guenther (This used to be commit 7f7e6ca9091101aa7a3dc275c1d0258d97743f4b)
2008-08-11netapi: add example code for NetUserModalsGet and NetUserModalsSet.Günther Deschner3-0/+284
Guenther (This used to be commit 316575b412e19008ecb6729f97e93b6103d8ba56)
2008-08-11netapi: add NetUserModalsGet and NetUserModalsSet to public headers.Günther Deschner1-0/+62
Guenther (This used to be commit b4c912bfbc62768ff4d7ecb39c02dc4a2a9825d2)
2008-08-11netapi: add skeleton for NetUserModalsGet and NetUserModalsSet.Günther Deschner3-0/+140
Guenther (This used to be commit 5648145bec3bd24ecedea24a8834ac6768bfc640)
2008-08-11netapi: add NetApiBufferAllocate.Günther Deschner2-0/+33
Guenther (This used to be commit 99cc8f023b4ad9210b677e11371f404048752031)
2008-08-11netapi: add ConvertStringSidToSid().Günther Deschner2-0/+41
Guenther (This used to be commit 36f1e45e4ec295115f1ba39ec7ad3690a96dac3e)
2008-08-10Make events robust against their event_context being freedVolker Lendecke1-5/+28
(This used to be commit 3d4e7b29c235e329aaea4fa2c2078df0ce3e59eb)
2008-08-10Remove an unused variable, process.c has its static copyVolker Lendecke1-2/+0
(This used to be commit 59136544ec16b6ceb14a75259aedd22856832bf1)
2008-08-09lib/access: make list_match() public.Michael Adam1-1/+1
Michael (This used to be commit 742bedce417c666b5e91d8d0a7dc7682dc62eba2)
2008-08-09lib/access: make client_match() public.Michael Adam1-1/+1
Michael (This used to be commit 1b2dec93b635dfd23af78a370c223ea2dd486aa7)
2008-08-08using NGROUPS_MAX instead of 32 for the max group value in rep_initgroups() ↵Yannick Bergeron1-1/+1
subroutine in lib/replace/replace.c (This used to be commit 13b1a232d2fe05ae3e924ea2503d05ff5084146e)
2008-08-08Add simple async wrappers around send, recv and connectVolker Lendecke1-0/+674
To be used later :-) (This used to be commit 0d161d336ab9eeccd90d19ef1473646c3008864a)
2008-08-06Solve an IBM XL C/C++ compiler error encountered in get_exit_code() ↵Yannick Bergeron1-1/+2
auth_errors array initialization in client/smbspool.c (This used to be commit b45e7fabc64e699e4fa013ef15f98a004dae3f32)
2008-08-06fixed permissions on ctdb databasesAndrew Tridgell1-0/+5
(This used to be commit 123fc3980a83d956bffaa689f3af81bbf81ce1c1)
2008-08-05dbwrap: add comment describing behaviour of dbwrap_change_int32_atomic().Michael Adam1-0/+7
Michael (This used to be commit f8f21c8e3922806230e240cb54205fc2db7a3619)
2008-08-05secrets: fix replacemend random seed generator (security issue).Michael Adam1-2/+6
This is a regression introduced by the change to dbwrap. The replacement dbwrap_change_int32_atomic() does not correctly mimic the behaviour of tdb_change_int32_atomic(): The intended behaviour is to use *oldval as an initial value when the entry does not yet exist in the db and to return the old value in *oldval. The effect was that: 1. get_rand_seed() always returns sys_getpid() in *new_seed instead of the incremented seed from the secrets.tdb. 2. the seed stored in the tdb is always starting at 0 instead of sys_getpid() + 1 and incremented in subsequent calls. In principle this is a security issue, but i think the danger is low, since this is only used as a fallback when there is no useable /dev/urandom, and this is at most called on startup or via reinit_after_fork. Michael (This used to be commit bfc5d34a196f667276ce1e173821db478d01258b)
2008-08-05dbwrap: add comment describing behaviour of dbwrap_change_uint32_atomic().Michael Adam1-0/+7
Michael (This used to be commit 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0)