Age | Commit message (Collapse) | Author | Files | Lines |
|
All callers are replaced by Get_Pwnam_alloc
(This used to be commit 735f59315497113aebadcf9ad387e3dbfffa284a)
|
|
initial-v3-2-unstable-716-g12cce3b
On Tue, Dec 18, 2007 at 06:04:32PM -0600, Jeremy Allison wrote:
> Fix valgrind error in dbwrap_rbt where rec_priv->node was
> being accessed after free. VALOKER PLEASE CHECK THIS VERY
> CAREFULLY !!!! This is a correct fix in that it fixes the
> valgrind error, but it looks inelegant to me. I think if
> I understood this code better I could craft a more subtle
> fix. Still looking at it....
Thanks a lot. Fully correct. What about the attached little
simplification?
Volker
(This used to be commit 5b72828600fb057a7aeb5f1a6fb6c23c23f28cd8)
|
|
cache.h conflicts with an XFS DMAPI include on "opi" :-(
(This used to be commit b8db804e07cc19d406ba3892d6eecbe16132a89a)
|
|
keyval.
Jeremy.
(This used to be commit 39f3efbcc5fbdff1db1b12e5fc7368968f240993)
|
|
being accessed after free. VALOKER PLEASE CHECK THIS VERY
CAREFULLY !!!! This is a correct fix in that it fixes the
valgrind error, but it looks inelegant to me. I think if
I understood this code better I could craft a more subtle
fix. Still looking at it....
Jeremy.
(This used to be commit 12cce3be2a24fd72106d747890caf6c7f29db43d)
|
|
This is a more general API that caches data with a LRU scheme. See
include/cache.h. No comments yet, I'm still working on it. But Jeremy has given
me a hint in one of his checkins that he would like to make use of this now.
The idea is that we get rid of all our silly little caches and merge them all
into one cache that we can then very easily trim, for example even with a
smbcontrol message if someone decides memory is tight. The main user is the
stat cache, this patch also converts the getwd cache. More caches to come.
(This used to be commit 7a911b35713538d82001a3c9f34152e293fe1943)
|
|
Jeremy.
(This used to be commit 92acc0115d8d4111289c2ade1db7bb060ee908db)
|
|
Jeremy.
(This used to be commit 4ae4b2358688bf289305a2db0ed01b653ac073b2)
|
|
system).
Jeremy.
(This used to be commit 545cd2139cfc9484b733693814d4724d37125942)
|
|
If I'm not completely blind, then check_dos_char is *only* used in the case
when we can't mmap() valid.dat. To me this looks as if we initialize the 65536
bits in doschar_table[] with check_dos_char_slowly, use it once to initialize
valid_table[] and *never* use them again. I think there's no point in keeping
these 8k of modified memory around for an unlikely case (no "valid.dat") and
even that only to use it exactly once.
(This used to be commit 0bfea7259e4091c6d914528a0e65fc10d8a56fb8)
|
|
(This used to be commit a8948e0727b100945ab730d4d144ccbe219bbc94)
|
|
It's only called directly before init_valid_table() anyway, so move it there.
(This used to be commit b6d1d2428866712a550a354732e2386b4f87b67b)
|
|
It's only called in t_doschar, a pretty bogus test program that is not compiled
by default
(This used to be commit 99c59e809ef3c5abcdfb796d50be7c40f7033787)
|
|
(This used to be commit a9c62c57db9e580640d0265b08b3178496de76a8)
|
|
Jeremy.
(This used to be commit e799eb8da6f5e7a2173ba6b8fb040430fd1c6f34)
|
|
least surprise for callers
(This used to be commit eb523ba77697346a365589101aac379febecd546)
|
|
Remove some code duplication, but introduce one more dependency on librpc/ndr.
Easily turned around so that librpc/ndr depends on lib/util_sid if necessary
(This used to be commit 3a0b1b2060facd5f1ac1461b23dd86c75cdd9458)
|
|
We now have four ways to do sid_to_string:
sid_to_string: Convert it into an existing fstring, when you have one
sid_string_talloc: The obvious thing
sid_string_tos: For the lazy, use only with care
sid_string_dbg: The one to use in DEBUG statements
(This used to be commit 7b8276aaa48852270c6b70b081c3f28e316a7a2c)
|
|
This adds 28 fstrings on the stack, but I think an fstring on the stack is
still far better than a static one.
(This used to be commit c7c885078be8fd3024c186044ac28275d7609679)
|
|
(This used to be commit bb35e794ec129805e874ceba882bcc1e84791a09)
|
|
This makes use of the just added debug_ctx and will kill many
sid_string_static() calls
(This used to be commit 3e4148c280efe154c3f8d552731c8b29d6977507)
|
|
Sorry, Jeremy, I think for debug messages this is just the right way to do it.
(This used to be commit 6312016e2727c2b5b1a4964a98cfb9585d77cc8c)
|
|
(This used to be commit 9e3ef0923d71cc06b8445be2625ebd8dfed1b42d)
|
|
metze
(This used to be commit af3392cc20942158ac9e0a533799c5904ff23347)
|
|
this was introduced by the pstring removal
(1ea3ac80146b83c2522b69e7747c823366a2b47d)
metze
(This used to be commit a412e6c7c676a054acd9db371221a50078cfe1d9)
|
|
Guenther
(This used to be commit bd5308e5f63e4f692761557d0ecdee7226b66a15)
|
|
Republic <Jiri.Sasek@Sun.COM>
- slightly modified - Jiri please check ! to allow Solaris to get passwords > 8 chars.
Jeremy.
(This used to be commit 657bf8c3479d6192f269e3daef1517e77a9fa9cb)
|
|
them with malloc'ing accessor functions. Should save a
lot of static space :-).
Jeremy.
(This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)
|
|
This is meant as a replacement for the internal tdb. To me it seems a bit silly
that for in-memory structures we do our own memory management. With this rbt
based approach we can make use of the system-supplied malloc.
(This used to be commit 54e5d4404619443caed32e2acff8921cdbff9ed1)
|
|
(This used to be commit c871fd802f3c0c5ef1f63b2d01a636c885f22b23)
|
|
These are copies taken from 94545baded0bfbabdc30a3a4cb48b3db479dd6ef from Linus' kernel tree
(This used to be commit 8a3289f913fc0432211b0e9937da1d71d4e18893)
|
|
(This used to be commit efa8764c21edfbd09f535900ba37359d72903bf8)
|
|
(This used to be commit 1e214b536b0628db299d701839e62a4ac52727c9)
|
|
Revert 5c347cb46d85d04bbba7c99dca7ff9628f977d84
"Choose a better default for sockaddr length.".
Jeremy.
(This used to be commit 677ac6adc38b0747f825ee597e0502277a8f74b1)
|
|
(This used to be commit 5c347cb46d85d04bbba7c99dca7ff9628f977d84)
|
|
Some systems (eg Mac OSX 10.5) require the length passed to match
the socket address family. This introduces sys_connect() that does
the right thing, and replaces all uses oc connect(2) with sys_connect().
Note that there are some LGPL callers that still call connect(2)
directly.
(This used to be commit e1bfdc17c49da582cdf907e260301ab1946b2ed3)
|
|
No more temptations to use static length strings.
Jeremy.
(This used to be commit ec003f39369910dee852b7cafb883ddaa321c2de)
|
|
Jeremy.
(This used to be commit 78dc75600099b5b3b5a8ecffec747a227ff51d70)
|
|
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
Jeremy
(This used to be commit 4c32a22ac50ada3275d2ffba3c1aa08bee7d1549)
|
|
Don't build this for now.
Jeremy.
(This used to be commit 46b67fd82c795d1a34a1efca9e409c0f3fa4f3a2)
|
|
Jeremy.
(This used to be commit 187d8a94eae87a32432c7c295698517b6ae31523)
|
|
Jeremy.
(This used to be commit b91b61b54f02f11d80fc25b268faa354fcd1f6e0)
|
|
into lib/util.c
Jeremy.
(This used to be commit 6ac5d81655927ba8eabea35adaae5adfcbb821c9)
|
|
accessor functions.
Jeremy.
(This used to be commit 420195dd3e8b1b6771ab8be8bc974edaafc0cf8f)
|
|
Mostly compiles....
Jeremy.
(This used to be commit c87f3eba9aa52f4ab25d77e2167262bf5c43b1a6)
|
|
(This used to be commit 487ab6e75e8b8d15f2a37e4ba4129eb2475d4c86)
|
|
(This used to be commit 31d0a846db08d845e6cdfd85def4ac1c34031e02)
|
|
(This used to be commit 111502d3a2901abcff25792bed3c4038a7592410)
|
|
(This used to be commit 8acd4a202f6b4518c2ce9cdd30f5dfb14b86c07c)
|
|
Jeremy.
(This used to be commit 7d3959f81a5439800b813ef052382e67424c90cd)
|