Age | Commit message (Collapse) | Author | Files | Lines |
|
one of our virtualised functions, such as db_open(), but error is only
set when a system call fails, and it is not uncommon for us to fail a
function internally without ever making a system call. That led to us
passing back success when a function had in fact failed.
I found two places where we relied on map_nt_error_from_unix()
returning success when errno==0, but lots and lots of places where we
relied on the reverse, so I fixed those two places.
map_nt_error_from_unix() will now always return an error, returning
NT_STATUS_UNSUCCESSFUL if errno is 0
(cherry picked from commit 69d40ca4c1af925d4b0e59ddc69ef8c26e6501d1)
(This used to be commit 834684a524a24bb4eb46b4af583d39947dc87d95)
|
|
for one
(This used to be commit 469ba9b87103aa0053c371e481acc5acf0f98ac1)
|
|
Guenther
(This used to be commit 4fea49ae83510225c51c580a2bea2c664851bb39)
|
|
Guenther
(This used to be commit b2a413148e470e059c877f4e54955ab61559edee)
|
|
Guenther
(This used to be commit 01c4640b1ca66c3285fd23d447d08db12cf83b42)
|
|
Guenther
(This used to be commit bb52ba58e47364d7c7ed38862a007e8e3d9dc104)
|
|
Guenther
(This used to be commit bd31d8f9ec9a24ca68e1d5441c0cafd98132060f)
|
|
Guenther
(This used to be commit 53dc9a11810b93a1771304fbfbf4ae84f551612b)
|
|
Guenther
(This used to be commit d4a51bb01d33ad17db4e623085a89d258e91b57e)
|
|
Guenther
(This used to be commit 563fb06107d2d3279e08c5c801a940f03229131b)
|
|
Guenther
(This used to be commit a9c444a342968b539918c082b78af8640f8c87cd)
|
|
Guenther
(This used to be commit bb345187b7c62e9ad214037120545addd87a666d)
|
|
Guenther
(This used to be commit 7f7e6ca9091101aa7a3dc275c1d0258d97743f4b)
|
|
Guenther
(This used to be commit 316575b412e19008ecb6729f97e93b6103d8ba56)
|
|
Guenther
(This used to be commit b4c912bfbc62768ff4d7ecb39c02dc4a2a9825d2)
|
|
Guenther
(This used to be commit 5648145bec3bd24ecedea24a8834ac6768bfc640)
|
|
Guenther
(This used to be commit 99cc8f023b4ad9210b677e11371f404048752031)
|
|
Guenther
(This used to be commit 36f1e45e4ec295115f1ba39ec7ad3690a96dac3e)
|
|
(This used to be commit 3d4e7b29c235e329aaea4fa2c2078df0ce3e59eb)
|
|
(This used to be commit 59136544ec16b6ceb14a75259aedd22856832bf1)
|
|
Michael
(This used to be commit 742bedce417c666b5e91d8d0a7dc7682dc62eba2)
|
|
Michael
(This used to be commit 1b2dec93b635dfd23af78a370c223ea2dd486aa7)
|
|
subroutine in lib/replace/replace.c
(This used to be commit 13b1a232d2fe05ae3e924ea2503d05ff5084146e)
|
|
To be used later :-)
(This used to be commit 0d161d336ab9eeccd90d19ef1473646c3008864a)
|
|
auth_errors array initialization in client/smbspool.c
(This used to be commit b45e7fabc64e699e4fa013ef15f98a004dae3f32)
|
|
(This used to be commit 123fc3980a83d956bffaa689f3af81bbf81ce1c1)
|
|
Michael
(This used to be commit f8f21c8e3922806230e240cb54205fc2db7a3619)
|
|
This is a regression introduced by the change to dbwrap.
The replacement dbwrap_change_int32_atomic() does not
correctly mimic the behaviour of tdb_change_int32_atomic():
The intended behaviour is to use *oldval as an initial
value when the entry does not yet exist in the db and to
return the old value in *oldval.
The effect was that:
1. get_rand_seed() always returns sys_getpid() in *new_seed
instead of the incremented seed from the secrets.tdb.
2. the seed stored in the tdb is always starting at 0 instead
of sys_getpid() + 1 and incremented in subsequent calls.
In principle this is a security issue, but i think the danger is
low, since this is only used as a fallback when there is no useable
/dev/urandom, and this is at most called on startup or via
reinit_after_fork.
Michael
(This used to be commit bfc5d34a196f667276ce1e173821db478d01258b)
|
|
Michael
(This used to be commit 7edfb54c865ddcfd5cdcc8c2184b96aaac2d2ec0)
|
|
The race is a regression introduced by the change to dbwrap.
It might have led to two concurrent processes returning the same id.
This fix is achieved by changing dbwrap_change_uint32_atomic() to
match the original behaviour of tdb_change_uint32_atomic(), which
is the following: *oldval is used as initial value when
the value does not yet exist and that the old value should be
returned in *oldval.
dbwrap_change_uint32_atomic() is used (only) in idmap_tdb2.c,
to get new ids.
Michael
(This used to be commit 72bd83fea7572a6202027b200d192c05023aa633)
|
|
Guenther
(This used to be commit 7e9fa2c5396d3663e83ffbf90475473fdb509871)
|
|
Jeremy.
(This used to be commit 1db7e00a5400863fd5dbb81c1a4c6ea6092d0495)
|
|
Guenther
(This used to be commit 0298f7fe9e273a94d14b5b6ce3dbd5e6deee9ecb)
|
|
Guenther
(This used to be commit d31f822b79ed5344ec3c6795d66ceefd024b7d30)
|
|
GUenther
(This used to be commit 0b4e2687ae8fb48faacceb4078d61f9fd2acea9d)
|
|
Guenther
(This used to be commit 52218506d6ad51c4f340206d035f79272ba15e3b)
|
|
Guenther
(This used to be commit 80957bc1bc1462a2478b3eea64f5cb7a84d08677)
|
|
Guenther
(This used to be commit 97106199f1a2add886a14523aa7b402667d2cd89)
|
|
Guenther
(This used to be commit ff9bcd57738aa04c5e18e0e21dd0e788127317c4)
|
|
Guenther
(This used to be commit c3e4c7cb5f2728a8219789aeb2344bff368713d5)
|
|
Guenther
(This used to be commit 8b3149b4a663f59b504c1458cd7ecafe0c0e0322)
|
|
Guenther
(This used to be commit d4594a7a03381fb251c9f8caf4c70e1ed97674b6)
|
|
A bit hard to believe, but substitute.c does not use current_user anymore.
(This used to be commit de5d27d70abcad996af91b4e93879fc415f2b38d)
|
|
(This used to be commit 1dab45b16a23b1126fbf29890747a2b256f08968)
|
|
This fixes BUG #5635.
Finished print jobs were not removed from the $PRINTER.tdb file if
"printing=cups".
In print_queue_update, talloc_string_sub2 is used to assemble the
"lprm command". In the case of using "printing=cups", the default
"lprm command" is an empty string. talloc_string_sub2 is called with
this empty string and returns NULL which leads to exiting
print_queue_update without doing the actual print queue update.
Signed-off by Michael Adam <obnox@samba.org>
(This used to be commit 03d66554d1bbd9d6c72a3dd5203e5305343c76b8)
|
|
Add a configure test for the availability of f_frsize in struct statvfs
(for broken platforms that define statvfs but still have
f_bsize/f_iosize). Also add sys/types.h to the other struct statvfs test
(again, some platforms need it).
(This used to be commit 591bf1d15ff3b93db908cc3a4b6e10d09e5b74b6)
|
|
Fix two shadowed declaration warnings on FreeBSD-based platform:
'reboot' is a 4.0BSD syscall in unistd.h and 'tcp_seq' is a typedef in
netinet/tcp.h.
(This used to be commit 14d2a4da1da38d6f69c63505d35990322f253e5d)
|
|
This fixes various build warnings on our platform. I'm sure I haven't
caught them all, but it's a start.
(This used to be commit 6b73f259cb67d9dda9127907d706f9244a871fa3)
|
|
(This used to be commit 726e56c72fdb685ab5eddefd2fd8b043dc38d6ad)
|
|
Pass in ndr_syntax_id instead of pipe_idx, return NTSTATUS
(This used to be commit 9abc9dc4dc13bd3e42f98eff64eacf24b51f5779)
|