summaryrefslogtreecommitdiff
path: root/source3/lib
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r14764: Fix possible null pointer deref. Coverity #253.Jeremy Allison1-2/+4
Jeremy. (This used to be commit 7a18f38947385b8a5fb27a42610320003689e9e1)
2007-10-10r14751: Use the noreturn attribute to try and tell coverity thatJeremy Allison1-9/+12
smb_panic can't return. Jeremy. (This used to be commit ba9c98983efbf4871e1ec07df37590d97ec52fba)
2007-10-10r14746: Add the Samba4 replacements for opendir/readdir etc. toJeremy Allison2-1/+219
Samba3 - with some 64-bit macro madness. Attempt to fix the broken directory handling in the *BSD-of-the-month club. Jeremy. (This used to be commit fd98427f64f4206c01f16f82fadf24f5863878db)
2007-10-10r14703: Clarify the return codes for the POSIX locking case. ThisJeremy Allison1-1/+1
was confusing. Jeremy. (This used to be commit bc1a605a39e58a7dbdcd4d132345e957e3ed9d5e)
2007-10-10r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-basedJames Peach3-2/+35
HSM is interested in. Tested on both IRIX and SLES9. (This used to be commit 514a767c57f8194547e5b708ad2573ab9a0719c6)
2007-10-10r14618: add --no-process-group to all server programmsStefan Metzmacher1-3/+3
to make the following possible: timelimit 20000 bin/nmbd -F -S --no-process-group timelimit 20000 bin/smbd -F -S --no-process-group this is needed to 'make test' working without losing child processes metze (This used to be commit c3a9f30e2a12cc852c9fa3a7d161f5c6ee0694ce)
2007-10-10r14600: Refactor capability interface from being IRIX-specific to using onlyJames Peach2-56/+70
the POSIX interface. Note that this removes support for inherited capabilities. This wasn't used, and probably should not be. (This used to be commit 763f4c01488a96aec000c18bca313da37ed1df1b)
2007-10-10r14522: sync socket_wrapper code with samba4Stefan Metzmacher1-64/+309
metze (This used to be commit 7cf4ad8899d2109ff30d3168fd5028f8548ec34f)
2007-10-10r14462: Fix warning. ber_tag_t is an unsigned int forJeremy Allison1-1/+1
printing purposes. Jeremy. (This used to be commit 3c33eda430426e40e179799e7341db10c4b2e98e)
2007-10-10r14454: Janitor for tridge - same code exists in Samba3 and 4.Jeremy Allison1-1/+1
Jeremy. ----------------------------- fixed an hmac-md5 error for keys longer than 64 (using deallocated stack variable) (This used to be commit f3879dd6bbbb20524e138b9ba8a54f6464fee5eb)
2007-10-10r14432: Give in and grant BUILT\Administrators all privilegesGerald Carter2-2/+25
(This used to be commit b6170910604dba6533b727de8d7f0cc75256d14f)
2007-10-10r14397: Fix deadcode in coverity error #1.Jeremy Allison1-7/+8
Jeremy. (This used to be commit 4a4953c4d27cd1e925c9afe24fa49b015ce033ec)
2007-10-10r14393: Fix a couple of AIX warnings.Jeremy Allison1-1/+0
Jeremy. (This used to be commit 8444c997bd3e18b1d04ebe85f06c8c6e34d7373f)
2007-10-10r14387: Try and fix the coverity issues (#53, #54) with negativeJeremy Allison1-2/+2
sink by ensuring all uses of rpcstr_push are consistent with a size_t dest size arg. Jeremy. (This used to be commit f65d7afe1977d9d85046732842f9643716c15088)
2007-10-10r14345: Fix Coverity #71. We don't currently propagate *any*Jeremy Allison1-10/+15
alloc error back up the stack from smbldap_set_mod() so ensure we abort correctly. Jeremy. (This used to be commit 9a1e35079af9404e1775e2a098990277b3771086)
2007-10-10r14342: Fix coverity #68, resource leak on error path.Jeremy Allison1-22/+54
Jeremy. (This used to be commit 7520a8d2a10c72d330099c6502848afca60f56ff)
2007-10-10r14292: Janitor for tridge (samba3 talloc is almost identicalJeremy Allison1-3/+19
to Samba4 talloc). Jeremy - make the snprintf call in talloc portable to older solaris boxes - fixed an error found sing the beam analyser (This used to be commit 1e1bae7afd9cd0051878ff1810c8ddfc28129233)
2007-10-10r14280: Fix Coverity #129 and 130: check before dereferencing a pointer. ThisJim McDonough1-4/+4
was especially silly as we checked immediately _after_ dereferencing it :-/ (This used to be commit 7ebfe2cb26b72d7fac397cfe3ceb14f244388224)
2007-10-10r14249: We've dereferenced the_acl before, no point in checking.Volker Lendecke1-1/+1
Fix Coverity bug # 128. Volker (This used to be commit 84e9e73f3c71a0ccef76d56bc72dcd21160ed286)
2007-10-10r14131: Fix Coverity bug # 127Volker Lendecke1-1/+3
(This used to be commit c105bfae2647752b31d8c3b59a0ee80c56f97138)
2007-10-10r14075: * add support for long variable names in smb.conf in the form of %(....)Gerald Carter1-210/+155
* add support for %(DomainSID) * replace standard_sub_XXX() functions with wrappers around their alloc_sub_XXX() counterparts * add support for using SIDs in read list, et. al. (anything that is checked by nt_token_contains_name_in_list()) (This used to be commit 71d960250d2c6d01096a03e98884d3f9c395baa0)
2007-10-10r14060: Only set the last rebind timestamp when we did rebind after a non-readGünther Deschner1-2/+21
LDAP operation. That way we avoid the replication sleep after a simple redirected search operation Guenther (This used to be commit d236caac211ff45a3e2da73a3b0316194740a722)
2007-10-10r14020: Coverity bug CID #66. Missing free on error exit.Jeremy Allison1-1/+4
Jeremy. (This used to be commit b9980bddf5ee74b2887196d6d1a0cf393720ba3a)
2007-10-10r14002: Quick fix for Coverity CID #12.Jeremy Allison1-0/+4
Jeremy (This used to be commit 7c6e274cd578521192a0b0c4e6a4fb5dc7d722ac)
2007-10-10r13999: Quick fix for Coverity bug #11.Jeremy Allison1-1/+7
Jeremy. (This used to be commit b9de6c926953b3321fa3850d501c807c6eabf230)
2007-10-10r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistentJeremy Allison2-4/+5
between Realloc and realloc_array. Jeremy. (This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
2007-10-10r13971: Fix Coverity bugs #209 - #213 - it detected mistakesJeremy Allison1-56/+67
in the pointer aliasing once realloc could change a pointer. This was in the bugzilla.samba.org database as #687 but we never figured out what it was ! Jeremy. (This used to be commit 8d183441403524fe39e79af843d6cfe65898f7d3)
2007-10-10r13948: Fix the build. Remove rpcclient.h include.Jim McDonough1-1/+0
(This used to be commit 6bf879bee3c59ba54b1b4c465c777e3dd0043f83)
2007-10-10r13945: Move display_sec.c to lib/ (as suggested by Volker).Günther Deschner1-0/+187
Guenther (This used to be commit 7e80d5358eb181c3515acb732a3594e80391261b)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison9-94/+125
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13693: More Solaris/LDAP fixes from Bjoern <bjoern@j3e.de>Volker Lendecke1-3/+3
(This used to be commit 7c098ca0ae4c7e11c7100fb09b42ce716beffb56)
2007-10-10r13682: Actually give a developer a prayer of finding out whereJeremy Allison1-16/+17
random error messages are coming from. Yes I'm pissed as I'm working on a live issue right now... Jeremy. (This used to be commit 07d1037e17d782ce10dc6f4d15dcd686730c0b92)
2007-10-10r13622: Allow to rename machine accounts in a Samba Domain. This still uses theGünther Deschner1-3/+8
"rename user script" to do the rename of the posix machine account (this might be changed later). Fixes #2331. Guenther (This used to be commit b2eac2e6eb6ddd1bcb4ed5172e7cd64144c18d16)
2007-10-10r13601: * Remove unused code from pdb_ldap.cGerald Carter1-5/+4
* Add a 'struct passwd *' to the struct samu for later reference (I know this may be controversial but its easily reverted which is is why I'm checking this is as a seaparate patch before I get too deep). * Remove unix_homedir from struct samu {} and update the pdb wrapper functions associated with it. (This used to be commit 92c251fdf0f1f566cfeca3c75ba2284b644aef5d)
2007-10-10r13591: I really have no idea how this code ever worked. And I haveGerald Carter1-19/+22
no idea why no one (including myself) caught this with a compiler warning....Make sure new_chunk() actually returns a pointer to the allocated memory. SAMBA_3_0 now works again on Solaris. (This used to be commit cf9140ad266a8a710651570d0af8dc6188fafed0)
2007-10-10r13574: fix build; talloctort.c should not use the TALLOC_FREE() macroGerald Carter1-40/+40
(This used to be commit af57e4a4cc5efc9c7aba35790cf10377c76b5e4a)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter8-55/+55
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13566: Fix EA support for AIX.Günther Deschner1-0/+24
Patch from Bjoern Jacke <bjacke-at-sernet-dot-de>. Guenther (This used to be commit 69fb189a6b9947069afebb15d6ee6f2f20d15171)
2007-10-10r13539: Add 128 bit creds processing client and server. Thanks to Andrew ↵Jeremy Allison1-12/+13
Bartlett's Samba4 code. Jeremy. (This used to be commit a2fb436fc5dd536cfe860be93f55f9cb58139a0e)
2007-10-10r13521: Implement LOOKUPNAME3 and 4.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 6ec0e9124a1a7b19c9853b8e26075cbbb8751f10)
2007-10-10r13494: Merge the stuff I've done in head the last days.Volker Lendecke3-914/+10
Volker (This used to be commit bb40e544de68f01a6e774753f508e69373b39899)
2007-10-10r13460: by popular demand....Gerald Carter1-3/+24
* remove pdb_context data structure * set default group for DOMAIN_RID_GUEST user as RID 513 (just like Windows) * Allow RID 513 to resolve to always resolve to a name * Remove auto mapping of guest account primary group given the previous 2 changes (This used to be commit 7a2da5f0cc05c1920c664c9a690a23bdf854e285)
2007-10-10r13427: Fix ctime -> st_ctime.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 95793d7e64d30190ebf917745c719f9c5a1b31e2)
2007-10-10r13423: Write wrapper functions (and configure tests) so we canJeremy Allison1-0/+102
always assume we can get a struct timespec out of a stat struct. This will allow us to portably move to nsec timestamps on files and directories in the file server code in future. Jeremy. (This used to be commit 07132d8796a08aa71d6719cb07b5b2c999930632)
2007-10-10r13409: No functional changes, just some DEBUG cleanup.Günther Deschner1-2/+2
Guenther (This used to be commit 286f6fc2339cf4ef232c16466b8dffdcddbe343f)
2007-10-10r13393: Do not initialize the lp_svcctl_list() value since it is handledGerald Carter1-0/+3
internally in services_db.c now. This prevents internal services from being listed twice (one internal and one external) when no 'svcctl list' parameter is explcitly set in smb.conf (This used to be commit 6c4ede6cee7e1d25a6357e959972e8d390c27fe3)
2007-10-10r13374: new revision of the snprintf replace codeSimo Sorce1-176/+580
still missing a configure test to make us substitute our snprintf to system one when the system one does not have positional parameters support (This used to be commit e9bcc24b13c0e264d1d4aaf31a56e38cb3fec830)
2007-10-10r13350: Implement rpccli_samr_set_domain_info. Weird that it was not around :-)Volker Lendecke1-7/+21
Implement 'net rpc shell account' -- An editor for account policies nt_time_to_unix_abs changed its argument which to me seems wrong, and I could not find a caller that depends on this. So I changed it. Applied some more const in time.c. Volker (This used to be commit fc73690a7000d5a3f0f5ad34461c1f3a87edeac5)
2007-10-10r13316: Let the carnage begin....Gerald Carter19-328/+920
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r13310: first round of server affinity patches for winbindd & net ads joinGerald Carter1-11/+9
(This used to be commit 6c3480f9aecc061660ad5c06347b8f1d3e11a330)