Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix escaping of DN components and filters around the code
Add some notes to commandline help messages about how to pass DNs
revert jra's "concistency" commit to nsswitch/winbindd_ads.c, as it was
incorrect.
The 2 functions use DNs in different ways.
- lookup_usergroups_member() uses the DN in a search filter,
and must use the filter escaping function to escape it
Escaping filters that include escaped DNs ("\," becomes "\5c,") is the
correct way to do it (tested against W2k3).
- lookup_usergroups_memberof() instead uses the DN ultimately as a base dn.
Both functions do NOT need any DN escaping function as DNs can't be reliably
escaped when in a string form, intead each single RDN value must be escaped
separately.
DNs coming from other ldap calls (like ads_get_dn()), do not need escaping as
they come already escaped on the wire and passed as is by the ldap libraries
DN filtering has been tested.
For example now it is possible to do something like:
'net ads add user joe#5' as now the '#' character is correctly escaped when
building the DN, previously such a call failed with Invalid DN Syntax.
Simo.
(This used to be commit 5b4838f62ab1a92bfe02626ef40d7f94c2598322)
|
|
Guenther
(This used to be commit 28ce79629bc36929f508c1ccb1d27d48e8898045)
|
|
is the case where we don't have memalign() or posix_memalign().
(This used to be commit 1635bac80011d15e3ed30b6d43b6e22b2ce2a000)
|
|
others don't get stuck with the winbindd hang.
Still waiting on additional confirmation from Guenther
that this fixes thes issues he was observing as well.
But it's been running in my local tree for a day without
problems.
(This used to be commit 0d2b80c6c4a744b05a0efdec352cddccc430e0c4)
|
|
(This used to be commit 78d6c88f10d600e05c4346affbba1d95c614dc34)
|
|
fix memory hierachy, and access to already freed memory
metze
(This used to be commit 05a23dd75655a80667627e00e0a441b54ec92b22)
|
|
(This used to be commit 1b3239f2abea9146c7d0d4af06c47a63e0caf006)
|
|
connection is
dead. Might be my code, this rings a very distant bell...
Attempt to fix bug # 4372.
Volker
(This used to be commit 730cc3dc1e332449f3e902217ccb9cc3057b9ef3)
|
|
(This used to be commit e2681eb4be1a9bd001eed0f39e5b5d370cf71ed6)
|
|
Windows Vista RC1 and RC2 can't delete directory on Samba share
based on work by Joe Meadows <jmeadows@webopolis.com>.
Jeremy.
(This used to be commit 2dab8928769938ab79da7b7ce2d165fc388f9b00)
|
|
based on the flags2 values in the negprot request.
This also includes some code for testing the dialect
strings for "SMB 2.001" but this is unreliable as Vista
only sends that in the 1st negprot and caches the fact
that we don't support it. Restartnig the WOrkstation
service on the client clears the cache.
(This used to be commit d781eeb0e4362b7af1497634d26315498a5257d4)
|
|
(This used to be commit 04f6f01dfeda2fa076209a94cdf8e59f6ce47008)
|
|
crashed. So
it needs the specific error message.
Make messages.c return NTSTATUS and specificially NT_STATUS_INVALID_HANDLE if
sending to a non-existent process.
Volker
(This used to be commit 3f620d181da0c356c8ffbdb5b380ccab3645a972)
|
|
Volker
(This used to be commit c24854433a28cc066072a7107e29aa7fe2bec3c8)
|
|
(This used to be commit 4a99fa266672e2989f9e62baf9090eb45df750ea)
|
|
messaging wrapper
and tdb_wrap_open.
Volker
(This used to be commit c01f164dcaf88fb7f3bed8f69b210ba8fab326d1)
|
|
void message_register(int msg_type,
void (*fn)(int msg_type, struct process_id pid,
- void *buf, size_t len))
+ void *buf, size_t len,
+ void *private_data),
+ void *private_data)
{
struct dispatch_fns *dfn;
So this adds a (so far unused) private pointer that is passed from
message_register to the message handler. A prerequisite to implement a tiny
samba4-API compatible wrapper around our messaging system. That itself is
necessary for the Samba4 notify system.
Yes, I know, I could import the whole Samba4 messaging system, but I want to
do it step by step and I think getting notify in is more important in this
step.
Volker
(This used to be commit c8ae60ed65dcce9660ee39c75488f2838cf9a28b)
|
|
into functions.
Jeremy.
(This used to be commit 461db3c8ed045cac70eccf3200bf9163dbce5826)
|
|
Volker
(This used to be commit 70c589a8323637ff8e1f96a56f8acaf550a58dc4)
|
|
with -DDEVELOPER.
Jeremy.
(This used to be commit 7f817067a70930ee3502ea3373173e0c23733253)
|
|
Jeremy.
(This used to be commit dce98dae2d18126d8380f92595f315b96d48a7df)
|
|
moving events around.
Jeremy.
(This used to be commit 6fee874ab420b4c406e38b5e189a6d6ea8594fc9)
|
|
Allow us to correctly refuse to set delete on close on a
non-empty directory. There are still some delete-on-close
wrinkles to be fixed, but I understand how to do that better
now. I'll fix this tomorrow.
Jeremy.
(This used to be commit 029635885825a5562e7974a6f5675cce3bf1b5dc)
|
|
This add a struct event_context and infrastructure for fd events to smbd. This
is step zero to import lib/events.
Jeremy, I rely on you to watch the change in receive_message_or_smb()
closely. For the normal code path this should be the only relevant change. The
rest is either not yet used or is cosmetic.
Volker
(This used to be commit cd07f93a8aecb24c056e33b1ad3447a41959810f)
|
|
pointer deref.
Jeremy
(This used to be commit 34d891c81ad4226bb1f0e26902c4e4afaba6d62f)
|
|
- include system/aio.h
- use full prototype for main
- use ifdef instead if
metze
(This used to be commit 024dd7d7c95bcf8d77914dc2063f16220358e690)
|
|
metze
(This used to be commit 352ee730308bbc151a742938818c9b8b3a6e8014)
|
|
- remove the epoll configure checks from libreplace
metze
(This used to be commit 3061c333eca4aaff6af4b200cfe07d17f87018b2)
|
|
Jeremy.
(This used to be commit 66cca893e1aa035fa0aa05c0d542848f084fac31)
|
|
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
(This used to be commit 31f8e0edc0c3e76654728b2c204faa70830e1f1b)
|
|
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
(This used to be commit f4e898b6224fd82d9805da771ef6040065de7b12)
|
|
Checking in because Jeremy was bugging me. Potentially this becomes quite
intrusive, I'm not sure if I should open a temporary branch for this.
Jeremy, Jerry, do you think 3_0 is the right place for this?
Volker
(This used to be commit bcf5c751cbe203c00814642e26440cf88f300bce)
|
|
only try to find dlfcn.h if the dlopen symbol was found,
it hopefully fixes systems where dlfcn.h but no library with dlopen
metze
(This used to be commit b303e929d1ac6f1d931d0b92bdecdf292e1598cd)
|
|
found by Volker.
Jeremy
(This used to be commit 08d551163c9563bd02acd437bc1a1595e7939cee)
|
|
more no previous prototype warnings
(This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)
|
|
clean up a bunch of no previous prototype warnings
(This used to be commit c60687db112405262adf26dbf267804b04074e67)
|
|
get rid of warning: value computed is not used
(This used to be commit ebe16589cb6c45524b90abe5f9be5e4affa1598e)
|
|
I think "anonimous" is correctly spelled "anonymous". The Solaris compile is
referring to this as "anonymous" in line 814 of smbldap.c. Simo, please check.
Thanks,
Volker
(This used to be commit a77d8fa08e5a7c9c0c7c415ce3b7848b265b4b95)
|
|
but always use a talloc context.
Thanks to simo for pointing this out.
Jeremy.
(This used to be commit 437cb7c88833d7eab0e3c3dcf175860df74a7a38)
|
|
- make most static functions inline
- handle NULL pointers in talloc_parent_chunk()
- use talloc_parent_chunk() in talloc_parent_name()
to fix a bug found by the IBM checker
metze
(This used to be commit c718eb7a7c3cdc4acb25f303a73a3ca478c27af0)
|
|
Guenther
(This used to be commit fe3ed63d29e7a68413bffc11d634b61a664ed1a2)
|
|
Jeremy.
(This used to be commit 794ebd8a84115a636d8fa4a9f859f8a999135e5e)
|
|
end parsing a file.
Jeremy.
(This used to be commit ea8215935e5f3952a4480c1f7dafafa9458f66a9)
|
|
then terminate the traversal once we've done that.
Jeremy.
(This used to be commit da3d0b62340b545950ea2081f30c252fd4609981)
|
|
per type - this is all we use right now and makes
re-entrancy problems with deleting handlers with
a message dispatch loop go away.
Jeremy.
(This used to be commit 2e9b6faeae1474d65a5c12f5a19b0ae045d47c2e)
|
|
in tdb message processing. If we're inside a dispatch
function and we delete our own handler we'd walk onto
the next pointer from a deleted memory block. Fixes
crash bug in winbindd (and goodness knows where else).
Jeremy.
(This used to be commit 27a4c1121404e346432d90b97b518861e038e9f2)
|
|
is safe from signals.
Jeremy.
(This used to be commit c264a0aa4a83a3d47db33446b16a8766bc14824f)
|
|
inside the #ifdef HAVE_NATIVE_ICONV
(This used to be commit 43ab1d2ba5eb24fc22f8d53c650bf39e95fb133b)
|
|
(This used to be commit e710a7d39a662a1a339f3f71c4b051fde1bb5a16)
|
|
Simo.
(This used to be commit 50cd8bffeeed2cac755f75fc3d76fe41c451976b)
|