samba - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author	Files	Lines
2009-01-29	Fix coverity CID#117 - resource leak in error path.	Jeremy Allison	1	-24/+53
	Jeremy.
2009-01-29	Fix coverity CID#116. Resource leak on error path.	Jeremy Allison	1	-2/+4
	Jeremy.
2009-01-29	Fix coverity CID#115. Resource leak in error path.	Jeremy Allison	1	-1/+4
	Jeremy.
2008-12-23	Fix another "format not a string literal and no format arguments" warning.	Jeremy Allison	1	-2/+5
	Jeremy
2008-11-18	s3-libnet-samsync: pass sequence number pointer to process routine.	Günther Deschner	1	-0/+2
	Guenther
2008-11-18	s3-libnet-samsync: move all modules to startup,process,finish callbacks.	Günther Deschner	1	-29/+76
	Guenther
2008-11-18	s3-libnet-samsync: use samsync_ops.	Günther Deschner	1	-10/+10
	Guenther
2008-11-18	s3-libnet-samsync: add samsync_ops to all samsync modules.	Günther Deschner	1	-0/+4
	Guenther
2008-10-22	Fix net rpc vampire, based on an amazing piece of debugging work by ↵	Jeremy Allison	1	-6/+5
	"Cooper S. Blake" <the_analogkid@yahoo.com>. "I believe I have found two bugs in the 3.2 code and one bug that carried on to the 3.3 branch. In the 3.2 code, everything is located in the utils/net_rpc_samsync.c file. What I believe is the first problem is that fetch_database() is calling samsync_fix_delta_array() with rid_crypt set to true, which means the password hashes are unencrypted from the RID encryption. However, I believe this call is redundant, and the corresponding call for samdump has rid_crypt set to false. So I think the rid_crypt param should be false in fetch_database(). If you follow the code, it makes its way to sam_account_from_delta() where the password hashes are decrypted a second time by calling sam_pwd_hash(). I believe this is what is scrambling my passwords. These methods were refactored somewhere in the 3.3 branch. Now the net_rpc_samsync.c class calls rpc_vampire_internals, which calls libnet/libnet_samsync.c, which calls samsync_fix_delta_array() with rid_crypt always set to false. I think that's correct. But the second bug has carried through in the sam_account_from_delta() function: 208 if (memcmp(r->ntpassword.hash, zero_buf, 16) != 0) { 209 sam_pwd_hash(r->rid, r->ntpassword.hash, lm_passwd, 0); 210 pdb_set_lanman_passwd(account, lm_passwd, PDB_CHANGED); 211 } 212 213 if (memcmp(r->lmpassword.hash, zero_buf, 16) != 0) { 214 sam_pwd_hash(r->rid, r->lmpassword.hash, nt_passwd, 0); 215 pdb_set_nt_passwd(account, nt_passwd, PDB_CHANGED); If you look closely you'll see that the nt hash is going into the lm_passwd variable and the decrypted value is being set in the lanman hash, and the lanman hash is being decrypted and put into the nt hash field. So the LanMan and NT hashes look like they're being put in the opposite fields." Fix this by removing the rid_crypt parameter. Jeremy.
2008-08-08	libnet samsync ldif: fix the build without LDAP.	Michael Adam	1	-0/+15
	Michael (This used to be commit 32df05bd1f49f2290ad69f84d5a47207b1469629)
2008-07-18	Use LDAP macros instead of attribute names.	Karolin Seeger	1	-24/+24
	Karolin (This used to be commit 7dae8b04f126d0ac86a452dcf373a690ee687ead)
2008-06-27	net_vampire: use bool for last_query information in samsync.	Günther Deschner	1	-2/+2
	Guenther (This used to be commit fa1976e23a33bd3fab17c3f6ab5573ee1fdf9e31)
2008-06-23	net_vampire: fix included header.	Günther Deschner	1	-1/+1
	Guenther (This used to be commit 1dbe6ea8607549649f69e1b63cc427efe67e0778)
2008-06-17	net_vampire: add error and result_message to samsync_context.	Günther Deschner	1	-1/+6
	Guenther (This used to be commit e0b117200441f842fbc11cc817ab2cde4d63a22e)
2008-06-17	net_vampire: use generic output filename and use correct argv element.	Günther Deschner	1	-1/+1
	Guenther (This used to be commit e0843e631e379645296a5fe34dfc83bc265ebef3)
2008-06-17	net_vampire: move ldif code out of net_rpc_samsync.c	Günther Deschner	1	-0/+1209
	Guenther (This used to be commit 1d5758ec3a5160e5649242c42f6e4a7b39eb6199)