Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2011-09-14 | s3:libsmb: return NT_STATUS_CONNECTION_DISCONNECTED instead of ↵ | Stefan Metzmacher | 1 | -1/+1 | |
NT_STATUS_CONNECTION_INVALID We should return the same in all places. metze | |||||
2011-09-12 | s3:libsmb: let cli_pull_raw_error() return NT_STATUS_OK as DOS-Error success | Stefan Metzmacher | 1 | -1/+6 | |
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Sep 12 19:12:21 CEST 2011 on sn-devel-104 | |||||
2011-08-28 | s3:libsmb: move cli_session_request*() to smbsock_connect.c | Stefan Metzmacher | 1 | -127/+0 | |
metze | |||||
2011-08-28 | s3:libsmb: move cli_smb_oplock_break_waiter*() to clioplock.c | Stefan Metzmacher | 1 | -79/+0 | |
metze | |||||
2011-08-28 | s3:libsmb: use cli_smb_req_set_mid() in cli_smb_oplock_break_waiter_send() | Stefan Metzmacher | 1 | -3/+1 | |
metze | |||||
2011-08-28 | s3:libsmb: let cli_smb_req_mid() return the mid set by cli_smb_req_set_mid() | Stefan Metzmacher | 1 | -0/+5 | |
metze | |||||
2011-08-12 | s3:libsmb: keep a cli_smb_state->one_way | Stefan Metzmacher | 1 | -12/+19 | |
This moves the SMB1 specific stuff to cli_smb_req_create(), instead of having it in the core dispatching code. metze | |||||
2011-08-12 | s3:libsmb: abstract the incoming dispatch function via a function pointer | Stefan Metzmacher | 1 | -5/+6 | |
This will allow handling of SMB2 in future. metze | |||||
2011-08-12 | s3:libsmb: split out cli_state_dispatch_smb1() from cli_smb_received() | Stefan Metzmacher | 1 | -45/+66 | |
metze | |||||
2011-08-12 | s3:libsmb: add missing TALLOC_FREE(frame) to cli_smb_received() | Stefan Metzmacher | 1 | -0/+1 | |
metze | |||||
2011-08-12 | s3:libsmb: keep the request order in cli_smb_req_unset_pending() | Stefan Metzmacher | 1 | -1/+3 | |
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Aug 12 12:36:03 CEST 2011 on sn-devel-104 | |||||
2011-08-12 | s3:libsmb: use tevent_req_defer_callback() unless there's only one request ↵ | Stefan Metzmacher | 1 | -4/+41 | |
in cli_smb_received() Callers of tevent_req_done() (or similar functions) have to return directly. Otherwise the callback could invalidate the current stack state, which is likely to trigger segfaults. If there was only one pending request and we just got the response for that one, we can use tevent_req_done() directly. Otherwise there're more pending requests and we need to call cli_state_receive_next() or we got the response for chained requests. Both means that we have to use tevent_req_defer_callback(). metze | |||||
2011-08-12 | s3:libsmb: make use of cli_state_receive_next() in cli_smb_received() | Stefan Metzmacher | 1 | -17/+2 | |
metze | |||||
2011-08-12 | s3:libsmb: notify all request about failures in cli_smb_req_set_pending() | Stefan Metzmacher | 1 | -0/+7 | |
It's up to the caller to notify the current request, but we have to notify all other pending requests if we're not able to read the next response from the server. metze | |||||
2011-08-12 | s3:libsmb: split out cli_state_receive_next() from cli_smb_req_set_pending() | Stefan Metzmacher | 1 | -2/+25 | |
metze | |||||
2011-08-12 | s3:libsmb: use talloc_stackframe() in cli_smb_received() | Stefan Metzmacher | 1 | -8/+12 | |
metze | |||||
2011-08-12 | s3:libsmb: call cli_smb_req_unset_pending() before tevent_req_done() also ↵ | Stefan Metzmacher | 1 | -0/+1 | |
for chained requests metze | |||||
2011-08-12 | s3:libsmb: reset the destructor in cli_smb_req_unset_pending() | Stefan Metzmacher | 1 | -1/+2 | |
metze | |||||
2011-08-12 | s3:libsmb: add cli_state_notify_pending() and use it | Stefan Metzmacher | 1 | -25/+45 | |
If we got a problem on the connection we need to notify every pending request. But we need to make use of tevent_req_defer_callback() before tevent_req_nterror(), otherwise the callback, triggered by tevent_req_nterror(), could invalidate the state of current caller, which will likely cause segfaults. metze | |||||
2011-07-27 | s3: Fix async smb handling | Volker Lendecke | 1 | -9/+21 | |
In cli_echo with more than one response we ended up with more than one read_smb request. One from the call to cli_smb_req_set_pending called from cli_smb_received. The other one from cli_smb_received itself. I don't really see another way to deal with this than to hold the read_smb request in the cli_state. Metze, please check! Volker | |||||
2011-07-22 | s3:libsmb: move cli_state->fd to cli_state->conn.fd | Stefan Metzmacher | 1 | -3/+3 | |
metze | |||||
2011-07-22 | s3:libsmb: make use of cli_state_disconnect() | Stefan Metzmacher | 1 | -10/+3 | |
metze | |||||
2011-07-22 | s3:libsmb: make use of cli_state_is_connected() | Stefan Metzmacher | 1 | -1/+1 | |
metze | |||||
2011-07-22 | s3:libsmb: move cli_state->outgoing to cli_state->conn.outgoing | Stefan Metzmacher | 1 | -2/+2 | |
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Jul 22 09:53:59 CEST 2011 on sn-devel-104 | |||||
2011-07-22 | s3:libsmb: move cli_state->pending to cli_state->conn.pending | Stefan Metzmacher | 1 | -24/+26 | |
metze | |||||
2011-07-20 | s3:libsmb: move cli->cnum to cli->smb1.tid and hide it behind ↵ | Stefan Metzmacher | 1 | -1/+1 | |
cli_state_[g|s]et_tid() metze | |||||
2011-07-20 | s3:libsmb: move cli->mid to cli->smb1.mid | Stefan Metzmacher | 1 | -1/+1 | |
metze | |||||
2011-07-13 | s3:libsmb: remove unused cli_smb_inbuf() | Stefan Metzmacher | 1 | -7/+0 | |
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Jul 13 01:19:51 CEST 2011 on sn-devel-104 | |||||
2011-07-08 | s3:libsmb: don't use the cli->inbuf to store the last error | Stefan Metzmacher | 1 | -34/+16 | |
We keep the raw error in cli->raw_status now, until we fixed all caller to get the NTSTATUS from the function calls. metze | |||||
2011-06-20 | Use tevent_req_oom | Volker Lendecke | 1 | -1/+1 | |
This fixes a few Coverity errors | |||||
2011-06-10 | s3:libsmb/async_smb: add helpers to get and set the seqnum for signing | Stefan Metzmacher | 1 | -0/+14 | |
This will be used for correct signing in [nt]trans[2][s] requests. metze | |||||
2011-06-10 | s3:libsmb/async_smb: don't remove pending requests if the mid is set | Stefan Metzmacher | 1 | -0/+15 | |
If the mid was set explicitly, it means the request expects more than one reply, so leave it in the pending array. metze | |||||
2011-06-10 | s3:libsmb/async_smb: call cli_smb_req_unset_pending() instead of destructor ↵ | Stefan Metzmacher | 1 | -2/+2 | |
directly metze | |||||
2011-06-10 | s3:libsmb/async_smb: let cli_smb_recv() initialize output values for one way ↵ | Stefan Metzmacher | 1 | -0/+18 | |
requests metze | |||||
2011-06-06 | s3: Remove a pointless if-statement | Volker Lendecke | 1 | -3/+1 | |
We are here only if we have more than one num_pending Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Jun 6 18:21:17 CEST 2011 on sn-devel-104 | |||||
2011-06-01 | lib/util/time.c: timeval_current_ofs_msec | Rusty Russell | 1 | -2/+1 | |
Several places want "milliseconds from current time", and several were simply doing "msec * 1000" which can (and does in one place) result in a usec value over 1 a million. Using a helper to do this is safer and more readable. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> | |||||
2011-05-23 | s3: Directly call common_encrypt_buffer in cli_smb_req_iov_send | Volker Lendecke | 1 | -2/+2 | |
2011-05-19 | s3: Do central cli_set_error | Volker Lendecke | 1 | -0/+2 | |
2011-05-19 | s3: Make read_smb_send/recv public | Volker Lendecke | 1 | -87/+1 | |
2011-05-10 | async_smb.c: convert cli->timeout properly | Rusty Russell | 1 | -1/+2 | |
I have a test failure on my 32-bit Ubuntu system, in that samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than waiting 5 seconds for the child). Debugging revealed this code: timeout is in ms and is set to > 1000 in various places. The code dates from 2002, and other perturbations didn't reveal why it breaks now, but fix it anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User: Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104 | |||||
2011-05-06 | s3-libsmb: move protos to libsmb/proto.h | Günther Deschner | 1 | -0/+1 | |
Guenther | |||||
2011-05-05 | More const fixes for compiler warnings from the waf build. | Jeremy Allison | 1 | -1/+1 | |
2011-04-29 | s3-tevent: only include ../lib/util/tevent wrappers where needed. | Günther Deschner | 1 | -0/+2 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Apr 29 14:00:30 CEST 2011 on sn-devel-104 | |||||
2011-03-30 | s3-libsmb: put namequery headers to nmblib.h | Günther Deschner | 1 | -0/+1 | |
We might find a better name for it and merge other namequery related things as well here... Guenther | |||||
2011-03-16 | s3-libsmb: move smb encryption structs into own header. | Günther Deschner | 1 | -0/+1 | |
Guenther | |||||
2010-12-22 | s3: Add async cli_session_request | Volker Lendecke | 1 | -0/+127 | |
This does not do the redirects, but I think that might be obsolete anyway | |||||
2010-11-18 | s3: Make winbind recover from a signing error | Volker Lendecke | 1 | -0/+2 | |
When winbind sees a signing error on the smb connection to a DC (for whatever reason, our bug, network glitch, etc) it should recover properly. The "old" code in clientgen.c just closed the socket in this case. This is the right thing to do, this connection is spoiled anyway. The new, async code did not do this so far, which led to the code in winbindd_cm.c not detect that we need to reconnect. | |||||
2010-09-20 | s3-build: only include async headers where needed. | Günther Deschner | 1 | -0/+2 | |
Guenther | |||||
2010-08-19 | s3-libsmbclient Convert dos error codes to NTstatus in async libsmbclient. | Jim McDonough | 1 | -7/+1 | |
DOS error codes were being lost with the conversion to async libsmbclient. If we're passing around NTSTATUS internally, let's just convert it when we get it. DOS ACCESS_DENIED on nautilus was not prompting for other credentials, because it was not being mapped. | |||||
2010-03-30 | If the timeout has been set to zero, don't register an end time. | Jeremy Allison | 1 | -3/+5 | |
The caller doesn't want a timeout. Jeremy. |