summaryrefslogtreecommitdiff
path: root/source3/libsmb/cliconnect.c
AgeCommit message (Collapse)AuthorFilesLines
2008-02-11Add a missing returnVolker Lendecke1-1/+1
If I'm not completely blind, we should return here. Not doing it here seems not to be a major flaw, as far as I can see we're only missing the error code. This might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error messages people see during joins. All with stake in Samba client, please check! (This used to be commit eadd15c9363a57c214ede3c489057646baca48f8)
2008-01-23Don't leak memory in error path.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 2df0cdaafdced798f81e30d34371aa1d8e963208)
2008-01-23Use strchr_m in seaching for '.' in the hostname to make sure we're mb safe.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 090061b73a1c086ff8a7797e1a63532eacd91148)
2008-01-23Fix Windows 2008 (Longhorn) join.Andreas Schneider1-1/+15
During 'net ads join' the cli->desthost is a hostname (e.g. rupert.galaxy.site). Check if we have a hostname and use only the first part, the machine name, of the string. (This used to be commit 5f60ed4af680ba2811db8d9f8267348ce05f26d2)
2007-12-26Add SMB encryption. Still fixing client decrypt butJeremy Allison1-11/+11
negotiation works. Jeremy. (This used to be commit d78045601af787731f0737b8627450018902b104)
2007-12-21Use ADS_IGNORE_PRINCIPAL define.Günther Deschner1-2/+1
Guenther (This used to be commit 763e13315fc71237b14a186810bc201e725648f5)
2007-12-19Fix debug messagesVolker Lendecke1-8/+9
When warning that "client plaintext auth" is not enabled where the server requested them we should not talk about "client use plaintext auth" (This used to be commit 7799e18994354b2705ee8c64ae8c75e062ace460)
2007-12-15Added patch originally by Andreas Schneider <anschneider@suse.de>Jeremy Allison1-8/+42
to cause us to behave like Vista when looking for remote machine principal. Modified by me. Jeremy. (This used to be commit d0e33840fb4cfc85990d3ee327428b0854a22722)
2007-12-12Allow cliconnect to loop through multiple ip addressesJeremy Allison1-23/+49
for a server. We should have been doing this for a while, but it's more critical with IPv6. Original patch fixed up by James. Jeremy. (This used to be commit 5c7f7629a97ef0929e00e52f1fae4386c984000b)
2007-12-07Don't build rpctorture anymore - not maintained. Just remove.Jeremy Allison1-4/+6
Remove all vestiges of pstring (except for smbctool as noted in previous commit). Jeremy (This used to be commit 4c32a22ac50ada3275d2ffba3c1aa08bee7d1549)
2007-11-29Remove PSTRING_LEN from smbd/ nmbd/.Jeremy Allison1-3/+12
Remove pstring from libsmb/clidfs.c except for a nasty hack (that will be removed when pstrings are gone from client/). Jeremy. (This used to be commit cc257b71d13daa47e6f2315d0f07a60eb4aaeca6)
2007-11-29Remove the explicit TALLOC_CTX * from cli_struct.Jeremy Allison1-4/+14
Make us very explicit about how long a talloc ctx should last. Jeremy. (This used to be commit ba9e2be2b5a59684e854609f9d82ea1633448c62)
2007-11-11Remove a static fstringVolker Lendecke1-1/+1
I'm not sure why this used to be static, to me it seems that every time this variable is overwritten. I just don't see how name_status_find() could return true and not overwrite name. Can someone please review this and potentially check it in? Thanks, Volker (This used to be commit 329c688e4a9e69b71996fd1b0eee2202a849f3f5)
2007-11-09Remove the silly "user_socket_options" global variableVolker Lendecke1-4/+2
This is better done with a 'lp_do_parameter(-1, "socket options", ..); (This used to be commit 814bed029efa391e664ac432d0d68dfeab26381f)
2007-11-08Remove more pstring/fstrings.Jeremy Allison1-4/+1
Jeremy. (This used to be commit 7a1de5b44e84a7474e78518c6ba33b3fedc42b5f)
2007-11-03Remove the smb_read_error global variable and replaceJeremy Allison1-1/+1
it with accessor functions. "One global or pstring a day...." :-). Jeremy. (This used to be commit d50d14c300abc83b7015718ec48acc8b3227a273)
2007-10-27Change all occurrences of zero_addr(&ss,AF_INET) toJeremy Allison1-1/+1
zero_addr(&ss). All current uses were always of the AF_INET form, so simplify the call. If in the future we need to zero an addr to AF_INET6 this can be done separately. Jeremy. (This used to be commit 2e92418a138bf2738b77b7e0fcb2fa37ad84fc0c)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison1-65/+87
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-15/+15
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison1-4/+4
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-12/+13
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.Gerald Carter1-28/+10
The translate_name() used by cli_session_setup_spnego() cann rely Winbindd since it is needed by the join process (and hence before Winbind can be run). (This used to be commit 00a93ed336c5f36643e6e33bd277608eaf05677c)
2007-10-10r25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,Gerald Carter1-10/+28
and client fixes. Patch from Todd Stetcher <todd.stetcher@isilon.com>. (This used to be commit 8304ccba7346597425307e260e88647e49081f68)
2007-10-10r24737: Remove older TODO: Convert internal_resolve_name() and friends to ↵Günther Deschner1-1/+2
NTSTATUS. Guenther (This used to be commit 8300aac4944613e411a78ab98de5d77f8fd38fa7)
2007-10-10r24281: Fix bug found by Herb. The vuid entry in the cli_state structure getsJeremy Allison1-0/+4
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try to authenticate as the user in cli_session_setup this returns an error "Bad userid" (as seen in wireshark). "We should only leave cli->vuid != 0 on success. Looks like it's getting set in the cli_session_setup_blob_receive() call and not cleared again on error." Jeremy. (This used to be commit fa8e66dd8d2c68b91b27169c3c43820989f58758)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.Jeremy Allison1-13/+12
Long overdue fix.... Jeremy. (This used to be commit 073fdc5a58139796dbaa7ea9833dca5308f11282)
2007-10-10r22950: Fix the issue Volker reported here :Jeremy Allison1-1/+1
"Attempt to fix some build farm failures: On port 139 the first successful packet gives len==0 from the server, so the = in if (len <= 0) { in line 136 of clientgen.c throws a failure." The irritating thing is that I already had it correct in SAMBA_3_0_26 and forgot to merge the change across. len == 0 is a valid return - I messed that up when converting client_receive_smb() to return a length rather than a BOOL. Doh ! Jeremy. (This used to be commit a398bdf08d9efac51af28aed29f2c0f151cd5aad)
2007-10-10r22929: Attempt to fix some build farm failures: On port 139 the firstVolker Lendecke1-1/+1
successful packet gives len==0 from the server, so the = in if (len <= 0) { in line 136 of clientgen.c throws a failure. Jeremy, please fix this properly, I'm not merging this to 3_0_26 so that you can filter it when you merge. Volker (This used to be commit 9c5111d8c5064a43762d7d0146acff5e7691dafd)
2007-10-10r22844: Introduce const DATA_BLOB data_blob_null = { NULL, 0, NULL }; andVolker Lendecke1-15/+15
replace all data_blob(NULL, 0) calls. (This used to be commit 3d3d61687ef00181f4f04e001d42181d93ac931e)
2007-10-10r22644: Fix memleak.Günther Deschner1-1/+3
Guenther (This used to be commit 65a2701f36439db37e8cd6067be69e8ffdc4615b)
2007-10-10r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison1-11/+11
to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy. (This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
2007-10-10r22122: Start to fix csc issue with Vista. Make smbd supportJeremy Allison1-0/+1
the extended 7 word response for tconX rather than the 3 word one we supported previously. Jeremy. (This used to be commit 137953226a2d691259e7e84d6ae0dc24755e5a3a)
2007-10-10r22092: - make spnego_parse_auth_response() more generic andStefan Metzmacher1-1/+1
not specific for NTLMSSP - it's possible that the server sends a mechOID and authdata if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE metze (This used to be commit e9f2aa22f90208a5e530ef3b68664151960a0a22)
2007-10-10r21990: Stop messing with the signing engine just becauseJeremy Allison1-10/+10
we're encrypted. This will make further changes and spec much more clear. Jeremy. (This used to be commit ffa3a5c508a494d22e8ee3ada424a6517ddf8923)
2007-10-10r21922: Fixed the build by rather horrid means. I really needJeremy Allison1-10/+10
to restructure libsmb/smb_signing.c so it isn't in the base libs path but lives in libsmb instead (like smb_seal.c does). Jeremy. (This used to be commit 1b828f051d0782201f697de15ff973bd6b097d5b)
2007-10-10r21894: Some refactoring of server side encryption context. SupportJeremy Allison1-2/+1
"raw" NTLM auth (no spnego). Jeremy. (This used to be commit 6b5ff7bd591b4f65e2eb767928db50ddf445f09a)
2007-10-10r21755: Memory leak fixes from Zack Kirsch <zack.kirsch@isilon.com>.Jeremy Allison1-2/+3
Jeremy. (This used to be commit 02d08ca0be8c374e30c3c0e665853fa9e57f043a)
2007-10-10r21577: Remove unneeded #define (part of earlier patch that wasJeremy Allison1-2/+0
removed). Jeremy. (This used to be commit 645b0438dde0dad26e950b3184cc412d3d87560a)
2007-10-10r21576: Patch based on work from Todd Stecher <todd.stecher@isilon.com>Jeremy Allison1-16/+74
to allow client to fragment large SPNEGO blobs (large krb5 tickets). Tested against W2K3R2. Should fix bug #4400. Jeremy. (This used to be commit b81c5c6adce51cec06df0e993534064b20666a8e)
2007-10-10r21240: Fix longstanding Bug #4009.Günther Deschner1-1/+1
For the winbind cached ADS LDAP connection handling (ads_cached_connection()) we were (incorrectly) assuming that the service ticket lifetime equaled the tgt lifetime. For setups where the service ticket just lives 10 minutes, we were leaving hundreds of LDAP connections in CLOSE_WAIT state, until we fail to service entirely with "Too many open files". Also sequence_number() in winbindd_ads.c needs to delete the cached LDAP connection after the ads_do_search_retry() has failed to submit the search request (although the bind succeeded (returning an expired service ticket that we cannot delete from the memory cred cache - this will get fixed later)). Guenther (This used to be commit 7e1a84b7226fb8dcd5d34c64a3478a6d886a9a91)
2007-10-10r19250: Fixes bug 4156.Derrell Lipman1-0/+1
The protocol negotiation string "LANMAN2.1" was not listed in the set of negotiatiable possibilities, so non-optimal negotiation was taking place. (This used to be commit a0dfa60fc5146ea6af0b88d91e030a4ec3d7f01e)
2007-10-10r19043: There's no point in #ifdef'ing the detection whether we were offered ↵Volker Lendecke1-8/+2
KRB5 in SPNEGO, as long as we don't make use of it without krb libs. Makes the code a bit simpler. Volker (This used to be commit 23549e6c082e92e45ced4eee215bcc0094b2a88b)
2007-10-10r19042: Fix the non-krb5 build. This needs sooo severe cleanup ... :-)Volker Lendecke1-0/+2
Volker (This used to be commit b601fc42cb289366b7c522f41aa4c66920006890)
2007-10-10r19041: Make us connect to Vista RC1. Apparently metze had done the same ↵Volker Lendecke1-1/+14
patch some weeks ago. We have some work before us, when in AD mode Vista sends "not_defined_in_RFC4178@please_ignore" as the principal..... Volker (This used to be commit af85d8ec02b36b765ceadf0a342c7eda2410034b)
2007-10-10r18969: Fix typo.Günther Deschner1-2/+2
Guenther (This used to be commit 31f21282cd5fb27c867615790e7fd27df4cd4c0e)
2007-10-10r18613: Metze, in your DLINKLIST commit you changed thisJeremy Allison1-1/+1
from 10 seconds to 30 seconds. I don't think you meant to do this.... Jeremy. (This used to be commit dd1691cf81492cfecc7f015ba201b78e2588db90)
2007-10-10r18605: sync dlinklist.h with samba4, that means DLIST_ADD_END()Stefan Metzmacher1-1/+1
and DLIST_DEMOTE() now take the type of the tmp pointer not the tmp pointer itself anymore. metze (This used to be commit 2f58645b7094e81dff3734f11aa183ea2ab53d2d)
2007-10-10r17800: Start using struct timespec internally for file timesJeremy Allison1-1/+3
on the wire. This allows us to go to nsec resolution for systems that support it. It should also now be easy to add a correct "create time" (birth time) for systems that support it (*BSD). I'll be watching the build farm closely after this one for breakage :-). Jeremy. (This used to be commit 425280a1d23f97ef0b0be77462386d619f47b21d)