Age | Commit message (Collapse) | Author | Files | Lines |
|
This code wrote to the full buffer in fstrcpy(), pstrcpy() and other
fixed-length string manipulation functions.
The hope of this code was to find out at run time if we were mixing up
pstring and fstring etc, and to record where this came from. It has a
runtime performance impact (particularly if compiled with
--enable-developer).
It is being removed because of the complexity it adds, and the
distinct lack of bugs that this complexity has been credited in
finding.
The macro-based compile-time checking of string sizes remains.
Andrew Bartlett
|
|
This avoids duplication between FUNCTION_NAME and __FUNCTION__
|
|
in case the cli was closed before (e.g. via a dropped ip message)
it can be expected that the read here returns with an error and so
we should not log that a connection is dead when it was closed before
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb 23 16:51:03 CET 2011 on sn-devel-104
|
|
|
|
|
|
Guenther
|
|
|
|
Guenther
|
|
|
|
metze
|
|
|
|
|
|
This is a sync wrapper around cli_smb_send/cli_smb_recv. This is a hack to
speed up converting libsmb/ away from cli_send_smb/cli_receive_smb. Some
routines in libsmb/ are only called in one place in smbtorture for example,
where making it async right now is not worth it. With cli_smb_send/cli_smb_recv
in place, pushing the asynchronosity out one level is "just" boilerplate code
that is easy to do should it become necessary.
|
|
manipulating p->prev directly is not safe any more
(cherry picked from commit 3c650ac1e3e1cdbbabecfddcd29325f20b5dcb48)
|
|
Revert change from 3.3 -> 3.4 with read_socket_with_timeout changed
from sys_read() to sys_recv(). read_socket_with_timeout() is called
with non-fd's (with a pty in chgpasswd.c and with a disk file in
lib/dbwrap_file.c via read_data()). recv works for the disk file,
but not the pty. Change the name of read_socket_with_timeout() to
read_fd_with_timeout() to make this clear (and add comments).
Jeremy.
|
|
should quieten some warnings with picky compilers on the buildfarm.
Jeremy.
|
|
Convert all uses of cli_open(), cli_nt_createXXX to NTSTATUS versions.
This is smaller than it looks, it just fixes a lot of old code.
Next up, ensure all cli_XX functions return NTSTATUS.
Jeremy.
|
|
|
|
I know this is just yet another iteration, but I like this one much better than
the one that exists right now :-)
It will do trans and echo requests without a _recv helper and without
unnecessary memcpy().
|
|
We store the seqnum/mid mapping in the cli_request structure
for async requests and in the cli_state structure for sync calls.
We skip the signing check for oplock requests while waiting
for async requests coming in.
metze
|
|
|
|
password talloc'ed strings within the cli_struct.
Jeremy.
|
|
the problem that stops libsmbclient being thread safe. Subsidiary
DFS connections are now hung off a list inside the cli_state struct.
Much more to do in order to get libsmbclient to thread safety, but
this is a good start.
Jeremy.
|
|
metze
|
|
*cli_initialise_ex()
This prepares the next changes.
metze
|
|
|
|
|
|
|
|
the connections list and authentication structures to worry about.
Jeremy
|
|
It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
|
|
This parameter makes smb_spice_chain add padding before the bytes field
|
|
Introduce async_req_is_error() and async_req_simple_recv()
|
|
|
|
req->private_data==NULL at this point is definitely a bug.
(This used to be commit ce3dc9f616cafc1289a94ac7cae0beca967d836e)
|
|
(This used to be commit c1d645fbe39433541d8bfe6b818c855cee318dc5)
|
|
Jeremy.
(This used to be commit d85cbdbe296ec6de5bdbd66a90ca41345f55c837)
|
|
can result in a buffer overrun.
Jeremy.
(This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
|
|
(This used to be commit 99fc3283c4ecc791f5a242bd1983b4352ce3e6cf)
|
|
This reduces the dependency on cli_state
(This used to be commit 783afab9c891dd7bcb78895b2a639b6f3a0edf5b)
|
|
(This used to be commit a6d74a5a562b54f0b36934965f545fdeb1e8b34a)
|
|
This is == cli_setup_packet but takes an explicit buffer argument
(This used to be commit f64b46dc278899c3449cfd3dbb614aadcf5614d3)
|
|
(This used to be commit e69244a5c8c7c6b7c1897adc4b4b1cfdfc7a7999)
|
|
(This used to be commit ffc1c8cc03e6bad40ed2be91392074b4f038a1bf)
|
|
(This used to be commit db6ae9ed2326e6cd68475375d049084cf1d5a98c)
|
|
(This used to be commit ba771bd858602452a9e58c3aab1336f2ac8a25ef)
|
|
(This used to be commit 90554799afa42855c3e7b87dc632e67f0952f988)
|
|
(This used to be commit f9c8ac83ff42137d2101d3bb17e5dcc3c3d70a8f)
|
|
(This used to be commit 7101026061c470ed962267b43ac0aa67cc761a64)
|
|
Jeremy.
(This used to be commit d67b2634068be9c69082a2b8c22c831aba371cd9)
|
|
negotiation works.
Jeremy.
(This used to be commit d78045601af787731f0737b8627450018902b104)
|