summaryrefslogtreecommitdiff
path: root/source3/libsmb/clireadwrite.c
AgeCommit message (Collapse)AuthorFilesLines
2008-08-01cli_request_new() already gave use the req, remove a pointless function callVolker Lendecke1-2/+0
(This used to be commit 08e97bd369ebe3ab1fd92433b168585faea92c68)
2008-05-28Security fix for CVE-2008-1105: Boundary failure when parsing SMB responsesJeremy Allison1-100/+0
can result in a buffer overrun. Jeremy. (This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
2008-05-21Fix bug #5479, print spool shares require max_xmit toJeremy Allison1-1/+6
be adhered to. Jeremy. (This used to be commit 478a359edead0677281a3ca4e64db6521941b0f3)
2008-04-19Fix bug 5399Volker Lendecke1-5/+0
Thanks to Jason Mader! Volker (This used to be commit 36740f4959194cfaa98b1e37eed08f22edbda1e4)
2008-03-28Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.Jeremy Allison1-1/+3
Jeremy. (This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
2008-03-28More ssize_t->SMB_OFF_TVolker Lendecke1-5/+5
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
2008-03-21On Solaris, size_t seems to be only 32 bit.Volker Lendecke1-5/+7
Fix bug 5341, thanks a lot to Karoly Vegh for testing it! Volker (This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
2008-03-19!NT_STATUS_IS_OK != NT_STATUS_IS_ERRVolker Lendecke1-1/+1
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not* an error. (This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
2008-03-18Fix bug 5334Volker Lendecke1-0/+8
I did not test with a zero length file :-) (This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
2008-03-08Correctly calculate the max read sizeVolker Lendecke1-1/+1
(This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
2008-03-06Convert cli_read to use cli_pullVolker Lendecke1-163/+15
(This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
2008-03-06Add async cli_pull supportVolker Lendecke1-0/+425
This is the big (and potentially controversial) one. It took a phone call to explain to metze what is going on inside cli_pull_read_done, but I would really like everybody to understand this function. It is a very good and reasonably complex example of async programming. If we want more asynchronism in s3, this is what we will have to deal with :-) Make use of it in the smbclient "get" command. Volker (This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
2008-01-16Fix bug found by Derrell - windows returns an read returnJeremy Allison1-21/+28
offset of zero if return size is zero. Should fix testread libsmbclient code. Jeremy. (This used to be commit df3c4648399f8d62ff6fe0013be8b89abc18f0f0)
2008-01-14Windows insists on write sizes < max_xmit on signed connections.Jeremy Allison1-3/+6
Jeremy. (This used to be commit ef9b278b6289a9ecdd6b103927058f64fbb7eb97)
2007-12-26Add SMB encryption. Still fixing client decrypt butJeremy Allison1-14/+17
negotiation works. Jeremy. (This used to be commit d78045601af787731f0737b8627450018902b104)
2007-11-06Ensure we don't use massive writes in pipe mode.Jeremy Allison1-2/+3
Jeremy. (This used to be commit 47640fb20e42f226e7ea104076fd52547bfe1abb)
2007-11-02Change the client library to write directly out ofJeremy Allison1-32/+74
the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
2007-10-30Our userlevel SMBwriteX call is non-standard in that itJeremy Allison1-8/+10
sometimes uses a 12-word write and doesn't include a pad byte (as Windows does). Fix this so that we are identical to Windows clients. This will make recvfile processing much easier to detect (as we can just read a standard writeX header length to decide). Jeremy. (This used to be commit 3d3d1b806aef3617abaac46daf230ed32076e2ce)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison1-7/+7
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter1-8/+6
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell1-2/+1
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23148: Fix old old bug in cli_smbwrite() (not incrementingJeremy Allison1-1/+1
data being sent). Patch from mnix@wanm.com.au. Jeremy. (This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)
2007-10-10r22920: Add in the UNIX capability for 24-bit readX, as discussedJeremy Allison1-10/+40
with the Apple guys and Linux kernel guys. Still looking at how to do writeX as there's no recvfile(). Jeremy. (This used to be commit a53268fb2082de586e2df250d8ddfcff53379102)
2007-10-10r22391: Looks bigger than it is. Make "inbuf" availableJeremy Allison1-5/+5
to all callers of smb_setlen (via set_message() calls). This will allow the server to reflect back the correct encryption context. Jeremy. (This used to be commit 2d80a96120a5fe2fe726f00746d36d85044c4bdb)
2007-10-10r17333: Some C++ warningsVolker Lendecke1-2/+2
(This used to be commit be9aaffdaccae06c8c035eaf31862e34b7cfbe38)
2007-10-10r15162: Patch for bug #3668. Windows has a bug with LARGE_READXJeremy Allison1-1/+5
where if you ask for exactly 64k bytes it returns 0. Jeremy. (This used to be commit dcef65acb5bc08ea4b61ef490a518b7e668ff2ee)
2007-10-10r13915: Fixed a very interesting class of realloc() bugs found by Coverity.Jeremy Allison1-1/+6
realloc can return NULL in one of two cases - (1) the realloc failed, (2) realloc succeeded but the new size requested was zero, in which case this is identical to a free() call. The error paths dealing with these two cases should be different, but mostly weren't. Secondly the standard idiom for dealing with realloc when you know the new size is non-zero is the following : tmp = realloc(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } However, there were *many* *many* places in Samba where we were using the old (broken) idiom of : p = realloc(p, size) if (!p) { return error; } which will leak the memory pointed to by p on realloc fail. This commit (hopefully) fixes all these cases by moving to a standard idiom of : p = SMB_REALLOC(p, size) if (!p) { return error; } Where if the realloc returns null due to the realloc failing or size == 0 we *guarentee* that the storage pointed to by p has been freed. This allows me to remove a lot of code that was dealing with the standard (more verbose) method that required a tmp pointer. This is almost always what you want. When a realloc fails you never usually want the old memory, you want to free it and get into your error processing asap. For the 11 remaining cases where we really do need to keep the old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR, which can be used as follows : tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size); if (!tmp) { SAFE_FREE(p); return error; } else { p = tmp; } SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the pointer p, even on size == 0 or realloc fail. All this is done by a hidden extra argument to Realloc(), BOOL free_old_on_error which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR macros (and their array counterparts). It remains to be seen what this will do to our Coverity bug count :-). Jeremy. (This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
2007-10-10r13119: Fix for #1779 from William Jojo <jojowil@hvcc.edu>Jeremy Allison1-4/+6
Jeremy. (This used to be commit 103cac7dd314117b15e27fd263a64beeb36ed6e6)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter1-6/+6
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10r8572: Remove crufty #define NO_SYSLOG as it's not used at all anymore.Tim Potter1-2/+0
(This used to be commit 985dbb47d925e79c1195ca219f7ab5d6648b22b8)
2007-10-10r4212: Ensure we only look at the bottom bit of large_readx.Jeremy Allison1-5/+6
Set the 14 word version of write if size > 0xffff as well as 64-bit offset. Jeremy. (This used to be commit 94779ccb39560bf5eecab77d70f1fa04bfcf1456)
2007-10-10r4188: Ensure we add in the upper length in the right place !Jeremy Allison1-1/+1
Jeremy. (This used to be commit 9d4e57f06c4f75f42036e91401b0d0392647752b)
2007-10-10r4186: Fix client & server to allow 127k READX calls.Jeremy Allison1-1/+7
Jeremy. (This used to be commit 831cb21a874601e4536c2cf76c5351e1d0defcb5)
2007-10-10r4088: Get medieval on our ass about malloc.... :-). Take control of all our ↵Jeremy Allison1-2/+2
allocation functions so we can funnel through some well known functions. Should help greatly with malloc checking. HEAD patch to follow. Jeremy. (This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)
2007-10-10r2959: If we want to support writes >= 65536 with cli_write, then it had betterRichard Sharpe1-4/+4
return a size_t, not an ssize_t, and we had better left shift the upper part of the write count, not right shift it. (This used to be commit 3eb33fbc64415600d62ff7b1f2edd67d2dac05b4)
2007-10-10r2373: Fix typo.Jeremy Allison1-3/+3
Jeremy. (This used to be commit b1033fc77c97f0d9b5613a0b9f7d45dcf58e6b56)
2007-10-10r2371: Fix for talking to OS/2 clients (max_mux ignored) by Guenter Kukkukk ↵Jeremy Allison1-1/+7
<guenter.kukkukk@kukkukk.com>. Bugid #1590. Jeremy. (This used to be commit 330025d1a669de927a3879a9c3a9fc20e1be464f)
2003-08-08RPC fix from Ronan Waide <waider@waider.ie>. Tested with rpcecho.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 68590b9e2266cf76b46a68cca0acaa47733811fe)
2003-01-15*lots of small merges form HEADGerald Carter1-2/+5
*sync up configure.in *don't build torture tools in make all *make sure to remove torture tools as part of make clean (This used to be commit 0fb724b3216eeeb97e61ff12755ca3a31bcad6ef)
2003-01-03Merge from HEAD - make Samba compile with -Wwrite-strings without additionalAndrew Bartlett1-2/+3
warnings. (Adds a lot of const). Andrew Bartlett (This used to be commit 3a7458f9472432ef12c43008414925fd1ce8ea0c)
2002-12-30Merge Richard's write > 4Gb fix.Jeremy Allison1-2/+12
Jeremy. (This used to be commit 5431bae8944496f44d8cc6d2c4de86e9feb60f32)
2002-12-19merge from 2.2 fix for smbclient large filesHerb Lewis1-1/+9
(This used to be commit 17f685fdbf5d36f82e3da0a09457f5e248b3f109)
2002-11-27Test was reversed for ERRmoredata in cli_read.Jeremy Allison1-0/+10
Jeremy. (This used to be commit fff7f3cbe248982bcd70abb1da6624186bab42d2)
2002-09-25sync'ing up for 3.0alpha20 releaseGerald Carter1-1/+1
(This used to be commit 65e7b5273bb58802bf0c389b77f7fcae0a1f6139)
2002-07-15updated the 3.0 branch from the head branch - ready for alpha18Andrew Tridgell1-26/+38
(This used to be commit 03ac082dcb375b6f3ca3d810a6a6367542bc23ce)
2002-03-20Correctly increment offset in cli_smbwrite.Jeremy Allison1-0/+2
Jeremy. (This used to be commit 5b04b5f1df3ee509e7314064966be09e2202b0ef)
2002-03-20Test against W2K that we're doing large read/writes correctly (we are).Jeremy Allison1-0/+9
At least with 14 word writes. Jeremy. (This used to be commit 24ef6258a16e6b4673f1088d64b79bddcd268df5)
2002-01-30Removed version number from file header.Tim Potter1-2/+1
Changed "SMB/Netbios" to "SMB/CIFS" in file header. (This used to be commit 6a58c9bd06d0d7502a24bf5ce5a2faf0a146edfa)
2002-01-11Same fix as went into 2.2 (I'm waiting for jerry to finish some code).Jeremy Allison1-6/+6
Jeremy. (This used to be commit 01ff6ce4963e1daff019f2b936cef218e1c93f67)
generated by cgit (git 2.34.1) at 2024-12-19 12:56:11 +0000