Age | Commit message (Collapse) | Author | Files | Lines |
|
Convert all uses of cli_open(), cli_nt_createXXX to NTSTATUS versions.
This is smaller than it looks, it just fixes a lot of old code.
Next up, ensure all cli_XX functions return NTSTATUS.
Jeremy.
|
|
Metze, please check!
Thanks,
Volker
|
|
|
|
|
|
|
|
|
|
|
|
buffers"
This reverts commit 9579a6f193f570e4ce2af80f4aac7c2f25ae5b22.
It's confusing to have a boolean to alter the behavior of cli_push
and as the new feature isn't used yet I revert it.
We can readd a extra function later.
metze
|
|
metze
|
|
metze
|
|
There were the following problems:
1.) if window_size was a multiple of the chunk_size,
we silently dropped the last truncated chunk.
2.) if window_size was 0 pushed only the first chunk
to the server and silently dropped the rest.
3.) we had only transferred state->num_reqs writes,
even if there would be more data to send.
metze
|
|
Now I need to document this :-)
|
|
|
|
This streamlines setting up a multi-step async request a bit
|
|
|
|
|
|
This parameter makes smb_spice_chain add padding before the bytes field
|
|
|
|
|
|
Introduce async_req_is_error() and async_req_simple_recv()
|
|
|
|
req->private_data==NULL at this point is definitely a bug.
(This used to be commit ce3dc9f616cafc1289a94ac7cae0beca967d836e)
|
|
Along the lines of cli_request_send this abstracts away the smb-level buffer
handling when parsing replies we got from the server.
(This used to be commit 253134d3aaa359fdfb665709dd5686f69af7f8fd)
|
|
Storing the event_context as permanent state in struct cli_state creates more
complex code than necessary IMO.
(This used to be commit debb37f703075008e5ea7d34d214cfa4d0f8f916)
|
|
cli_request_send() is supposed to bundle all generic SMB-header handling. This
makes cli_request_new static to async_smb.c.
(This used to be commit 7e73dd4e7622db64d30d48ba106892e0895fc188)
|
|
This reverts commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1.
... how did this end up here??
Volker
(This used to be commit 7dd9fd0956bd1c46105d1072c4774972933ab9ec)
|
|
(This used to be commit 4ed73cbbbeff4b554cc8d28252b756241396b3a1)
|
|
(This used to be commit 08e97bd369ebe3ab1fd92433b168585faea92c68)
|
|
can result in a buffer overrun.
Jeremy.
(This used to be commit 23b825e9d2c74c5b940cf4d3aa56c18692259972)
|
|
be adhered to.
Jeremy.
(This used to be commit 478a359edead0677281a3ca4e64db6521941b0f3)
|
|
Thanks to Jason Mader!
Volker
(This used to be commit 36740f4959194cfaa98b1e37eed08f22edbda1e4)
|
|
Jeremy.
(This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
|
|
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
|
|
Fix bug 5341, thanks a lot to Karoly Vegh for testing it!
Volker
(This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
|
|
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not*
an error.
(This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
|
|
I did not test with a zero length file :-)
(This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
|
|
(This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
|
|
(This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
|
|
This is the big (and potentially controversial) one. It took a phone call to
explain to metze what is going on inside cli_pull_read_done, but I would really
like everybody to understand this function. It is a very good and reasonably
complex example of async programming. If we want more asynchronism in s3, this
is what we will have to deal with :-)
Make use of it in the smbclient "get" command.
Volker
(This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
|
|
offset of zero if return size is zero. Should fix testread
libsmbclient code.
Jeremy.
(This used to be commit df3c4648399f8d62ff6fe0013be8b89abc18f0f0)
|
|
Jeremy.
(This used to be commit ef9b278b6289a9ecdd6b103927058f64fbb7eb97)
|
|
negotiation works.
Jeremy.
(This used to be commit d78045601af787731f0737b8627450018902b104)
|
|
Jeremy.
(This used to be commit 47640fb20e42f226e7ea104076fd52547bfe1abb)
|
|
the incoming buffer in the non-signed case. Speeds
up writes by over 10% or so. Complete the server
recvfile implementation.
Jeremy.
(This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
|
|
sometimes uses a 12-word write and doesn't include a pad
byte (as Windows does). Fix this so that we are identical
to Windows clients. This will make recvfile processing
much easier to detect (as we can just read a standard
writeX header length to decide).
Jeremy.
(This used to be commit 3d3d1b806aef3617abaac46daf230ed32076e2ce)
|
|
bugs in various places whilst doing this (places that assumed
BOOL == int). I also need to fix the Samba4 pidl generation
(next checkin).
Jeremy.
(This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
|
|
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
|
|
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
|
|
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
|
|
data being sent). Patch from mnix@wanm.com.au.
Jeremy.
(This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)
|