summaryrefslogtreecommitdiff
path: root/source3/libsmb/libsmbclient.c
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r14418: Try and fix Coverity #39 and #40 by making theJeremy Allison1-2/+10
implicit function contract explicit. Jeremy. (This used to be commit 6de5e9ae4628d384631db9b66e22d439a303b75c)
2007-10-10r14279: Fix coverity #86, 87, 88, 89:Jim McDonough1-10/+27
Free grp_sid and owner_sid before returning. Also, only allow one group or owner. (This used to be commit 1043e0d90ccb3493417f7bf05b70bdf5513bb1a3)
2007-10-10r14241: Fix Coverity bug # 146Volker Lendecke1-1/+3
(This used to be commit 97789ec8fc4ae2d31f6dd554d9979abce186eb30)
2007-10-10r14236: Fix Coverity bug # 90Volker Lendecke1-0/+1
(This used to be commit 019dff53f906a6eb7961a95089bff12361e31e57)
2007-10-10r14235: Fix Coverity bug # 91Volker Lendecke1-0/+12
(This used to be commit 26d471c02c6ddff15836a3c0d30f9e37f018b66d)
2007-10-10r14234: Fix Coverity bug # 93Volker Lendecke1-0/+1
(This used to be commit 8a8d9057d98b24710c98fa48df9d7f330a8ebdc0)
2007-10-10r14158: Fix coverity CID #147 -- do not dereference pointers before checking ↵Alexander Bokovoy1-2/+4
their existence (This used to be commit 6b52423033b2eccdfad1e91e9d59619664f570ac)
2007-10-10r13571: Replace all calls to talloc_free() with thye TALLOC_FREE()Gerald Carter1-1/+1
macro which sets the freed pointer to NULL. (This used to be commit b65be8874a2efe5a4b167448960a4fcf6bd995e2)
2007-10-10r13495: Derell, I'm removing that double setup_logging(), just a typo.Günther Deschner1-1/+0
Guenther (This used to be commit c0d91f9d19b33995237847389e4c37e086938b9e)
2007-10-10r13316: Let the carnage begin....Gerald Carter1-10/+3
Sync with trunk as off r13315 (This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)
2007-10-10r13216: r12422@cabra: derrell | 2006-01-28 23:57:35 -0500Derrell Lipman1-33/+0
Fix cli_setpathinfo() to actually do what it's supposed to. Also, get rid of some apparently drug-induced code to deal with create time which isn't being manipulated anyway. (This used to be commit aa25dc1248b15e8e1b39cf8a98496e5aba475c4a)
2007-10-10r13214: r12420@cabra: derrell | 2006-01-28 19:10:58 -0500Derrell Lipman1-44/+57
This should fix bug #3446. - The authentication domain provided an an SMB URL was being ignored. This patch fixes that. - There were a number of places where string copies were not being confirmed to be properly null-terminated. Now, all string copies in libsmbclient.c are properly null-terminated. (This used to be commit 5fbc2fbb461f02ad6c889de2ce9929c605a44e24)
2007-10-10r13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500Derrell Lipman1-3/+3
lp_load() could not be called multiple times to modify parameter settings based on reading from multiple configuration settings. Each time, it initialized all of the settings back to their defaults before reading the specified configuration file. This patch adds a parameter to lp_load() specifying whether the settings should be initialized. It does, however, still force the settings to be initialized the first time, even if the request was to not initialize them. (Not doing so could wreak havoc due to uninitialized values.) (This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)
2007-10-10r12579: r12122@cabra: derrell | 2005-12-29 12:03:00 -0500Derrell Lipman1-1/+9
allow for arbitrary option value types (This used to be commit 64c8e32b6382e48bce5c1f18179e66ca765a70af)
2007-10-10r12576: r12115@cabra: derrell | 2005-12-29 11:16:03 -0500Derrell Lipman1-2/+28
bug (enhancement) #2651: add option to log debug messages to stderr instead of stdout (This used to be commit 4182eb99af5b343291a661a87d08edd91fd09a7a)
2007-10-10r12570: r12084@cabra: derrell | 2005-12-29 10:05:16 -0500Derrell Lipman1-25/+56
do not open connection when only looking for cached connection; also, fix crash caused by missing initialization following recent locale changes (This used to be commit 0070d816ab53eba047c009604d02f7e088290978)
2007-10-10r12569: r12083@cabra: derrell | 2005-12-29 09:39:45 -0500Derrell Lipman1-255/+526
fix line length and make formatting/indentation more consistent (This used to be commit 3d45023368e651315ff5620345c755c103c91065)
2007-10-10r12485: r12044@cabra: derrell | 2005-12-25 16:46:47 -0500Derrell Lipman1-73/+87
When enumerating what could be a server name or a workgroup name, first check for an existing server structure. If none exists, then go through the previous determination of whether it's a serrver or a workgroup. This should avoid doing a NetBIOS name query each time, if we've already connected to the specified server. (While we're at it, clean up indenting and line length in this area of code.) (This used to be commit 85e4cab1d949f1ab9ce04b96de0b8d1c8113df67)
2007-10-10r12472: r12040@cabra: derrell | 2005-12-24 23:26:55 -0500Derrell Lipman1-7/+2
revert immediately previous change and fix problem correctly. Interfaces were being loaded before all configuration files had been read. *This* should fix byg 3336. (This used to be commit ded5fceef1e9086dcdaba1959f812810f04fe8bc)
2007-10-10r12471: r12038@cabra: derrell | 2005-12-24 23:17:16 -0500Derrell Lipman1-0/+5
libsmbclient was not loading the global configuration file. This should fix 3336. (This used to be commit 6d7a9ce7a7060b9b397ae77b8b54d3cf25e50e5a)
2007-10-10r12466: r12028@cabra: derrell | 2005-12-24 20:25:38 -0500Derrell Lipman1-2/+4
parse dates correctly. w_time and m_time were reversed. (This used to be commit 481abfbab40209e087c82eadc15c3697eae0ae5b)
2007-10-10r12235: r11738@cabra: derrell | 2005-12-14 13:15:14 -0500Derrell Lipman1-0/+2
Ensure that when libsmbclient copies a cli, it prevents the cli from later being freed, by turning off the 'allocated' flag. Change a DEBUG message in pipe_open code from level 0 to level 1 since libsmbclient is now regularly attempting to open a pipe for share enumeration, and falling back to RAP if RPC is unavailable (e.g. win98). We don't want the debug message to display when the pipe open fails, under these normal circumstances. (This used to be commit 965025c057d9e00fb68ea0819e675fcf9ad2f819)
2007-10-10r12225: r11729@cabra: derrell | 2005-12-13 22:59:45 -0500Derrell Lipman1-27/+46
1. Fix a crash bug which should have reared its ugly head ages ago, but for some reason, remained dormant until recently. The bug pertained to libsmbclient doing a structure assignment of a cli after having opened a pipe. The pipe open code makes a copy of the cli pointer that was passed to it. If the cli is later copied (and that cli pointer that was saved is no longer valid), the pipe code will cause a crash during shutdown or when the copied cli is closed. 2. The 'type' field in enumerated shares was not being set correctly with the new RPC-based mechanism for enumerating shares. (This used to be commit 62a02b8f2a1fcb66881a9c9636e0b27e3049c5a1)
2007-10-10r12119: r10812@cabra: derrell | 2005-12-07 22:44:26 -0500Derrell Lipman1-5/+0
sync to repository didn't work correctly...??? (This used to be commit 86ab4cf42b3bfe78239ee0b367bff9cfc5484107)
2007-10-10r12118: r10805@cabra: derrell | 2005-12-07 22:34:55 -0500Derrell Lipman1-12/+101
first go at supporting long file names. seeems to work; requires more testing (This used to be commit 99fbe44ac569f218bd1b4d1026c18cc72f0a1f0e)
2007-10-10r12098: r10797@cabra: derrell | 2005-12-06 12:09:00 -0500Derrell Lipman1-5/+9
fixed another memory leak and reverted an (incorrect) fix from yesterday (This used to be commit 8a86d7bddc291da094d060fbe185f071ffdbddd8)
2007-10-10r12081: r10674@cabra: derrell | 2005-12-05 13:31:28 -0500Derrell Lipman1-19/+0
get rid of temporary #if 0 blocks (This used to be commit 376445c90b05c36206c87c974c13e5f9297f35eb)
2007-10-10r12080: r10673@cabra: derrell | 2005-12-05 13:22:34 -0500Derrell Lipman1-0/+32
Correct some memory and file descriptor leaks. This should fix bugs 3257, 3267 and 3273. (This used to be commit c5781c9cf5f1f8297e084fbe2c4a22257420a447)
2007-10-10r11256: Remove use of long long and strtoll in libsmbclient (weJeremy Allison1-31/+30
can't assume long long is always there). Removed unused var in new a/c rename code. long long still used in eventlog code but Jerry has promised to fix that. Jeremy. (This used to be commit f46d8470652b8bc5c4b8cac8e96973c6165ab19a)
2007-10-10r11124: Commit Chris' fixes for libmsrpc after the rpc_clientGerald Carter1-17/+19
rewrite. His comments: I've gotten the libmsrpc code to work with TRUNK. I've put the patch at: www.uoguelph.ca/~cnicholl/libmsrpc_trunk_v1.patch.gz It is from revision 11093. I also fixed a minor bug in the svcctl code, the timeout parameter for all the control functions was working in milliseconds instead of seconds. Also fixed bug in Makefile when building libmsrpc.a (This used to be commit d3a52900ec223316779e59a13cea87ecb500bccc)
2007-10-10r10970: Fix bug #3166 - null pointer dereference if $HOME notJeremy Allison1-10/+16
defined. Also clarified confusing error messages. Jeremy. (This used to be commit e2639ac9ff8319dde04fc6b4a0c257f7af29cf44)
2007-10-10r10656: BIG merge from trunk. Features not copied overGerald Carter1-31/+58
* \PIPE\unixinfo * winbindd's {group,alias}membership new functions * winbindd's lookupsids() functionality * swat (trunk changes to be reverted as per discussion with Deryck) (This used to be commit 939c3cb5d78e3a2236209b296aa8aba8bdce32d3)
2007-10-10r10176: adding smbctool from Kalim's SoC project; requires make bin/smbctoolGerald Carter1-36/+253
(This used to be commit 79fcc3bb7b955da5eb1b2af475aa6ef7694a7157)
2007-10-10r10001: adding in libmsrpc from Chris Nicholls (SoC project). not built by ↵Gerald Carter1-20/+23
default per conversation with Jeremy until the rpc changes from trunk are merged back (This used to be commit e813de1e522692a6471828bf1fdf503d33f8cd72)
2007-10-10r8093: Next round. Now it compiles with --enable-socket-wrapper.Volker Lendecke1-7/+7
Volker (This used to be commit 25cbcfba30f534f3fb31627ba43421c42ccd5b0f)
2007-10-10r7882: Looks like a large patch - but what it actually does is make SambaJeremy Allison1-3/+3
safe for using our headers and linking with C++ modules. Stops us from using C++ reserved keywords in our code. Jeremy (This used to be commit 9506b8e145982b1160a2f0aee5c9b7a54980940a)
2007-10-10r7817: Eliminate use of ctime_r() in libsmbclient DEBUG statement. It seems ↵Derrell Lipman1-4/+16
that ctime_r() takes different parameters on Solaris than it does on Linux, and it's easier to just eliminate the use of it than to write a configure test. (This used to be commit 513ea79b2ebc9a78c118042abca942da061d4647)
2007-10-10r7245: bug fixes in libsmbclient, setting time attributesDerrell Lipman1-2/+11
(This used to be commit bf33902c059b7f222f89673ce07c8f929860a85f)
2007-10-10r7175: fix incorrect commentDerrell Lipman1-1/+4
(This used to be commit 6f951c863ea4671a62075c6ac963f198fbf322b1)
2007-10-10r7172: This is the proper fix for setting file times from libsmbclient. We nowDerrell Lipman1-84/+147
try setpathinfo, and if that doesn't work (e.g. on win98), revert to the previous slower method. (This used to be commit 6c05812bd90b0db69d974ee2758721dc2974a507)
2007-10-10r7168: Updating file times from libsmbclient was not working for win98. ↵Derrell Lipman1-33/+62
Although the function that was being used to set attributes is a core protocol function (SMBsetatr = 0x09), it does not appear to work on win98. As a temporary measure, when file times are to be set, this version opens the file and uses SMBsetattrE = 0x22 instead. (The other advantage of this function over the original one is that it supports setting access time as well as modification time.) The next step, the proper solution if it can be made to work, is to write functions that use TRANS2_SET_PATH_INFO instead. (This used to be commit bab0bf7f4f9d2a4b6fcee4429094349302bbeb33)
2007-10-10r6595: This is Volkers new-talloc patch. Just got the go-ahead fromJeremy Allison1-1/+1
Volker to commit. Woo Hoo ! Jeremy. (This used to be commit 316df944a456f150944761dab34add5e8c4ab699)
2007-10-10r6392: - Fixes bug 2564: when smbc_opendir() was called with a file rather thanDerrell Lipman1-5/+26
a directory, the errno returned could end up as ENOENT rather than ENOTDIR. - Fixes some compiler warnings which showed up on IRIX, as reported by James Peach. (This used to be commit 615a62b21f8d2f7f97bde2f166ddd6849d39b95c)
2007-10-10r6156: Fixes bug #2543. Properly cache anonmous username when reverting to ↵Derrell Lipman1-9/+20
anonymous login, in libsmbclient. (This used to be commit cf2dcc110824cb3a4ce4e4bf608de25b7cfc2054)
2007-10-10r6155: Fixes bug #1133Derrell Lipman1-4/+19
Added provision for overloading some global configuration options via the new, per-user file ~/.smb/smb.conf.append which is read after the global config file is read (and only if the global config file was read). This leave the original, BC behavior of ~/.smb/smb.conf which, if found, is read but causes the global config file to not be read. Also fixed a potential seg fault in to lp_dump_one(). (This used to be commit 2c5a6305bd127b1a7e65356c2b3aa5c13cd2bd74)
2007-10-10r6149: Fixes bugs #2498 and 2484.Derrell Lipman1-335/+489
1. using smbc_getxattr() et al, one may now request all access control entities in the ACL without getting all other NT attributes. 2. added the ability to exclude specified attributes from the result set provided by smbc_getxattr() et al, when requesting all attributes, all NT attributes, or all DOS attributes. 3. eliminated all compiler warnings, including when --enable-developer compiler flags are in use. removed -Wcast-qual flag from list, as that is specifically to force warnings in the case of casting away qualifiers. Note: In the process of eliminating compiler warnings, a few nasties were discovered. In the file libads/sasl.c, PRIVATE kerberos interfaces are being used; and in libsmb/clikrb5.c, both PRIAVE and DEPRECATED kerberos interfaces are being used. Someone who knows kerberos should look at these and determine if there is an alternate method of accomplishing the task. (This used to be commit 994694f7f26da5099f071e1381271a70407f33bb)
2007-10-10r6102: add support for opening a file for write with O_APPEND in libsmbclientDerrell Lipman1-1/+35
(This used to be commit 542922cb2e5c8e7522f14492418686c339f0a5a4)
2007-10-10r5968: derrell's large file fix for libsmbclient (BUG 2505)Gerald Carter1-32/+31
(This used to be commit 85be4c5df398faa6c5bfacd1f9d2f12c39d411e1)
2007-10-10r5953: more compiler cleanups; moved SID_LIST from smb.h to privileges.c to ↵Gerald Carter1-1/+1
cleanup the name space (This used to be commit 7dfafa712deb115e425c7367296400c54827a217)
2007-10-10r5851: BUG 2456: reported by Jason Mader; remove non standard pragma (my ↵Gerald Carter1-2/+0
fault); should fix some builds with non-gcc compilers (This used to be commit 300150a1bee1bf927236c6d9942784a1359e7054)