summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2007-11-19Always check return from push_ascii.Jeremy Allison1-1/+6
Jeremy. (This used to be commit 9c3d10521e691169cfbb8b728f123911c3c970ae)
2007-11-19Add stackframes to public libsmbclient functionsVolker Lendecke1-64/+245
As we use talloc_tos() in inner libsmbclient/ functions more and more, we need to make sure not to create memleaks by not free'ing talloc stackframes. This patch wraps all calls in libsmbclient.c that are publically exported into a talloc_stackframe()/talloc_free() pair. Jeremy, Derrell, can you check this? Thanks, Volker (This used to be commit db9fa472a89eb78a7b1f7cabcf195331c3b448d9)
2007-11-19Remove pstring from nmbd.Jeremy Allison1-12/+34
Jeremy. (This used to be commit a317f70c229f7730279eaa323f7ebfd499257f76)
2007-11-15More pstring removal. This one was tricky. I had to addJeremy Allison1-2/+6
one horror (pstring_clean_name()) which will have to remain until I've removed all pstrings from the client code. Jeremy. (This used to be commit 1ea3ac80146b83c2522b69e7747c823366a2b47d)
2007-11-12Remove all pstrings from smbd/chgpasswd.c.Jeremy Allison1-11/+25
Jeremy. (This used to be commit eaf14c701b08e9eff5b94bf57af68cb29142d7fc)
2007-11-11Some pstring removalVolker Lendecke4-40/+61
Hi! Feel free to push :-) Volker From 7fae6b3709a973bd0a5a13d3f5c880c61d5e35de Mon Sep 17 00:00:00 2001 From: Volker Lendecke <vl@sernet.de> Date: Sun, 11 Nov 2007 15:28:59 +0100 Subject: [PATCH] Remove some static pstrings (This used to be commit c3a66b4ee97a902c5cf43c3bb145541849a029ed)
2007-11-11Remove a static fstringVolker Lendecke1-11/+12
Feel free to push :-) Volker (This used to be commit f213556f50de4a28b5c5d2e1e762013837feb722)
2007-11-11Remove a static fstringVolker Lendecke1-1/+1
I'm not sure why this used to be static, to me it seems that every time this variable is overwritten. I just don't see how name_status_find() could return true and not overwrite name. Can someone please review this and potentially check it in? Thanks, Volker (This used to be commit 329c688e4a9e69b71996fd1b0eee2202a849f3f5)
2007-11-09Fix some warningsVolker Lendecke1-1/+2
(This used to be commit 0a1f524e8cce9bbe4fd10467c1f64f7a8862d298)
2007-11-09Remove the silly "user_socket_options" global variableVolker Lendecke1-4/+2
This is better done with a 'lp_do_parameter(-1, "socket options", ..); (This used to be commit 814bed029efa391e664ac432d0d68dfeab26381f)
2007-11-09pstring removalVolker Lendecke1-4/+5
(This used to be commit 0ee896827215a24e70a4ac6bde5ded13f9497296)
2007-11-08Remove more pstring/fstrings.Jeremy Allison1-4/+1
Jeremy. (This used to be commit 7a1de5b44e84a7474e78518c6ba33b3fedc42b5f)
2007-11-08Remove more fstring/pstring bad useage. Go talloc !Jeremy Allison1-20/+24
Jeremy. (This used to be commit 2a0173743d2cf615d52278f3dd87cc804abe2d16)
2007-11-08add win_errstr() as wrapper of dos_errstr().Stefan Metzmacher1-0/+6
this makes merging stuff from samba4 easier metze (This used to be commit cfbdb133b998a704c6c167b9b4b56370f4ff666d)
2007-11-06Ensure we don't use massive writes in pipe mode.Jeremy Allison1-2/+3
Jeremy. (This used to be commit 47640fb20e42f226e7ea104076fd52547bfe1abb)
2007-11-05Remove the horror that was the global smb_rw_error.Jeremy Allison1-11/+12
Each cli struct has it's own local copy of this variable, so use that in client code. In the smbd server, add one static to smbd/proccess.c and use that inside smbd. Fix a bunch of places where smb_rw_error could be set by calling read_data() in places where we weren't reading from the SMB client socket (ie. winbindd). Jeremy. (This used to be commit 255c2adf7b6ef30932b5bb9f142ccef4a5d3d0db)
2007-11-03Remove the smb_read_error global variable and replaceJeremy Allison3-22/+21
it with accessor functions. "One global or pstring a day...." :-). Jeremy. (This used to be commit d50d14c300abc83b7015718ec48acc8b3227a273)
2007-11-02Change the client library to write directly out ofJeremy Allison2-35/+136
the incoming buffer in the non-signed case. Speeds up writes by over 10% or so. Complete the server recvfile implementation. Jeremy. (This used to be commit 81ca5853b2475f123faab3b550f0a7b24ae3c208)
2007-11-01Fix for bug 5021Volker Lendecke1-1/+5
This is a different fix than the bug reporter (Evgeniy Dushistov <dushistov at mail.ru>, thanks!) created, but it lives without the boolean status variable. Untested so far, but I can not add attachments to bugs right now. But to me this looks really obvious. (This used to be commit b481abf5914dcafe5642c4d9394d02603e905bbb)
2007-10-30Our userlevel SMBwriteX call is non-standard in that itJeremy Allison1-8/+10
sometimes uses a 12-word write and doesn't include a pad byte (as Windows does). Fix this so that we are identical to Windows clients. This will make recvfile processing much easier to detect (as we can just read a standard writeX header length to decide). Jeremy. (This used to be commit 3d3d1b806aef3617abaac46daf230ed32076e2ce)
2007-10-29Fix the setup_kaddr() call to cope with IPv6.Jeremy Allison1-8/+34
This is the last obvious change I can see. At this point we can start claiming IPv6 support (Hurrah !:-). Jeremy. (This used to be commit bda8c0bf571c994b524a9d67eebc422033d17094)
2007-10-29Change our DNS code to cope with AAAA records. A6 recordsJeremy Allison2-12/+11
look like a nightmare to use, so ignore them for now. Jeremy. (This used to be commit 814daded90781dc5a5bdd522ea8cfe5d47e6d7a7)
2007-10-27Change all occurrences of zero_addr(&ss,AF_INET) toJeremy Allison5-12/+12
zero_addr(&ss). All current uses were always of the AF_INET form, so simplify the call. If in the future we need to zero an addr to AF_INET6 this can be done separately. Jeremy. (This used to be commit 2e92418a138bf2738b77b7e0fcb2fa37ad84fc0c)
2007-10-26Move the horrible hack for link local addresses out of namequery.cJeremy Allison1-26/+0
and into util_sock.c. is_ipaddress() now copes with link:local:v6%ifname addresses, as does interpret_string_addr(). Jeremy (This used to be commit a3f7db3d30ced566c8340696914f1be3293a9c5b)
2007-10-25Fix resolve name to resolve IPv6 addresses of link-local%ifaddrJeremy Allison1-0/+26
Jeremy. (This used to be commit e6609cab732d5cd5cc9a5ae50aee15147f2ec6ec)
2007-10-25Fix cast typo - would have broken all dgram sends.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 17ea899f39e80241afa235cb933695ba6bae846a)
2007-10-24This is a large patch (sorry). Migrate from struct in_addrJeremy Allison11-694/+999
to struct sockaddr_storage in most places that matter (ie. not the nmbd and NetBIOS lookups). This passes make test on an IPv4 box, but I'll have to do more work/testing on IPv6 enabled boxes. This should now give us a framework for testing and finishing the IPv6 migration. It's at the state where someone with a working IPv6 setup should (theorecically) be able to type : smbclient //ipv6-address/share and have it work. Jeremy. (This used to be commit 98e154c3125d5732c37a72d74b0eb5cd7b6155fd)
2007-10-19Fix a crash in resolve_hosts() caused by an out-of-bounds array reference.Gerald (Jerry) Carter1-1/+2
(This used to be commit fd28d09a95b31bdbc6babd13c5a4ed9fc9ef4bfd)
2007-10-18RIP BOOL. Convert BOOL -> bool. I found a few interestingJeremy Allison39-383/+383
bugs in various places whilst doing this (places that assumed BOOL == int). I also need to fix the Samba4 pidl generation (next checkin). Jeremy. (This used to be commit f35a266b3cbb3e5fa6a86be60f34fe340a3ca71f)
2007-10-18Add net rap file userKarolin Seeger1-1/+4
(This used to be commit 2972c97e5e676964585de930601f083c19080735)
2007-10-15Move to protocol independent code in most of lib/util_sock.cJeremy Allison1-10/+50
We don't use gethostbyname any more except in one case where we're looking for host aliases (I don't know how to do that with getaddrinfo yet). New function should be getaddrinfo(). Next step will be fixing lib/access.c, and then changing libsmb/namequery.c to cope with IPv6 address returns. Jeremy. (This used to be commit 4a56b697b6adcf095e25895c4a9ba3192ed34124)
2007-10-15Add WERR_SERVICE_ALREADY_RUNNING.Günther Deschner1-0/+1
Guenther (This used to be commit 357f00384994946485a5190b6a9c493aeee53cd2)
2007-10-10Add start of IPv6 implementation. Currently most of this is avoidingJeremy Allison6-26/+39
IPv6 in winbindd, but moves most of the socket functions that were wrongly in lib/util.c into lib/util_sock.c and provides generic IPv4/6 independent versions of most things. Still lots of work to do, but now I can see how I'll fix the access check code. Nasty part that remains is the name resolution code which is used to returning arrays of in_addr structs. Jeremy. (This used to be commit 3f6bd0e1ec5cc6670f3d08f76fc2cd94c9cd1a08)
2007-10-10[GLUE] Rsync SAMBA_3_2_0 SVN r25598 in order to create the v3-2-test branch.Gerald (Jerry) Carter15-1100/+112
(This used to be commit 5c6c8e1fe93f340005110a7833946191659d88ab)
2007-10-10r25538: Revert r25533Volker Lendecke1-2/+26
(This used to be commit 1e02208c43cb27ca4b43d268a7f0324f2a9b2cfd)
2007-10-10r25533: remove a pstringVolker Lendecke1-26/+2
(This used to be commit 0f2552e20fb66b0b80006a8a7b999ccf6f54c656)
2007-10-10r25510: Now we're returning the port instead of using a global,Jeremy Allison1-1/+1
remember to use ntohs. Hopefully will fix the build farm. Jeremy. (This used to be commit 5174acccb589edbfbe4ba633f4178f7200d7d6c4)
2007-10-10r25492: Start adding IPv6 compatible code to lib/util_sock.c and deal withJeremy Allison2-216/+333
the ripple effects this causes. utmp has to change etc. Remove some global varables and store address/port in the unexpected db. Jeremy. (This used to be commit 18c6a2211d9e25233d01715b3f78977edcd6d869)
2007-10-10r25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.Gerald Carter4-77/+11
The translate_name() used by cli_session_setup_spnego() cann rely Winbindd since it is needed by the join process (and hence before Winbind can be run). (This used to be commit 00a93ed336c5f36643e6e33bd277608eaf05677c)
2007-10-10r25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,Gerald Carter4-11/+77
and client fixes. Patch from Todd Stetcher <todd.stetcher@isilon.com>. (This used to be commit 8304ccba7346597425307e260e88647e49081f68)
2007-10-10r25227: Patch from "Steven Danneman" <steven.danneman@isilon.com>:Stefan Metzmacher1-0/+14
- We ran across a bug joining our Samba server to a Win2K domain with LDAP signing turned on. Upon investigation I discovered that there is a bug in Win2K server which returns a duplicated responseToken in the LDAP bindResponse packet. This blob is placed in the optional mechListMIC field which is unsupported in both Win2K and Win2K3. You can see RFC 2478 for the proper packet construction. I've worked with metze on this to confirm all these finding. This patch properly parses then discards the mechListMIC field if it exists in the packet, so we don't produce a malformed packet error, causing LDAP signed joins to fail. Also attached is a sniff of the domain join, exposing Win2Ks bad behavior (packet 21). - (I've just changed the scope of the DATA_BLOB mechList) metze (This used to be commit 200b5bfb8180af09446762e915eac63d14c6c7b0)
2007-10-10r25138: More pstring elimination. Add a TALLOC_CTX parameterJeremy Allison1-1/+2
to unix_convert(). Jeremy. (This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
2007-10-10r25032: Contact an off site DC if non is available on site.Lars Müller1-9/+16
(This used to be commit 50879e6de5101b6c5ab8b3fb954f1d2a48530716)
2007-10-10r24981: - Use the formal syntax for calling functions through pointers. ↵Derrell Lipman2-94/+98
I've wanted to make this change for ages, but now with the issue of "open" requiring it, this is the time to just do all of them. Derrell (This used to be commit e746aaaf4db7099252ef048da7857bd488cb681f)
2007-10-10r24969: Fwd port "open" patchSimo Sorce2-3/+3
(This used to be commit 113d62682ae8b045ff0132a743a32f3bc4856d54)
2007-10-10r24864: - Correct failure of libsmbclient against a version of Windows found ↵Derrell Lipman1-24/+2
on a NAS device. The device resets a NBT connection on port 139 when it receives a NetBIOS keepalive request. That request should be supported when NetBIOS is in use; Windows is behaving badly. libsmbclient needs a way to determine if a connection is still alive, and was using a NetBIOS keepalive request if port 139 was in use (on the assumption that it was probably NBT), and getpeername() when port 139 was not being used (assuming naked transport). This patch simplifies the code by exclusively using getpeername() to check whether a connection is still alive. The NetBIOS keepalive request is optional anyway (with preference being given to using TCP mechanisms for the same purpose), so this should be both simpler and more reliable. Derrell (This used to be commit 1f122352b02e3f4be9ac2d638b18807dafd05429)
2007-10-10r24797: Fix logic in dsgetdcname().Günther Deschner1-1/+1
Guenther (This used to be commit aca2d78db139ed32bcedec9861e83cb8c42809cf)
2007-10-10r24782: Fix C++ warningsVolker Lendecke1-3/+4
(This used to be commit f7e8df81ef9e1deadb1251e5e5959e90a4432f40)
2007-10-10r24776: Remove accidentially commited flag checks.Günther Deschner1-8/+0
Guenther (This used to be commit 1efc5009a4b72a5a4c600ca3af7dc7cf05f74353)
2007-10-10r24750: Fix one more caller of name_resolve_bcast().Michael Adam1-1/+3
Michael (This used to be commit 757b5c1bd7ff3d6bbf99753c1b617338ee837531)
generated by cgit (git 2.34.1) at 2024-12-16 09:08:47 +0000