summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2009-03-27[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errnoDerrell Lipman3-1/+15
Fixed. It turns out there were a number of places where cli_resolve_path() was called and the error path upon that function failing did not set errno. There were a couple of places the failure handling code did set errno to ENOENT, so I made them all consistent, although I think better errno choices for this condition exist, e.g. EHOSTUNREACH. Derrell
2009-03-24s3: parse_packet can return NULL which is then dereferenced in ↵Tim Prouty1-0/+2
match_mailslot_name
2009-03-24Fix two memleaks in the encryption codeVolker Lendecke1-1/+2
ntlmssp_seal_packet creates its own signature data blob, which we then have to free. Jeremy, please check and merge appropriately (Yes, I'm asking you to do the janitor work, I want you to *look* at this :-)) Volker
2009-03-24s3:dsgetdcname: use parentheses in if condition to make negation clearBjörn Jacke1-1/+1
Signed-off-by: Günther Deschner <gd@samba.org>
2009-03-23s3:libsmb: use new simplified smb_signing code for the client sideStefan Metzmacher5-686/+204
We store the seqnum/mid mapping in the cli_request structure for async requests and in the cli_state structure for sync calls. We skip the signing check for oplock requests while waiting for async requests coming in. metze
2009-03-23s3:smbd: use new simplified snb_signing code in the serverStefan Metzmacher1-333/+0
We keep the seqnum/mid mapping in the smb_request structure. This also moves one global variable into the smbd_server_connection struct. metze
2009-03-23s3:libsmb: add a much simplified smb_siging infrastructureStefan Metzmacher1-0/+370
It's the job of the caller to maintain the seqnum/mid mapping. Hopefully we can use this code in s4 later too. metze
2009-03-23s3:libsmb: rename smb_signing.c => clisigning.cStefan Metzmacher1-0/+0
This prepares a large simplification of the smb_signing code metze
2009-03-23Fix connect to port 139 only -- thanks gd for bugging me :-)Volker Lendecke1-4/+3
2009-03-20s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).Günther Deschner1-12/+18
Guenther
2009-03-20Fix crash in async_smb.cBo Yang1-3/+6
2009-03-19s3:libsmb: always create bytes array in cli_trans codeStefan Metzmacher1-5/+14
Otherwise we return NO_MEMORY without a reason for fragmented trans requests, as talloc_append_blob() returns buf if we append a 0 length blob. When we pass buf = NULL we'll get back NULL and then assume NO_MEMORY... metze
2009-03-19s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requestsStefan Metzmacher1-23/+7
Before we send the secondary requests we need to remove the old mid=>seqnum mapping and reset cli->mid and make the new mid=>seqnum mapping "persistent". The bug we had in cli_send_trans was this: The first cli_send_smb() incremented cli->mid and the secondary requests used the incremented mid, but as cli->outbuf still had the correct mid, we send the correct mid to the server. The real problem was that the cli_send_smb() function stored the seqnum under the wrong mid. cli_send_nttrans() was totally broken and now follows the same logic as cli_send_trans(). The good thing is that in practice the problem is unlikely to happen, because max_xmit is large enough to avoid secondary requests. metze
2009-03-18Allow DFS client paths to work when POSIX pathnames have beenJeremy Allison1-2/+12
selected (we need to path in pathname /that/look/like/this). Jeremy.
2009-03-18s3: remove POLICY_HND.Günther Deschner2-7/+7
Guenther
2009-03-17Remove the global "struct cm_cred_struct" and associated calls, makeJeremy Allison6-168/+148
callers pass in a struct user_auth_info * instead. This commit causes smbc_set_credentials() to print out a message telling callers to use smbc_set_credentials_with_fallback() instead, as smbc_set_credentials() has a broken API (no SMBCCTX * pointer). No more global variables used in the connection manager API for client dfs calls. Jeremy.
2009-03-16Convert open_socket_out_defer to tevent_reqVolker Lendecke1-22/+37
2009-03-15Fix a malloc/talloc mismatch when cli_initialise() failsVolker Lendecke1-3/+2
2009-03-13Remove pwd_cache.c, it was doing nothing. Make user_name, domain, andJeremy Allison4-78/+95
password talloc'ed strings within the cli_struct. Jeremy.
2009-03-12Remove the static "struct client_connection" mess which is part ofJeremy Allison3-113/+82
the problem that stops libsmbclient being thread safe. Subsidiary DFS connections are now hung off a list inside the cli_state struct. Much more to do in order to get libsmbclient to thread safety, but this is a good start. Jeremy.
2009-03-12Revert "s3:libsmb: add an option to cli_push to let the caller provide the ↵Stefan Metzmacher1-25/+8
buffers" This reverts commit 9579a6f193f570e4ce2af80f4aac7c2f25ae5b22. It's confusing to have a boolean to alter the behavior of cli_push and as the new feature isn't used yet I revert it. We can readd a extra function later. metze
2009-03-10s3:libsmb: add an option to cli_push to let the caller provide the buffersStefan Metzmacher1-8/+25
metze
2009-03-10s3:libsmb: only treat a return 0 as end of fileStefan Metzmacher1-4/+1
metze
2009-03-10s3:libsmb: fix a lot of cli_push() bugsStefan Metzmacher1-95/+107
There were the following problems: 1.) if window_size was a multiple of the chunk_size, we silently dropped the last truncated chunk. 2.) if window_size was 0 pushed only the first chunk to the server and silently dropped the rest. 3.) we had only transferred state->num_reqs writes, even if there would be more data to send. metze
2009-03-07Fix a smbclient segfault against security=share serversVolker Lendecke1-3/+10
2009-03-07Fix some nonempty blank linesVolker Lendecke1-22/+22
2009-03-06s3:libsmb: merge cli_setup_signing_state() into cli_initialise_ex()Stefan Metzmacher1-27/+25
metze
2009-03-06s3:libsmb: remove cli_setup_signing_state() and add struct cli_state ↵Stefan Metzmacher3-7/+10
*cli_initialise_ex() This prepares the next changes. metze
2009-03-06s3:signing: the seqnum should only be decremented by 1 for ntcancel requestsStefan Metzmacher1-2/+4
[MS-SMB] 3.3.5.1 Receiving Any Message says that the seqnum is incremented by only for ntcancel requests for any other request it's by incremented by 2, even if it doesn't expect a response. metze
2009-03-06s3:libsmb: smb signing works the same for extented and non-extended securityStefan Metzmacher1-5/+18
This is only cosmetic, but it makes it easier to understand. metze
2009-02-24Convert name_mangle() to use tallocVolker Lendecke2-8/+32
2009-02-23More warning fixes for Solaris.Jeremy Allison1-1/+1
Jeremy.
2009-02-23Make char* parameters constDerrell Lipman1-16/+6
- Use const in function signatures whenever appropriate, to help prevent errant scribbling on users' buffers. smbc_set_credentials() always acted as if its formal parameters were const char *, and changing the formal declaration to specify that should not cause any change to the ABI. It is still allowable to pass a writable buffer to a function which specifies that it will not write to the buffer. I'm making this change only in master. Derrell
2009-02-21Remove the static "chal" from ntlmssp.c:get_challenge()Volker Lendecke1-7/+5
2009-02-21Move some bytes from the data to the text segmentVolker Lendecke1-3/+3
2009-02-20Change smbc_set_credentials_with_fallback() (unreleased) to useJeremy Allison1-7/+14
const approptiately. Jeremy.
2009-02-20variable grouping: just my OCD desire to keep similar things togetherDerrell Lipman1-5/+7
2009-02-20Make libsmbclient work with DFSBo Yang6-6/+96
Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
2009-02-19s3: Add extid to the dev/inode pairTim Prouty1-12/+27
This extends the file_id struct to add an additional generic uint64_t field: extid. For backwards compatibility with dev/inodes stored in xattr_tdbs and acl_tdbs, the ext id is ignored for these databases. This patch should cause no functional change on systems that don't use SMB_VFS_FILE_ID_CREATE to set the extid. Existing code that uses the smb_share_mode library will need to be updated to be compatibile with the new extid.
2009-02-19Interesting C compiler you have there... :-)Volker Lendecke1-1/+1
2009-02-18Fix coverity CID-602. Possible use of uninitialized var.Jeremy Allison1-1/+1
Jeremy.
2009-02-17Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin ↵Jeremy Allison1-0/+5
<gmachin@sandia.gov>. Jeremy.
2009-02-14remove accidental white spaceDerrell Lipman1-1/+0
2009-02-14Get rid of the warnings I had for testingDerrell Lipman1-5/+0
2009-02-14It seems some systems use f_flags instead of f_flag. Use the appropriate one.Derrell Lipman1-4/+11
2009-02-14f_frsize field is not ubiquitous. Check for it.Derrell Lipman1-0/+4
2009-02-14The f_fsid field is not always an integer type. Don't set it in that case.Derrell Lipman1-0/+5
2009-02-14Ensure consistency of values on stack (caught by AIX compiler)Derrell Lipman1-16/+16
2009-02-14Check for the right error return valueDerrell Lipman1-2/+3
2009-02-14[Bug 6069] Add a fstatvfs function for libsmbclientDerrell Lipman2-4/+4
- Revert Tim's changes for the moment. I need to see what the issue is and arrange to use "struct statvfs" if at all possible. Derrell