summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2008-04-11Cleanup size_t return values in convert_string_allocateTim Prouty1-2/+3
This patch is the first iteration of an inside-out conversion to cleanup functions in charcnv.c returning size_t == -1 to indicate failure. (This used to be commit 59124382d2894a1b194b48dd82bc5f956959eb48)
2008-04-10Add some more cli_cm_set_X functions.Günther Deschner1-1/+52
Guenther (This used to be commit 882475f5566592b3a675d3609c3af8cf7d4e256d)
2008-04-08Add CLI_FULL_CONNECTION_FALLBACK_AFTER_KERBEROS define.Günther Deschner1-0/+5
This allows to switch on the cli->fallback_after_kerberos switch. Guenther (This used to be commit 15ba45e567d910c1b2336dcc0c475e12b082f30f)
2008-04-07Fix Kerberos interop with Mac OS X 10.5 clients.Bill Ricker1-0/+12
Ignore optional req_flags. Use the Kerberos mechanism OID negotiated with the client rather than hardcoding OID_KERBEROS5_OLD. (This used to be commit 59a2bcf30fef14ecc826271862b645dd3a61cb48)
2008-04-07Use bool for BOOL and true/false for True/False. We need lowercaseJames Peach1-63/+76
bool to get the declarations picked up by the prototype parser. (This used to be commit fd168e7b5065ba15b1cf56522b6810b8e6fdd7d5)
2008-04-07Fix a misleading debug messageVolker Lendecke1-2/+3
(This used to be commit 494b32197f0872b115f0cd1a35421d00a89360a6)
2008-04-04When using plaintext ucs2 passwords clistr_push calls ucs2_align, which causesJeremy Allison1-3/+9
the space taken by the unicode password to be one byte too long (as we're on an odd byte boundary here). Reduce the count by 1 to cope with this. Fixes smbclient against NetApp servers which can't cope. Fix from bryan.kolodziej@allenlund.com in bug #3840. Jeremy. (This used to be commit 1e7e7d86a1ae1cd2c3cc3de9f36b7326ad249b82)
2008-04-04Always uppercase cli->srv_name_slash.Günther Deschner1-0/+1
Not that I think it is of any importance... Guenther (This used to be commit 352f8440c74bc22416e21783e1dc5fecf5869902)
2008-04-03Add NT_STATUS_RPC_CANNOT_SUPPORT.Günther Deschner1-0/+1
Guenther (This used to be commit 9e15ce03ca66a0b5ffdb39dd2faaad6e0f967e31)
2008-04-02Apply some const in clirap.Günther Deschner1-1/+1
Guenther (This used to be commit 8a1a9f967db25d3928f19e46d60af249f934f323)
2008-04-02Fix NETLOGON credential chain with Windows 2008 all over the place.Günther Deschner1-1/+1
In order to avoid receiving NT_STATUS_DOWNGRADE_DETECTED from a w2k8 netr_ServerAuthenticate2 reply, we need to start with the AD netlogon negotiate flags everywhere (not only when running in security=ads). Only for NT4 we need to do a downgrade to the returned negotiate flags. Tested with w2k8, w2ksp4, w2k3r2 and nt4sp6. Guenther (This used to be commit 0970369ca0cb9ae465cff40e5c75739824daf1d0)
2008-03-28Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.Jeremy Allison1-1/+3
Jeremy. (This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)
2008-03-28Add a talloc context parameter to current_timestring() to fix memleaks.Michael Adam1-1/+1
current_timestring used to return a string talloced to talloc_tos(). When called by DEBUG from a TALLOC_FREE, this produced messages "no talloc stackframe around, leaking memory". For example when used from net conf. This also adds a temporary talloc context to alloc_sub_basic(). For this purpose, the exit strategy is slightly altered: a common exit point is used for success and failure. Michael (This used to be commit 16b5800d4e3a8b88bac67b2550d14e0aaaa302a9)
2008-03-28More ssize_t->SMB_OFF_TVolker Lendecke1-5/+5
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)
2008-03-28Check for buffer in decode_wkssvc_join_password_buffer.Günther Deschner1-1/+10
Guenther (This used to be commit 2134d80c05fd7a37f44317335b40d7961c429c7b)
2008-03-28Remove unneeded pack_dsdcinfo/unpack_dsdcinfo.Günther Deschner1-144/+0
Guenther (This used to be commit 34dd8f32e1b7fe256ab5dfde5ef5bb8abeec121a)
2008-03-28Use NDR for netr_DsRGetDCNameInfo un-/marshalling in dsgetdcname.Günther Deschner1-16/+26
Guenther (This used to be commit 7fa53911054a39681df3f08d19aad92f60d59e28)
2008-03-25Fix a valgrind errorVolker Lendecke1-1/+1
In winbind, we're using the info3 struct to send it to the winbind client after netsamlogon_cache_store. Without this info3->base.account_name.string was prematurely freed. (This used to be commit aa4377561b691e2c5108c18aeb34fff39d8775df)
2008-03-21On Solaris, size_t seems to be only 32 bit.Volker Lendecke1-5/+7
Fix bug 5341, thanks a lot to Karoly Vegh for testing it! Volker (This used to be commit 19eb8c9316b10b1277121e90d0d3ef50ee562118)
2008-03-20Add error mapping for WERR_SERVICE_NEVER_STARTED.Günther Deschner1-0/+1
Guenther (This used to be commit 818044d877597ba5c11dc7f30bab929c4b41db89)
2008-03-19!NT_STATUS_IS_OK != NT_STATUS_IS_ERRVolker Lendecke1-1/+1
When reading from a pipe, Windows return STATUS_BUFFER_OVERFLOW which is *not* an error. (This used to be commit 24018d882d1b1cfece47c533fe5bbca91de124cc)
2008-03-18Fix bug 5334Volker Lendecke1-0/+8
I did not test with a zero length file :-) (This used to be commit 7d7a73944c2dcf078f7bc8de65d575f32f9aa851)
2008-03-17Fix use of AuthDataWithContext capabilityDerrell Lipman2-5/+20
During my initial plans for, and the subsequent discussion of a more significant change to the API for libsmbclient, I had removed the AuthDataWithContext usage, in favor of a more generalized planned interface. When the API returned to its original state, I neglected to reinsert this code. Use of an authentication function with the context can be tested using examples/libsmbclient/testbrowse -C Derrell (This used to be commit 38eab68dfb2d8abe8ad00f5a86fc54c778d0d303)
2008-03-15Fix Coverity ID 555Volker Lendecke1-0/+1
(This used to be commit 44122f06d02492a7a0a37413d6f975c3b1e3c283)
2008-03-12For convenience reasons, always create cli->srv_name_slash in the rpc_client.Günther Deschner1-0/+1
Guenther (This used to be commit 6363c383d6989d2dfb2ee488ffa7aeb128c5385b)
2008-03-10Use rpccli_srvsvc_NetShareEnumAll in libsmbclient.Günther Deschner1-17/+23
Guenther (This used to be commit 6aad05f3f12fd6b3276486f60c10f5b3fd3fa17c)
2008-03-10Remove insane amount of whitespace.Günther Deschner1-368/+368
Guenther (This used to be commit 8216310e9f0d7dcccfe761a184a014b7b2ce03c5)
2008-03-08Correctly calculate the max read sizeVolker Lendecke1-1/+1
(This used to be commit f556c9e162e2bc0d16710e994a00edc33a146cd5)
2008-03-08Move inbuf handling to before the PDU handlingVolker Lendecke1-58/+59
In an error case, correctly discard the offending PDU (This used to be commit 0aa195b5d623e1f26f2a1b9e91323a5ddd3ff282)
2008-03-08Pass specific packets to build_nmb and build_dgramVolker Lendecke1-6/+4
To me it was not clear what parts of struct packet_struct are actually used in build_packet(). This makes it a bit more clear that only the specific parts are used. (This used to be commit eb8b6f2404e49d6a837935c5b411d78fb6ff23ef)
2008-03-08Fix some typosVolker Lendecke1-2/+2
(This used to be commit cfa1b838144800c0758969921b8904fd62e46c07)
2008-03-06Eliminate global variable in_client and a plethora of extern declarations.Derrell Lipman1-3/+1
Derrell (This used to be commit b7f34e7ef2907b498a0645ce68f2773ed7d60cdc)
2008-03-06Fix a "nested extern declaration" warningVolker Lendecke1-1/+2
(This used to be commit e473e6d50c56f52ef5e4853e4ca3b3548af06f51)
2008-03-06Check for NULL pointers before dereferencing them.Derrell Lipman1-4/+4
(This used to be commit 6f65390cec218a6aac4370ee381f30439617dcec)
2008-03-06Convert cli_read to use cli_pullVolker Lendecke1-163/+15
(This used to be commit d69b20111a849152a7d9108763207c813bf9068b)
2008-03-06Add async cli_pull supportVolker Lendecke1-0/+425
This is the big (and potentially controversial) one. It took a phone call to explain to metze what is going on inside cli_pull_read_done, but I would really like everybody to understand this function. It is a very good and reasonably complex example of async programming. If we want more asynchronism in s3, this is what we will have to deal with :-) Make use of it in the smbclient "get" command. Volker (This used to be commit 76f9b360ee1d973630d82d401eeddce858189301)
2008-03-06Add infrastructure to support async SMB requestsVolker Lendecke1-0/+483
(This used to be commit e2153301351559f30f2714345f4c1ca6c5f1a45f)
2008-03-06Check the right pointer for non-NULLVolker Lendecke1-1/+1
Fix Coverity ID 558, 559 (This used to be commit 8e33d19d93ef57a9438aad085aaf04b7c09fe09b)
2008-03-03Continued revamping of libsmbclient.Derrell Lipman10-1043/+1091
- James suggested using gcc's "deprecated" attribute to mark the context structure fields to generate warnings. This creates a scenario with the best of all worlds. I'm able to move to an organization that more easily allows future enhancements, while avoiding any mandatory changes by applications. Thanks, James! - Updated WHATSNEW.txt so that it accurately reflects the current state of affairs. Derrell (This used to be commit a67f96fbe9683b46c2149f7cb439d13f7f0e6ecd)
2008-03-01Return NULL, not 0, from a function which returns a pointer.Derrell Lipman2-3/+2
(This used to be commit 23cb9c49e3724cecaa66655ef64c3111bf14c552)
2008-03-01Additional revamped libsmbclient documentationDerrell Lipman11-2050/+2232
- Ensured that all public functions have documentation in libsmbclient.h - Reformatted for "proper" indentation - Re-added temporarily-disabled alternate authentication function capability Derrell (This used to be commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
2008-03-01Modified revamp of the libsmbclient interface.Derrell Lipman9-227/+272
Given the tacit (if that) approval by some people, and clear disapproval by others for my proposed clean-up and reorganization of libsmbclient, I've come up with a slightly different approach. This commit changes back to the original libsmbclient.h SMBCCTX structure which will maintain ABI compatibility. I retain, here, the setter and getter functions which all new code should use. Older programs already compiled should continue to work fine. Older programs being recompiled will encounter compile-time errors (intentionally!) so that the code can be corrected to use the setter/getter interfaces. Although this doesn't clean up the interface in the way I had wanted, the code reorganization and requirement for new programs to use the setters and getters allows future progress to be made on libsmbclient without further muddying up the interface, while retaining the ABI compatibility that was the big issue causing disapproval. I hope that this compromise is adequate. Derrell (This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
2008-03-01Initial revamp of the libsmbclient interface.Derrell Lipman12-7397/+8385
The libsmbclient interface has suffered from difficulty of improvement and feature enrichment without causing ABI breakage. Although there were a number of issues, the primary ones were: (a) the user of the library would manually manipulate the context structure members, meaning that nothing in the context structure could change other than adding stuff at the end; (b) there were three methods of setting options: setting bits in a flags field within the context structure, setting explicit options variables within an options structure in the context structure, and by calling the smbc_option_set() function; (c) the authentication callback did not traditionally provide enough information to the callee which required adding an option for a callback with a different signature, and now there are requests for even more information at the callback, requiring yet a third signature and option to set it (if we implement that feature). This commit provides a reorganization of the code which fixes (a) and (b). The context structure is now entirely opaque, and there are setter and getter functions for manipulating it. This makes maintaining ABI consistency much, much easier. Additionally, the options setting/getting has been unified into a single mechanism using smbc_option_set() and smbc_option_get(). Yet to be completed is a refactoring of the authentication callback (c). The test programs in examples/libsmbclient have been modified (if necessary; some applications require no changes at all) for the new API and a few have been minimally tested. Derrell (This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
2008-03-01Revert "Add infrastructure to support async SMB requests"Volker Lendecke1-483/+0
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81. (This used to be commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
2008-03-01Revert "Add async cli_pull support"Volker Lendecke1-425/+0
This reverts commit 844a163458c7585e4306a21ffdae5d08e03d6e4d. (This used to be commit 5ab1cfda500de07ff3c712442ab2fc74eecc8886)
2008-03-01Revert "Convert cli_read to use cli_pull"Volker Lendecke1-15/+163
This reverts commit 719527f55e88f0c5fdceda5c807475aba299c79f. (This used to be commit ac301fada257e2d3b50148109a3d44fa1421b0b4)
2008-02-29Restore 3.0 behaviour with empty /etc/hostsVolker Lendecke1-2/+5
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail without filling in anything useful. Worked fine. Without this patch and a empty /etc/hosts and no DNS configured, session setup would return NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik is only ever returned from tcon normally. This restores the 3.0 behaviour. Comments? Volker (This used to be commit 2bd3b7d474768f842921945d283eac10da2a1684)
2008-02-29Check the right variable for being NULLVolker Lendecke1-1/+1
(This used to be commit f2c67803792f1fd3929e922c1f626f8247e08992)
2008-02-28Fix memleak in netsamlogon_cache_get().Günther Deschner1-0/+1
Guenther (This used to be commit b736c77dc6c36dcdb601903fadf0ef7f163052a3)
2008-02-28Convert cli_read to use cli_pullVolker Lendecke1-163/+15
(This used to be commit 719527f55e88f0c5fdceda5c807475aba299c79f)
generated by cgit (git 2.34.1) at 2024-12-23 13:18:08 +0000