summaryrefslogtreecommitdiff
path: root/source3/libsmb
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r24864: - Correct failure of libsmbclient against a version of Windows found ↵Derrell Lipman1-24/+2
on a NAS device. The device resets a NBT connection on port 139 when it receives a NetBIOS keepalive request. That request should be supported when NetBIOS is in use; Windows is behaving badly. libsmbclient needs a way to determine if a connection is still alive, and was using a NetBIOS keepalive request if port 139 was in use (on the assumption that it was probably NBT), and getpeername() when port 139 was not being used (assuming naked transport). This patch simplifies the code by exclusively using getpeername() to check whether a connection is still alive. The NetBIOS keepalive request is optional anyway (with preference being given to using TCP mechanisms for the same purpose), so this should be both simpler and more reliable. Derrell (This used to be commit 1f122352b02e3f4be9ac2d638b18807dafd05429)
2007-10-10r24797: Fix logic in dsgetdcname().Günther Deschner1-1/+1
Guenther (This used to be commit aca2d78db139ed32bcedec9861e83cb8c42809cf)
2007-10-10r24782: Fix C++ warningsVolker Lendecke1-3/+4
(This used to be commit f7e8df81ef9e1deadb1251e5e5959e90a4432f40)
2007-10-10r24776: Remove accidentially commited flag checks.Günther Deschner1-8/+0
Guenther (This used to be commit 1efc5009a4b72a5a4c600ca3af7dc7cf05f74353)
2007-10-10r24750: Fix one more caller of name_resolve_bcast().Michael Adam1-1/+3
Michael (This used to be commit 757b5c1bd7ff3d6bbf99753c1b617338ee837531)
2007-10-10r24749: Increase debuglevel.Günther Deschner1-1/+1
Guenther (This used to be commit d82c1638b8ada43cfcbf9f71586c4c6849902c7e)
2007-10-10r24742: Add experimental DsGetDcName() call (will be used by krb5 locator ↵Günther Deschner1-0/+955
for fine grained KDC DNS queries). Guenther (This used to be commit 3263cd680fe429430d789b284464fca72ef45719)
2007-10-10r24739: With resolve_ads() allow to query for PDCs as well.Günther Deschner1-6/+20
Also add dns query functions to find GCs and DCs by GUID. Guenther (This used to be commit cc469157f6684ec507bf1c3a659fc36a53d304a1)
2007-10-10r24737: Remove older TODO: Convert internal_resolve_name() and friends to ↵Günther Deschner2-97/+136
NTSTATUS. Guenther (This used to be commit 8300aac4944613e411a78ab98de5d77f8fd38fa7)
2007-10-10r24543: Apply missing portion of correction for bug 4750Derrell Lipman1-0/+5
(This used to be commit 5a83c306bb80b492a3c3d5e86b0767dc45e5c262)
2007-10-10r24466: - Sort ACEs according to http://support.microsoft.com/kb/269175 so thatDerrell Lipman1-10/+72
Windows Explorer doesn't complain about the order (and so that they get interpreted properly). Derrell (This used to be commit 8f371e2ea97a3b58d1c7c3aa1368a0904295f681)
2007-10-10r24462: - Removing all ACEs was causing removal of the DACL entirely. ↵Derrell Lipman1-4/+0
Win2000 ignored the request, presumably due to the PROTECTED flag not being set. Setting that flag (in make_sec_desc()) has much wider implications than just to libsmbclient, so instead of modifying that, we'll remove security descriptors by setting the number of ACEs to zero. At some point, we might want to look into whether we should actually be setting the PROTECTED flag in the DACL. Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true Derrell (This used to be commit 319df380e579fd860348a8f08a584e13161dde9d)
2007-10-10r24410: - I got tricked by function naming. Contrary to what seemed obvious ↵Derrell Lipman1-4/+0
to me, prs_mem_free() is not the function to be called to free memory allocated by prs_alloc_mem(). I've added a comment so others may not get bitten too. - Remove incorrect memory free calls added yesterday to replace SAFE_FREE. The memory is actually now on a talloc context, so gets freed by the caller when that context is freed. We don't need to free it iternally. Derrell (This used to be commit 2fde343150c17959fc970b18e1eb4efde800b4db)
2007-10-10r24388: - ACL retrieval provided incomplete information because the buffer ↵Derrell Lipman1-9/+22
pointer was incremented too far in some circumstances. In these cases, only the first of multiple concatenated strings would be seen. - Working on bug 4649 pertaining to delete an ACL, this fixes the reported crash. It appears to have been an incomplete switchover from malloc to talloc, as the memory was still being freed with SAFE_FREE. Deleting ACLs still doesn't work. Although a valid request is sent to the server and a SUCCESS response is returned, the method that's used in libsmbclient for deleting ACLs seems to be incorrect. In looking at the samba4 torture tests, it appears that we should be turning on the INHERIT flag if we want to delete the ACL. (I could use some assistance on the proper flags to send, from anyone familiar with this stuff.) - Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not returning a value useful to smbc_lseekdir_ctx(). Derrell (This used to be commit 2ac502e29bd8390252fe4ae8344faab49ca01ff5)
2007-10-10r24281: Fix bug found by Herb. The vuid entry in the cli_state structure getsJeremy Allison1-0/+4
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try to authenticate as the user in cli_session_setup this returns an error "Bad userid" (as seen in wireshark). "We should only leave cli->vuid != 0 on success. Looks like it's getting set in the cli_session_setup_blob_receive() call and not cleared again on error." Jeremy. (This used to be commit fa8e66dd8d2c68b91b27169c3c43820989f58758)
2007-10-10r24223: Convert reply_echo to the new APIVolker Lendecke1-7/+13
(This used to be commit 4863ff2899419e791ed0e340821072d004fb1d17)
2007-10-10r24133: Explicitly pass flags2 down to push_string_fnVolker Lendecke1-3/+11
This needs a bit closer review, it also touches the client libs (This used to be commit 824eb26738d64af1798d319d339582cf047521f0)
2007-10-10r23991: Some constVolker Lendecke1-1/+1
(This used to be commit 804be77e4695eb923048948dbc6e223967fdef94)
2007-10-10r23986: Some constVolker Lendecke1-5/+13
(This used to be commit dc6f4bdb7f5fc0fd4cd9f687c47af3719985da8b)
2007-10-10r23893: add dummy callbacks for LDAP SASL wrapping,Stefan Metzmacher1-0/+4
they're not used yet... metze (This used to be commit a3b97cdce719d9d5e82f26096c0e8c3a86ff3965)
2007-10-10r23888: move elements belonging to the current ldap connection to aStefan Metzmacher1-2/+2
substructure. metze (This used to be commit 00909194a6c1ed193dfdb296f50f58a53450583c)
2007-10-10r23801: The FSF has moved around a lot. This fixes their Mass Ave address.Andrew Tridgell5-10/+5
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10r23798: updated old Temple Place FSF addresses to new URLAndrew Tridgell2-4/+2
(This used to be commit c676a971142d7176fd5dbf21405fca14515a0a76)
2007-10-10r23790: LGPLv3+ conversion for our LGPLv2+ library codeAndrew Tridgell1-1/+1
(This used to be commit 1b78cace504f60c0f525765fbf59d9cc6506cd4d)
2007-10-10r23784: use the GPLv3 boilerplate as recommended by the FSF and the license textAndrew Tridgell44-88/+44
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10r23779: Change from v2 or later to v3 or later.Jeremy Allison50-50/+50
Jeremy. (This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The nextVolker Lendecke3-11/+17
checkin will pull this up to srvstr_get_path. At that point we can get more independent of the inbuf, the base_ptr in pull_string will only be used to satisfy UCS2 alignment constraints. (This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)
2007-10-10r23723: Alexander Larsson pointed me at a missing mapping in clierror.cSimo Sorce1-1/+3
When renaming a file across 2 filesystem a samba server returns NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV, and the generic EINVAL is returned instead. This should fix it, Jeremy or Derrel please check if this is ok. (This used to be commit b35038fa4e3e69f1397758497a46dc0d37edee79)
2007-10-10r23710: Remove some code duplication, we do have a random number generatorVolker Lendecke1-7/+3
(This used to be commit afd7febd980bb000f81d5251d03d500cb43c39f4)
2007-10-10r23651: Always, always, always compile before commit...Günther Deschner1-1/+1
Guenther (This used to be commit accb40446ad3f872c5167fc2306d892553293b7b)
2007-10-10r23650: Fix remaining callers of krb5_kt_default().Günther Deschner1-3/+3
Guenther (This used to be commit b9d7a2962a472afb0c6b8e3ac5c2c819d4af2b39)
2007-10-10r23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).Günther Deschner1-1/+137
Guenther (This used to be commit 19020d19dca7f34be92c8c2ec49ae7dbde60f8c1)
2007-10-10r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().Günther Deschner1-1/+1
Guenther (This used to be commit e9a7512a9f630340004913f1379452eea8a9b6ae)
2007-10-10r23624: Merge dos error code from samba4 (returned from dfs_Enum against ↵Günther Deschner1-0/+1
w2k3 as soon as a one DFS_VOLUME_FLAVOR_AD_BLOB dfsroot exists). Guenther (This used to be commit 837b0a14c430faa4e4cada03a1efe2823a7b2e2e)
2007-10-10r23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().Günther Deschner1-38/+26
Thanks Volker for the pointer hint :) Guenther (This used to be commit eb1ec508ace3a5eeb53cf47be44047bd9228cd19)
2007-10-10r23588: Some more cleanups and error checks in the krb5 renew function.Günther Deschner1-6/+12
Guenther (This used to be commit 277e07c8553e2ed20bc95493cdc996be43feb6bd)
2007-10-10r23587: Cleanup redundant code in the krb5 renew function.Günther Deschner1-23/+16
Guenther (This used to be commit 0b9acc8610ae2ba9c42168e9ceb2e9ea8bc2f5bd)
2007-10-10r23586: Fix heimdal path in the krb5 renew routine when we need to compose ↵Günther Deschner1-1/+5
the tgt string ourselves. Guenther (This used to be commit 1e4a7af99303fb17ebca499ff7e0a017a2017754)
2007-10-10r23582: Fix event based krb5 ticket refreshing in winbindd.Günther Deschner1-5/+5
We were incorrectly using the renew_till timestamp instead of the renewed ticket's endtime to calculate the next refreshing date. Guenther (This used to be commit aa3511a5b5e6a96a02110a7ad0ab1d43e6d25766)
2007-10-10r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.Jeremy Allison4-28/+35
Long overdue fix.... Jeremy. (This used to be commit 073fdc5a58139796dbaa7ea9833dca5308f11282)
2007-10-10r23510: Tidy calls to smb_panic by removing trailing newlines. Print theJames Peach1-8/+15
failed expression in SMB_ASSERT. (This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)
2007-10-10r23347: Fix Coverity 363. Dead code elimination.Jeremy Allison1-7/+3
Jeremy. (This used to be commit 4524ee2dbcd5c1c66085032de67c6d083f91cb8a)
2007-10-10r23224: Move map_nt_error_from_unix to lib/errmap_unix.c. This function isVolker Lendecke1-63/+0
useful even in binaries that don't link in libsmb (This used to be commit 52545d119277b42a46d13b5b031c85f47d96b84c)
2007-10-10r23183: Check in a change made by Tridge:Volker Lendecke1-6/+6
This replaces the internal explicit dev/ino file id representation by a "struct file_id". This is necessary as cluster file systems and NFS don't necessarily assign the same device number to the shared file system. With this structure in place we can now easily add different schemes to map a file to a unique 64-bit device node. Jeremy, you might note that I did not change the external interface of smb_share_modes.c. Volker (This used to be commit 9b10dbbd5de8813fc15ebbb6be9b18010ffe8139)
2007-10-10r23148: Fix old old bug in cli_smbwrite() (not incrementingJeremy Allison1-1/+1
data being sent). Patch from mnix@wanm.com.au. Jeremy. (This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)
2007-10-10r23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx,Günther Deschner1-1/+5
netr_DsRGetDCNameEx2) and add new ds request and reply flags, also add some more WERROR codes. Guenther (This used to be commit 37ae7f419702c563bcd0d9c27c02bde7efd34dd7)
2007-10-10r23001: - Fix but #4634. Type of the size parameter to getpeername was wrong.Derrell Lipman1-1/+1
(This used to be commit 6675c8acf1d83b7131d38f09f381062b6a604c7e)
2007-10-10r22950: Fix the issue Volker reported here :Jeremy Allison2-28/+2
"Attempt to fix some build farm failures: On port 139 the first successful packet gives len==0 from the server, so the = in if (len <= 0) { in line 136 of clientgen.c throws a failure." The irritating thing is that I already had it correct in SAMBA_3_0_26 and forgot to merge the change across. len == 0 is a valid return - I messed that up when converting client_receive_smb() to return a length rather than a BOOL. Doh ! Jeremy. (This used to be commit a398bdf08d9efac51af28aed29f2c0f151cd5aad)
2007-10-10r22930: Next attempt to get the build farm in line.Volker Lendecke1-1/+2
Jeremy, please check this and merge if appropriate. (This used to be commit 0bdf4f1a5937abd0ef266700115d74396bc1629c)
2007-10-10r22929: Attempt to fix some build farm failures: On port 139 the firstVolker Lendecke2-1/+27
successful packet gives len==0 from the server, so the = in if (len <= 0) { in line 136 of clientgen.c throws a failure. Jeremy, please fix this properly, I'm not merging this to 3_0_26 so that you can filter it when you merge. Volker (This used to be commit 9c5111d8c5064a43762d7d0146acff5e7691dafd)