Age | Commit message (Collapse) | Author | Files | Lines |
|
-
We ran across a bug joining our Samba server to a Win2K domain with LDAP
signing turned on. Upon investigation I discovered that there is a bug
in Win2K server which returns a duplicated responseToken in the LDAP
bindResponse packet. This blob is placed in the optional mechListMIC
field which is unsupported in both Win2K and Win2K3. You can see RFC
2478 for the proper packet construction. I've worked with metze on this
to confirm all these finding.
This patch properly parses then discards the mechListMIC field if it
exists in the packet, so we don't produce a malformed packet error,
causing LDAP signed joins to fail. Also attached is a sniff of the
domain join, exposing Win2Ks bad behavior (packet 21).
-
(I've just changed the scope of the DATA_BLOB mechList)
metze
(This used to be commit 200b5bfb8180af09446762e915eac63d14c6c7b0)
|
|
to unix_convert().
Jeremy.
(This used to be commit 39c211a702e91c34c1a5a689e1b0c4530ea8a1ac)
|
|
(This used to be commit 50879e6de5101b6c5ab8b3fb954f1d2a48530716)
|
|
I've wanted
to make this change for ages, but now with the issue of "open" requiring it,
this is the time to just do all of them.
Derrell
(This used to be commit e746aaaf4db7099252ef048da7857bd488cb681f)
|
|
(This used to be commit 113d62682ae8b045ff0132a743a32f3bc4856d54)
|
|
on a NAS
device. The device resets a NBT connection on port 139 when it receives a
NetBIOS keepalive request. That request should be supported when NetBIOS is
in use; Windows is behaving badly.
libsmbclient needs a way to determine if a connection is still alive, and
was using a NetBIOS keepalive request if port 139 was in use (on the
assumption that it was probably NBT), and getpeername() when port 139 was
not being used (assuming naked transport).
This patch simplifies the code by exclusively using getpeername() to check
whether a connection is still alive. The NetBIOS keepalive request is
optional anyway (with preference being given to using TCP mechanisms for the
same purpose), so this should be both simpler and more reliable.
Derrell
(This used to be commit 1f122352b02e3f4be9ac2d638b18807dafd05429)
|
|
Guenther
(This used to be commit aca2d78db139ed32bcedec9861e83cb8c42809cf)
|
|
(This used to be commit f7e8df81ef9e1deadb1251e5e5959e90a4432f40)
|
|
Guenther
(This used to be commit 1efc5009a4b72a5a4c600ca3af7dc7cf05f74353)
|
|
Michael
(This used to be commit 757b5c1bd7ff3d6bbf99753c1b617338ee837531)
|
|
Guenther
(This used to be commit d82c1638b8ada43cfcbf9f71586c4c6849902c7e)
|
|
for fine
grained KDC DNS queries).
Guenther
(This used to be commit 3263cd680fe429430d789b284464fca72ef45719)
|
|
Also add dns query functions to find GCs and DCs by GUID.
Guenther
(This used to be commit cc469157f6684ec507bf1c3a659fc36a53d304a1)
|
|
NTSTATUS.
Guenther
(This used to be commit 8300aac4944613e411a78ab98de5d77f8fd38fa7)
|
|
(This used to be commit 5a83c306bb80b492a3c3d5e86b0767dc45e5c262)
|
|
Windows Explorer doesn't complain about the order (and so that they get
interpreted properly).
Derrell
(This used to be commit 8f371e2ea97a3b58d1c7c3aa1368a0904295f681)
|
|
Win2000 ignored
the request, presumably due to the PROTECTED flag not being set. Setting
that flag (in make_sec_desc()) has much wider implications than just to
libsmbclient, so instead of modifying that, we'll remove security
descriptors by setting the number of ACEs to zero. At some point, we might
want to look into whether we should actually be setting the PROTECTED flag
in the DACL.
Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true
Derrell
(This used to be commit 319df380e579fd860348a8f08a584e13161dde9d)
|
|
to me,
prs_mem_free() is not the function to be called to free memory allocated by
prs_alloc_mem(). I've added a comment so others may not get bitten too.
- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
The memory is actually now on a talloc context, so gets freed by the caller
when that context is freed. We don't need to free it iternally.
Derrell
(This used to be commit 2fde343150c17959fc970b18e1eb4efde800b4db)
|
|
pointer was
incremented too far in some circumstances. In these cases, only the first
of multiple concatenated strings would be seen.
- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
crash. It appears to have been an incomplete switchover from malloc to
talloc, as the memory was still being freed with SAFE_FREE.
Deleting ACLs still doesn't work. Although a valid request is sent to the
server and a SUCCESS response is returned, the method that's used in
libsmbclient for deleting ACLs seems to be incorrect. In looking at the
samba4 torture tests, it appears that we should be turning on the INHERIT
flag if we want to delete the ACL. (I could use some assistance on the
proper flags to send, from anyone familiar with this stuff.)
- Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not
returning a value useful to smbc_lseekdir_ctx().
Derrell
(This used to be commit 2ac502e29bd8390252fe4ae8344faab49ca01ff5)
|
|
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
(This used to be commit fa8e66dd8d2c68b91b27169c3c43820989f58758)
|
|
(This used to be commit 4863ff2899419e791ed0e340821072d004fb1d17)
|
|
This needs a bit closer review, it also touches the client libs
(This used to be commit 824eb26738d64af1798d319d339582cf047521f0)
|
|
(This used to be commit 804be77e4695eb923048948dbc6e223967fdef94)
|
|
(This used to be commit dc6f4bdb7f5fc0fd4cd9f687c47af3719985da8b)
|
|
they're not used yet...
metze
(This used to be commit a3b97cdce719d9d5e82f26096c0e8c3a86ff3965)
|
|
substructure.
metze
(This used to be commit 00909194a6c1ed193dfdb296f50f58a53450583c)
|
|
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
|
|
(This used to be commit c676a971142d7176fd5dbf21405fca14515a0a76)
|
|
(This used to be commit 1b78cace504f60c0f525765fbf59d9cc6506cd4d)
|
|
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
|
|
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
|
|
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
(This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)
|
|
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.
(This used to be commit b35038fa4e3e69f1397758497a46dc0d37edee79)
|
|
(This used to be commit afd7febd980bb000f81d5251d03d500cb43c39f4)
|
|
Guenther
(This used to be commit accb40446ad3f872c5167fc2306d892553293b7b)
|
|
Guenther
(This used to be commit b9d7a2962a472afb0c6b8e3ac5c2c819d4af2b39)
|
|
Guenther
(This used to be commit 19020d19dca7f34be92c8c2ec49ae7dbde60f8c1)
|
|
Guenther
(This used to be commit e9a7512a9f630340004913f1379452eea8a9b6ae)
|
|
w2k3 as soon
as a one DFS_VOLUME_FLAVOR_AD_BLOB dfsroot exists).
Guenther
(This used to be commit 837b0a14c430faa4e4cada03a1efe2823a7b2e2e)
|
|
Thanks Volker for the pointer hint :)
Guenther
(This used to be commit eb1ec508ace3a5eeb53cf47be44047bd9228cd19)
|
|
Guenther
(This used to be commit 277e07c8553e2ed20bc95493cdc996be43feb6bd)
|
|
Guenther
(This used to be commit 0b9acc8610ae2ba9c42168e9ceb2e9ea8bc2f5bd)
|
|
the tgt
string ourselves.
Guenther
(This used to be commit 1e4a7af99303fb17ebca499ff7e0a017a2017754)
|
|
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.
Guenther
(This used to be commit aa3511a5b5e6a96a02110a7ad0ab1d43e6d25766)
|
|
Long overdue fix....
Jeremy.
(This used to be commit 073fdc5a58139796dbaa7ea9833dca5308f11282)
|
|
failed expression in SMB_ASSERT.
(This used to be commit 171dc060e2a576d724eed1ca65636bdafffd7713)
|
|
Jeremy.
(This used to be commit 4524ee2dbcd5c1c66085032de67c6d083f91cb8a)
|
|
useful even in binaries that don't link in libsmb
(This used to be commit 52545d119277b42a46d13b5b031c85f47d96b84c)
|
|
This replaces the internal explicit dev/ino file id representation by a
"struct file_id". This is necessary as cluster file systems and NFS
don't necessarily assign the same device number to the shared file
system. With this structure in place we can now easily add different
schemes to map a file to a unique 64-bit device node.
Jeremy, you might note that I did not change the external interface of
smb_share_modes.c.
Volker
(This used to be commit 9b10dbbd5de8813fc15ebbb6be9b18010ffe8139)
|
|
data being sent). Patch from mnix@wanm.com.au.
Jeremy.
(This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)
|